From: Eric Blake <eblake@redhat.com>
To: Markus Armbruster <armbru@redhat.com>, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] option: Drop unused get_param_value(), get_next_param_value()
Date: Fri, 6 Oct 2017 09:01:34 -0500 [thread overview]
Message-ID: <bc752b7a-c910-62c9-395b-3c7e10072408@redhat.com> (raw)
In-Reply-To: <20171006131645.17729-1-armbru@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 680 bytes --]
On 10/06/2017 08:16 AM, Markus Armbruster wrote:
> Their last user went away in commit f51074cdc6, "pci-hotplug-old: Has
> been dead for five major releases, bury", v2.3.0. Remove them, as new
> code should use QemuOpts or maybe keyval_parse() instead.
>
> Signed-off-by: Markus Armbruster <armbru@redhat.com>
> ---
> include/qemu/option.h | 5 -----
> util/qemu-option.c | 34 ----------------------------------
> 2 files changed, 39 deletions(-)
Always fun to kill dead code ;-)
Reviewed-by: Eric Blake <eblake@redhat.com>
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3266
Virtualization: qemu.org | libvirt.org
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 619 bytes --]
prev parent reply other threads:[~2017-10-06 14:01 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-06 13:16 [Qemu-devel] [PATCH] option: Drop unused get_param_value(), get_next_param_value() Markus Armbruster
2017-10-06 14:01 ` Eric Blake [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bc752b7a-c910-62c9-395b-3c7e10072408@redhat.com \
--to=eblake@redhat.com \
--cc=armbru@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.