From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-lf0-f53.google.com ([209.85.215.53]:33831 "EHLO mail-lf0-f53.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754262AbcGHLBS (ORCPT ); Fri, 8 Jul 2016 07:01:18 -0400 Received: by mail-lf0-f53.google.com with SMTP id h129so27102383lfh.1 for ; Fri, 08 Jul 2016 04:01:17 -0700 (PDT) Subject: Re: [PATCH] usb/gadget: fix gadgetfs aio support To: Mathieu Laurendeau , linux-usb@vger.kernel.org References: <577F44EE.20504@laurendeau.net> Cc: Felipe Balbi , stable@vger.kernel.org From: Sergei Shtylyov Message-ID: Date: Fri, 8 Jul 2016 14:01:14 +0300 MIME-Version: 1.0 In-Reply-To: <577F44EE.20504@laurendeau.net> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Sender: stable-owner@vger.kernel.org List-ID: Hello. On 7/8/2016 9:15 AM, Mathieu Laurendeau wrote: > Hi, Greetings should not be a part of the patch description. > Since commit 7fe3976e0f3ab26f8ffd9430d3d2a19a70f2c8d2 ("gadget: switch > ep_io_operations to ->read_iter/->write_iter") io submissions fail with > ENODEV. > > Fixes: 7fe3976e0f3a ("gadget: switch ep_io_operations to > ->read_iter/->write_iter") > Signed-off-by: Mathieu Laurendeau > --- > drivers/usb/gadget/legacy/inode.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/usb/gadget/legacy/inode.c b/drivers/usb/gadget/legacy/inode.c > index aa3707b..120a03a 100644 > --- a/drivers/usb/gadget/legacy/inode.c > +++ b/drivers/usb/gadget/legacy/inode.c > @@ -542,7 +542,7 @@ static ssize_t ep_aio(struct kiocb *iocb, > */ > spin_lock_irq(&epdata->dev->lock); > value = -ENODEV; > - if (unlikely(epdata->ep)) > + if (unlikely(epdata->ep) == NULL) This placement of the inner parens doesn't make sense, you should enclose the whole comparison. [...] MBR, Sergei