From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.0 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C15E4C433E0 for ; Wed, 8 Jul 2020 22:57:25 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 8E28A206DF for ; Wed, 8 Jul 2020 22:57:25 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="PA+MpYRu" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8E28A206DF Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:54752 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jtJ0G-0006jA-RL for qemu-devel@archiver.kernel.org; Wed, 08 Jul 2020 18:57:24 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:49708) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jtIVC-0000qR-Fz for qemu-devel@nongnu.org; Wed, 08 Jul 2020 18:25:19 -0400 Received: from us-smtp-2.mimecast.com ([205.139.110.61]:26425 helo=us-smtp-delivery-1.mimecast.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1jtIV5-0001OG-HV for qemu-devel@nongnu.org; Wed, 08 Jul 2020 18:25:18 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1594247110; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=CHGAEaesgAPitP8JdS597nS94aQyRssWojXDYB54AS4=; b=PA+MpYRuBZgK+CpKUsR0bA5sGsGUOaR4FF7hpMp9VNxvB/h96v5vjoFSKWi+2NG9KlMcpY D645pzHnPOOMqLc5mp9eYzXtL76MNzbZ8urU4JEISQQNpHf2VM09sRLsL6d6bS7Pm20TM5 st++tFQ/Hwb4Hc6mJEEwXxucgkdirBQ= Received: from mail-wr1-f71.google.com (mail-wr1-f71.google.com [209.85.221.71]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-32-SXetMSfXNG-n_IMihJLG2A-1; Wed, 08 Jul 2020 11:23:22 -0400 X-MC-Unique: SXetMSfXNG-n_IMihJLG2A-1 Received: by mail-wr1-f71.google.com with SMTP id y18so32821479wrq.4 for ; Wed, 08 Jul 2020 08:23:22 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=CHGAEaesgAPitP8JdS597nS94aQyRssWojXDYB54AS4=; b=WxAhRLLsvdLrdYO0TUbG2dErRSJZfnbHZYjLJo/IQgdM7Hdi1zT+FAXEXs+TYYqIZM mEfOl56XH09Fq55EYsxB46+rX5lN+N7vZB1snh/XjOvvjf2p47sTiydgljjrGnc7Uhmt zdGbLsv1j5ML3EmJQXTTh5m9pa6EDsEbg6f9rqBXF97aJ5Tnuk2CJJ3aIGTdYjQKvw/I nCf+L6K0PlBLGA8FAtWQku6eP1bxwGBioQPqRSvlfWh9H9aiHvKLforZUkC4JPR6kyyT PY3nJPN+bSZgcCzKg7IzJ6PY+ZXGetR2vP+NfrU2GxLivjlwNd91UK71+ge7bsIKOHRR 8mdg== X-Gm-Message-State: AOAM530od8lqTxSjbT+uFYNYawT/KNJHeIvprz9qgooafkpHyKIg/+xE NQxyQkCODs1fFR6nXAlv9+PR05oDG6QXOtVljcC70kqfd28NCVH6bnuNGHW81emTvhZGdgtmTrR XVJAq5tDUlv1mJxc= X-Received: by 2002:a5d:628b:: with SMTP id k11mr59658653wru.107.1594221801326; Wed, 08 Jul 2020 08:23:21 -0700 (PDT) X-Google-Smtp-Source: ABdhPJz9QXoNdqhFKHAj89SR91jKlnAFP2kQ+YJ++EPkH9loBWINnn5lztNWMrwMhkE834fNMADN3g== X-Received: by 2002:a5d:628b:: with SMTP id k11mr59658632wru.107.1594221801098; Wed, 08 Jul 2020 08:23:21 -0700 (PDT) Received: from ?IPv6:2001:b07:6468:f312:9541:9439:cb0f:89c? ([2001:b07:6468:f312:9541:9439:cb0f:89c]) by smtp.gmail.com with ESMTPSA id j16sm484430wrt.7.2020.07.08.08.23.20 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 08 Jul 2020 08:23:20 -0700 (PDT) Subject: Re: [PATCH 3/3] cpu-timers, icount: new modules To: Claudio Fontana , Thomas Huth , Laurent Vivier , =?UTF-8?Q?Alex_Benn=c3=a9e?= , Peter Maydell , =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= , Roman Bolshakov , Markus Armbruster References: <20200629093504.3228-1-cfontana@suse.de> <20200629093504.3228-4-cfontana@suse.de> <46322ba4-8aff-e8d6-8a1c-ea1043098624@suse.de> From: Paolo Bonzini Message-ID: Date: Wed, 8 Jul 2020 17:23:19 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.9.0 MIME-Version: 1.0 In-Reply-To: <46322ba4-8aff-e8d6-8a1c-ea1043098624@suse.de> Content-Language: en-US Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=pbonzini@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Received-SPF: pass client-ip=205.139.110.61; envelope-from=pbonzini@redhat.com; helo=us-smtp-delivery-1.mimecast.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/07/07 17:25:10 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] [fuzzy] X-Spam_score_int: -40 X-Spam_score: -4.1 X-Spam_bar: ---- X-Spam_report: (-4.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-1, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-1, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Eduardo Habkost , Colin Xu , Marcelo Tosatti , qemu-devel@nongnu.org, haxm-team@intel.com, Wenchao Wang , Sunil Muthuswamy , Richard Henderson Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On 08/07/20 17:17, Claudio Fontana wrote: > On 7/8/20 5:05 PM, Paolo Bonzini wrote: >> On 08/07/20 17:00, Claudio Fontana wrote: >>>> Bisectable, 100% failure rate, etc. :( Can you split the patch in >>>> multiple parts, specifically separating any rename or introducing of >>>> includes from the final file move? >>> Hi Paolo, >>> >>> will take a look! >>> >>> Is this captured by some travis / cirrus-ci / anything I can easily see the result of? >>> >>> >> >> Nope, unfortunately we don't have an s390 CI. But if you can get your >> hands on one, just "./configure --target-list=s390x-softmmu && make && >> make check-block" will show it. >> >>>> >>>> #if defined CONFIG_TCG || !defined NEED_CPU_H >>>> extern bool icount_enabled(void); >>>> #else >>>> #define icount_enabled() 0 >>>> #endif >>>> >>>> (This way, more TCG-only code in cpus.c gets elided). You can integrate >>>> this change in the next version. >>>> >>>> Paolo >>>> >>> >>> Weird, I tested with --disable-tcg explicitly (but may be some time ago now, as I constantly rebased). >>> >>> Will take a look at the introduction of this #defines in place of variables, >>> as this mechanisms will not work in the future for target-specific modules. >> >> This is only done for per-target files so it should not be a problem. >> >> Paolo >> > > K, I tried with latest master, disable-tcg build still works for me on x86, so it is something in queue I guess? Peter reported the issue in the v1 pull request; there were two different breakages but the cpus.c one was yours. Paolo