From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.6 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6E1EFC433E6 for ; Mon, 18 Jan 2021 16:11:08 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 41662222F9 for ; Mon, 18 Jan 2021 16:11:08 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2406392AbhARQKj (ORCPT ); Mon, 18 Jan 2021 11:10:39 -0500 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:48110 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2406350AbhARQEm (ORCPT ); Mon, 18 Jan 2021 11:04:42 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1610985794; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=FpH2fvvNBiSH7+LZf4kqHTix8ou/f0zVOc4swnogC40=; b=GIsewwpTIr8WHsnPmFp1Rrp2vdZyt5PMnGMZGXuPqbyebCwqitZDkyQPtdc4bzl8immTn+ EVqty+32XUh7tTDkKlb4UMR3c7zNorF0gmFC7RLJGnSkmK9w6a7z0agBwwbIzHMKlVp7nO pTM0gOVXSS3pBC07ZOUNb7orrwwVWHk= Received: from mail-ej1-f70.google.com (mail-ej1-f70.google.com [209.85.218.70]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-365-K56P-bcFM7iMfM2hHlftCQ-1; Mon, 18 Jan 2021 11:03:12 -0500 X-MC-Unique: K56P-bcFM7iMfM2hHlftCQ-1 Received: by mail-ej1-f70.google.com with SMTP id by20so667868ejc.1 for ; Mon, 18 Jan 2021 08:03:12 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=FpH2fvvNBiSH7+LZf4kqHTix8ou/f0zVOc4swnogC40=; b=AbNy3N+Qx+sGZCeYsvHOoYWTMviDhNCPHQnVZuv+tbh5D9Hv9pAtPYXVTGZ3CPYUkT OHIKvHvyXCs00GCAflpNzAeIC46aLUZ9IYiop7C6vX3mwxt0sB6fBjZzxANPbrqRVEPL QvFB9QrBPJgPqPEFqYN7weaqCjWKK+bxIYlftH7KJHVnr5NGHBiRvARnZZMlUvn8jS9w DrffI4ctE1h24EiI066KpgbVmz2X5YvIlPCWrX+OkP5w1aHEMsxVReowaMALcfWj1mpB rWk+fhsEPidM4pjTJg0sbKh1FmzZhR/U/rDSW635pyfedbKh/zzbt7R2Y7a0aq6nCOxH NuMw== X-Gm-Message-State: AOAM5312bnckOagpNCFPjmSkyTWumoJJ5EBFb+VmK9CNXh4iFDcVV9Nb 5YKZqBYR7lby0Tg9E+xv29164yjJl2WQAFzHo883rIMdSxD8rLAGudoOE24Czll3GV9PxeP75oh Ysm9N5/Spnud+oir735kM5A== X-Received: by 2002:aa7:c84c:: with SMTP id g12mr104599edt.193.1610985791064; Mon, 18 Jan 2021 08:03:11 -0800 (PST) X-Google-Smtp-Source: ABdhPJxxoBeWNVgS6qD7oqsR8mLDfnlxDvBu2ufUD/XP0BQo1iXg2+222x2MegLm1INYXknOJLnSSg== X-Received: by 2002:aa7:c84c:: with SMTP id g12mr104590edt.193.1610985790944; Mon, 18 Jan 2021 08:03:10 -0800 (PST) Received: from x1.localdomain (2001-1c00-0c1e-bf00-37a3-353b-be90-1238.cable.dynamic.v6.ziggo.nl. [2001:1c00:c1e:bf00:37a3:353b:be90:1238]) by smtp.gmail.com with ESMTPSA id hr31sm9312503ejc.125.2021.01.18.08.03.08 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 18 Jan 2021 08:03:09 -0800 (PST) Subject: Re: [PATCH v2 6/7] platform: x86: Add intel_skl_int3472 driver To: Daniel Scally , "andriy.shevchenko@linux.intel.com" Cc: =?UTF-8?Q?Barnab=c3=a1s_P=c5=91cze?= , "linux-kernel@vger.kernel.org" , "linux-acpi@vger.kernel.org" , "linux-gpio@vger.kernel.org" , "linux-i2c@vger.kernel.org" , "platform-driver-x86@vger.kernel.org" , "devel@acpica.org" , "rjw@rjwysocki.net" , "lenb@kernel.org" , "andy@kernel.org" , "mika.westerberg@linux.intel.com" , "linus.walleij@linaro.org" , "bgolaszewski@baylibre.com" , "wsa@kernel.org" , "lee.jones@linaro.org" , "mgross@linux.intel.com" , "robert.moore@intel.com" , "erik.kaneda@intel.com" , "sakari.ailus@linux.intel.com" , "laurent.pinchart@ideasonboard.com" , "kieran.bingham@ideasonboard.com" References: <20210118003428.568892-1-djrscally@gmail.com> <20210118003428.568892-7-djrscally@gmail.com> <-GKrxu8GJvGe-PlKkLpblw9N-DtVtS7i87BOCLgJR72yf4hUFpUgiOlGcFero_gqgUxJrX2gxtLOnz_31hJugfam0SXXmXxIzGIhS162mhI=@protonmail.com> <20210118135121.GM4077@smile.fi.intel.com> <20210118152323.GV4077@smile.fi.intel.com> <20210118154852.GY4077@smile.fi.intel.com> From: Hans de Goede Message-ID: Date: Mon, 18 Jan 2021 17:03:08 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.4.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-acpi@vger.kernel.org Hi, On 1/18/21 5:00 PM, Daniel Scally wrote: > > On 18/01/2021 15:48, andriy.shevchenko@linux.intel.com wrote: >> On Mon, Jan 18, 2021 at 04:32:54PM +0100, Hans de Goede wrote: >>> On 1/18/21 4:23 PM, andriy.shevchenko@linux.intel.com wrote: >> ... >> >>> 1. Using a folder is fine, desirable even >>> 2. I've some concerns about the name, but I'm not really objecting, >>> just giving my 2 cents. >> Let's get into compromised summary: >> - create a folder for these driver files >> - name it without _skl_ while leaving this in the file / driver names >> >> Does everybody agree on this approach? >> > > Works for me! Also works for me. Regards, Hans