From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 18ACBC433FE for ; Wed, 15 Sep 2021 16:34:44 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 0407061029 for ; Wed, 15 Sep 2021 16:34:43 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230296AbhIOQgC (ORCPT ); Wed, 15 Sep 2021 12:36:02 -0400 Received: from mga07.intel.com ([134.134.136.100]:58332 "EHLO mga07.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229962AbhIOQgB (ORCPT ); Wed, 15 Sep 2021 12:36:01 -0400 X-IronPort-AV: E=McAfee;i="6200,9189,10108"; a="286060921" X-IronPort-AV: E=Sophos;i="5.85,295,1624345200"; d="scan'208";a="286060921" Received: from orsmga004.jf.intel.com ([10.7.209.38]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 15 Sep 2021 09:34:42 -0700 X-IronPort-AV: E=Sophos;i="5.85,295,1624345200"; d="scan'208";a="583352209" Received: from mvetrive-mobl3.amr.corp.intel.com (HELO [10.212.69.198]) ([10.212.69.198]) by orsmga004-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 15 Sep 2021 09:34:40 -0700 Subject: Re: [PATCH v6 18/22] ASoC: qdsp6: audioreach: add topology support To: Srinivas Kandagatla , bjorn.andersson@linaro.org, broonie@kernel.org, robh@kernel.org Cc: plai@codeaurora.org, tiwai@suse.de, devicetree@vger.kernel.org, perex@perex.cz, alsa-devel@alsa-project.org, lgirdwood@gmail.com, bgoswami@codeaurora.org References: <20210915131333.19047-1-srinivas.kandagatla@linaro.org> <20210915131333.19047-19-srinivas.kandagatla@linaro.org> From: Pierre-Louis Bossart Message-ID: Date: Wed, 15 Sep 2021 11:22:23 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Firefox/78.0 Thunderbird/78.13.0 MIME-Version: 1.0 In-Reply-To: <20210915131333.19047-19-srinivas.kandagatla@linaro.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org > +static int audioreach_widget_load_buffer(struct snd_soc_component *component, > + int index, struct snd_soc_dapm_widget *w, > + struct snd_soc_tplg_dapm_widget *tplg_w) > +{ > + struct snd_soc_tplg_vendor_array *mod_array; > + struct audioreach_module *mod; > + struct snd_soc_dobj *dobj; > + int ret; > + > + ret = audioreach_widget_load_module_common(component, index, w, tplg_w); > + if (ret) > + return ret; > + > + dobj = &w->dobj; > + mod = dobj->private; > + > + mod_array = audioreach_get_module_array(&tplg_w->priv); > + > + switch (mod->module_id) { > + case MODULE_ID_CODEC_DMA_SINK: > + case MODULE_ID_CODEC_DMA_SOURCE: > + audioreach_widget_dma_module_load(mod, mod_array); > + break; > + case MODULE_ID_DATA_LOGGING: > + audioreach_widget_log_module_load(mod, mod_array); > + break; > + case MODULE_ID_I2S_SINK: > + case MODULE_ID_I2S_SOURCE: > + audioreach_widget_i2s_module_load(mod, mod_array); > + break; no default case? > + } > + > + return 0; > +} > + > +int audioreach_tplg_init(struct snd_soc_component *component) > +{ > + struct device *dev = component->dev; > + const struct firmware *fw; > + int ret; > + > + ret = request_firmware(&fw, "audioreach.bin", dev); > + if (ret < 0) { > + dev_err(dev, "tplg fw audioreach.bin load failed with %d\n", ret); > + return ret; > + } How does this work if you want to change the topology, which will happen rather frequently if you have a framework precisely to change the DSP graph? You need to override a file in userspace? Shouldn't you have a means to identify what topology file you want on a platform-basis? Or at the very least a means to change the file name with a kernel parameter or something. > + > + ret = snd_soc_tplg_component_load(component, &audioreach_tplg_ops, fw); > + if (ret < 0) { > + dev_err(dev, "tplg component load failed%d\n", ret); > + ret = -EINVAL; > + } > + > + release_firmware(fw); > + return ret; > +} > +EXPORT_SYMBOL_GPL(audioreach_tplg_init); > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 81922C433F5 for ; Wed, 15 Sep 2021 16:36:58 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id A6C7661029 for ; Wed, 15 Sep 2021 16:36:57 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org A6C7661029 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.intel.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=alsa-project.org Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 4AC14181A; Wed, 15 Sep 2021 18:36:06 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 4AC14181A DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1631723816; bh=l5TG2aZsbtqTeGnu+rXJzypl5GLHrRpaj/pgm8YOpd8=; h=Subject:To:References:From:Date:In-Reply-To:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=nK4GEraEKuRlCHFJqbBztkPf1Fe7tgHL/nE8A7oqDQlZvm3eR/PXHgGBzw/pKwtYt W1jtIWpWBSmRCZ1Ui3HcJ6SlFdimSJ3LdQTzV5+rsQfi5p1rIiKvtIvyShwfFpEqO/ 9fT0NZnkSi1b93T5qY+Ms9xmpV3EMXMaE/hG/RLA= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id B7746F804ED; Wed, 15 Sep 2021 18:34:52 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 99F6DF804ED; Wed, 15 Sep 2021 18:34:49 +0200 (CEST) Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id BF8DEF8027C for ; Wed, 15 Sep 2021 18:34:43 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz BF8DEF8027C X-IronPort-AV: E=McAfee;i="6200,9189,10108"; a="286060922" X-IronPort-AV: E=Sophos;i="5.85,295,1624345200"; d="scan'208";a="286060922" Received: from orsmga004.jf.intel.com ([10.7.209.38]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 15 Sep 2021 09:34:42 -0700 X-IronPort-AV: E=Sophos;i="5.85,295,1624345200"; d="scan'208";a="583352209" Received: from mvetrive-mobl3.amr.corp.intel.com (HELO [10.212.69.198]) ([10.212.69.198]) by orsmga004-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 15 Sep 2021 09:34:40 -0700 Subject: Re: [PATCH v6 18/22] ASoC: qdsp6: audioreach: add topology support To: Srinivas Kandagatla , bjorn.andersson@linaro.org, broonie@kernel.org, robh@kernel.org References: <20210915131333.19047-1-srinivas.kandagatla@linaro.org> <20210915131333.19047-19-srinivas.kandagatla@linaro.org> From: Pierre-Louis Bossart Message-ID: Date: Wed, 15 Sep 2021 11:22:23 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Firefox/78.0 Thunderbird/78.13.0 MIME-Version: 1.0 In-Reply-To: <20210915131333.19047-19-srinivas.kandagatla@linaro.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Cc: devicetree@vger.kernel.org, alsa-devel@alsa-project.org, bgoswami@codeaurora.org, tiwai@suse.de, plai@codeaurora.org, lgirdwood@gmail.com X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" > +static int audioreach_widget_load_buffer(struct snd_soc_component *component, > + int index, struct snd_soc_dapm_widget *w, > + struct snd_soc_tplg_dapm_widget *tplg_w) > +{ > + struct snd_soc_tplg_vendor_array *mod_array; > + struct audioreach_module *mod; > + struct snd_soc_dobj *dobj; > + int ret; > + > + ret = audioreach_widget_load_module_common(component, index, w, tplg_w); > + if (ret) > + return ret; > + > + dobj = &w->dobj; > + mod = dobj->private; > + > + mod_array = audioreach_get_module_array(&tplg_w->priv); > + > + switch (mod->module_id) { > + case MODULE_ID_CODEC_DMA_SINK: > + case MODULE_ID_CODEC_DMA_SOURCE: > + audioreach_widget_dma_module_load(mod, mod_array); > + break; > + case MODULE_ID_DATA_LOGGING: > + audioreach_widget_log_module_load(mod, mod_array); > + break; > + case MODULE_ID_I2S_SINK: > + case MODULE_ID_I2S_SOURCE: > + audioreach_widget_i2s_module_load(mod, mod_array); > + break; no default case? > + } > + > + return 0; > +} > + > +int audioreach_tplg_init(struct snd_soc_component *component) > +{ > + struct device *dev = component->dev; > + const struct firmware *fw; > + int ret; > + > + ret = request_firmware(&fw, "audioreach.bin", dev); > + if (ret < 0) { > + dev_err(dev, "tplg fw audioreach.bin load failed with %d\n", ret); > + return ret; > + } How does this work if you want to change the topology, which will happen rather frequently if you have a framework precisely to change the DSP graph? You need to override a file in userspace? Shouldn't you have a means to identify what topology file you want on a platform-basis? Or at the very least a means to change the file name with a kernel parameter or something. > + > + ret = snd_soc_tplg_component_load(component, &audioreach_tplg_ops, fw); > + if (ret < 0) { > + dev_err(dev, "tplg component load failed%d\n", ret); > + ret = -EINVAL; > + } > + > + release_firmware(fw); > + return ret; > +} > +EXPORT_SYMBOL_GPL(audioreach_tplg_init); >