From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.0 required=3.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED,DKIM_INVALID,DKIM_SIGNED,FREEMAIL_FORGED_FROMDOMAIN, FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6F8D8C43460 for ; Wed, 28 Apr 2021 07:03:22 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 13009613C0 for ; Wed, 28 Apr 2021 07:03:22 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 13009613C0 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id B0B956EAA8; Wed, 28 Apr 2021 07:03:20 +0000 (UTC) Received: from mail-ej1-x629.google.com (mail-ej1-x629.google.com [IPv6:2a00:1450:4864:20::629]) by gabe.freedesktop.org (Postfix) with ESMTPS id 72BD16EAA7; Wed, 28 Apr 2021 07:03:10 +0000 (UTC) Received: by mail-ej1-x629.google.com with SMTP id gx5so920874ejb.11; Wed, 28 Apr 2021 00:03:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:references:from:message-id:date:user-agent:mime-version :in-reply-to:content-transfer-encoding:content-language; bh=KG1nLMyF73Uu2La1XfcDKUiczoK0PzUlzNOdGLSVGwI=; b=hMSwBTPNBLkGLJU7R2NCX++K5Fxqgu1KvNxbbJkwWTfS8K2OYRxLTNswgPRm/8Pjjz hDLBhp9e5K83jDN9y3S43xOjDfGCrVFVIbogNjJX8rTvozYlWR7G2EYBCAHOFVfqBIOl ZqS92LNo2Cy8//S/scStEt3QjveiFzo1SzAjNBOMNrlrwuBDOtbRDdp6ee7/8FRGZghN 16gsc25C1MhvWKSV5fcvDFU6zr/Gc9Np/5t+AzGKlxePK97CgndmpbY5zSZZJu8/xN9Y M3398f3zte1MpgHWI8gJ4fFmAnWVxyHRlIXwYqleTB/hXN1ljyx1ULif6PlgJgze5+Z3 8M0w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding :content-language; bh=KG1nLMyF73Uu2La1XfcDKUiczoK0PzUlzNOdGLSVGwI=; b=PgCupZa2g/gwhGRTX/yiv5Vbs6Vc1bppRiYW8B0iZ0OOt8t0F85KQJUeSG9PS6Sgo8 O/WamApDnEPBCFj2y/ZjYHOjXV9y+w0zhVs8uJWSZThmXavQgB/39yIp/33rQ8gDho5H nCNB3Qkag38vTbZV5LhYPh4z4ftp700vLr/uLREh/4vEmsfl8Brn2BkCee+VX4D8gw6b saZOyDl5jUX6vprdkpcnK+mbPy6vMCYiaJmrHHF05n3qWP8yA5vbCBHIu6NUyl5LYsba DCYvh1rwvQyK3sYZXcSH0tCHhdkT7csS8qiBj3pr8Ns4M68ZuMeJvZqQuMnAKeTOLT78 W2Og== X-Gm-Message-State: AOAM533JCQiQw23Ta8wD5fRxzepsZuiFKHtEbsFE909Z2BKBqm/XXHRj IvgKRutITQLvjDkYVdfRc4n6jaJXmLQ= X-Google-Smtp-Source: ABdhPJxSJmtx0vgcEjOyM78Gjr9iD3foRPFcjz8EZ2gC1/2Hfcb0AfISFAiZqnnbukUt114w31Y5ZQ== X-Received: by 2002:a17:906:eda3:: with SMTP id sa3mr6535026ejb.415.1619593386130; Wed, 28 Apr 2021 00:03:06 -0700 (PDT) Received: from ?IPv6:2a02:908:1252:fb60:5565:6656:893b:2618? ([2a02:908:1252:fb60:5565:6656:893b:2618]) by smtp.gmail.com with ESMTPSA id c12sm4320665edx.54.2021.04.28.00.03.05 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 28 Apr 2021 00:03:05 -0700 (PDT) Subject: Re: [PATCH 2/2] drm/ttm: Fix swapout in ttm_tt_populate To: Felix Kuehling , dri-devel@lists.freedesktop.org, amd-gfx@lists.freedesktop.org References: <20210428053338.11560-1-Felix.Kuehling@amd.com> <20210428053338.11560-2-Felix.Kuehling@amd.com> From: =?UTF-8?Q?Christian_K=c3=b6nig?= Message-ID: Date: Wed, 28 Apr 2021 09:03:04 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.7.1 MIME-Version: 1.0 In-Reply-To: <20210428053338.11560-2-Felix.Kuehling@amd.com> Content-Language: en-US X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" That is already fixed upstream. Am 28.04.21 um 07:33 schrieb Felix Kuehling: > ttm_bo_swapout returns a non-0 value on success. Don't treat that as an > error in ttm_tt_populate. > > Signed-off-by: Felix Kuehling > --- > drivers/gpu/drm/ttm/ttm_tt.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/ttm/ttm_tt.c b/drivers/gpu/drm/ttm/ttm_tt.c > index 5d8820725b75..1858a7fb9169 100644 > --- a/drivers/gpu/drm/ttm/ttm_tt.c > +++ b/drivers/gpu/drm/ttm/ttm_tt.c > @@ -326,7 +326,7 @@ int ttm_tt_populate(struct ttm_device *bdev, > ttm_dma32_pages_limit) { > > ret = ttm_bo_swapout(ctx, GFP_KERNEL); > - if (ret) > + if (ret < 0) > goto error; > } > _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.0 required=3.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED,DKIM_INVALID,DKIM_SIGNED,FREEMAIL_FORGED_FROMDOMAIN, FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6FA5CC433B4 for ; Wed, 28 Apr 2021 07:03:21 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 00F6F610F7 for ; Wed, 28 Apr 2021 07:03:20 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 00F6F610F7 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=amd-gfx-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id D4B6D6EAA7; Wed, 28 Apr 2021 07:03:19 +0000 (UTC) Received: from mail-ej1-x629.google.com (mail-ej1-x629.google.com [IPv6:2a00:1450:4864:20::629]) by gabe.freedesktop.org (Postfix) with ESMTPS id 72BD16EAA7; Wed, 28 Apr 2021 07:03:10 +0000 (UTC) Received: by mail-ej1-x629.google.com with SMTP id gx5so920874ejb.11; Wed, 28 Apr 2021 00:03:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:references:from:message-id:date:user-agent:mime-version :in-reply-to:content-transfer-encoding:content-language; bh=KG1nLMyF73Uu2La1XfcDKUiczoK0PzUlzNOdGLSVGwI=; b=hMSwBTPNBLkGLJU7R2NCX++K5Fxqgu1KvNxbbJkwWTfS8K2OYRxLTNswgPRm/8Pjjz hDLBhp9e5K83jDN9y3S43xOjDfGCrVFVIbogNjJX8rTvozYlWR7G2EYBCAHOFVfqBIOl ZqS92LNo2Cy8//S/scStEt3QjveiFzo1SzAjNBOMNrlrwuBDOtbRDdp6ee7/8FRGZghN 16gsc25C1MhvWKSV5fcvDFU6zr/Gc9Np/5t+AzGKlxePK97CgndmpbY5zSZZJu8/xN9Y M3398f3zte1MpgHWI8gJ4fFmAnWVxyHRlIXwYqleTB/hXN1ljyx1ULif6PlgJgze5+Z3 8M0w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding :content-language; bh=KG1nLMyF73Uu2La1XfcDKUiczoK0PzUlzNOdGLSVGwI=; b=PgCupZa2g/gwhGRTX/yiv5Vbs6Vc1bppRiYW8B0iZ0OOt8t0F85KQJUeSG9PS6Sgo8 O/WamApDnEPBCFj2y/ZjYHOjXV9y+w0zhVs8uJWSZThmXavQgB/39yIp/33rQ8gDho5H nCNB3Qkag38vTbZV5LhYPh4z4ftp700vLr/uLREh/4vEmsfl8Brn2BkCee+VX4D8gw6b saZOyDl5jUX6vprdkpcnK+mbPy6vMCYiaJmrHHF05n3qWP8yA5vbCBHIu6NUyl5LYsba DCYvh1rwvQyK3sYZXcSH0tCHhdkT7csS8qiBj3pr8Ns4M68ZuMeJvZqQuMnAKeTOLT78 W2Og== X-Gm-Message-State: AOAM533JCQiQw23Ta8wD5fRxzepsZuiFKHtEbsFE909Z2BKBqm/XXHRj IvgKRutITQLvjDkYVdfRc4n6jaJXmLQ= X-Google-Smtp-Source: ABdhPJxSJmtx0vgcEjOyM78Gjr9iD3foRPFcjz8EZ2gC1/2Hfcb0AfISFAiZqnnbukUt114w31Y5ZQ== X-Received: by 2002:a17:906:eda3:: with SMTP id sa3mr6535026ejb.415.1619593386130; Wed, 28 Apr 2021 00:03:06 -0700 (PDT) Received: from ?IPv6:2a02:908:1252:fb60:5565:6656:893b:2618? ([2a02:908:1252:fb60:5565:6656:893b:2618]) by smtp.gmail.com with ESMTPSA id c12sm4320665edx.54.2021.04.28.00.03.05 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 28 Apr 2021 00:03:05 -0700 (PDT) Subject: Re: [PATCH 2/2] drm/ttm: Fix swapout in ttm_tt_populate To: Felix Kuehling , dri-devel@lists.freedesktop.org, amd-gfx@lists.freedesktop.org References: <20210428053338.11560-1-Felix.Kuehling@amd.com> <20210428053338.11560-2-Felix.Kuehling@amd.com> From: =?UTF-8?Q?Christian_K=c3=b6nig?= Message-ID: Date: Wed, 28 Apr 2021 09:03:04 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.7.1 MIME-Version: 1.0 In-Reply-To: <20210428053338.11560-2-Felix.Kuehling@amd.com> Content-Language: en-US X-BeenThere: amd-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Discussion list for AMD gfx List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: amd-gfx-bounces@lists.freedesktop.org Sender: "amd-gfx" That is already fixed upstream. Am 28.04.21 um 07:33 schrieb Felix Kuehling: > ttm_bo_swapout returns a non-0 value on success. Don't treat that as an > error in ttm_tt_populate. > > Signed-off-by: Felix Kuehling > --- > drivers/gpu/drm/ttm/ttm_tt.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/ttm/ttm_tt.c b/drivers/gpu/drm/ttm/ttm_tt.c > index 5d8820725b75..1858a7fb9169 100644 > --- a/drivers/gpu/drm/ttm/ttm_tt.c > +++ b/drivers/gpu/drm/ttm/ttm_tt.c > @@ -326,7 +326,7 @@ int ttm_tt_populate(struct ttm_device *bdev, > ttm_dma32_pages_limit) { > > ret = ttm_bo_swapout(ctx, GFP_KERNEL); > - if (ret) > + if (ret < 0) > goto error; > } > _______________________________________________ amd-gfx mailing list amd-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/amd-gfx