From mboxrd@z Thu Jan 1 00:00:00 1970 From: Doug Goldstein Subject: Re: [PATCH 4/4] x86: add multiboot2 protocol support for EFI platforms Date: Mon, 16 Jan 2017 08:41:08 -0500 Message-ID: References: <4b42ae6d42d409a44496eb546efe72c5060b1fd9.1484335095.git-series.cardoe@cardoe.com> <587CC44D02000078001306B4@prv-mh.provo.novell.com> <20170116125039.GQ23864@olila.local.net-space.pl> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============7371206671833636557==" Return-path: In-Reply-To: <20170116125039.GQ23864@olila.local.net-space.pl> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xen.org Sender: "Xen-devel" To: Daniel Kiper , Jan Beulich Cc: Juergen Gross , sstabellini@kernel.org, konrad.wilk@oracle.com, Andrew Cooper , pgnet.dev@gmail.com, ning.sun@intel.com, julien.grall@arm.com, qiaowei.ren@intel.com, xen-devel@lists.xen.org, gang.wei@intel.com, fu.wei@linaro.org List-Id: xen-devel@lists.xenproject.org This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --===============7371206671833636557== Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="oBRcRS61AW6JtGN5vIgnKCFcnnDEioR27" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --oBRcRS61AW6JtGN5vIgnKCFcnnDEioR27 Content-Type: multipart/mixed; boundary="S2dXMeF4o4CXiuxOwQfkwWN9qxFg5pb2r"; protected-headers="v1" From: Doug Goldstein To: Daniel Kiper , Jan Beulich Cc: julien.grall@arm.com, Andrew Cooper , pgnet.dev@gmail.com, gang.wei@intel.com, ning.sun@intel.com, qiaowei.ren@intel.com, sstabellini@kernel.org, fu.wei@linaro.org, xen-devel@lists.xen.org, konrad.wilk@oracle.com, Juergen Gross Message-ID: Subject: Re: [PATCH 4/4] x86: add multiboot2 protocol support for EFI platforms References: <4b42ae6d42d409a44496eb546efe72c5060b1fd9.1484335095.git-series.cardoe@cardoe.com> <587CC44D02000078001306B4@prv-mh.provo.novell.com> <20170116125039.GQ23864@olila.local.net-space.pl> In-Reply-To: <20170116125039.GQ23864@olila.local.net-space.pl> --S2dXMeF4o4CXiuxOwQfkwWN9qxFg5pb2r Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: quoted-printable On 1/16/17 7:50 AM, Daniel Kiper wrote: > On Mon, Jan 16, 2017 at 05:02:05AM -0700, Jan Beulich wrote: >>>>> On 13.01.17 at 20:21, wrote: >>> Doug v1 - fix incorrect assembly (identified by Andrew Cooper) >>> - fix issue where the trampoline size was left as 0 and the >>> way the memory is allocated for the trampolines we would go= to >>> the end of an available section and then subtract off the s= ize >>> to decide where to place it. The end result was that we wou= ld >>> always copy the trampolines and the 32-bit stack into some >>> form of reserved memory after the conventional region we >>> wanted to put things into. On some systems this did not >>> manifest as a crash while on others it did. Reworked the >>> changes to always reserve 64kb for both the stack and the s= ize >>> of the trampolines. Added an ASSERT to make sure we never b= low >>> through this size. >> >> Without having looked at the patch in detail, but knowing I did closel= y >> look at earlier versions (and iirc I was mostly fine with v10) the way= >> the above is written would require me to either inter-diff the patches= , >> or re-review the whole thing. For a large patch like this it would be >> rather helpful to be quite a bit more specific as to where exactly in = the >> patch changes were made. >=20 > I would prefer to not have this patch series applied because it will ma= ke me > more difficult to prepare v12. I hope that I will post it in about 2 we= eks. > Though I am going to take into account all comments posted by Doug for = v11. >=20 > Daniel >=20 Why? They're the first 4 patches remaining of your series. It'll literally be the following commands: git fetch origin git rebase origin/staging --=20 Doug Goldstein --S2dXMeF4o4CXiuxOwQfkwWN9qxFg5pb2r-- --oBRcRS61AW6JtGN5vIgnKCFcnnDEioR27 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG/MacGPG2 v2.0 iQJ8BAEBCgBmBQJYfM13XxSAAAAAAC4AKGlzc3Vlci1mcHJAbm90YXRpb25zLm9w ZW5wZ3AuZmlmdGhob3JzZW1hbi5uZXRBNTM5MEQ2RTNFMTkyNzlCNzVDMzIwOTVB MkJDMDNEQzg3RUQxQkQ0AAoJEKK8A9yH7RvUwHcP/1SCtrBCYl/obH4s48//3YgI /zLW2hKEVZ8di4AfUNvpgMYPUkXQa9KNlU7i2LjX2FjqSvpKsy0ekIzeSfjz/xLe J+RgbQ6o8EWv6O9+p516B5AvCB0ufcjRqi/IDb7cva3XRHdgkAz369LGLabA94hY j/Mkgp60tPQN0AH1Rwcq70HdpSox2PwBErivA/ohjtZC6j9jl0MECxlGYRp55G4q hsJWvpYO4FPJ34G17hDjdQaMewJhVWy84TOmkGj4zuMs1c+wUndAITUrBDpze4J/ yOmtySg3kCMl8Xa/P9HK3NSVqbVAVc//RSiAPCVQCiNk+jtQiGEQUpDFyB+bYRNd PIk/m5f2gHmLk8fo2WGV4nJE8hQVw0MyzFAzouMH/MsUsHCSUhHlFgKohBs8g9JP DBf6XZEyEUdC3r42+4V0ACQ5f0ya6FlGSfO6DovuqIG2ikvh9T2XH/wt0T/GB/w8 /qDABls4FqjJR3iYBmO+6HxsSazVIWq2WDWkX/u5fgTZvIju0nqLYlP62dshaNeQ Z+o6x6qukKQ9wU12I3TiBLnim0uQxNW84JirDMFtWBSN9QmBcozCK85ZfDQIcEXX 9RrcBzb2+TIwegEUpTjfT6mhhhZ+k1biHB79ZtTiTJ4/QgN5rx3+5waqWLDattLi 8g0RTihkUjtsWo20tAkG =yM+w -----END PGP SIGNATURE----- --oBRcRS61AW6JtGN5vIgnKCFcnnDEioR27-- --===============7371206671833636557== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KWGVuLWRldmVs IG1haWxpbmcgbGlzdApYZW4tZGV2ZWxAbGlzdHMueGVuLm9yZwpodHRwczovL2xpc3RzLnhlbi5v cmcveGVuLWRldmVsCg== --===============7371206671833636557==--