From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.3 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 06FD6C47078 for ; Fri, 21 May 2021 14:33:12 +0000 (UTC) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 1AA8A60720 for ; Fri, 21 May 2021 14:33:11 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 1AA8A60720 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmx.de Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 2B35182D68; Fri, 21 May 2021 16:33:09 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=fail (p=none dis=none) header.from=gmx.de Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; secure) header.d=gmx.net header.i=@gmx.net header.b="THspGH+y"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id C766C82E23; Fri, 21 May 2021 16:33:06 +0200 (CEST) Received: from mout.gmx.net (mout.gmx.net [212.227.17.21]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id F219780202 for ; Fri, 21 May 2021 16:33:03 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=gmx.de Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=xypron.glpk@gmx.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1621607580; bh=BlfUGaLJQ0zNmLM/Vrr1e7zQGVeRvX72BW8ulklND5o=; h=X-UI-Sender-Class:Subject:To:Cc:References:From:Date:In-Reply-To; b=THspGH+ysNmhSJDVNazsbkxuREb2CxPYEwNeJ+AtmMhm0U5O/m5yLgJj7ZygUKPoq BQ0v+2rfuNDSv+XCLLEUnfRWlHk5WFyxcEFmAroVGNyTv09fmzhfEebKIcmIM8AZK4 awxEDWTBisFhLeTTemb/l3DVZp32TAs45mDLDzgk= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Received: from [192.168.123.70] ([62.143.247.63]) by mail.gmx.net (mrgmx104 [212.227.17.168]) with ESMTPSA (Nemesis) id 1MEUz4-1lhPaI2zgg-00G2Ka; Fri, 21 May 2021 16:33:00 +0200 Subject: Re: [PATCH 4/5] lib/vsprintf.c: remove unused ip6_addr_string() To: Rasmus Villemoes , u-boot@lists.denx.de Cc: Simon Glass , Tom Rini References: <20210520100528.322846-1-rasmus.villemoes@prevas.dk> <20210520100528.322846-5-rasmus.villemoes@prevas.dk> From: Heinrich Schuchardt Message-ID: Date: Fri, 21 May 2021 16:32:58 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.10.0 MIME-Version: 1.0 In-Reply-To: <20210520100528.322846-5-rasmus.villemoes@prevas.dk> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: quoted-printable X-Provags-ID: V03:K1:ctXv+Fm5lPjxnf3xBiM+2RTi2QyCGJ7p6SfBLmDsPBUI4AUpLBU Wg25LJbCWdSH12iTlIuDcOhMrRkQHFR9nzGECbtGncoi/YNgBH/vp5QbtcOc+MQQSyS7qqM 4nDbjDIraFjVFcMPgvT/J/rmFG9OHRKt65Urra4I+3KDqzyMuwyxnVKgjcfHWJtTXDRe4lu h3QEUiaY+URAIck1f4qQA== X-UI-Out-Filterresults: notjunk:1;V03:K0:RDzCLXtmfBM=:xUzxng83+aMaw+hHFZNfl8 qK4ya5VtXvUQbbvGS6Sekw9PBfSLIoRUTminmvpAGrkEuKb/D10vytI8iMKixj+EQbYgW4lMr UYLOWm1wOVMf+/Zodyw/0+0H9SaIXfOaEhzwVWHgXeVk/lWxWo4EYWYNwvmxqmTXZ+2kNjEk8 5czOpPFg+XyQg+8KyhQOLh7fedlq9SpP1E2DmZx9nkPZaKH/KtktyzZDraOJImi5ZG5Jl3yuQ u3OMw/wcz7P1C0iMzMNNU3OsVALvAu4mJ159+hMEtgcvO9IB08Vp61jO29TbdC01fv8XaO0Fu H2Xty2DWmsvXkVqDN66sYht/djD6T4wkru8BhGdfceOZgZTBO93P53My7cco7mBqnum4UksvG WPsr2aw4Z7MH/im4MeRCQEk0G2TewfjLTad9HRLvkzr+kQCnkq9QKoIxBvH99tpMthrp+qqUf nQDrm4CXhSoc2OvUZlBk9vBZZhlj96kM9hduSGc48Dg3zVGaR/MqL90o4fTuVDz7Mmqpmils7 Iif1I+Wl2qBegZkzRLNCmRW/qQQqLKCpma+Zj+CD1AWOqU1+5TotXFOi010yUcqUf4lXDEKvr yHi62WoRNzgueyC58wY2nk2b3q/RNPeSJbc2jFyNkqucsxEID7bzXfSX6FTwc/dJWRiDR6dFg Xa84sEq0X5oynq2lVXt3Y56idt3/mtkbbYpFxMAPwTYBX5p7ghEH13j+xsS5hZT/D041XQC2v PUabZCi/qoLD056Ryqo3hMqbdf2OhkeecLYqX57jq9MeTjy7inY/V/tINjesjbvFRyHBf0dQz 1YvQd2cYnDxOfBbT7zm0TZOHWMYOAgx2NdXRKp9gjGh7eyM/u6qx8W0YdHFGd6QbLbrKBAD6f nKWc6bbi7QQhXxr0+CjgwAK4ZOa4OcQGmDsRCSVu/8/mgjpoH5nm/BBRNegMkTtWS3tnK/P2Z 8vnHfdieeLB4bHHj3GcmQfJFv2dluWJam4h+r1LGSoUHRKPJbev1KCxnGy5cKQQNO4gusWwdU Pg4glzg+iSQueyWAFuB5sH1r79k3Y0UQ5p1Xvgd9nQuP/6ImmGJ0Qqm5U2DUWxvoZjU1MSKHz 6EdusPfMO1MwpLKtkRgpbv1rIhhb3D0jev2jAQa5h80DSKltoRtrs5UE4zQXfWnH44uYe3vqU fbved3nnGDCriz9XKCL0TE+HwdxYv+IDzoQGAL0xrEkB+jzxvGfGSez20+cw3zTHyP4tw= X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.102.4 at phobos.denx.de X-Virus-Status: Clean On 20.05.21 12:05, Rasmus Villemoes wrote: > There's currently no user of %p[iI]6, so including ip6_addr_string() > in the image is a waste of bytes. It's easy enough to have the > compiler elide it without removing the code completely. > > The closest I can find to anybody "handling" ipv6 in U-Boot currently > is in efi_net.c which does > > if (ipv6) { > ret =3D EFI_UNSUPPORTED; > > As indicated in the comment, it can easily be put back, but preferably > under a config knob. > > Signed-off-by: Rasmus Villemoes > --- > lib/vsprintf.c | 5 ++++- > 1 file changed, 4 insertions(+), 1 deletion(-) > > diff --git a/lib/vsprintf.c b/lib/vsprintf.c > index 65d985982d..6742b0985a 100644 > --- a/lib/vsprintf.c > +++ b/lib/vsprintf.c > @@ -434,6 +434,9 @@ static char *uuid_string(char *buf, char *end, u8 *a= ddr, int field_width, > * - 'i' [46] for 'raw' IPv4/IPv6 addresses, IPv6 omits the colons, IPv= 4 is > * currently the same > * > + * Note: IPv6 support is currently if(0)'ed out. If you ever need > + * %pI6, please add an IPV6 Kconfig knob, make your code select or > + * depend on that, and change the 0 below to CONFIG_IS_ENABLED(IPV6). > */ > static char *pointer(const char *fmt, char *buf, char *end, void *ptr, > int field_width, int precision, int flags) > @@ -478,7 +481,7 @@ static char *pointer(const char *fmt, char *buf, cha= r *end, void *ptr, > flags |=3D SPECIAL; > /* Fallthrough */ > case 'I': > - if (fmt[1] =3D=3D '6') Please, provide a commment like "%pI6 currently unused" here. Best regards Heinrich > + if (0 && fmt[1] =3D=3D '6') > return ip6_addr_string(buf, end, ptr, field_width, > precision, flags); > if (fmt[1] =3D=3D '4') >