From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-lf1-f46.google.com (mail-lf1-f46.google.com [209.85.167.46]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 458DA7C for ; Thu, 8 Sep 2022 11:19:21 +0000 (UTC) Received: by mail-lf1-f46.google.com with SMTP id k10so12559362lfm.4 for ; Thu, 08 Sep 2022 04:19:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date; bh=iNS4D8S65NtETFVlL5t6U8r/BJqMmTweciJ4EUvTtkU=; b=Agb4n/PkJh9KNvgaGgewkPd2pInTS1xvRzqSeJtko+vl6q6Bi/ZF5/0eFTUhkYUbNb GPTiGBvmjQV50ga5vDtJxlaiF9jqaRHlq9gWS3h0tKgxPsNEPM/GXQpjcywZYc8o8+Ly +f9cFHPsCST7fTQIsPAE8MGTqq4WuGMPkkShwUP1z8Up2boqP2iFCyYxtp/xlNCrZzxO yPUUX+MbNB43/GyfKar520l072jW26fqkA5FrKQZs8uAc+i4B4o2fR4Fb1FOwPkxzcsz b9Lce2ZYnEvViv+AsYe1N5cqKgMezKtQKy5dKBFxLLFZQ2zLInkCEQRU17vtPzPOBvSS fG1Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date; bh=iNS4D8S65NtETFVlL5t6U8r/BJqMmTweciJ4EUvTtkU=; b=qtxmH+6BGfVbh5BrIRJ1uepVSJ6qpaDrB6RtZpuFv7MHU6sutSgOiWkVTkwV4IFOXB 5a2VRR1IqiXgd4yd6SUtOFyzkWcQUAoYubAYbCgzr/dkTZy5IQwuOD6CHsay7y+HxyFD xvft1eggwqs57hZn+RVNVVM3lZUyzSlqQvtt0hUhHOVsOfYMi+bl6WK5+E6qVerIhbPm TLPvmjxeD3XqY2CfJLS7DVRd+o7YrtuxpmQqwNXkMwWrJ8j8e7/RADyaVJVgCKMPmBaX UAmywUSXo7irJ97ww1S2kh/0XCuvjijYP1YfXsDF+RWSnYqu71OqUnXW/S5cfrrao/iG 6byQ== X-Gm-Message-State: ACgBeo2IYCgMdtRlP2b7B/ZXI+X33FmEXkxeUMKN6QQHrhPCRlD20wuJ jBkIamhbCgJIMk0tUAQtg72LZQ== X-Google-Smtp-Source: AA6agR69Y8vwmrHUvKObGzWP7Nlk4SetLItoUzeAWtumVSWoKGzQstY7fN7XL6OTB4HvjPFGGx80Rw== X-Received: by 2002:a05:6512:1154:b0:48b:3020:b29 with SMTP id m20-20020a056512115400b0048b30200b29mr2461897lfg.338.1662635959295; Thu, 08 Sep 2022 04:19:19 -0700 (PDT) Received: from [192.168.0.21] (78-11-189-27.static.ip.netia.com.pl. [78.11.189.27]) by smtp.gmail.com with ESMTPSA id i5-20020a056512318500b0048d1101d0d6sm228678lfe.121.2022.09.08.04.19.17 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 08 Sep 2022 04:19:18 -0700 (PDT) Message-ID: Date: Thu, 8 Sep 2022 13:19:17 +0200 Precedence: bulk X-Mailing-List: asahi@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.13.0 Subject: Re: [PATCH v2 2/5] dt-bindings: net: Add Broadcom BCM4377 family PCIe Bluetooth Content-Language: en-US To: Sven Peter , Marcel Holtmann , Johan Hedberg , Luiz Augusto von Dentz , Rob Herring , Krzysztof Kozlowski Cc: "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Hector Martin , Alyssa Rosenzweig , asahi@lists.linux.dev, netdev@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-bluetooth@vger.kernel.org, linux-kernel@vger.kernel.org References: <20220907170935.11757-1-sven@svenpeter.dev> <20220907170935.11757-3-sven@svenpeter.dev> From: Krzysztof Kozlowski In-Reply-To: <20220907170935.11757-3-sven@svenpeter.dev> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 07/09/2022 19:09, Sven Peter wrote: > These chips are combined Wi-Fi/Bluetooth radios which expose a > PCI subfunction for the Bluetooth part. > They are found in Apple machines such as the x86 models with the T2 > chip or the arm64 models with the M1 or M2 chips. > > Signed-off-by: Sven Peter > --- > changes from v1: > - added apple,* pattern to brcm,board-type > - s/PCI/PCIe/ > - fixed 1st reg cell inside the example to not contain the bus number > > .../bindings/net/brcm,bcm4377-bluetooth.yaml | 78 +++++++++++++++++++ > MAINTAINERS | 1 + > 2 files changed, 79 insertions(+) > create mode 100644 Documentation/devicetree/bindings/net/brcm,bcm4377-bluetooth.yaml > > diff --git a/Documentation/devicetree/bindings/net/brcm,bcm4377-bluetooth.yaml b/Documentation/devicetree/bindings/net/brcm,bcm4377-bluetooth.yaml > new file mode 100644 > index 000000000000..fb851f8e6bcb > --- /dev/null > +++ b/Documentation/devicetree/bindings/net/brcm,bcm4377-bluetooth.yaml > @@ -0,0 +1,78 @@ > +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/net/brcm,bcm4377-bluetooth.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Broadcom BCM4377 family PCIe Bluetooth Chips > + > +allOf: > + - $ref: bluetooth-controller.yaml# Put it before properties (so after description). > + > +maintainers: > + - Sven Peter > + > +description: > + This binding describes Broadcom BCM4377 family PCIe-attached bluetooth chips > + usually found in Apple machines. The Wi-Fi part of the chip is described in > + bindings/net/wireless/brcm,bcm4329-fmac.yaml. > + > +properties: > + compatible: > + enum: > + - pci14e4,5fa0 # BCM4377 > + - pci14e4,5f69 # BCM4378 > + - pci14e4,5f71 # BCM4387 > + > + reg: > + description: PCI device identifier. maxItems: X > + > + brcm,board-type: > + $ref: /schemas/types.yaml#/definitions/string > + description: Board type of the Bluetooth chip. This is used to decouple > + the overall system board from the Bluetooth module and used to construct > + firmware and calibration data filenames. > + On Apple platforms, this should be the Apple module-instance codename > + prefixed by "apple,", e.g. "apple,atlantisb". > + pattern: '^apple,.*' > + > + brcm,taurus-cal-blob: > + $ref: /schemas/types.yaml#/definitions/uint8-array > + description: A per-device calibration blob for the Bluetooth radio. This > + should be filled in by the bootloader from platform configuration > + data, if necessary, and will be uploaded to the device. > + This blob is used if the chip stepping of the Bluetooth module does not > + support beamforming. Isn't it: s/beamforming/beam forming/ ? > + > + brcm,taurus-bf-cal-blob: > + $ref: /schemas/types.yaml#/definitions/uint8-array > + description: A per-device calibration blob for the Bluetooth radio. This > + should be filled in by the bootloader from platform configuration > + data, if necessary, and will be uploaded to the device. > + This blob is used if the chip stepping of the Bluetooth module supports > + beamforming. Same here. > + > + local-bd-address: true > + > +required: > + - compatible > + - reg > + - local-bd-address > + - brcm,board-type > + > +additionalProperties: false > + > +examples: > + - | > + pcie { > + #address-cells = <3>; > + #size-cells = <2>; > + > + bluetooth@0,1 { The unit address seems to be different than reg. > + compatible = "pci14e4,5f69"; > + reg = <0x100 0x0 0x0 0x0 0x0>; > + brcm,board-type = "apple,honshu"; > + /* To be filled by the bootloader */ > + local-bd-address = [00 00 00 00 00 00]; > + }; > + }; Best regards, Krzysztof From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 4972DC54EE9 for ; Thu, 8 Sep 2022 11:20:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To: Subject:MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=hnxY9tkHOq6+aJNI2a58SRKHuxT6znmBikJ61Ya8KgA=; b=e5kaqwkGDN5ELl CubErUjSbob74hN5ni/odnIOgjvCdeiE3cpewWQmO7B5lxyXvcI5NzKPZVvFXXNQUJT2QYQdqIrJA GcuCXDu6jEBN5hJVbzZIK6+czMhfX5Y5gcxbeihrA69QrCqWeMCxPy1IwLkzlPxrTUnCYj/+2j/2m z2hWAPzSRMRXqhlT/kUexCZADDb1xtMT4yA0NmEwTnFd8LGyNnAdGmVCrx/5oxcynAHWuWkXrxWvE kAtfV/fjXtqM+KVL7b87ij2dpwd7XlU2APbdRoAzkj8PDP8X2yPIFWdzReXjsQSH4rAcSPxwMODpw t/ccEA/ZPHQYMMw8qmFg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1oWFZA-002eYb-2k; Thu, 08 Sep 2022 11:19:28 +0000 Received: from mail-lf1-x134.google.com ([2a00:1450:4864:20::134]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1oWFZ3-002eUK-29 for linux-arm-kernel@lists.infradead.org; Thu, 08 Sep 2022 11:19:23 +0000 Received: by mail-lf1-x134.google.com with SMTP id m15so7484880lfl.9 for ; Thu, 08 Sep 2022 04:19:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date; bh=iNS4D8S65NtETFVlL5t6U8r/BJqMmTweciJ4EUvTtkU=; b=Agb4n/PkJh9KNvgaGgewkPd2pInTS1xvRzqSeJtko+vl6q6Bi/ZF5/0eFTUhkYUbNb GPTiGBvmjQV50ga5vDtJxlaiF9jqaRHlq9gWS3h0tKgxPsNEPM/GXQpjcywZYc8o8+Ly +f9cFHPsCST7fTQIsPAE8MGTqq4WuGMPkkShwUP1z8Up2boqP2iFCyYxtp/xlNCrZzxO yPUUX+MbNB43/GyfKar520l072jW26fqkA5FrKQZs8uAc+i4B4o2fR4Fb1FOwPkxzcsz b9Lce2ZYnEvViv+AsYe1N5cqKgMezKtQKy5dKBFxLLFZQ2zLInkCEQRU17vtPzPOBvSS fG1Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date; bh=iNS4D8S65NtETFVlL5t6U8r/BJqMmTweciJ4EUvTtkU=; b=pPB2IfqQFSRDDs9ODhP4PQYihmWUgBR69WyV43wAdsipD5hrb8LQNyWhMiUX7Rt/qi mBsiNbr0vZUBisYW1+WNDm00WgQFv4FULB8Vx8OGuCdl+sjt5Q2UY0BZwDYrreeVfBdu DIs/Ui5R68M2/sb7AJnkPz1Nd7addtMaw80u4A1c6bOS9xhcP2JNM91ySLYLvj9HPGG2 vpcysXU09z8QyXfrBxkCpGX+XO89aFngnye50GHvmQg0QhyybRHKH0LbkPi93ua4UUuO 1CfY7xWmw+Qyd7ttV712b8AgCB38N9AW1doECgwz2W0XjwjMaqsZvfgxkDOw033zK00y blxQ== X-Gm-Message-State: ACgBeo3T7PbAJTB5/YrFBi1oJ7P4IsPnGqMhnYz4TbIh6wHGPc/awfez QYnhtcsO6DaN0PBaLG7xy70Pcg== X-Google-Smtp-Source: AA6agR69Y8vwmrHUvKObGzWP7Nlk4SetLItoUzeAWtumVSWoKGzQstY7fN7XL6OTB4HvjPFGGx80Rw== X-Received: by 2002:a05:6512:1154:b0:48b:3020:b29 with SMTP id m20-20020a056512115400b0048b30200b29mr2461897lfg.338.1662635959295; Thu, 08 Sep 2022 04:19:19 -0700 (PDT) Received: from [192.168.0.21] (78-11-189-27.static.ip.netia.com.pl. [78.11.189.27]) by smtp.gmail.com with ESMTPSA id i5-20020a056512318500b0048d1101d0d6sm228678lfe.121.2022.09.08.04.19.17 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 08 Sep 2022 04:19:18 -0700 (PDT) Message-ID: Date: Thu, 8 Sep 2022 13:19:17 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.13.0 Subject: Re: [PATCH v2 2/5] dt-bindings: net: Add Broadcom BCM4377 family PCIe Bluetooth Content-Language: en-US To: Sven Peter , Marcel Holtmann , Johan Hedberg , Luiz Augusto von Dentz , Rob Herring , Krzysztof Kozlowski Cc: "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Hector Martin , Alyssa Rosenzweig , asahi@lists.linux.dev, netdev@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-bluetooth@vger.kernel.org, linux-kernel@vger.kernel.org References: <20220907170935.11757-1-sven@svenpeter.dev> <20220907170935.11757-3-sven@svenpeter.dev> From: Krzysztof Kozlowski In-Reply-To: <20220907170935.11757-3-sven@svenpeter.dev> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220908_041921_286909_AD8F5EA0 X-CRM114-Status: GOOD ( 26.64 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 07/09/2022 19:09, Sven Peter wrote: > These chips are combined Wi-Fi/Bluetooth radios which expose a > PCI subfunction for the Bluetooth part. > They are found in Apple machines such as the x86 models with the T2 > chip or the arm64 models with the M1 or M2 chips. > > Signed-off-by: Sven Peter > --- > changes from v1: > - added apple,* pattern to brcm,board-type > - s/PCI/PCIe/ > - fixed 1st reg cell inside the example to not contain the bus number > > .../bindings/net/brcm,bcm4377-bluetooth.yaml | 78 +++++++++++++++++++ > MAINTAINERS | 1 + > 2 files changed, 79 insertions(+) > create mode 100644 Documentation/devicetree/bindings/net/brcm,bcm4377-bluetooth.yaml > > diff --git a/Documentation/devicetree/bindings/net/brcm,bcm4377-bluetooth.yaml b/Documentation/devicetree/bindings/net/brcm,bcm4377-bluetooth.yaml > new file mode 100644 > index 000000000000..fb851f8e6bcb > --- /dev/null > +++ b/Documentation/devicetree/bindings/net/brcm,bcm4377-bluetooth.yaml > @@ -0,0 +1,78 @@ > +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/net/brcm,bcm4377-bluetooth.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Broadcom BCM4377 family PCIe Bluetooth Chips > + > +allOf: > + - $ref: bluetooth-controller.yaml# Put it before properties (so after description). > + > +maintainers: > + - Sven Peter > + > +description: > + This binding describes Broadcom BCM4377 family PCIe-attached bluetooth chips > + usually found in Apple machines. The Wi-Fi part of the chip is described in > + bindings/net/wireless/brcm,bcm4329-fmac.yaml. > + > +properties: > + compatible: > + enum: > + - pci14e4,5fa0 # BCM4377 > + - pci14e4,5f69 # BCM4378 > + - pci14e4,5f71 # BCM4387 > + > + reg: > + description: PCI device identifier. maxItems: X > + > + brcm,board-type: > + $ref: /schemas/types.yaml#/definitions/string > + description: Board type of the Bluetooth chip. This is used to decouple > + the overall system board from the Bluetooth module and used to construct > + firmware and calibration data filenames. > + On Apple platforms, this should be the Apple module-instance codename > + prefixed by "apple,", e.g. "apple,atlantisb". > + pattern: '^apple,.*' > + > + brcm,taurus-cal-blob: > + $ref: /schemas/types.yaml#/definitions/uint8-array > + description: A per-device calibration blob for the Bluetooth radio. This > + should be filled in by the bootloader from platform configuration > + data, if necessary, and will be uploaded to the device. > + This blob is used if the chip stepping of the Bluetooth module does not > + support beamforming. Isn't it: s/beamforming/beam forming/ ? > + > + brcm,taurus-bf-cal-blob: > + $ref: /schemas/types.yaml#/definitions/uint8-array > + description: A per-device calibration blob for the Bluetooth radio. This > + should be filled in by the bootloader from platform configuration > + data, if necessary, and will be uploaded to the device. > + This blob is used if the chip stepping of the Bluetooth module supports > + beamforming. Same here. > + > + local-bd-address: true > + > +required: > + - compatible > + - reg > + - local-bd-address > + - brcm,board-type > + > +additionalProperties: false > + > +examples: > + - | > + pcie { > + #address-cells = <3>; > + #size-cells = <2>; > + > + bluetooth@0,1 { The unit address seems to be different than reg. > + compatible = "pci14e4,5f69"; > + reg = <0x100 0x0 0x0 0x0 0x0>; > + brcm,board-type = "apple,honshu"; > + /* To be filled by the bootloader */ > + local-bd-address = [00 00 00 00 00 00]; > + }; > + }; Best regards, Krzysztof _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel