From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from relaydlg-01.paragon-software.com (relaydlg-01.paragon-software.com [81.5.88.159]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C52BC2C93 for ; Wed, 6 Oct 2021 14:47:05 +0000 (UTC) Received: from dlg2.mail.paragon-software.com (vdlg-exch-02.paragon-software.com [172.30.1.105]) by relaydlg-01.paragon-software.com (Postfix) with ESMTPS id 242DD820BB; Wed, 6 Oct 2021 17:47:04 +0300 (MSK) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=paragon-software.com; s=mail; t=1633531624; bh=Pw9hI4lsPJ1rdGR/XG9311bw97T6BOdPPTpkqyVhOSs=; h=Date:Subject:To:CC:References:From:In-Reply-To; b=arN2NQvC6BVoGD2VXZ09ZJCmiVU3RJC6569dmIW/eJ6+Vg7ykjquaRb9MA+AlYxxS OQmJSRGMBYOTZbTn2t4385frrCDKK+j5h1dR0bAbMLm4sTNX5P5+RmnuYaLkI2IKWG YLt2wsyQoh+spqf5QjLObtILAiKyliyM7gR2eCOo= Received: from [192.168.211.53] (192.168.211.53) by vdlg-exch-02.paragon-software.com (172.30.1.105) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2176.2; Wed, 6 Oct 2021 17:47:03 +0300 Message-ID: Date: Wed, 6 Oct 2021 17:47:03 +0300 Precedence: bulk X-Mailing-List: ntfs3@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.1.2 Subject: Re: [PATCH] fs/ntfs3: Check for NULL if ATTR_EA_INFO is incorrect Content-Language: en-US To: Mohammad Rasim , Kari Argillander CC: , , References: <227c13e3-5a22-0cba-41eb-fcaf41940711@paragon-software.com> <20211003175036.ly4m3lw2bjoippsh@kari-VirtualBox> From: Konstantin Komarov In-Reply-To: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit X-Originating-IP: [192.168.211.53] X-ClientProxiedBy: vdlg-exch-02.paragon-software.com (172.30.1.105) To vdlg-exch-02.paragon-software.com (172.30.1.105) On 04.10.2021 23:39, Mohammad Rasim wrote: > > On 10/3/21 20:50, Kari Argillander wrote: >> On Wed, Sep 29, 2021 at 07:35:43PM +0300, Konstantin Komarov wrote: >>> This can be reason for reported panic. >>> Fixes: 4342306f0f0d ("fs/ntfs3: Add file operations and implementation") >> I see that you have include this to devel branch but you did not send V2 >> [1]. I also included Mohammad Rasim to this thread. Maybe they can test >> this patch. Rasim can you test [2] if your problem will be fixed with >> this tree. Or just test this patch if you prefer that way. >> >> [1]: github.com/Paragon-Software-Group/linux-ntfs3/commit/35afb70dcfe4eb445060dd955e5b67d962869ce5 >> [2]: github.com/Paragon-Software-Group/linux-ntfs3/tree/devel > > Yeah unfortunately the problem still exist, moving the buildroot git tree from my nvme ext4 partition to my wd ntfs partition still causes the panic. > > Note that i used the master branch if that matters but it contains the same commit > > > Regards > Is panic the same as old one? BUG: kernel NULL pointer dereference, address: 000000000000000e RIP: 0010:ni_write_inode+0xe6b/0xed0 [ntfs3] etc. >>> Signed-off-by: Konstantin Komarov >>> --- >>>   fs/ntfs3/frecord.c | 4 +++- >>>   1 file changed, 3 insertions(+), 1 deletion(-) >>> >>> diff --git a/fs/ntfs3/frecord.c b/fs/ntfs3/frecord.c >>> index 9a53f809576d..007602badd90 100644 >>> --- a/fs/ntfs3/frecord.c >>> +++ b/fs/ntfs3/frecord.c >>> @@ -3080,7 +3080,9 @@ static bool ni_update_parent(struct ntfs_inode *ni, struct NTFS_DUP_INFO *dup, >>>                          const struct EA_INFO *info; >>>                            info = resident_data_ex(attr, sizeof(struct EA_INFO)); >>> -                       dup->ea_size = info->size_pack; >>> +                       /* If ATTR_EA_INFO exists 'info' can't be NULL. */ >>> +                       if (info) >>> +                               dup->ea_size = info->size_pack; >>>                  } >>>          } >>>   --  >>> 2.33.0 >>>