From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0B4FFC433EF for ; Tue, 30 Nov 2021 17:16:36 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238493AbhK3RTv (ORCPT ); Tue, 30 Nov 2021 12:19:51 -0500 Received: from linux.microsoft.com ([13.77.154.182]:33650 "EHLO linux.microsoft.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232181AbhK3RTJ (ORCPT ); Tue, 30 Nov 2021 12:19:09 -0500 Received: from [192.168.254.32] (unknown [47.187.212.181]) by linux.microsoft.com (Postfix) with ESMTPSA id B6BEE20DED70; Tue, 30 Nov 2021 09:15:49 -0800 (PST) DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com B6BEE20DED70 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com; s=default; t=1638292550; bh=wkVF+KmAVekeXtq/dNGof3Ieis7OrebbdJMsotX+cZk=; h=Subject:To:Cc:References:From:Date:In-Reply-To:From; b=aasZm6vaAMLTEgy2AGEe2jZz+44yK5Yq02mlMPB7eRz0nV/7XKkw0s0clfE2Ewgzq otF5scQwOM33aunAPk2iHfMVJNFfMIhTtFWFxl7/TG34ekHnY1s3MWmwJppbtT41wf PwABVKJo/G9Glrt0abJOpSmz0xAeBFjeASGvDUoI= Subject: Re: [PATCH v11 2/5] arm64: Rename unwinder functions To: Mark Rutland Cc: broonie@kernel.org, jpoimboe@redhat.com, ardb@kernel.org, nobuta.keiya@fujitsu.com, sjitindarsingh@gmail.com, catalin.marinas@arm.com, will@kernel.org, jmorris@namei.org, linux-arm-kernel@lists.infradead.org, live-patching@vger.kernel.org, linux-kernel@vger.kernel.org References: <8b861784d85a21a9bf08598938c11aff1b1249b9> <20211123193723.12112-1-madvenka@linux.microsoft.com> <20211123193723.12112-3-madvenka@linux.microsoft.com> From: "Madhavan T. Venkataraman" Message-ID: Date: Tue, 30 Nov 2021 11:15:48 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.14.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 11/30/21 9:08 AM, Mark Rutland wrote: > On Tue, Nov 23, 2021 at 01:37:20PM -0600, madvenka@linux.microsoft.com wrote: >> From: "Madhavan T. Venkataraman" >> >> Rename unwinder functions for consistency and better naming. >> >> - Rename start_backtrace() to unwind_start(). >> - Rename unwind_frame() to unwind_next(). >> - Rename walk_stackframe() to unwind(). > > Super trivial, but could we s/unwind_start/unwind_init/ ? That makes it > slightly clearer that it's not performing an unwind step. > > Otherwise, this looks good to me. > Will do. > For the rename: > > Acked-by: Mark Rutland > > It's be nice if we could also clean up 'struct stackframe' into 'struct > unwind_state', but that can be a follow-up, and this is fine as it is, modulo > the super trivial comment above. > I could do this rename as well in the next version if you want. Might as well get all the renaming done in one shot. Thanks, Madhavan From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D24F3C433EF for ; Tue, 30 Nov 2021 17:17:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date: Message-ID:From:References:Cc:To:Subject:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Owner; bh=IyIvGwOhrkrVW7jvch0VMXCwnt5SLJkvzIUy+rJWe94=; b=BEiBHyqP8Ka5PkIX1wWON0HrK8 4A98i6e6PYMoNBt6F7x+UXiTr6Dxlf3buU5LJgO2QviofdThOF9tZ9nWrHvXvlWXIEmDN7RgACc8z AJqu2+VMCAFZEs0USlfu1GuPFIzS/eV3PlYiKuMvE6BWQBxrviUL+lqphNBtPPK5xMYIGQQwfyt1C L6rrpeCagvjs28QU8VStnbPTHE9uU/s91D4NGALIyJT4GDz774BSG1CIGHf2YgvdLSC+Th7KtriZa IZFgQaV+GVHx+Dv7QMlNkGbpdhAyKb2sT+jWw0Tq32KqLeoffkp4Iy2P44DY8FAayRTHifFCdKagc 4md2S3/A==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1ms6jS-006HJM-Ub; Tue, 30 Nov 2021 17:15:55 +0000 Received: from linux.microsoft.com ([13.77.154.182]) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1ms6jO-006HIn-Sd for linux-arm-kernel@lists.infradead.org; Tue, 30 Nov 2021 17:15:52 +0000 Received: from [192.168.254.32] (unknown [47.187.212.181]) by linux.microsoft.com (Postfix) with ESMTPSA id B6BEE20DED70; Tue, 30 Nov 2021 09:15:49 -0800 (PST) DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com B6BEE20DED70 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com; s=default; t=1638292550; bh=wkVF+KmAVekeXtq/dNGof3Ieis7OrebbdJMsotX+cZk=; h=Subject:To:Cc:References:From:Date:In-Reply-To:From; b=aasZm6vaAMLTEgy2AGEe2jZz+44yK5Yq02mlMPB7eRz0nV/7XKkw0s0clfE2Ewgzq otF5scQwOM33aunAPk2iHfMVJNFfMIhTtFWFxl7/TG34ekHnY1s3MWmwJppbtT41wf PwABVKJo/G9Glrt0abJOpSmz0xAeBFjeASGvDUoI= Subject: Re: [PATCH v11 2/5] arm64: Rename unwinder functions To: Mark Rutland Cc: broonie@kernel.org, jpoimboe@redhat.com, ardb@kernel.org, nobuta.keiya@fujitsu.com, sjitindarsingh@gmail.com, catalin.marinas@arm.com, will@kernel.org, jmorris@namei.org, linux-arm-kernel@lists.infradead.org, live-patching@vger.kernel.org, linux-kernel@vger.kernel.org References: <8b861784d85a21a9bf08598938c11aff1b1249b9> <20211123193723.12112-1-madvenka@linux.microsoft.com> <20211123193723.12112-3-madvenka@linux.microsoft.com> From: "Madhavan T. Venkataraman" Message-ID: Date: Tue, 30 Nov 2021 11:15:48 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.14.0 MIME-Version: 1.0 In-Reply-To: Content-Language: en-US X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211130_091550_986272_3F8EDADA X-CRM114-Status: GOOD ( 14.87 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 11/30/21 9:08 AM, Mark Rutland wrote: > On Tue, Nov 23, 2021 at 01:37:20PM -0600, madvenka@linux.microsoft.com wrote: >> From: "Madhavan T. Venkataraman" >> >> Rename unwinder functions for consistency and better naming. >> >> - Rename start_backtrace() to unwind_start(). >> - Rename unwind_frame() to unwind_next(). >> - Rename walk_stackframe() to unwind(). > > Super trivial, but could we s/unwind_start/unwind_init/ ? That makes it > slightly clearer that it's not performing an unwind step. > > Otherwise, this looks good to me. > Will do. > For the rename: > > Acked-by: Mark Rutland > > It's be nice if we could also clean up 'struct stackframe' into 'struct > unwind_state', but that can be a follow-up, and this is fine as it is, modulo > the super trivial comment above. > I could do this rename as well in the next version if you want. Might as well get all the renaming done in one shot. Thanks, Madhavan _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel