From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B7494C4332F for ; Tue, 11 Jan 2022 16:15:19 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 8AF8180562; Tue, 11 Jan 2022 17:15:17 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=fail (p=none dis=none) header.from=seco.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=fail reason="signature verification failed" (1024-bit key; unprotected) header.d=secospa.onmicrosoft.com header.i=@secospa.onmicrosoft.com header.b="n5Ebj11S"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 1B2CF80FD5; Tue, 11 Jan 2022 17:15:16 +0100 (CET) Received: from EUR05-AM6-obe.outbound.protection.outlook.com (mail-am6eur05on2062f.outbound.protection.outlook.com [IPv6:2a01:111:f400:7e1b::62f]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id E7054803CA for ; Tue, 11 Jan 2022 17:15:12 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=seco.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=sean.anderson@seco.com ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=cGBXXCzDgaFNf1GcGrJviwhvNFNNFe8GcSvcgniN4sTOUIYjLRneBl6VZL1oUmlejgqsNR59lIoAJBz9VlqLB72SaQrMuN/biIANW7YHKWp7drnkUcRZjgvFHa8GayEcc1t3Te/Ky1WkdYKyrnrIX56mFmtWSyh1i7qFwovxGN2kWoJPfAPGTzcFyLxjV6xU39fHc9TqvG6PNAgGbS3Aoa8FyM9AG3JhpGL8yIzYzQYExaVCfKmdY8ZvkCYAb4Qi+LhT9saBK8EN3cFjcEQu1Ym5za8BAUqg00kqlKy7I8dWA1s8k85/Kzmqyu2vsoAL+rzMhnGP05OVW5dZieY/rA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=/BfpEBHjhyxSpuwuDLLnR9oDzu3Fp/WmvLTBSK7jW24=; b=SA34pvG8PgnG/KAazKUpPvyuVf/HkJrk9h1MQNnwuRMZkwMC0QjMJzwPzC2NNCnYTYAZsswVx8EPZcM3wDN4xGL9QEnmVGcLIBm/B9+iIx4dlkmOS8MggVPgPMeLwHFbmrtllPMPAXyB5SCHQJDRZsFtcO5cNf+brjQa1CvE8jXctYUZJp35Hxt2yjYkVQrxbQuHlczsuMfm0/5IjdYUe7A+iZpFWM5Ql6FVwIU7Rjb0JEFLSrLL+Y5LQJPerXOBXZPPiwP0D/Gn4ivfSbUePQdEam2DOvxWVpis133NyJS+8HYErsuwTVZF2h8t7on4Jr20RqeUq6z87uH3kvpixA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=seco.com; dmarc=pass action=none header.from=seco.com; dkim=pass header.d=seco.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=secospa.onmicrosoft.com; s=selector2-secospa-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=/BfpEBHjhyxSpuwuDLLnR9oDzu3Fp/WmvLTBSK7jW24=; b=n5Ebj11S+9KH+7ORSCOIH3taiSZNFr07pLpvGIicVPTobcom6FXtutO5A6PgFBjIZ532tyy5UjF9IDASewqKHrRkeXwHphpkMEW77+OxYit2Jnwfd9YmX5iRtJwXRgGvaHM5nhuKF760cUwOvForOgVa757rXes84GUDi1p6vOU= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=seco.com; Received: from DB7PR03MB4523.eurprd03.prod.outlook.com (2603:10a6:10:19::27) by AM7PR03MB6481.eurprd03.prod.outlook.com (2603:10a6:20b:1c1::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4888.9; Tue, 11 Jan 2022 16:15:11 +0000 Received: from DB7PR03MB4523.eurprd03.prod.outlook.com ([fe80::d47e:81b0:256:3005]) by DB7PR03MB4523.eurprd03.prod.outlook.com ([fe80::d47e:81b0:256:3005%4]) with mapi id 15.20.4888.009; Tue, 11 Jan 2022 16:15:11 +0000 Subject: Re: [RESEND PATCH v3 01/12] mmc: fsl_esdhc_imx: make BLK as hard requirement of DM_MMC To: Jaehoon Chung , u-boot@lists.denx.de, Peng Fan Cc: Haibo Chen , Fabio Estevam , Yangbo Lu , Michael Walle References: <20211123200347.3772343-1-sean.anderson@seco.com> <17862939-c7b1-310e-d98e-ce68f776ee40@seco.com> From: Sean Anderson Message-ID: Date: Tue, 11 Jan 2022 11:15:07 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 In-Reply-To: Content-Type: text/plain; charset=windows-1252; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit X-ClientProxiedBy: MN2PR15CA0008.namprd15.prod.outlook.com (2603:10b6:208:1b4::21) To DB7PR03MB4523.eurprd03.prod.outlook.com (2603:10a6:10:19::27) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: f40d1e24-4f57-48ba-8a1e-08d9d51d8af4 X-MS-TrafficTypeDiagnostic: AM7PR03MB6481:EE_ X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:4714; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: JdXkHebDG9nXDMZBwzE7jdzxxEKXTIK/wfmR1obzivFKVtLUzW/fgnhFGKjoAP00SQNjyhHfgiToFEe5W6uyCBexLasBiUwCtkqFghdTcipNUuZFn988pCht2HgkMIjdxyNTimOuiWrgt2pYQExjydc3TYMcSNLAWEawGS1IifG+czks/1i3mlt0qex0A7XvrTVgjKg3/ZFWLEK9cewHVHFc+ccvtPYx0UBgcgXoegMcvmYYCofkpqFuLabWeoH85gbtkejcSK++R5o098nQEhRflN5pyR9jJCv5i1mjtfgyEawn5eTeS3ywHIu3dUwl8DPymO6TLWMJn6IM/TB+Y477IDDQi69dDuiBaXDD9EQQFl3+MPfcNx9CyAzp68B13F0c8V+qTnDtW5dRaQWR3xgRCvLQC2kLIYqZ7kcmdMhsdL+GuSlmvHqEdQ8Y3khD2aISgluCyfgzki+q7mLxQgGMtb10VWRm5j5q/qme3TTU88L7axggjYsHLuGKf83pPFSe8fwJ6kOk1HH+JnbkR94ZR4qEqhi4DlQyl5CSylALL+3vXlM+uTcMLbv98nC8r+xAygR1k1fOF7/z46q869rLemEAXNZfSNVmum/xLDf84KavWjEvPnEJqNQx5bYgBZ7fldxP2v1COyFNReK+3KtBEkYzLWq/dEObDV14BGiqQ9ReU2G5Z+A2T3xlOIJm2urAHknUoJgm9mfOe3i1NYBVZ6o4+aaRtGQxTrzEDykbFv3mqwokmw+RH/pJ3iXsmS4HlY/JxSylYPBmu8Vq98WjNnMXPCNZVSnpuAe7aTV6ZMXuNdTzCJERlB4RicOKfI5n/ZTnxg4Xf0hRonMD7jHwdJBk6Eqm4tWFDNFN1pA= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DB7PR03MB4523.eurprd03.prod.outlook.com; PTR:; CAT:NONE; SFS:(136003)(39850400004)(396003)(366004)(376002)(346002)(2906002)(54906003)(110136005)(6486002)(66476007)(52116002)(508600001)(5660300002)(2616005)(66556008)(316002)(36756003)(86362001)(4326008)(38100700002)(38350700002)(6666004)(53546011)(31696002)(8676002)(966005)(26005)(8936002)(66946007)(83380400001)(44832011)(6512007)(31686004)(186003)(6506007)(43740500002)(45980500001); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?Windows-1252?Q?83r64eiaIygrk1KUp4cvNJTOa6YN69CbazWr1Ug56k0GaujPqTVKJxQt?= =?Windows-1252?Q?fGo4BN+vmxeHDwF9qziumptG642ZYNXO0F/XV9oHT/KGZriaiQLsqFhO?= =?Windows-1252?Q?B3jeNV7TcMTTbgb3Om/r+8POftWQO5HpNcHNUVZUZVlN7WOVHg3H6Z2U?= =?Windows-1252?Q?EIHmQ1r09S+j/QXDjCXTZ0qPfqtEKc7WFnWnNSxtSdKmWd+ih8RSTPRs?= =?Windows-1252?Q?Hy08VDOcry2vtdIC0CZWa348sOTyDBs22N9fiNSiAFV0VT9/W1tAo2Kh?= =?Windows-1252?Q?LDJ0kr438zMEUNzaUVNJT90QqIFPAgmm1yJCjcO+0vBovzbKFPI39YbN?= =?Windows-1252?Q?ibPUIZmRp7e5IyF/3kRkaEfLJRvYrRhd4Zm8S6UBZLUiMARQ1jNhHvRd?= =?Windows-1252?Q?5UjPe9s96pps2OKCXIDx7q4FoMrSnPq765R/PboLgRuh+S0nz5G+B2YU?= =?Windows-1252?Q?/1S6DRc9ZopP5EQrkw/0XylipZxs+T/Tx0YJZQ2J57aS9OTgbRWhbb9M?= =?Windows-1252?Q?7jnRzuSl/y+S/QvZJpb0k2FlE80zyADpQNJymWAb2TTZ7bfZznz0MW0d?= =?Windows-1252?Q?w2fommHtTv6g5jDhGD+UURf0pKg+ehB/yi77QNworvZHgoIi28j3skJI?= =?Windows-1252?Q?DwiJX8slJ7AeTAAGBE1E2f7RTDe+cQKMYhqVi+3cyI1yFrTBpXmo52oT?= =?Windows-1252?Q?YsCuJcgy+Htb9LiMOA+/qa/X8QHgkHL+M6wGTQojLLyLdL7PSZtwMD+W?= =?Windows-1252?Q?1IK7F7oGOnEokRyRO6BX2C+c3M363Sh79DisK0EjtiQFEBDwakWcor9C?= =?Windows-1252?Q?g3rx96Db7QEUwkFh34rjfVtWYk9jWWa2VlMgGWuvcHU8NQFJP1XUHM6U?= =?Windows-1252?Q?kYaib0EnPfzjWJmdDRvdyPql8hxNNlIZdYkn5+A479sjNXo4iFMQOn0M?= =?Windows-1252?Q?TFr34xTZDiRtxZHYcZgDc9MOr80OL+5Ch17yZHDsGEjAGhqAaiIzwuKm?= =?Windows-1252?Q?kaCHW01F7CRmsdD0fCuKIp7Pn1R/ORQGxkKQBohEqDvjTHeEGT8Ltvck?= =?Windows-1252?Q?7ZrOmq+wVlBfVPnZtDqOFoNffFPReLJseciqyLV/+aeEbWhamD/LFGTI?= =?Windows-1252?Q?xVygwSDQBHA6aXoIeXfRFDoobWv04d7wI7xtctOQjdxoaccpE+nvi6ez?= =?Windows-1252?Q?35TWftW8Uk1DLrZ2RF0U5zg1UtTuKCDZpcT7EFBcy1+QZzhrB64LQcNJ?= =?Windows-1252?Q?5UtjrVbuasx3m6OCFVsYAGt2cI0xoQfJd287X1It88aCjwM/qNVCAIx8?= =?Windows-1252?Q?jDNlxAtzBIKE5pclC2QOaOBq+bxqCTCJD16IgWqGWMCB7sUsytfzQAe2?= =?Windows-1252?Q?cVHo9EABdfiPZ7S3C9oa5vcEmBw5E8smdieYfZHYpRHyA1SkSm62GrqR?= =?Windows-1252?Q?tL2OnxX4/R6wgDQa2chQY/0TTe91Mciv9jhg8j4seIIeZwFCf3gg/KU5?= =?Windows-1252?Q?g++EWfAyaqAr8WUeZwcMgyPK9WGpg2Uaj7+xeZYuyffVFExNnc/DEdWm?= =?Windows-1252?Q?N3yOM2ma/1T4R143X+CDIvfRg12vSluRXsjKS6eDLlXcvru7d8aNrIpz?= =?Windows-1252?Q?7ZqcZYVgoGVPeG+caYkEALk2LTSFVA/vsVmPzsGDsq20WvX1LbhQ2rCM?= =?Windows-1252?Q?4dDnDgMr8W9balZcfo4lj46K/gq1v4sbnZq4tjgkpX7FJtKEIQnS8m3u?= =?Windows-1252?Q?v+mxQplaYoqbD3vIoso=3D?= X-OriginatorOrg: seco.com X-MS-Exchange-CrossTenant-Network-Message-Id: f40d1e24-4f57-48ba-8a1e-08d9d51d8af4 X-MS-Exchange-CrossTenant-AuthSource: DB7PR03MB4523.eurprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Jan 2022 16:15:11.4654 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: bebe97c3-6438-442e-ade3-ff17aa50e733 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: /Qe6Mhgmz0HL4QYzqVz0TTV5hN3AzehI6AjajMlFHpMBXo+jrK2w27KIOShlzva2R6BaG+CTs5Zj3BH+F+nvQA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM7PR03MB6481 X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean On 1/10/22 8:14 PM, Jaehoon Chung wrote: > Dear Sean, > > On 1/5/22 1:16 AM, Sean Anderson wrote: >> [ fsl_esdhc commit 41dec2fe99512e941261594f522b2e7d485c314b ] >> >> U-boot prefers DM_MMC + BLK for MMC. Now eSDHC driver has already >> support it, so let's force to use it. >> >> - Drop non-BLK support for DM_MMC introduced by below patch. >>   66fa035 mmc: fsl_esdhc: fix probe issue without CONFIG_BLK enabled >> >> - Support only DM_MMC + BLK (assuming BLK is always enabled for DM_MMC). >> >> - Use DM_MMC instead of BLK for conditional compile. > > > Thanks for resend this. But it can't apply your patch from patchwork directly. > https://patchwork.ozlabs.org/project/uboot/patch/17862939-c7b1-310e-d98e-ce68f776ee40@seco.com/ > > If you're ok, I will apply after modified your patch. That's fine; looks like it got mangled a bit by my mail client. --Sean > >> >> Signed-off-by: Yangbo Lu >> Signed-off-by: Sean Anderson >> --- >> >> Changes in v3: >> - Drop Kconfig BLK dependency >> >>  drivers/mmc/fsl_esdhc_imx.c | 33 +-------------------------------- >>  1 file changed, 1 insertion(+), 32 deletions(-) >> >> diff --git a/drivers/mmc/fsl_esdhc_imx.c b/drivers/mmc/fsl_esdhc_imx.c >> index 4c06361bee..85cd72a796 100644 >> --- a/drivers/mmc/fsl_esdhc_imx.c >> +++ b/drivers/mmc/fsl_esdhc_imx.c >> @@ -39,10 +39,6 @@ >>  #include >>  #include >>  -#if !CONFIG_IS_ENABLED(BLK) >> -#include "mmc_private.h" >> -#endif >> - >>  #ifndef ESDHCI_QUIRK_BROKEN_TIMEOUT_VALUE >>  #ifdef CONFIG_FSL_USDHC >>  #define ESDHCI_QUIRK_BROKEN_TIMEOUT_VALUE    1 >> @@ -58,7 +54,6 @@ DECLARE_GLOBAL_DATA_PTR; >>                  IRQSTATEN_DEBE | IRQSTATEN_BRR | IRQSTATEN_BWR | \ >>                  IRQSTATEN_DINT) >>  #define MAX_TUNING_LOOP 40 >> -#define ESDHC_DRIVER_STAGE_VALUE 0xffffffff >>   struct fsl_esdhc { >>      uint    dsaddr;        /* SDMA system address register */ >> @@ -157,7 +152,7 @@ struct fsl_esdhc_priv { >>      unsigned int clock; >>      unsigned int mode; >>      unsigned int bus_width; >> -#if !CONFIG_IS_ENABLED(BLK) >> +#if !CONFIG_IS_ENABLED(DM_MMC) >>      struct mmc *mmc; >>  #endif >>      struct udevice *dev; >> @@ -1510,9 +1505,6 @@ static int fsl_esdhc_probe(struct udevice *dev) >>      struct esdhc_soc_data *data = >>          (struct esdhc_soc_data *)dev_get_driver_data(dev); >>      struct mmc *mmc; >> -#if !CONFIG_IS_ENABLED(BLK) >> -    struct blk_desc *bdesc; >> -#endif >>      int ret; >>   #if CONFIG_IS_ENABLED(OF_PLATDATA) >> @@ -1611,25 +1603,6 @@ static int fsl_esdhc_probe(struct udevice *dev) >>      mmc = &plat->mmc; >>      mmc->cfg = &plat->cfg; >>      mmc->dev = dev; >> -#if !CONFIG_IS_ENABLED(BLK) >> -    mmc->priv = priv; >> - >> -    /* Setup dsr related values */ >> -    mmc->dsr_imp = 0; >> -    mmc->dsr = ESDHC_DRIVER_STAGE_VALUE; >> -    /* Setup the universal parts of the block interface just once */ >> -    bdesc = mmc_get_blk_desc(mmc); >> -    bdesc->if_type = IF_TYPE_MMC; >> -    bdesc->removable = 1; >> -    bdesc->devnum = mmc_get_next_devnum(); >> -    bdesc->block_read = mmc_bread; >> -    bdesc->block_write = mmc_bwrite; >> -    bdesc->block_erase = mmc_berase; >> - >> -    /* setup initial part type */ >> -    bdesc->part_type = mmc->cfg->part_type; >> -    mmc_list_add(mmc); >> -#endif >>       upriv->mmc = mmc; >>  @@ -1740,14 +1713,12 @@ static const struct udevice_id fsl_esdhc_ids[] = { >>      { /* sentinel */ } >>  }; >>  -#if CONFIG_IS_ENABLED(BLK) >>  static int fsl_esdhc_bind(struct udevice *dev) >>  { >>      struct fsl_esdhc_plat *plat = dev_get_plat(dev); >>       return mmc_bind(dev, &plat->mmc, &plat->cfg); >>  } >> -#endif >>   U_BOOT_DRIVER(fsl_esdhc) = { >>      .name    = "fsl_esdhc", >> @@ -1755,9 +1726,7 @@ U_BOOT_DRIVER(fsl_esdhc) = { >>      .of_match = fsl_esdhc_ids, >>      .of_to_plat = fsl_esdhc_of_to_plat, >>      .ops    = &fsl_esdhc_ops, >> -#if CONFIG_IS_ENABLED(BLK) >>      .bind    = fsl_esdhc_bind, >> -#endif >>      .probe    = fsl_esdhc_probe, >>      .plat_auto    = sizeof(struct fsl_esdhc_plat), >>      .priv_auto    = sizeof(struct fsl_esdhc_priv), >