From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-23.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING, NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DBF54C4320A for ; Mon, 9 Aug 2021 09:00:23 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id B44396103B for ; Mon, 9 Aug 2021 09:00:23 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234142AbhHIJAm (ORCPT ); Mon, 9 Aug 2021 05:00:42 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]:35141 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233940AbhHIJAl (ORCPT ); Mon, 9 Aug 2021 05:00:41 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1628499621; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=bM9kpP02f9r/g3VdMnj8Zaen8YVGN2Vayf0/HbSkdec=; b=RHf4lumHJOJr5ypwBCmTRbJo0ki6fMp0L9tKWvrQSG7yBQ37T/bwXqu2W4EJYu4rVkXPqr Gyd1R82SqoUy8IaK6xIaCZDY/O5ZMki9R9n9e2p3hmjgrMpgfcwk6IPolpv6Hf6JhEncQs DHxeA9mRsuo9YPHzQaW/+D+fYZsDslg= Received: from mail-ed1-f70.google.com (mail-ed1-f70.google.com [209.85.208.70]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-436-URde7FBFMtudp46koCIv-A-1; Mon, 09 Aug 2021 05:00:19 -0400 X-MC-Unique: URde7FBFMtudp46koCIv-A-1 Received: by mail-ed1-f70.google.com with SMTP id k14-20020a05640212ceb02903bc50d32c17so8626149edx.12 for ; Mon, 09 Aug 2021 02:00:19 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=bM9kpP02f9r/g3VdMnj8Zaen8YVGN2Vayf0/HbSkdec=; b=oYPQbepr2xG5c8PoUlGO2bgcBGJEUIgNWYsqtaGHgRgFQoBL1cQkOysz0n/Sj8eIdZ PAd4DIrN1sD5eLJmbr9jL/HyT+DeOFzpBYaq6gQEjpBfLlNzYFNytCF1WkVzMPrthY3E O7wntGhcUCqjpFMc3scAVsvjbtzlBm8BFT7rDYdHnS+bFZwIlkeZvVIci+ow/TdscKio vw4ZzIQHYd07WGZg+wfLvjvsGDIsHWGWXBppMGQJemEascluJ9Waj68s+fcaZQ9DgWob zYxQ8ADTlOWRFJ7YQkRDl1mQzKJAi0JQeu6OLs9J0JXTRevbMmrOHeY/VUXpHIcGYLlc slIQ== X-Gm-Message-State: AOAM533eh0I1f+hRBUoV4zy9NVdknzcdkwv4Y3qNEkSeJXvwPlJeez1Z GQ0thrTBIJ7OtQepnzLB65tCX7ZbYbe+cmFWVIaRa1DbKAAcdhC2EPKUCuYNcqXfN9zb1pS8FYK mCpeXvGwevDp18ZYbBxkJLsyY X-Received: by 2002:a50:bb43:: with SMTP id y61mr28265780ede.22.1628499618626; Mon, 09 Aug 2021 02:00:18 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwxejhDaFK1lU/Mdj22pcgEsWm+7KHeAaq6avCqQ1xtRDNgVuNPgWKj4yk7Zt+RqYFU6xdF8A== X-Received: by 2002:a50:bb43:: with SMTP id y61mr28265764ede.22.1628499618446; Mon, 09 Aug 2021 02:00:18 -0700 (PDT) Received: from x1.localdomain ([81.30.35.201]) by smtp.gmail.com with ESMTPSA id s3sm5690626ejm.49.2021.08.09.02.00.18 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 09 Aug 2021 02:00:18 -0700 (PDT) Subject: Re: [PATCH v1 1/1] platform/x86/intel: int33fe: Use y instead of objs in Makefile To: Andy Shevchenko , platform-driver-x86@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Mark Gross References: <20210806154941.4491-1-andriy.shevchenko@linux.intel.com> From: Hans de Goede Message-ID: Date: Mon, 9 Aug 2021 11:00:17 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: <20210806154941.4491-1-andriy.shevchenko@linux.intel.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, On 8/6/21 5:49 PM, Andy Shevchenko wrote: > The 'objs' is for user space tools, for the kernel modules > we should use 'y'. > > Signed-off-by: Andy Shevchenko Thank you for your patch, I've applied this patch to my review-hans branch: https://git.kernel.org/pub/scm/linux/kernel/git/pdx86/platform-drivers-x86.git/log/?h=review-hans Note it will show up in my review-hans branch once I've pushed my local branch there, which might take a while. Once I've run some tests on this branch the patches there will be added to the platform-drivers-x86/for-next branch and eventually will be included in the pdx86 pull-request to Linus for the next merge-window. Regards, Hans > --- > drivers/platform/x86/intel/int33fe/Makefile | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/platform/x86/intel/int33fe/Makefile b/drivers/platform/x86/intel/int33fe/Makefile > index cc11183ce179..9456e3b37f6f 100644 > --- a/drivers/platform/x86/intel/int33fe/Makefile > +++ b/drivers/platform/x86/intel/int33fe/Makefile > @@ -1,5 +1,5 @@ > # SPDX-License-Identifier: GPL-2.0-only > obj-$(CONFIG_INTEL_CHT_INT33FE) += intel_cht_int33fe.o > -intel_cht_int33fe-objs := intel_cht_int33fe_common.o \ > +intel_cht_int33fe-y := intel_cht_int33fe_common.o \ > intel_cht_int33fe_typec.o \ > intel_cht_int33fe_microb.o >