Re: [PATCH v3 3/9] of: irq: add helper to remap interrupts to another irqdomain

From: Marc Zyngier <marc.zyngier@arm.com>
To: Lina Iyer <ilina@codeaurora.org>,
	swboyd@chromium.org, evgreen@chromium.org
Cc: linux-kernel@vger.kernel.org, rplsssn@codeaurora.org,
	linux-arm-msm@vger.kernel.org, thierry.reding@gmail.com,
	bjorn.andersson@linaro.org, dianders@chromium.org,
	linus.walleij@linaro.org
Subject: Re: [PATCH v3 3/9] of: irq: add helper to remap interrupts to another irqdomain
Date: Mon, 11 Mar 2019 10:51:04 +0000	[thread overview]
Message-ID: <bcd89c7e-ab26-f84f-9fe9-8a4958437c04@arm.com> (raw)
In-Reply-To: <20190222221850.26939-4-ilina@codeaurora.org>

On 22/02/2019 22:18, Lina Iyer wrote:
> From: Stephen Boyd <swboyd@chromium.org>
> 
> Sometimes interrupts are routed from an interrupt controller to another
> in no specific order. Having these in the drives makes it difficult to

s/drives/driver/ ?

> maintain when the same drivers supports multiple variants with different
> mapping. Also, specifying them in DT makes little sense with a
> bunch of numbers like -
> 	<0, 13>, <5, 32>,
> It makes more sense when we can have the parent handle along with
> interrupt specificers for the incoming interrupt as well as that of the

specifiers

> outgoing interrupt like -
> 	<22 0 &intc 36 0>,
> 	<24 0 &intc 37 0>,
> 	<26 0 &intc 38 0>,
> And the interrupt specifiers can be interpred using these properties -

interpreted

> 	irqdomain-map-mask = <0xff 0>;
> 	irqdomain-map-pass-thru = <0 0xff>;

Talking about interpretation, can you please expand on how these should
be used? You definitely want to have this documented as a generic
binding somewhere.

Thanks,

	M.
-- 
Jazz is not dead. It just smells funny...