[PATCH 0/7] ARM: dts: exynos: Remove skeleton.dtsi usage and fix memory node DTC warnings

[PATCH 0/7] ARM: dts: exynos: Remove skeleton.dtsi usage and fix memory node DTC warnings

[Javier Martinez Canillas]

Hello Krzysztof,

This series removes the usage of the skeleton.dtsi in all the Exynos dts,
which allows to get rid of the DTC warnings about a mismatch between the
memory nodes' unit names and reg properties.

Patches are pretty trivial and shouldn't cause functional changes AFAIK,
but only the Exynos5 changes have been tested. The others patches were
just built tested.

Best regards,
Javier


Javier Martinez Canillas (7):
  ARM: dts: exynos: Add missing memory node for Exynos5440 boards
  ARM: dts: exynos: Remove skeleton.dtsi usage for Exynos3
  ARM: dts: exynos: Remove skeleton.dtsi usage for Exynos4
  ARM: dts: exynos: Remove skeleton.dtsi usage for Exynos5
  ARM: dts: exynos: Add missing unit name to memory nodes in Exynos3 DTS
  ARM: dts: exynos: Add missing unit name to memory nodes in Exynos4 DTS
  ARM: dts: exynos: Add missing unit name to memory nodes in Exynos5 DTS

 arch/arm/boot/dts/exynos3250-artik5.dtsi           | 3 ++-
 arch/arm/boot/dts/exynos3250-monk.dts              | 3 ++-
 arch/arm/boot/dts/exynos3250-rinato.dts            | 3 ++-
 arch/arm/boot/dts/exynos3250.dtsi                  | 3 ++-
 arch/arm/boot/dts/exynos4.dtsi                     | 3 ++-
 arch/arm/boot/dts/exynos4210-origen.dts            | 3 ++-
 arch/arm/boot/dts/exynos4210-smdkv310.dts          | 3 ++-
 arch/arm/boot/dts/exynos4210-trats.dts             | 3 ++-
 arch/arm/boot/dts/exynos4210-universal_c210.dts    | 3 ++-
 arch/arm/boot/dts/exynos4412-odroidu3.dts          | 3 ++-
 arch/arm/boot/dts/exynos4412-odroidx.dts           | 3 ++-
 arch/arm/boot/dts/exynos4412-odroidx2.dts          | 3 ++-
 arch/arm/boot/dts/exynos4412-origen.dts            | 3 ++-
 arch/arm/boot/dts/exynos4412-smdk4412.dts          | 3 ++-
 arch/arm/boot/dts/exynos4412-tiny4412.dts          | 3 ++-
 arch/arm/boot/dts/exynos4412-trats2.dts            | 3 ++-
 arch/arm/boot/dts/exynos4415.dtsi                  | 3 ++-
 arch/arm/boot/dts/exynos5.dtsi                     | 3 ++-
 arch/arm/boot/dts/exynos5250-arndale.dts           | 3 ++-
 arch/arm/boot/dts/exynos5250-smdk5250.dts          | 3 ++-
 arch/arm/boot/dts/exynos5250-snow-common.dtsi      | 3 ++-
 arch/arm/boot/dts/exynos5250-spring.dts            | 3 ++-
 arch/arm/boot/dts/exynos5260-xyref5260.dts         | 3 ++-
 arch/arm/boot/dts/exynos5260.dtsi                  | 4 ++--
 arch/arm/boot/dts/exynos5410-odroidxu.dts          | 3 ++-
 arch/arm/boot/dts/exynos5410-smdk5410.dts          | 3 ++-
 arch/arm/boot/dts/exynos5420-arndale-octa.dts      | 3 ++-
 arch/arm/boot/dts/exynos5420-peach-pit.dts         | 3 ++-
 arch/arm/boot/dts/exynos5420-smdk5420.dts          | 3 ++-
 arch/arm/boot/dts/exynos5422-odroidxu3-common.dtsi | 3 ++-
 arch/arm/boot/dts/exynos5440-sd5v1.dts             | 5 +++++
 arch/arm/boot/dts/exynos5440-ssdk5440.dts          | 5 +++++
 arch/arm/boot/dts/exynos5440.dtsi                  | 3 ++-
 arch/arm/boot/dts/exynos54xx.dtsi                  | 1 -
 arch/arm/boot/dts/exynos5800-peach-pi.dts          | 3 ++-
 35 files changed, 74 insertions(+), 34 deletions(-)

-- 
2.7.4

[PATCH 1/7] ARM: dts: exynos: Add missing memory node for Exynos5440 boards

[Javier Martinez Canillas]

The skeleton.dtsi file was removed in ARM64 for different reasons as
explained in commit ("3ebee5a2e141 arm64: dts: kill skeleton.dtsi").

These also applies to ARM and it will also allow to get rid of the
following DTC warnings in the future:

"Node /memory has a reg or ranges property, but no unit name"

But these boards don't have a memory node defined, so removing the
skeleton.dtsi inclusion in exynos4.dtsi will cause a change in the
compiled DTB. Add a dummy memory node so the compiled DTB doesn't
change if the skeleton.dtsi is removed from exynos4.dtsi.

Eventually the correct starting addresses and sizes should be used
but I didn't find that information.

Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com>
---

 arch/arm/boot/dts/exynos5440-sd5v1.dts    | 5 +++++
 arch/arm/boot/dts/exynos5440-ssdk5440.dts | 5 +++++
 2 files changed, 10 insertions(+)

diff --git a/arch/arm/boot/dts/exynos5440-sd5v1.dts b/arch/arm/boot/dts/exynos5440-sd5v1.dts
index a98501bab6fc..333db4ff373a 100644
--- a/arch/arm/boot/dts/exynos5440-sd5v1.dts
+++ b/arch/arm/boot/dts/exynos5440-sd5v1.dts
@@ -20,6 +20,11 @@
 		bootargs = "root=/dev/sda2 rw rootwait ignore_loglevel earlyprintk no_console_suspend mem=2048M@0x80000000 mem=6144M@0x100000000 console=ttySAC0,115200";
 	};
 
+	memory {
+		device_type = "memory";
+		reg = <0 0>;
+	};
+
 	fixed-rate-clocks {
 		xtal {
 			compatible = "samsung,clock-xtal";
diff --git a/arch/arm/boot/dts/exynos5440-ssdk5440.dts b/arch/arm/boot/dts/exynos5440-ssdk5440.dts
index 6a0d802e87c8..82fea6f94704 100644
--- a/arch/arm/boot/dts/exynos5440-ssdk5440.dts
+++ b/arch/arm/boot/dts/exynos5440-ssdk5440.dts
@@ -21,6 +21,11 @@
 		bootargs = "root=/dev/sda2 rw rootwait ignore_loglevel earlyprintk no_console_suspend mem=2048M@0x80000000 mem=6144M@0x100000000 console=ttySAC0,115200";
 	};
 
+	memory {
+		device_type = "memory";
+		reg = <0 0>;
+	};
+
 	fixed-rate-clocks {
 		xtal {
 			compatible = "samsung,clock-xtal";
-- 
2.7.4

[PATCH 2/7] ARM: dts: exynos: Remove skeleton.dtsi usage for Exynos3

[Javier Martinez Canillas]

The skeleton.dtsi file was removed in ARM64 for different reasons as
explained in commit ("3ebee5a2e141 arm64: dts: kill skeleton.dtsi").

These also applies to ARM and it will also allow to get rid of the
following DTC warnings in the future:

"Node /memory has a reg or ranges property, but no unit name"

The disassembled DTB are almost the same besides an empty chosen
node being removed and nodes reordered, so it should not have
functional changes.

Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com>
---

 arch/arm/boot/dts/exynos3250-artik5.dtsi | 1 +
 arch/arm/boot/dts/exynos3250-monk.dts    | 1 +
 arch/arm/boot/dts/exynos3250-rinato.dts  | 1 +
 arch/arm/boot/dts/exynos3250.dtsi        | 3 ++-
 4 files changed, 5 insertions(+), 1 deletion(-)

diff --git a/arch/arm/boot/dts/exynos3250-artik5.dtsi b/arch/arm/boot/dts/exynos3250-artik5.dtsi
index 130e946f1414..bedc13bef5d9 100644
--- a/arch/arm/boot/dts/exynos3250-artik5.dtsi
+++ b/arch/arm/boot/dts/exynos3250-artik5.dtsi
@@ -25,6 +25,7 @@
 	};
 
 	memory {
+		device_type = "memory";
 		reg = <0x40000000 0x1ff00000>;
 	};
 
diff --git a/arch/arm/boot/dts/exynos3250-monk.dts b/arch/arm/boot/dts/exynos3250-monk.dts
index 8c8906266310..249fcfd5b297 100644
--- a/arch/arm/boot/dts/exynos3250-monk.dts
+++ b/arch/arm/boot/dts/exynos3250-monk.dts
@@ -28,6 +28,7 @@
 	};
 
 	memory {
+		device_type = "memory";
 		reg =  <0x40000000 0x1ff00000>;
 	};
 
diff --git a/arch/arm/boot/dts/exynos3250-rinato.dts b/arch/arm/boot/dts/exynos3250-rinato.dts
index a92181368e5b..ae125ece061d 100644
--- a/arch/arm/boot/dts/exynos3250-rinato.dts
+++ b/arch/arm/boot/dts/exynos3250-rinato.dts
@@ -28,6 +28,7 @@
 	};
 
 	memory {
+		device_type = "memory";
 		reg =  <0x40000000 0x1ff00000>;
 	};
 
diff --git a/arch/arm/boot/dts/exynos3250.dtsi b/arch/arm/boot/dts/exynos3250.dtsi
index 70e3aceab3a9..e9d2556c0dfd 100644
--- a/arch/arm/boot/dts/exynos3250.dtsi
+++ b/arch/arm/boot/dts/exynos3250.dtsi
@@ -17,7 +17,6 @@
  * published by the Free Software Foundation.
  */
 
-#include "skeleton.dtsi"
 #include "exynos4-cpu-thermal.dtsi"
 #include "exynos-syscon-restart.dtsi"
 #include <dt-bindings/clock/exynos3250.h>
@@ -25,6 +24,8 @@
 / {
 	compatible = "samsung,exynos3250";
 	interrupt-parent = <&gic>;
+	#address-cells = <1>;
+	#size-cells = <1>;
 
 	aliases {
 		pinctrl0 = &pinctrl_0;
-- 
2.7.4

[PATCH 3/7] ARM: dts: exynos: Remove skeleton.dtsi usage for Exynos4

[Javier Martinez Canillas]

The skeleton.dtsi file was removed in ARM64 for different reasons as
explained in commit ("3ebee5a2e141 arm64: dts: kill skeleton.dtsi").

These also applies to ARM and it will also allow to get rid of the
following DTC warnings in the future:

"Node /memory has a reg or ranges property, but no unit name"

The disassembled DTB are almost the same besides an empty chosen
node being removed and nodes reordered, so it should not have
functional changes.

Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com>
---

 arch/arm/boot/dts/exynos4.dtsi                  | 3 ++-
 arch/arm/boot/dts/exynos4210-origen.dts         | 1 +
 arch/arm/boot/dts/exynos4210-smdkv310.dts       | 1 +
 arch/arm/boot/dts/exynos4210-trats.dts          | 1 +
 arch/arm/boot/dts/exynos4210-universal_c210.dts | 1 +
 arch/arm/boot/dts/exynos4412-odroidu3.dts       | 1 +
 arch/arm/boot/dts/exynos4412-odroidx.dts        | 1 +
 arch/arm/boot/dts/exynos4412-odroidx2.dts       | 1 +
 arch/arm/boot/dts/exynos4412-origen.dts         | 1 +
 arch/arm/boot/dts/exynos4412-smdk4412.dts       | 1 +
 arch/arm/boot/dts/exynos4412-tiny4412.dts       | 1 +
 arch/arm/boot/dts/exynos4412-trats2.dts         | 1 +
 arch/arm/boot/dts/exynos4415.dtsi               | 3 ++-
 13 files changed, 15 insertions(+), 2 deletions(-)

diff --git a/arch/arm/boot/dts/exynos4.dtsi b/arch/arm/boot/dts/exynos4.dtsi
index 32f22e12c70b..5f034eb5a5e2 100644
--- a/arch/arm/boot/dts/exynos4.dtsi
+++ b/arch/arm/boot/dts/exynos4.dtsi
@@ -21,11 +21,12 @@
 
 #include <dt-bindings/clock/exynos4.h>
 #include <dt-bindings/clock/exynos-audss-clk.h>
-#include "skeleton.dtsi"
 #include "exynos-syscon-restart.dtsi"
 
 / {
 	interrupt-parent = <&gic>;
+	#address-cells = <1>;
+	#size-cells = <1>;
 
 	aliases {
 		spi0 = &spi_0;
diff --git a/arch/arm/boot/dts/exynos4210-origen.dts b/arch/arm/boot/dts/exynos4210-origen.dts
index be2751eebaf8..6b2c41a87a3e 100644
--- a/arch/arm/boot/dts/exynos4210-origen.dts
+++ b/arch/arm/boot/dts/exynos4210-origen.dts
@@ -25,6 +25,7 @@
 	compatible = "insignal,origen", "samsung,exynos4210", "samsung,exynos4";
 
 	memory {
+		device_type = "memory";
 		reg = <0x40000000 0x10000000
 		       0x50000000 0x10000000
 		       0x60000000 0x10000000
diff --git a/arch/arm/boot/dts/exynos4210-smdkv310.dts b/arch/arm/boot/dts/exynos4210-smdkv310.dts
index 847fae3dd1f1..3c759baeadcc 100644
--- a/arch/arm/boot/dts/exynos4210-smdkv310.dts
+++ b/arch/arm/boot/dts/exynos4210-smdkv310.dts
@@ -24,6 +24,7 @@
 	compatible = "samsung,smdkv310", "samsung,exynos4210", "samsung,exynos4";
 
 	memory {
+		device_type = "memory";
 		reg = <0x40000000 0x80000000>;
 	};
 
diff --git a/arch/arm/boot/dts/exynos4210-trats.dts b/arch/arm/boot/dts/exynos4210-trats.dts
index 79d983036560..5f7ddb0627fb 100644
--- a/arch/arm/boot/dts/exynos4210-trats.dts
+++ b/arch/arm/boot/dts/exynos4210-trats.dts
@@ -21,6 +21,7 @@
 	compatible = "samsung,trats", "samsung,exynos4210", "samsung,exynos4";
 
 	memory {
+		device_type = "memory";
 		reg =  <0x40000000 0x10000000
 			0x50000000 0x10000000
 			0x60000000 0x10000000
diff --git a/arch/arm/boot/dts/exynos4210-universal_c210.dts b/arch/arm/boot/dts/exynos4210-universal_c210.dts
index cf95202fa310..30d938e17c9f 100644
--- a/arch/arm/boot/dts/exynos4210-universal_c210.dts
+++ b/arch/arm/boot/dts/exynos4210-universal_c210.dts
@@ -21,6 +21,7 @@
 	compatible = "samsung,universal_c210", "samsung,exynos4210", "samsung,exynos4";
 
 	memory {
+		device_type = "memory";
 		reg =  <0x40000000 0x10000000
 			0x50000000 0x10000000>;
 	};
diff --git a/arch/arm/boot/dts/exynos4412-odroidu3.dts b/arch/arm/boot/dts/exynos4412-odroidu3.dts
index d73aa6c58fe3..cc1b87e09534 100644
--- a/arch/arm/boot/dts/exynos4412-odroidu3.dts
+++ b/arch/arm/boot/dts/exynos4412-odroidu3.dts
@@ -19,6 +19,7 @@
 	compatible = "hardkernel,odroid-u3", "samsung,exynos4412", "samsung,exynos4";
 
 	memory {
+		device_type = "memory";
 		reg = <0x40000000 0x7FF00000>;
 	};
 
diff --git a/arch/arm/boot/dts/exynos4412-odroidx.dts b/arch/arm/boot/dts/exynos4412-odroidx.dts
index 2af235151301..518ca57837be 100644
--- a/arch/arm/boot/dts/exynos4412-odroidx.dts
+++ b/arch/arm/boot/dts/exynos4412-odroidx.dts
@@ -19,6 +19,7 @@
 	compatible = "hardkernel,odroid-x", "samsung,exynos4412", "samsung,exynos4";
 
 	memory {
+		device_type = "memory";
 		reg = <0x40000000 0x3FF00000>;
 	};
 
diff --git a/arch/arm/boot/dts/exynos4412-odroidx2.dts b/arch/arm/boot/dts/exynos4412-odroidx2.dts
index 3e3584270e00..92cdeea1cfb3 100644
--- a/arch/arm/boot/dts/exynos4412-odroidx2.dts
+++ b/arch/arm/boot/dts/exynos4412-odroidx2.dts
@@ -18,6 +18,7 @@
 	compatible = "hardkernel,odroid-x2", "samsung,exynos4412", "samsung,exynos4";
 
 	memory {
+		device_type = "memory";
 		reg = <0x40000000 0x7FF00000>;
 	};
 };
diff --git a/arch/arm/boot/dts/exynos4412-origen.dts b/arch/arm/boot/dts/exynos4412-origen.dts
index 26a36fed9652..9156a35a6117 100644
--- a/arch/arm/boot/dts/exynos4412-origen.dts
+++ b/arch/arm/boot/dts/exynos4412-origen.dts
@@ -23,6 +23,7 @@
 	compatible = "insignal,origen4412", "samsung,exynos4412", "samsung,exynos4";
 
 	memory {
+		device_type = "memory";
 		reg = <0x40000000 0x40000000>;
 	};
 
diff --git a/arch/arm/boot/dts/exynos4412-smdk4412.dts b/arch/arm/boot/dts/exynos4412-smdk4412.dts
index 231ffbdbf9d0..2e868c4c307e 100644
--- a/arch/arm/boot/dts/exynos4412-smdk4412.dts
+++ b/arch/arm/boot/dts/exynos4412-smdk4412.dts
@@ -21,6 +21,7 @@
 	compatible = "samsung,smdk4412", "samsung,exynos4412", "samsung,exynos4";
 
 	memory {
+		device_type = "memory";
 		reg = <0x40000000 0x40000000>;
 	};
 
diff --git a/arch/arm/boot/dts/exynos4412-tiny4412.dts b/arch/arm/boot/dts/exynos4412-tiny4412.dts
index 4840bbdaa9ec..ad60f3840e24 100644
--- a/arch/arm/boot/dts/exynos4412-tiny4412.dts
+++ b/arch/arm/boot/dts/exynos4412-tiny4412.dts
@@ -24,6 +24,7 @@
 	};
 
 	memory {
+		device_type = "memory";
 		reg = <0x40000000 0x40000000>;
 	};
 
diff --git a/arch/arm/boot/dts/exynos4412-trats2.dts b/arch/arm/boot/dts/exynos4412-trats2.dts
index 129e973a06a6..e1380bae8ee3 100644
--- a/arch/arm/boot/dts/exynos4412-trats2.dts
+++ b/arch/arm/boot/dts/exynos4412-trats2.dts
@@ -31,6 +31,7 @@
 	};
 
 	memory {
+		device_type = "memory";
 		reg =  <0x40000000 0x40000000>;
 	};
 
diff --git a/arch/arm/boot/dts/exynos4415.dtsi b/arch/arm/boot/dts/exynos4415.dtsi
index 28b04b6795c9..3c40f8a956dd 100644
--- a/arch/arm/boot/dts/exynos4415.dtsi
+++ b/arch/arm/boot/dts/exynos4415.dtsi
@@ -16,13 +16,14 @@
  * published by the Free Software Foundation.
  */
 
-#include "skeleton.dtsi"
 #include <dt-bindings/clock/exynos4415.h>
 #include <dt-bindings/clock/exynos-audss-clk.h>
 
 / {
 	compatible = "samsung,exynos4415";
 	interrupt-parent = <&gic>;
+	#address-cells = <1>;
+	#size-cells = <1>;
 
 	aliases {
 		pinctrl0 = &pinctrl_0;
-- 
2.7.4

[PATCH 4/7] ARM: dts: exynos: Remove skeleton.dtsi usage for Exynos5

[Javier Martinez Canillas]

The skeleton.dtsi file was removed in ARM64 for different reasons as
explained in commit ("3ebee5a2e141 arm64: dts: kill skeleton.dtsi").

These also applies to ARM and it will also allow to get rid of the
following DTC warnings in the future:

"Node /memory has a reg or ranges property, but no unit name"

The disassembled DTB are almost the same besides an empty chosen
node being removed and nodes reordered, so it should not have
functional changes.

Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com>
---

 arch/arm/boot/dts/exynos5.dtsi                     | 3 ++-
 arch/arm/boot/dts/exynos5250-arndale.dts           | 1 +
 arch/arm/boot/dts/exynos5250-smdk5250.dts          | 1 +
 arch/arm/boot/dts/exynos5250-snow-common.dtsi      | 1 +
 arch/arm/boot/dts/exynos5250-spring.dts            | 1 +
 arch/arm/boot/dts/exynos5260-xyref5260.dts         | 1 +
 arch/arm/boot/dts/exynos5260.dtsi                  | 4 ++--
 arch/arm/boot/dts/exynos5410-odroidxu.dts          | 1 +
 arch/arm/boot/dts/exynos5410-smdk5410.dts          | 1 +
 arch/arm/boot/dts/exynos5420-arndale-octa.dts      | 1 +
 arch/arm/boot/dts/exynos5420-peach-pit.dts         | 1 +
 arch/arm/boot/dts/exynos5420-smdk5420.dts          | 1 +
 arch/arm/boot/dts/exynos5422-odroidxu3-common.dtsi | 1 +
 arch/arm/boot/dts/exynos5440.dtsi                  | 3 ++-
 arch/arm/boot/dts/exynos54xx.dtsi                  | 1 -
 arch/arm/boot/dts/exynos5800-peach-pi.dts          | 1 +
 16 files changed, 18 insertions(+), 5 deletions(-)

diff --git a/arch/arm/boot/dts/exynos5.dtsi b/arch/arm/boot/dts/exynos5.dtsi
index cab91782e20c..8f06609879f5 100644
--- a/arch/arm/boot/dts/exynos5.dtsi
+++ b/arch/arm/boot/dts/exynos5.dtsi
@@ -13,11 +13,12 @@
  * published by the Free Software Foundation.
  */
 
-#include "skeleton.dtsi"
 #include "exynos-syscon-restart.dtsi"
 
 / {
 	interrupt-parent = <&gic>;
+	#address-cells = <1>;
+	#size-cells = <1>;
 
 	aliases {
 		i2c0 = &i2c_0;
diff --git a/arch/arm/boot/dts/exynos5250-arndale.dts b/arch/arm/boot/dts/exynos5250-arndale.dts
index 3d981f32874d..54397c7e8d7c 100644
--- a/arch/arm/boot/dts/exynos5250-arndale.dts
+++ b/arch/arm/boot/dts/exynos5250-arndale.dts
@@ -21,6 +21,7 @@
 	compatible = "insignal,arndale", "samsung,exynos5250", "samsung,exynos5";
 
 	memory {
+		device_type = "memory";
 		reg = <0x40000000 0x80000000>;
 	};
 
diff --git a/arch/arm/boot/dts/exynos5250-smdk5250.dts b/arch/arm/boot/dts/exynos5250-smdk5250.dts
index 7f27263728a1..b85b78a57299 100644
--- a/arch/arm/boot/dts/exynos5250-smdk5250.dts
+++ b/arch/arm/boot/dts/exynos5250-smdk5250.dts
@@ -23,6 +23,7 @@
 	};
 
 	memory {
+		device_type = "memory";
 		reg = <0x40000000 0x80000000>;
 	};
 
diff --git a/arch/arm/boot/dts/exynos5250-snow-common.dtsi b/arch/arm/boot/dts/exynos5250-snow-common.dtsi
index 1055d25c0ccc..5324eb488e30 100644
--- a/arch/arm/boot/dts/exynos5250-snow-common.dtsi
+++ b/arch/arm/boot/dts/exynos5250-snow-common.dtsi
@@ -20,6 +20,7 @@
 	};
 
 	memory {
+		device_type = "memory";
 		reg = <0x40000000 0x80000000>;
 	};
 
diff --git a/arch/arm/boot/dts/exynos5250-spring.dts b/arch/arm/boot/dts/exynos5250-spring.dts
index 1d52a79b2f18..bdc55fa7c576 100644
--- a/arch/arm/boot/dts/exynos5250-spring.dts
+++ b/arch/arm/boot/dts/exynos5250-spring.dts
@@ -21,6 +21,7 @@
 	compatible = "google,spring", "samsung,exynos5250", "samsung,exynos5";
 
 	memory {
+		device_type = "memory";
 		reg = <0x40000000 0x80000000>;
 	};
 
diff --git a/arch/arm/boot/dts/exynos5260-xyref5260.dts b/arch/arm/boot/dts/exynos5260-xyref5260.dts
index 3daef94bee38..d7f62918ed4b 100644
--- a/arch/arm/boot/dts/exynos5260-xyref5260.dts
+++ b/arch/arm/boot/dts/exynos5260-xyref5260.dts
@@ -17,6 +17,7 @@
 	compatible = "samsung,xyref5260", "samsung,exynos5260", "samsung,exynos5";
 
 	memory {
+		device_type = "memory";
 		reg = <0x20000000 0x80000000>;
 	};
 
diff --git a/arch/arm/boot/dts/exynos5260.dtsi b/arch/arm/boot/dts/exynos5260.dtsi
index 36da38e29000..a86a4898d077 100644
--- a/arch/arm/boot/dts/exynos5260.dtsi
+++ b/arch/arm/boot/dts/exynos5260.dtsi
@@ -9,13 +9,13 @@
  * published by the Free Software Foundation.
 */
 
-#include "skeleton.dtsi"
-
 #include <dt-bindings/clock/exynos5260-clk.h>
 
 / {
 	compatible = "samsung,exynos5260", "samsung,exynos5";
 	interrupt-parent = <&gic>;
+	#address-cells = <1>;
+	#size-cells = <1>;
 
 	aliases {
 		pinctrl0 = &pinctrl_0;
diff --git a/arch/arm/boot/dts/exynos5410-odroidxu.dts b/arch/arm/boot/dts/exynos5410-odroidxu.dts
index a5ae76c1838f..f1d831fe4ac0 100644
--- a/arch/arm/boot/dts/exynos5410-odroidxu.dts
+++ b/arch/arm/boot/dts/exynos5410-odroidxu.dts
@@ -22,6 +22,7 @@
 	compatible = "hardkernel,odroid-xu", "samsung,exynos5410", "samsung,exynos5";
 
 	memory {
+		device_type = "memory";
 		reg = <0x40000000 0x7ea00000>;
 	};
 
diff --git a/arch/arm/boot/dts/exynos5410-smdk5410.dts b/arch/arm/boot/dts/exynos5410-smdk5410.dts
index 777fcf2edd79..6ea1ac4cf1e7 100644
--- a/arch/arm/boot/dts/exynos5410-smdk5410.dts
+++ b/arch/arm/boot/dts/exynos5410-smdk5410.dts
@@ -17,6 +17,7 @@
 	compatible = "samsung,smdk5410", "samsung,exynos5410", "samsung,exynos5";
 
 	memory {
+		device_type = "memory";
 		reg = <0x40000000 0x80000000>;
 	};
 
diff --git a/arch/arm/boot/dts/exynos5420-arndale-octa.dts b/arch/arm/boot/dts/exynos5420-arndale-octa.dts
index 39a3b81478fd..98138bd64fad 100644
--- a/arch/arm/boot/dts/exynos5420-arndale-octa.dts
+++ b/arch/arm/boot/dts/exynos5420-arndale-octa.dts
@@ -23,6 +23,7 @@
 	compatible = "insignal,arndale-octa", "samsung,exynos5420", "samsung,exynos5";
 
 	memory {
+		device_type = "memory";
 		reg = <0x20000000 0x80000000>;
 	};
 
diff --git a/arch/arm/boot/dts/exynos5420-peach-pit.dts b/arch/arm/boot/dts/exynos5420-peach-pit.dts
index f6f256fd9b5e..cd0c44b0bfa5 100644
--- a/arch/arm/boot/dts/exynos5420-peach-pit.dts
+++ b/arch/arm/boot/dts/exynos5420-peach-pit.dts
@@ -80,6 +80,7 @@
 	};
 
 	memory {
+		device_type = "memory";
 		reg = <0x20000000 0x80000000>;
 	};
 
diff --git a/arch/arm/boot/dts/exynos5420-smdk5420.dts b/arch/arm/boot/dts/exynos5420-smdk5420.dts
index 29546465d3da..3a744d5611ea 100644
--- a/arch/arm/boot/dts/exynos5420-smdk5420.dts
+++ b/arch/arm/boot/dts/exynos5420-smdk5420.dts
@@ -20,6 +20,7 @@
 	compatible = "samsung,smdk5420", "samsung,exynos5420", "samsung,exynos5";
 
 	memory {
+		device_type = "memory";
 		reg = <0x20000000 0x80000000>;
 	};
 
diff --git a/arch/arm/boot/dts/exynos5422-odroidxu3-common.dtsi b/arch/arm/boot/dts/exynos5422-odroidxu3-common.dtsi
index 7bb8a370072a..05ae7284bb1b 100644
--- a/arch/arm/boot/dts/exynos5422-odroidxu3-common.dtsi
+++ b/arch/arm/boot/dts/exynos5422-odroidxu3-common.dtsi
@@ -22,6 +22,7 @@
 
 / {
 	memory {
+		device_type = "memory";
 		reg = <0x40000000 0x7EA00000>;
 	};
 
diff --git a/arch/arm/boot/dts/exynos5440.dtsi b/arch/arm/boot/dts/exynos5440.dtsi
index fd176819b4bf..e6bffd13cedd 100644
--- a/arch/arm/boot/dts/exynos5440.dtsi
+++ b/arch/arm/boot/dts/exynos5440.dtsi
@@ -10,12 +10,13 @@
 */
 
 #include <dt-bindings/clock/exynos5440.h>
-#include "skeleton.dtsi"
 
 / {
 	compatible = "samsung,exynos5440", "samsung,exynos5";
 
 	interrupt-parent = <&gic>;
+	#address-cells = <1>;
+	#size-cells = <1>;
 
 	aliases {
 		serial0 = &serial_0;
diff --git a/arch/arm/boot/dts/exynos54xx.dtsi b/arch/arm/boot/dts/exynos54xx.dtsi
index 06a604911e87..9d31cdce1959 100644
--- a/arch/arm/boot/dts/exynos54xx.dtsi
+++ b/arch/arm/boot/dts/exynos54xx.dtsi
@@ -14,7 +14,6 @@
  * published by the Free Software Foundation.
  */
 
-#include "skeleton.dtsi"
 #include "exynos5.dtsi"
 
 / {
diff --git a/arch/arm/boot/dts/exynos5800-peach-pi.dts b/arch/arm/boot/dts/exynos5800-peach-pi.dts
index 51a8bca4691c..72f89c8803d4 100644
--- a/arch/arm/boot/dts/exynos5800-peach-pi.dts
+++ b/arch/arm/boot/dts/exynos5800-peach-pi.dts
@@ -80,6 +80,7 @@
 	};
 
 	memory {
+		device_type = "memory";
 		reg = <0x20000000 0x80000000>;
 	};
 
-- 
2.7.4

[PATCH 5/7] ARM: dts: exynos: Add missing unit name to memory nodes in Exynos3 DTS

[Javier Martinez Canillas]

This patch fixes the following DTC warnings:

"Node /memory has a reg or ranges property, but no unit name"

Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com>
---

 arch/arm/boot/dts/exynos3250-artik5.dtsi | 2 +-
 arch/arm/boot/dts/exynos3250-monk.dts    | 2 +-
 arch/arm/boot/dts/exynos3250-rinato.dts  | 2 +-
 3 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/arch/arm/boot/dts/exynos3250-artik5.dtsi b/arch/arm/boot/dts/exynos3250-artik5.dtsi
index bedc13bef5d9..a70819b1b739 100644
--- a/arch/arm/boot/dts/exynos3250-artik5.dtsi
+++ b/arch/arm/boot/dts/exynos3250-artik5.dtsi
@@ -24,7 +24,7 @@
 		stdout-path = &serial_2;
 	};
 
-	memory {
+	memory@40000000 {
 		device_type = "memory";
 		reg = <0x40000000 0x1ff00000>;
 	};
diff --git a/arch/arm/boot/dts/exynos3250-monk.dts b/arch/arm/boot/dts/exynos3250-monk.dts
index 249fcfd5b297..66f04f6ba6bb 100644
--- a/arch/arm/boot/dts/exynos3250-monk.dts
+++ b/arch/arm/boot/dts/exynos3250-monk.dts
@@ -27,7 +27,7 @@
 		i2c7 = &i2c_max77836;
 	};
 
-	memory {
+	memory@40000000 {
 		device_type = "memory";
 		reg =  <0x40000000 0x1ff00000>;
 	};
diff --git a/arch/arm/boot/dts/exynos3250-rinato.dts b/arch/arm/boot/dts/exynos3250-rinato.dts
index ae125ece061d..3967ee5f7752 100644
--- a/arch/arm/boot/dts/exynos3250-rinato.dts
+++ b/arch/arm/boot/dts/exynos3250-rinato.dts
@@ -27,7 +27,7 @@
 		i2c7 = &i2c_max77836;
 	};
 
-	memory {
+	memory@40000000 {
 		device_type = "memory";
 		reg =  <0x40000000 0x1ff00000>;
 	};
-- 
2.7.4

[PATCH 6/7] ARM: dts: exynos: Add missing unit name to memory nodes in Exynos4 DTS

[Javier Martinez Canillas]

This patch fixes the following DTC warnings:

"Node /memory has a reg or ranges property, but no unit name"

Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com>
---

 arch/arm/boot/dts/exynos4210-origen.dts         | 2 +-
 arch/arm/boot/dts/exynos4210-smdkv310.dts       | 2 +-
 arch/arm/boot/dts/exynos4210-trats.dts          | 2 +-
 arch/arm/boot/dts/exynos4210-universal_c210.dts | 2 +-
 arch/arm/boot/dts/exynos4412-odroidu3.dts       | 2 +-
 arch/arm/boot/dts/exynos4412-odroidx.dts        | 2 +-
 arch/arm/boot/dts/exynos4412-odroidx2.dts       | 2 +-
 arch/arm/boot/dts/exynos4412-origen.dts         | 2 +-
 arch/arm/boot/dts/exynos4412-smdk4412.dts       | 2 +-
 arch/arm/boot/dts/exynos4412-tiny4412.dts       | 2 +-
 arch/arm/boot/dts/exynos4412-trats2.dts         | 2 +-
 11 files changed, 11 insertions(+), 11 deletions(-)

diff --git a/arch/arm/boot/dts/exynos4210-origen.dts b/arch/arm/boot/dts/exynos4210-origen.dts
index 6b2c41a87a3e..a2c6a13fe67b 100644
--- a/arch/arm/boot/dts/exynos4210-origen.dts
+++ b/arch/arm/boot/dts/exynos4210-origen.dts
@@ -24,7 +24,7 @@
 	model = "Insignal Origen evaluation board based on Exynos4210";
 	compatible = "insignal,origen", "samsung,exynos4210", "samsung,exynos4";
 
-	memory {
+	memory@40000000 {
 		device_type = "memory";
 		reg = <0x40000000 0x10000000
 		       0x50000000 0x10000000
diff --git a/arch/arm/boot/dts/exynos4210-smdkv310.dts b/arch/arm/boot/dts/exynos4210-smdkv310.dts
index 3c759baeadcc..af6ef3e6214d 100644
--- a/arch/arm/boot/dts/exynos4210-smdkv310.dts
+++ b/arch/arm/boot/dts/exynos4210-smdkv310.dts
@@ -23,7 +23,7 @@
 	model = "Samsung smdkv310 evaluation board based on Exynos4210";
 	compatible = "samsung,smdkv310", "samsung,exynos4210", "samsung,exynos4";
 
-	memory {
+	memory@40000000 {
 		device_type = "memory";
 		reg = <0x40000000 0x80000000>;
 	};
diff --git a/arch/arm/boot/dts/exynos4210-trats.dts b/arch/arm/boot/dts/exynos4210-trats.dts
index 5f7ddb0627fb..0ca1b4d355f2 100644
--- a/arch/arm/boot/dts/exynos4210-trats.dts
+++ b/arch/arm/boot/dts/exynos4210-trats.dts
@@ -20,7 +20,7 @@
 	model = "Samsung Trats based on Exynos4210";
 	compatible = "samsung,trats", "samsung,exynos4210", "samsung,exynos4";
 
-	memory {
+	memory@40000000 {
 		device_type = "memory";
 		reg =  <0x40000000 0x10000000
 			0x50000000 0x10000000
diff --git a/arch/arm/boot/dts/exynos4210-universal_c210.dts b/arch/arm/boot/dts/exynos4210-universal_c210.dts
index 30d938e17c9f..f1172be318cd 100644
--- a/arch/arm/boot/dts/exynos4210-universal_c210.dts
+++ b/arch/arm/boot/dts/exynos4210-universal_c210.dts
@@ -20,7 +20,7 @@
 	model = "Samsung Universal C210 based on Exynos4210 rev0";
 	compatible = "samsung,universal_c210", "samsung,exynos4210", "samsung,exynos4";
 
-	memory {
+	memory@40000000 {
 		device_type = "memory";
 		reg =  <0x40000000 0x10000000
 			0x50000000 0x10000000>;
diff --git a/arch/arm/boot/dts/exynos4412-odroidu3.dts b/arch/arm/boot/dts/exynos4412-odroidu3.dts
index cc1b87e09534..99634c54dca9 100644
--- a/arch/arm/boot/dts/exynos4412-odroidu3.dts
+++ b/arch/arm/boot/dts/exynos4412-odroidu3.dts
@@ -18,7 +18,7 @@
 	model = "Hardkernel ODROID-U3 board based on Exynos4412";
 	compatible = "hardkernel,odroid-u3", "samsung,exynos4412", "samsung,exynos4";
 
-	memory {
+	memory@40000000 {
 		device_type = "memory";
 		reg = <0x40000000 0x7FF00000>;
 	};
diff --git a/arch/arm/boot/dts/exynos4412-odroidx.dts b/arch/arm/boot/dts/exynos4412-odroidx.dts
index 518ca57837be..d0a07673ae8b 100644
--- a/arch/arm/boot/dts/exynos4412-odroidx.dts
+++ b/arch/arm/boot/dts/exynos4412-odroidx.dts
@@ -18,7 +18,7 @@
 	model = "Hardkernel ODROID-X board based on Exynos4412";
 	compatible = "hardkernel,odroid-x", "samsung,exynos4412", "samsung,exynos4";
 
-	memory {
+	memory@40000000 {
 		device_type = "memory";
 		reg = <0x40000000 0x3FF00000>;
 	};
diff --git a/arch/arm/boot/dts/exynos4412-odroidx2.dts b/arch/arm/boot/dts/exynos4412-odroidx2.dts
index 92cdeea1cfb3..4d228858f172 100644
--- a/arch/arm/boot/dts/exynos4412-odroidx2.dts
+++ b/arch/arm/boot/dts/exynos4412-odroidx2.dts
@@ -17,7 +17,7 @@
 	model = "Hardkernel ODROID-X2 board based on Exynos4412";
 	compatible = "hardkernel,odroid-x2", "samsung,exynos4412", "samsung,exynos4";
 
-	memory {
+	memory@40000000 {
 		device_type = "memory";
 		reg = <0x40000000 0x7FF00000>;
 	};
diff --git a/arch/arm/boot/dts/exynos4412-origen.dts b/arch/arm/boot/dts/exynos4412-origen.dts
index 9156a35a6117..54a9f6906ed2 100644
--- a/arch/arm/boot/dts/exynos4412-origen.dts
+++ b/arch/arm/boot/dts/exynos4412-origen.dts
@@ -22,7 +22,7 @@
 	model = "Insignal Origen evaluation board based on Exynos4412";
 	compatible = "insignal,origen4412", "samsung,exynos4412", "samsung,exynos4";
 
-	memory {
+	memory@40000000 {
 		device_type = "memory";
 		reg = <0x40000000 0x40000000>;
 	};
diff --git a/arch/arm/boot/dts/exynos4412-smdk4412.dts b/arch/arm/boot/dts/exynos4412-smdk4412.dts
index 2e868c4c307e..2e208d84ff6a 100644
--- a/arch/arm/boot/dts/exynos4412-smdk4412.dts
+++ b/arch/arm/boot/dts/exynos4412-smdk4412.dts
@@ -20,7 +20,7 @@
 	model = "Samsung SMDK evaluation board based on Exynos4412";
 	compatible = "samsung,smdk4412", "samsung,exynos4412", "samsung,exynos4";
 
-	memory {
+	memory@40000000 {
 		device_type = "memory";
 		reg = <0x40000000 0x40000000>;
 	};
diff --git a/arch/arm/boot/dts/exynos4412-tiny4412.dts b/arch/arm/boot/dts/exynos4412-tiny4412.dts
index ad60f3840e24..5504398e6e37 100644
--- a/arch/arm/boot/dts/exynos4412-tiny4412.dts
+++ b/arch/arm/boot/dts/exynos4412-tiny4412.dts
@@ -23,7 +23,7 @@
 		stdout-path = &serial_0;
 	};
 
-	memory {
+	memory@40000000 {
 		device_type = "memory";
 		reg = <0x40000000 0x40000000>;
 	};
diff --git a/arch/arm/boot/dts/exynos4412-trats2.dts b/arch/arm/boot/dts/exynos4412-trats2.dts
index e1380bae8ee3..41ecd6d465a7 100644
--- a/arch/arm/boot/dts/exynos4412-trats2.dts
+++ b/arch/arm/boot/dts/exynos4412-trats2.dts
@@ -30,7 +30,7 @@
 		i2c12 = &i2c_max77693_fuel;
 	};
 
-	memory {
+	memory@40000000 {
 		device_type = "memory";
 		reg =  <0x40000000 0x40000000>;
 	};
-- 
2.7.4

[PATCH 6/7] ARM: dts: exynos: Add missing unit name to memory nodes in Exynos4 DTS

[Javier Martinez Canillas]

This patch fixes the following DTC warnings:

"Node /memory has a reg or ranges property, but no unit name"

Signed-off-by: Javier Martinez Canillas <javier-JPH+aEBZ4P+UEJcrhfAQsw@public.gmane.org>
---

 arch/arm/boot/dts/exynos4210-origen.dts         | 2 +-
 arch/arm/boot/dts/exynos4210-smdkv310.dts       | 2 +-
 arch/arm/boot/dts/exynos4210-trats.dts          | 2 +-
 arch/arm/boot/dts/exynos4210-universal_c210.dts | 2 +-
 arch/arm/boot/dts/exynos4412-odroidu3.dts       | 2 +-
 arch/arm/boot/dts/exynos4412-odroidx.dts        | 2 +-
 arch/arm/boot/dts/exynos4412-odroidx2.dts       | 2 +-
 arch/arm/boot/dts/exynos4412-origen.dts         | 2 +-
 arch/arm/boot/dts/exynos4412-smdk4412.dts       | 2 +-
 arch/arm/boot/dts/exynos4412-tiny4412.dts       | 2 +-
 arch/arm/boot/dts/exynos4412-trats2.dts         | 2 +-
 11 files changed, 11 insertions(+), 11 deletions(-)

diff --git a/arch/arm/boot/dts/exynos4210-origen.dts b/arch/arm/boot/dts/exynos4210-origen.dts
index 6b2c41a87a3e..a2c6a13fe67b 100644
--- a/arch/arm/boot/dts/exynos4210-origen.dts
+++ b/arch/arm/boot/dts/exynos4210-origen.dts
@@ -24,7 +24,7 @@
 	model = "Insignal Origen evaluation board based on Exynos4210";
 	compatible = "insignal,origen", "samsung,exynos4210", "samsung,exynos4";
 
-	memory {
+	memory@40000000 {
 		device_type = "memory";
 		reg = <0x40000000 0x10000000
 		       0x50000000 0x10000000
diff --git a/arch/arm/boot/dts/exynos4210-smdkv310.dts b/arch/arm/boot/dts/exynos4210-smdkv310.dts
index 3c759baeadcc..af6ef3e6214d 100644
--- a/arch/arm/boot/dts/exynos4210-smdkv310.dts
+++ b/arch/arm/boot/dts/exynos4210-smdkv310.dts
@@ -23,7 +23,7 @@
 	model = "Samsung smdkv310 evaluation board based on Exynos4210";
 	compatible = "samsung,smdkv310", "samsung,exynos4210", "samsung,exynos4";
 
-	memory {
+	memory@40000000 {
 		device_type = "memory";
 		reg = <0x40000000 0x80000000>;
 	};
diff --git a/arch/arm/boot/dts/exynos4210-trats.dts b/arch/arm/boot/dts/exynos4210-trats.dts
index 5f7ddb0627fb..0ca1b4d355f2 100644
--- a/arch/arm/boot/dts/exynos4210-trats.dts
+++ b/arch/arm/boot/dts/exynos4210-trats.dts
@@ -20,7 +20,7 @@
 	model = "Samsung Trats based on Exynos4210";
 	compatible = "samsung,trats", "samsung,exynos4210", "samsung,exynos4";
 
-	memory {
+	memory@40000000 {
 		device_type = "memory";
 		reg =  <0x40000000 0x10000000
 			0x50000000 0x10000000
diff --git a/arch/arm/boot/dts/exynos4210-universal_c210.dts b/arch/arm/boot/dts/exynos4210-universal_c210.dts
index 30d938e17c9f..f1172be318cd 100644
--- a/arch/arm/boot/dts/exynos4210-universal_c210.dts
+++ b/arch/arm/boot/dts/exynos4210-universal_c210.dts
@@ -20,7 +20,7 @@
 	model = "Samsung Universal C210 based on Exynos4210 rev0";
 	compatible = "samsung,universal_c210", "samsung,exynos4210", "samsung,exynos4";
 
-	memory {
+	memory@40000000 {
 		device_type = "memory";
 		reg =  <0x40000000 0x10000000
 			0x50000000 0x10000000>;
diff --git a/arch/arm/boot/dts/exynos4412-odroidu3.dts b/arch/arm/boot/dts/exynos4412-odroidu3.dts
index cc1b87e09534..99634c54dca9 100644
--- a/arch/arm/boot/dts/exynos4412-odroidu3.dts
+++ b/arch/arm/boot/dts/exynos4412-odroidu3.dts
@@ -18,7 +18,7 @@
 	model = "Hardkernel ODROID-U3 board based on Exynos4412";
 	compatible = "hardkernel,odroid-u3", "samsung,exynos4412", "samsung,exynos4";
 
-	memory {
+	memory@40000000 {
 		device_type = "memory";
 		reg = <0x40000000 0x7FF00000>;
 	};
diff --git a/arch/arm/boot/dts/exynos4412-odroidx.dts b/arch/arm/boot/dts/exynos4412-odroidx.dts
index 518ca57837be..d0a07673ae8b 100644
--- a/arch/arm/boot/dts/exynos4412-odroidx.dts
+++ b/arch/arm/boot/dts/exynos4412-odroidx.dts
@@ -18,7 +18,7 @@
 	model = "Hardkernel ODROID-X board based on Exynos4412";
 	compatible = "hardkernel,odroid-x", "samsung,exynos4412", "samsung,exynos4";
 
-	memory {
+	memory@40000000 {
 		device_type = "memory";
 		reg = <0x40000000 0x3FF00000>;
 	};
diff --git a/arch/arm/boot/dts/exynos4412-odroidx2.dts b/arch/arm/boot/dts/exynos4412-odroidx2.dts
index 92cdeea1cfb3..4d228858f172 100644
--- a/arch/arm/boot/dts/exynos4412-odroidx2.dts
+++ b/arch/arm/boot/dts/exynos4412-odroidx2.dts
@@ -17,7 +17,7 @@
 	model = "Hardkernel ODROID-X2 board based on Exynos4412";
 	compatible = "hardkernel,odroid-x2", "samsung,exynos4412", "samsung,exynos4";
 
-	memory {
+	memory@40000000 {
 		device_type = "memory";
 		reg = <0x40000000 0x7FF00000>;
 	};
diff --git a/arch/arm/boot/dts/exynos4412-origen.dts b/arch/arm/boot/dts/exynos4412-origen.dts
index 9156a35a6117..54a9f6906ed2 100644
--- a/arch/arm/boot/dts/exynos4412-origen.dts
+++ b/arch/arm/boot/dts/exynos4412-origen.dts
@@ -22,7 +22,7 @@
 	model = "Insignal Origen evaluation board based on Exynos4412";
 	compatible = "insignal,origen4412", "samsung,exynos4412", "samsung,exynos4";
 
-	memory {
+	memory@40000000 {
 		device_type = "memory";
 		reg = <0x40000000 0x40000000>;
 	};
diff --git a/arch/arm/boot/dts/exynos4412-smdk4412.dts b/arch/arm/boot/dts/exynos4412-smdk4412.dts
index 2e868c4c307e..2e208d84ff6a 100644
--- a/arch/arm/boot/dts/exynos4412-smdk4412.dts
+++ b/arch/arm/boot/dts/exynos4412-smdk4412.dts
@@ -20,7 +20,7 @@
 	model = "Samsung SMDK evaluation board based on Exynos4412";
 	compatible = "samsung,smdk4412", "samsung,exynos4412", "samsung,exynos4";
 
-	memory {
+	memory@40000000 {
 		device_type = "memory";
 		reg = <0x40000000 0x40000000>;
 	};
diff --git a/arch/arm/boot/dts/exynos4412-tiny4412.dts b/arch/arm/boot/dts/exynos4412-tiny4412.dts
index ad60f3840e24..5504398e6e37 100644
--- a/arch/arm/boot/dts/exynos4412-tiny4412.dts
+++ b/arch/arm/boot/dts/exynos4412-tiny4412.dts
@@ -23,7 +23,7 @@
 		stdout-path = &serial_0;
 	};
 
-	memory {
+	memory@40000000 {
 		device_type = "memory";
 		reg = <0x40000000 0x40000000>;
 	};
diff --git a/arch/arm/boot/dts/exynos4412-trats2.dts b/arch/arm/boot/dts/exynos4412-trats2.dts
index e1380bae8ee3..41ecd6d465a7 100644
--- a/arch/arm/boot/dts/exynos4412-trats2.dts
+++ b/arch/arm/boot/dts/exynos4412-trats2.dts
@@ -30,7 +30,7 @@
 		i2c12 = &i2c_max77693_fuel;
 	};
 
-	memory {
+	memory@40000000 {
 		device_type = "memory";
 		reg =  <0x40000000 0x40000000>;
 	};
-- 
2.7.4

--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[PATCH 7/7] ARM: dts: exynos: Add missing unit name to memory nodes in Exynos5 DTS

[Javier Martinez Canillas]

This patch fixes the following DTC warnings:

"Node /memory has a reg or ranges property, but no unit name"

Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com>

---

 arch/arm/boot/dts/exynos5250-arndale.dts           | 2 +-
 arch/arm/boot/dts/exynos5250-smdk5250.dts          | 2 +-
 arch/arm/boot/dts/exynos5250-snow-common.dtsi      | 2 +-
 arch/arm/boot/dts/exynos5250-spring.dts            | 2 +-
 arch/arm/boot/dts/exynos5260-xyref5260.dts         | 2 +-
 arch/arm/boot/dts/exynos5410-odroidxu.dts          | 2 +-
 arch/arm/boot/dts/exynos5410-smdk5410.dts          | 2 +-
 arch/arm/boot/dts/exynos5420-arndale-octa.dts      | 2 +-
 arch/arm/boot/dts/exynos5420-peach-pit.dts         | 2 +-
 arch/arm/boot/dts/exynos5420-smdk5420.dts          | 2 +-
 arch/arm/boot/dts/exynos5422-odroidxu3-common.dtsi | 2 +-
 arch/arm/boot/dts/exynos5440-sd5v1.dts             | 2 +-
 arch/arm/boot/dts/exynos5440-ssdk5440.dts          | 2 +-
 arch/arm/boot/dts/exynos5800-peach-pi.dts          | 2 +-
 14 files changed, 14 insertions(+), 14 deletions(-)

diff --git a/arch/arm/boot/dts/exynos5250-arndale.dts b/arch/arm/boot/dts/exynos5250-arndale.dts
index 54397c7e8d7c..6098dacd09f1 100644
--- a/arch/arm/boot/dts/exynos5250-arndale.dts
+++ b/arch/arm/boot/dts/exynos5250-arndale.dts
@@ -20,7 +20,7 @@
 	model = "Insignal Arndale evaluation board based on EXYNOS5250";
 	compatible = "insignal,arndale", "samsung,exynos5250", "samsung,exynos5";
 
-	memory {
+	memory@40000000 {
 		device_type = "memory";
 		reg = <0x40000000 0x80000000>;
 	};
diff --git a/arch/arm/boot/dts/exynos5250-smdk5250.dts b/arch/arm/boot/dts/exynos5250-smdk5250.dts
index b85b78a57299..124e7bf1ed97 100644
--- a/arch/arm/boot/dts/exynos5250-smdk5250.dts
+++ b/arch/arm/boot/dts/exynos5250-smdk5250.dts
@@ -22,7 +22,7 @@
 	aliases {
 	};
 
-	memory {
+	memory@40000000 {
 		device_type = "memory";
 		reg = <0x40000000 0x80000000>;
 	};
diff --git a/arch/arm/boot/dts/exynos5250-snow-common.dtsi b/arch/arm/boot/dts/exynos5250-snow-common.dtsi
index 5324eb488e30..9ddf5d2701c2 100644
--- a/arch/arm/boot/dts/exynos5250-snow-common.dtsi
+++ b/arch/arm/boot/dts/exynos5250-snow-common.dtsi
@@ -19,7 +19,7 @@
 		i2c104 = &i2c_104;
 	};
 
-	memory {
+	memory@40000000 {
 		device_type = "memory";
 		reg = <0x40000000 0x80000000>;
 	};
diff --git a/arch/arm/boot/dts/exynos5250-spring.dts b/arch/arm/boot/dts/exynos5250-spring.dts
index bdc55fa7c576..103d8f94e1da 100644
--- a/arch/arm/boot/dts/exynos5250-spring.dts
+++ b/arch/arm/boot/dts/exynos5250-spring.dts
@@ -20,7 +20,7 @@
 	model = "Google Spring";
 	compatible = "google,spring", "samsung,exynos5250", "samsung,exynos5";
 
-	memory {
+	memory@40000000 {
 		device_type = "memory";
 		reg = <0x40000000 0x80000000>;
 	};
diff --git a/arch/arm/boot/dts/exynos5260-xyref5260.dts b/arch/arm/boot/dts/exynos5260-xyref5260.dts
index d7f62918ed4b..d75685cad627 100644
--- a/arch/arm/boot/dts/exynos5260-xyref5260.dts
+++ b/arch/arm/boot/dts/exynos5260-xyref5260.dts
@@ -16,7 +16,7 @@
 	model = "SAMSUNG XYREF5260 board based on EXYNOS5260";
 	compatible = "samsung,xyref5260", "samsung,exynos5260", "samsung,exynos5";
 
-	memory {
+	memory@20000000 {
 		device_type = "memory";
 		reg = <0x20000000 0x80000000>;
 	};
diff --git a/arch/arm/boot/dts/exynos5410-odroidxu.dts b/arch/arm/boot/dts/exynos5410-odroidxu.dts
index f1d831fe4ac0..cdc577265002 100644
--- a/arch/arm/boot/dts/exynos5410-odroidxu.dts
+++ b/arch/arm/boot/dts/exynos5410-odroidxu.dts
@@ -21,7 +21,7 @@
 	model = "Hardkernel Odroid XU";
 	compatible = "hardkernel,odroid-xu", "samsung,exynos5410", "samsung,exynos5";
 
-	memory {
+	memory@40000000 {
 		device_type = "memory";
 		reg = <0x40000000 0x7ea00000>;
 	};
diff --git a/arch/arm/boot/dts/exynos5410-smdk5410.dts b/arch/arm/boot/dts/exynos5410-smdk5410.dts
index 6ea1ac4cf1e7..5e36bddb0509 100644
--- a/arch/arm/boot/dts/exynos5410-smdk5410.dts
+++ b/arch/arm/boot/dts/exynos5410-smdk5410.dts
@@ -16,7 +16,7 @@
 	model = "Samsung SMDK5410 board based on EXYNOS5410";
 	compatible = "samsung,smdk5410", "samsung,exynos5410", "samsung,exynos5";
 
-	memory {
+	memory@40000000 {
 		device_type = "memory";
 		reg = <0x40000000 0x80000000>;
 	};
diff --git a/arch/arm/boot/dts/exynos5420-arndale-octa.dts b/arch/arm/boot/dts/exynos5420-arndale-octa.dts
index 98138bd64fad..68b91e6e5526 100644
--- a/arch/arm/boot/dts/exynos5420-arndale-octa.dts
+++ b/arch/arm/boot/dts/exynos5420-arndale-octa.dts
@@ -22,7 +22,7 @@
 	model = "Insignal Arndale Octa evaluation board based on EXYNOS5420";
 	compatible = "insignal,arndale-octa", "samsung,exynos5420", "samsung,exynos5";
 
-	memory {
+	memory@20000000 {
 		device_type = "memory";
 		reg = <0x20000000 0x80000000>;
 	};
diff --git a/arch/arm/boot/dts/exynos5420-peach-pit.dts b/arch/arm/boot/dts/exynos5420-peach-pit.dts
index cd0c44b0bfa5..bc76dfdc57e6 100644
--- a/arch/arm/boot/dts/exynos5420-peach-pit.dts
+++ b/arch/arm/boot/dts/exynos5420-peach-pit.dts
@@ -79,7 +79,7 @@
 		};
 	};
 
-	memory {
+	memory@20000000 {
 		device_type = "memory";
 		reg = <0x20000000 0x80000000>;
 	};
diff --git a/arch/arm/boot/dts/exynos5420-smdk5420.dts b/arch/arm/boot/dts/exynos5420-smdk5420.dts
index 3a744d5611ea..b9192ef11257 100644
--- a/arch/arm/boot/dts/exynos5420-smdk5420.dts
+++ b/arch/arm/boot/dts/exynos5420-smdk5420.dts
@@ -19,7 +19,7 @@
 	model = "Samsung SMDK5420 board based on EXYNOS5420";
 	compatible = "samsung,smdk5420", "samsung,exynos5420", "samsung,exynos5";
 
-	memory {
+	memory@20000000 {
 		device_type = "memory";
 		reg = <0x20000000 0x80000000>;
 	};
diff --git a/arch/arm/boot/dts/exynos5422-odroidxu3-common.dtsi b/arch/arm/boot/dts/exynos5422-odroidxu3-common.dtsi
index 05ae7284bb1b..0747c6fdadf8 100644
--- a/arch/arm/boot/dts/exynos5422-odroidxu3-common.dtsi
+++ b/arch/arm/boot/dts/exynos5422-odroidxu3-common.dtsi
@@ -21,7 +21,7 @@
 #include "exynos-mfc-reserved-memory.dtsi"
 
 / {
-	memory {
+	memory@40000000 {
 		device_type = "memory";
 		reg = <0x40000000 0x7EA00000>;
 	};
diff --git a/arch/arm/boot/dts/exynos5440-sd5v1.dts b/arch/arm/boot/dts/exynos5440-sd5v1.dts
index 333db4ff373a..c371760e85cd 100644
--- a/arch/arm/boot/dts/exynos5440-sd5v1.dts
+++ b/arch/arm/boot/dts/exynos5440-sd5v1.dts
@@ -20,7 +20,7 @@
 		bootargs = "root=/dev/sda2 rw rootwait ignore_loglevel earlyprintk no_console_suspend mem=2048M@0x80000000 mem=6144M@0x100000000 console=ttySAC0,115200";
 	};
 
-	memory {
+	memory@0 {
 		device_type = "memory";
 		reg = <0 0>;
 	};
diff --git a/arch/arm/boot/dts/exynos5440-ssdk5440.dts b/arch/arm/boot/dts/exynos5440-ssdk5440.dts
index 82fea6f94704..92b0f2a961e9 100644
--- a/arch/arm/boot/dts/exynos5440-ssdk5440.dts
+++ b/arch/arm/boot/dts/exynos5440-ssdk5440.dts
@@ -21,7 +21,7 @@
 		bootargs = "root=/dev/sda2 rw rootwait ignore_loglevel earlyprintk no_console_suspend mem=2048M@0x80000000 mem=6144M@0x100000000 console=ttySAC0,115200";
 	};
 
-	memory {
+	memory@0 {
 		device_type = "memory";
 		reg = <0 0>;
 	};
diff --git a/arch/arm/boot/dts/exynos5800-peach-pi.dts b/arch/arm/boot/dts/exynos5800-peach-pi.dts
index 72f89c8803d4..9fafe10d9e4e 100644
--- a/arch/arm/boot/dts/exynos5800-peach-pi.dts
+++ b/arch/arm/boot/dts/exynos5800-peach-pi.dts
@@ -79,7 +79,7 @@
 
 	};
 
-	memory {
+	memory@20000000 {
 		device_type = "memory";
 		reg = <0x20000000 0x80000000>;
 	};
-- 
2.7.4

Re: [PATCH 0/7] ARM: dts: exynos: Remove skeleton.dtsi usage and fix memory node DTC warnings

[Krzysztof Kozlowski]

On 08/31/2016 02:14 PM, Javier Martinez Canillas wrote:
> Hello Krzysztof,
> 
> This series removes the usage of the skeleton.dtsi in all the Exynos dts,
> which allows to get rid of the DTC warnings about a mismatch between the
> memory nodes' unit names and reg properties.
> 
> Patches are pretty trivial and shouldn't cause functional changes AFAIK,
> but only the Exynos5 changes have been tested. The others patches were
> just built tested.

I think this is a common problem, not only Exynos-specific, so I would
prefer to stick to common pattern. Either all DTS/DTSI include skeleton
or none of them.

Best regards,
Krzysztof

Re: [PATCH 0/7] ARM: dts: exynos: Remove skeleton.dtsi usage and fix memory node DTC warnings

[Krzysztof Kozlowski]

On 08/31/2016 02:14 PM, Javier Martinez Canillas wrote:
> Hello Krzysztof,
> 
> This series removes the usage of the skeleton.dtsi in all the Exynos dts,
> which allows to get rid of the DTC warnings about a mismatch between the
> memory nodes' unit names and reg properties.
> 
> Patches are pretty trivial and shouldn't cause functional changes AFAIK,
> but only the Exynos5 changes have been tested. The others patches were
> just built tested.

I think this is a common problem, not only Exynos-specific, so I would
prefer to stick to common pattern. Either all DTS/DTSI include skeleton
or none of them.

Best regards,
Krzysztof

--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH 0/7] ARM: dts: exynos: Remove skeleton.dtsi usage and fix memory node DTC warnings

[Javier Martinez Canillas]

Hello Krzysztof,

On 08/31/2016 02:55 PM, Krzysztof Kozlowski wrote:
> On 08/31/2016 02:14 PM, Javier Martinez Canillas wrote:
>> Hello Krzysztof,
>>
>> This series removes the usage of the skeleton.dtsi in all the Exynos dts,
>> which allows to get rid of the DTC warnings about a mismatch between the
>> memory nodes' unit names and reg properties.
>>
>> Patches are pretty trivial and shouldn't cause functional changes AFAIK,
>> but only the Exynos5 changes have been tested. The others patches were
>> just built tested.
> 
> I think this is a common problem, not only Exynos-specific, so I would

That's correct.

> prefer to stick to common pattern. Either all DTS/DTSI include skeleton
> or none of them.
>

The idea is to get rid of skeleton.dtsi [0], but that will of course take
time until the dtsi is removed from all the files. So this patch is a step
in the right direction so at least Exynos is not a blocker to remove it.
 
> Best regards,
> Krzysztof
> 

[0]: https://lkml.org/lkml/2016/8/3/195

Best regards,
-- 
Javier Martinez Canillas
Open Source Group
Samsung Research America

Re: [PATCH 0/7] ARM: dts: exynos: Remove skeleton.dtsi usage and fix memory node DTC warnings

[Javier Martinez Canillas]

Hello Krzysztof,

On 08/31/2016 02:55 PM, Krzysztof Kozlowski wrote:
> On 08/31/2016 02:14 PM, Javier Martinez Canillas wrote:
>> Hello Krzysztof,
>>
>> This series removes the usage of the skeleton.dtsi in all the Exynos dts,
>> which allows to get rid of the DTC warnings about a mismatch between the
>> memory nodes' unit names and reg properties.
>>
>> Patches are pretty trivial and shouldn't cause functional changes AFAIK,
>> but only the Exynos5 changes have been tested. The others patches were
>> just built tested.
> 
> I think this is a common problem, not only Exynos-specific, so I would

That's correct.

> prefer to stick to common pattern. Either all DTS/DTSI include skeleton
> or none of them.
>

The idea is to get rid of skeleton.dtsi [0], but that will of course take
time until the dtsi is removed from all the files. So this patch is a step
in the right direction so at least Exynos is not a blocker to remove it.
 
> Best regards,
> Krzysztof
> 

[0]: https://lkml.org/lkml/2016/8/3/195

Best regards,
-- 
Javier Martinez Canillas
Open Source Group
Samsung Research America
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH 1/7] ARM: dts: exynos: Add missing memory node for Exynos5440 boards

[Bartlomiej Zolnierkiewicz]

Hi,

On Wednesday, August 31, 2016 02:14:33 PM Javier Martinez Canillas wrote:
> The skeleton.dtsi file was removed in ARM64 for different reasons as
> explained in commit ("3ebee5a2e141 arm64: dts: kill skeleton.dtsi").
> 
> These also applies to ARM and it will also allow to get rid of the
> following DTC warnings in the future:
> 
> "Node /memory has a reg or ranges property, but no unit name"
> 
> But these boards don't have a memory node defined, so removing the
> skeleton.dtsi inclusion in exynos4.dtsi will cause a change in the
> compiled DTB. Add a dummy memory node so the compiled DTB doesn't
> change if the skeleton.dtsi is removed from exynos4.dtsi.
> 
> Eventually the correct starting addresses and sizes should be used
> but I didn't find that information.
> 
> Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com>
> ---
> 
>  arch/arm/boot/dts/exynos5440-sd5v1.dts    | 5 +++++
>  arch/arm/boot/dts/exynos5440-ssdk5440.dts | 5 +++++
>  2 files changed, 10 insertions(+)
> 
> diff --git a/arch/arm/boot/dts/exynos5440-sd5v1.dts b/arch/arm/boot/dts/exynos5440-sd5v1.dts
> index a98501bab6fc..333db4ff373a 100644
> --- a/arch/arm/boot/dts/exynos5440-sd5v1.dts
> +++ b/arch/arm/boot/dts/exynos5440-sd5v1.dts
> @@ -20,6 +20,11 @@
>  		bootargs = "root=/dev/sda2 rw rootwait ignore_loglevel earlyprintk no_console_suspend mem=2048M@0x80000000 mem=6144M@0x100000000 console=ttySAC0,115200";
>  	};
>  
> +	memory {
> +		device_type = "memory";
> +		reg = <0 0>;
> +	};

I think that this node deserves a FIXME comment.

> +
>  	fixed-rate-clocks {
>  		xtal {
>  			compatible = "samsung,clock-xtal";
> diff --git a/arch/arm/boot/dts/exynos5440-ssdk5440.dts b/arch/arm/boot/dts/exynos5440-ssdk5440.dts
> index 6a0d802e87c8..82fea6f94704 100644
> --- a/arch/arm/boot/dts/exynos5440-ssdk5440.dts
> +++ b/arch/arm/boot/dts/exynos5440-ssdk5440.dts
> @@ -21,6 +21,11 @@
>  		bootargs = "root=/dev/sda2 rw rootwait ignore_loglevel earlyprintk no_console_suspend mem=2048M@0x80000000 mem=6144M@0x100000000 console=ttySAC0,115200";
>  	};
>  
> +	memory {
> +		device_type = "memory";
> +		reg = <0 0>;
> +	};

ditto

>  	fixed-rate-clocks {
>  		xtal {
>  			compatible = "samsung,clock-xtal";
> 

Best regards,
--
Bartlomiej Zolnierkiewicz
Samsung R&D Institute Poland
Samsung Electronics

Re: [PATCH 0/7] ARM: dts: exynos: Remove skeleton.dtsi usage and fix memory node DTC warnings

[Bartlomiej Zolnierkiewicz]

Hi,

On Wednesday, August 31, 2016 03:45:24 PM Javier Martinez Canillas wrote:
> Hello Krzysztof,
> 
> On 08/31/2016 02:55 PM, Krzysztof Kozlowski wrote:
> > On 08/31/2016 02:14 PM, Javier Martinez Canillas wrote:
> >> Hello Krzysztof,
> >>
> >> This series removes the usage of the skeleton.dtsi in all the Exynos dts,
> >> which allows to get rid of the DTC warnings about a mismatch between the
> >> memory nodes' unit names and reg properties.
> >>
> >> Patches are pretty trivial and shouldn't cause functional changes AFAIK,
> >> but only the Exynos5 changes have been tested. The others patches were
> >> just built tested.
> > 
> > I think this is a common problem, not only Exynos-specific, so I would
> 
> That's correct.
> 
> > prefer to stick to common pattern. Either all DTS/DTSI include skeleton
> > or none of them.
> >
> 
> The idea is to get rid of skeleton.dtsi [0], but that will of course take
> time until the dtsi is removed from all the files. So this patch is a step
> in the right direction so at least Exynos is not a blocker to remove it.

Krzysztof's point is valid.  If you are going to convert all DTS/DTSI
then it is okay to apply Exynos specific changes, otherwise the code
should stay as it is currently.

Exynos won't be a blocker since we have your patches now and they can
be applied when/if needed ;)..

> > Best regards,
> > Krzysztof
> > 
> 
> [0]: https://lkml.org/lkml/2016/8/3/195
> 
> Best regards,

Best regards,
--
Bartlomiej Zolnierkiewicz
Samsung R&D Institute Poland
Samsung Electronics

Re: [PATCH 0/7] ARM: dts: exynos: Remove skeleton.dtsi usage and fix memory node DTC warnings

[Bartlomiej Zolnierkiewicz]

Hi,

On Wednesday, August 31, 2016 03:45:24 PM Javier Martinez Canillas wrote:
> Hello Krzysztof,
> 
> On 08/31/2016 02:55 PM, Krzysztof Kozlowski wrote:
> > On 08/31/2016 02:14 PM, Javier Martinez Canillas wrote:
> >> Hello Krzysztof,
> >>
> >> This series removes the usage of the skeleton.dtsi in all the Exynos dts,
> >> which allows to get rid of the DTC warnings about a mismatch between the
> >> memory nodes' unit names and reg properties.
> >>
> >> Patches are pretty trivial and shouldn't cause functional changes AFAIK,
> >> but only the Exynos5 changes have been tested. The others patches were
> >> just built tested.
> > 
> > I think this is a common problem, not only Exynos-specific, so I would
> 
> That's correct.
> 
> > prefer to stick to common pattern. Either all DTS/DTSI include skeleton
> > or none of them.
> >
> 
> The idea is to get rid of skeleton.dtsi [0], but that will of course take
> time until the dtsi is removed from all the files. So this patch is a step
> in the right direction so at least Exynos is not a blocker to remove it.

Krzysztof's point is valid.  If you are going to convert all DTS/DTSI
then it is okay to apply Exynos specific changes, otherwise the code
should stay as it is currently.

Exynos won't be a blocker since we have your patches now and they can
be applied when/if needed ;)..

> > Best regards,
> > Krzysztof
> > 
> 
> [0]: https://lkml.org/lkml/2016/8/3/195
> 
> Best regards,

Best regards,
--
Bartlomiej Zolnierkiewicz
Samsung R&D Institute Poland
Samsung Electronics

--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH 1/7] ARM: dts: exynos: Add missing memory node for Exynos5440 boards

[Krzysztof Kozlowski]

On Wed, Aug 31, 2016 at 02:14:33PM +0200, Javier Martinez Canillas wrote:
> The skeleton.dtsi file was removed in ARM64 for different reasons as
> explained in commit ("3ebee5a2e141 arm64: dts: kill skeleton.dtsi").
> 
> These also applies to ARM and it will also allow to get rid of the
> following DTC warnings in the future:
> 
> "Node /memory has a reg or ranges property, but no unit name"
> 
> But these boards don't have a memory node defined, so removing the
> skeleton.dtsi inclusion in exynos4.dtsi will cause a change in the
> compiled DTB. Add a dummy memory node so the compiled DTB doesn't
> change if the skeleton.dtsi is removed from exynos4.dtsi.

You mean extnos5440.dtsi?

> 
> Eventually the correct starting addresses and sizes should be used
> but I didn't find that information.
> 
> Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com>
> ---
> 
>  arch/arm/boot/dts/exynos5440-sd5v1.dts    | 5 +++++
>  arch/arm/boot/dts/exynos5440-ssdk5440.dts | 5 +++++
>  2 files changed, 10 insertions(+)
> 
> diff --git a/arch/arm/boot/dts/exynos5440-sd5v1.dts b/arch/arm/boot/dts/exynos5440-sd5v1.dts
> index a98501bab6fc..333db4ff373a 100644
> --- a/arch/arm/boot/dts/exynos5440-sd5v1.dts
> +++ b/arch/arm/boot/dts/exynos5440-sd5v1.dts
> @@ -20,6 +20,11 @@
>  		bootargs = "root=/dev/sda2 rw rootwait ignore_loglevel earlyprintk no_console_suspend mem=2048M@0x80000000 mem=6144M@0x100000000 console=ttySAC0,115200";
>  	};
>  
> +	memory {
> +		device_type = "memory";
> +		reg = <0 0>;
> +	};
> +
>  	fixed-rate-clocks {
>  		xtal {
>  			compatible = "samsung,clock-xtal";
> diff --git a/arch/arm/boot/dts/exynos5440-ssdk5440.dts b/arch/arm/boot/dts/exynos5440-ssdk5440.dts
> index 6a0d802e87c8..82fea6f94704 100644
> --- a/arch/arm/boot/dts/exynos5440-ssdk5440.dts
> +++ b/arch/arm/boot/dts/exynos5440-ssdk5440.dts
> @@ -21,6 +21,11 @@
>  		bootargs = "root=/dev/sda2 rw rootwait ignore_loglevel earlyprintk no_console_suspend mem=2048M@0x80000000 mem=6144M@0x100000000 console=ttySAC0,115200";
>  	};
>  
> +	memory {
> +		device_type = "memory";
> +		reg = <0 0>;
> +	};

This looks okay, but the default size and address cells won't be
present. Won't that be a problem?

Best regards,
Krzysztof

Re: [PATCH 0/7] ARM: dts: exynos: Remove skeleton.dtsi usage and fix memory node DTC warnings

[Krzysztof Kozlowski]

On Wed, Aug 31, 2016 at 03:45:24PM +0200, Javier Martinez Canillas wrote:
> Hello Krzysztof,
> 
> On 08/31/2016 02:55 PM, Krzysztof Kozlowski wrote:
> > On 08/31/2016 02:14 PM, Javier Martinez Canillas wrote:
> >> Hello Krzysztof,
> >>
> >> This series removes the usage of the skeleton.dtsi in all the Exynos dts,
> >> which allows to get rid of the DTC warnings about a mismatch between the
> >> memory nodes' unit names and reg properties.
> >>
> >> Patches are pretty trivial and shouldn't cause functional changes AFAIK,
> >> but only the Exynos5 changes have been tested. The others patches were
> >> just built tested.
> > 
> > I think this is a common problem, not only Exynos-specific, so I would
> 
> That's correct.
> 
> > prefer to stick to common pattern. Either all DTS/DTSI include skeleton
> > or none of them.
> >
> 
> The idea is to get rid of skeleton.dtsi [0], but that will of course take
> time until the dtsi is removed from all the files. So this patch is a step
> in the right direction so at least Exynos is not a blocker to remove it.

Acknowledged, thanks for pointing it.

I will start review and apply.

BR,
Krzysztof

Re: [PATCH 0/7] ARM: dts: exynos: Remove skeleton.dtsi usage and fix memory node DTC warnings

[Krzysztof Kozlowski]

On Wed, Aug 31, 2016 at 03:45:24PM +0200, Javier Martinez Canillas wrote:
> Hello Krzysztof,
> 
> On 08/31/2016 02:55 PM, Krzysztof Kozlowski wrote:
> > On 08/31/2016 02:14 PM, Javier Martinez Canillas wrote:
> >> Hello Krzysztof,
> >>
> >> This series removes the usage of the skeleton.dtsi in all the Exynos dts,
> >> which allows to get rid of the DTC warnings about a mismatch between the
> >> memory nodes' unit names and reg properties.
> >>
> >> Patches are pretty trivial and shouldn't cause functional changes AFAIK,
> >> but only the Exynos5 changes have been tested. The others patches were
> >> just built tested.
> > 
> > I think this is a common problem, not only Exynos-specific, so I would
> 
> That's correct.
> 
> > prefer to stick to common pattern. Either all DTS/DTSI include skeleton
> > or none of them.
> >
> 
> The idea is to get rid of skeleton.dtsi [0], but that will of course take
> time until the dtsi is removed from all the files. So this patch is a step
> in the right direction so at least Exynos is not a blocker to remove it.

Acknowledged, thanks for pointing it.

I will start review and apply.

BR,
Krzysztof
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH 1/7] ARM: dts: exynos: Add missing memory node for Exynos5440 boards

[Javier Martinez Canillas]

Hello Bartlomiej,

On 08/31/2016 07:22 PM, Bartlomiej Zolnierkiewicz wrote:
> 
> Hi,
> 
> On Wednesday, August 31, 2016 02:14:33 PM Javier Martinez Canillas wrote:
>> The skeleton.dtsi file was removed in ARM64 for different reasons as
>> explained in commit ("3ebee5a2e141 arm64: dts: kill skeleton.dtsi").
>>
>> These also applies to ARM and it will also allow to get rid of the
>> following DTC warnings in the future:
>>
>> "Node /memory has a reg or ranges property, but no unit name"
>>
>> But these boards don't have a memory node defined, so removing the
>> skeleton.dtsi inclusion in exynos4.dtsi will cause a change in the
>> compiled DTB. Add a dummy memory node so the compiled DTB doesn't
>> change if the skeleton.dtsi is removed from exynos4.dtsi.
>>
>> Eventually the correct starting addresses and sizes should be used
>> but I didn't find that information.
>>
>> Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com>
>> ---
>>
>>  arch/arm/boot/dts/exynos5440-sd5v1.dts    | 5 +++++
>>  arch/arm/boot/dts/exynos5440-ssdk5440.dts | 5 +++++
>>  2 files changed, 10 insertions(+)
>>
>> diff --git a/arch/arm/boot/dts/exynos5440-sd5v1.dts b/arch/arm/boot/dts/exynos5440-sd5v1.dts
>> index a98501bab6fc..333db4ff373a 100644
>> --- a/arch/arm/boot/dts/exynos5440-sd5v1.dts
>> +++ b/arch/arm/boot/dts/exynos5440-sd5v1.dts
>> @@ -20,6 +20,11 @@
>>  		bootargs = "root=/dev/sda2 rw rootwait ignore_loglevel earlyprintk no_console_suspend mem=2048M@0x80000000 mem=6144M@0x100000000 console=ttySAC0,115200";
>>  	};
>>  
>> +	memory {
>> +		device_type = "memory";
>> +		reg = <0 0>;
>> +	};
> 
> I think that this node deserves a FIXME comment.
> 

Agreed. I'll add one in v2 for both nodes.

Best regards,
-- 
Javier Martinez Canillas
Open Source Group
Samsung Research America

Re: [PATCH 1/7] ARM: dts: exynos: Add missing memory node for Exynos5440 boards

[Javier Martinez Canillas]

Hello Bartlomiej,

On 08/31/2016 07:22 PM, Bartlomiej Zolnierkiewicz wrote:
> 
> Hi,
> 
> On Wednesday, August 31, 2016 02:14:33 PM Javier Martinez Canillas wrote:
>> The skeleton.dtsi file was removed in ARM64 for different reasons as
>> explained in commit ("3ebee5a2e141 arm64: dts: kill skeleton.dtsi").
>>
>> These also applies to ARM and it will also allow to get rid of the
>> following DTC warnings in the future:
>>
>> "Node /memory has a reg or ranges property, but no unit name"
>>
>> But these boards don't have a memory node defined, so removing the
>> skeleton.dtsi inclusion in exynos4.dtsi will cause a change in the
>> compiled DTB. Add a dummy memory node so the compiled DTB doesn't
>> change if the skeleton.dtsi is removed from exynos4.dtsi.
>>
>> Eventually the correct starting addresses and sizes should be used
>> but I didn't find that information.
>>
>> Signed-off-by: Javier Martinez Canillas <javier-JPH+aEBZ4P+UEJcrhfAQsw@public.gmane.org>
>> ---
>>
>>  arch/arm/boot/dts/exynos5440-sd5v1.dts    | 5 +++++
>>  arch/arm/boot/dts/exynos5440-ssdk5440.dts | 5 +++++
>>  2 files changed, 10 insertions(+)
>>
>> diff --git a/arch/arm/boot/dts/exynos5440-sd5v1.dts b/arch/arm/boot/dts/exynos5440-sd5v1.dts
>> index a98501bab6fc..333db4ff373a 100644
>> --- a/arch/arm/boot/dts/exynos5440-sd5v1.dts
>> +++ b/arch/arm/boot/dts/exynos5440-sd5v1.dts
>> @@ -20,6 +20,11 @@
>>  		bootargs = "root=/dev/sda2 rw rootwait ignore_loglevel earlyprintk no_console_suspend mem=2048M@0x80000000 mem=6144M@0x100000000 console=ttySAC0,115200";
>>  	};
>>  
>> +	memory {
>> +		device_type = "memory";
>> +		reg = <0 0>;
>> +	};
> 
> I think that this node deserves a FIXME comment.
> 

Agreed. I'll add one in v2 for both nodes.

Best regards,
-- 
Javier Martinez Canillas
Open Source Group
Samsung Research America
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH 0/7] ARM: dts: exynos: Remove skeleton.dtsi usage and fix memory node DTC warnings

[Javier Martinez Canillas]

Hello Bartlomiej,

On 08/31/2016 07:40 PM, Bartlomiej Zolnierkiewicz wrote:
> 
> Hi,
> 
> On Wednesday, August 31, 2016 03:45:24 PM Javier Martinez Canillas wrote:
>> Hello Krzysztof,
>>
>> On 08/31/2016 02:55 PM, Krzysztof Kozlowski wrote:
>>> On 08/31/2016 02:14 PM, Javier Martinez Canillas wrote:
>>>> Hello Krzysztof,
>>>>
>>>> This series removes the usage of the skeleton.dtsi in all the Exynos dts,
>>>> which allows to get rid of the DTC warnings about a mismatch between the
>>>> memory nodes' unit names and reg properties.
>>>>
>>>> Patches are pretty trivial and shouldn't cause functional changes AFAIK,
>>>> but only the Exynos5 changes have been tested. The others patches were
>>>> just built tested.
>>>
>>> I think this is a common problem, not only Exynos-specific, so I would
>>
>> That's correct.
>>
>>> prefer to stick to common pattern. Either all DTS/DTSI include skeleton
>>> or none of them.
>>>
>>
>> The idea is to get rid of skeleton.dtsi [0], but that will of course take
>> time until the dtsi is removed from all the files. So this patch is a step
>> in the right direction so at least Exynos is not a blocker to remove it.
> 
> Krzysztof's point is valid.  If you are going to convert all DTS/DTSI
> then it is okay to apply Exynos specific changes, otherwise the code
> should stay as it is currently.
> 
> Exynos won't be a blocker since we have your patches now and they can
> be applied when/if needed ;)..
>

Sorry but I disagree. I see no reasons to need this to be an atomic, rather
than incremental change. Deprecated things are usually handled by removing
the usage and once there are no users, finally removing them.

Also, each subsystem maintainer should carry the patches for their platform
so it can't be a kernel wide change anyways and most likely split by kernel
releases.
 
Best regards,
-- 
Javier Martinez Canillas
Open Source Group
Samsung Research America

Re: [PATCH 0/7] ARM: dts: exynos: Remove skeleton.dtsi usage and fix memory node DTC warnings

[Javier Martinez Canillas]

Hello Bartlomiej,

On 08/31/2016 07:40 PM, Bartlomiej Zolnierkiewicz wrote:
> 
> Hi,
> 
> On Wednesday, August 31, 2016 03:45:24 PM Javier Martinez Canillas wrote:
>> Hello Krzysztof,
>>
>> On 08/31/2016 02:55 PM, Krzysztof Kozlowski wrote:
>>> On 08/31/2016 02:14 PM, Javier Martinez Canillas wrote:
>>>> Hello Krzysztof,
>>>>
>>>> This series removes the usage of the skeleton.dtsi in all the Exynos dts,
>>>> which allows to get rid of the DTC warnings about a mismatch between the
>>>> memory nodes' unit names and reg properties.
>>>>
>>>> Patches are pretty trivial and shouldn't cause functional changes AFAIK,
>>>> but only the Exynos5 changes have been tested. The others patches were
>>>> just built tested.
>>>
>>> I think this is a common problem, not only Exynos-specific, so I would
>>
>> That's correct.
>>
>>> prefer to stick to common pattern. Either all DTS/DTSI include skeleton
>>> or none of them.
>>>
>>
>> The idea is to get rid of skeleton.dtsi [0], but that will of course take
>> time until the dtsi is removed from all the files. So this patch is a step
>> in the right direction so at least Exynos is not a blocker to remove it.
> 
> Krzysztof's point is valid.  If you are going to convert all DTS/DTSI
> then it is okay to apply Exynos specific changes, otherwise the code
> should stay as it is currently.
> 
> Exynos won't be a blocker since we have your patches now and they can
> be applied when/if needed ;)..
>

Sorry but I disagree. I see no reasons to need this to be an atomic, rather
than incremental change. Deprecated things are usually handled by removing
the usage and once there are no users, finally removing them.

Also, each subsystem maintainer should carry the patches for their platform
so it can't be a kernel wide change anyways and most likely split by kernel
releases.
 
Best regards,
-- 
Javier Martinez Canillas
Open Source Group
Samsung Research America
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH 1/7] ARM: dts: exynos: Add missing memory node for Exynos5440 boards

[Javier Martinez Canillas]

Hello Krzysztof,

On 08/31/2016 07:46 PM, Krzysztof Kozlowski wrote:
> On Wed, Aug 31, 2016 at 02:14:33PM +0200, Javier Martinez Canillas wrote:
>> The skeleton.dtsi file was removed in ARM64 for different reasons as
>> explained in commit ("3ebee5a2e141 arm64: dts: kill skeleton.dtsi").
>>
>> These also applies to ARM and it will also allow to get rid of the
>> following DTC warnings in the future:
>>
>> "Node /memory has a reg or ranges property, but no unit name"
>>
>> But these boards don't have a memory node defined, so removing the
>> skeleton.dtsi inclusion in exynos4.dtsi will cause a change in the
>> compiled DTB. Add a dummy memory node so the compiled DTB doesn't
>> change if the skeleton.dtsi is removed from exynos4.dtsi.
> 
> You mean extnos5440.dtsi?
>

Yes, I meant exynos5440.dtsi, it's a commit message copy and paste error.
Thanks for pointing out, I'll fix it in v2.
 
>>
>> Eventually the correct starting addresses and sizes should be used
>> but I didn't find that information.
>>
>> Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com>
>> ---
>>
>>  arch/arm/boot/dts/exynos5440-sd5v1.dts    | 5 +++++
>>  arch/arm/boot/dts/exynos5440-ssdk5440.dts | 5 +++++
>>  2 files changed, 10 insertions(+)
>>
>> diff --git a/arch/arm/boot/dts/exynos5440-sd5v1.dts b/arch/arm/boot/dts/exynos5440-sd5v1.dts
>> index a98501bab6fc..333db4ff373a 100644
>> --- a/arch/arm/boot/dts/exynos5440-sd5v1.dts
>> +++ b/arch/arm/boot/dts/exynos5440-sd5v1.dts
>> @@ -20,6 +20,11 @@
>>  		bootargs = "root=/dev/sda2 rw rootwait ignore_loglevel earlyprintk no_console_suspend mem=2048M@0x80000000 mem=6144M@0x100000000 console=ttySAC0,115200";
>>  	};
>>  
>> +	memory {
>> +		device_type = "memory";
>> +		reg = <0 0>;
>> +	};
>> +
>>  	fixed-rate-clocks {
>>  		xtal {
>>  			compatible = "samsung,clock-xtal";
>> diff --git a/arch/arm/boot/dts/exynos5440-ssdk5440.dts b/arch/arm/boot/dts/exynos5440-ssdk5440.dts
>> index 6a0d802e87c8..82fea6f94704 100644
>> --- a/arch/arm/boot/dts/exynos5440-ssdk5440.dts
>> +++ b/arch/arm/boot/dts/exynos5440-ssdk5440.dts
>> @@ -21,6 +21,11 @@
>>  		bootargs = "root=/dev/sda2 rw rootwait ignore_loglevel earlyprintk no_console_suspend mem=2048M@0x80000000 mem=6144M@0x100000000 console=ttySAC0,115200";
>>  	};
>>  
>> +	memory {
>> +		device_type = "memory";
>> +		reg = <0 0>;
>> +	};
> 
> This looks okay, but the default size and address cells won't be
> present. Won't that be a problem?
>

They will be present since at this point exynos5440.dtsi is still including
exynos5440.dtsi, we are just overriding the memory node with the same values
than skeleton.dtsi so this can be removed later in patch 7/7.
 
> Best regards,
> Krzysztof
> 

Best regards,
-- 
Javier Martinez Canillas
Open Source Group
Samsung Research America

Re: [PATCH 1/7] ARM: dts: exynos: Add missing memory node for Exynos5440 boards

[Krzysztof Kozlowski]

On 09/01/2016 10:43 AM, Javier Martinez Canillas wrote:
>>> --- a/arch/arm/boot/dts/exynos5440-ssdk5440.dts
>>> +++ b/arch/arm/boot/dts/exynos5440-ssdk5440.dts
>>> @@ -21,6 +21,11 @@
>>>  		bootargs = "root=/dev/sda2 rw rootwait ignore_loglevel earlyprintk no_console_suspend mem=2048M@0x80000000 mem=6144M@0x100000000 console=ttySAC0,115200";
>>>  	};
>>>  
>>> +	memory {
>>> +		device_type = "memory";
>>> +		reg = <0 0>;
>>> +	};
>>
>> This looks okay, but the default size and address cells won't be
>> present. Won't that be a problem?
>>
> 
> They will be present since at this point exynos5440.dtsi is still including
> exynos5440.dtsi, we are just overriding the memory node with the same values
> than skeleton.dtsi so this can be removed later in patch 7/7.

I don't get it. exynos5440.dtsi does not set size/address cells in top node.

Best regards,
Krzysztof

Re: [PATCH 1/7] ARM: dts: exynos: Add missing memory node for Exynos5440 boards

[Javier Martinez Canillas]

Hello Krzysztof,

On 09/01/2016 11:05 AM, Krzysztof Kozlowski wrote:
> On 09/01/2016 10:43 AM, Javier Martinez Canillas wrote:
>>>> --- a/arch/arm/boot/dts/exynos5440-ssdk5440.dts
>>>> +++ b/arch/arm/boot/dts/exynos5440-ssdk5440.dts
>>>> @@ -21,6 +21,11 @@
>>>>  		bootargs = "root=/dev/sda2 rw rootwait ignore_loglevel earlyprintk no_console_suspend mem=2048M@0x80000000 mem=6144M@0x100000000 console=ttySAC0,115200";
>>>>  	};
>>>>  
>>>> +	memory {
>>>> +		device_type = "memory";
>>>> +		reg = <0 0>;
>>>> +	};
>>>
>>> This looks okay, but the default size and address cells won't be
>>> present. Won't that be a problem?
>>>
>>
>> They will be present since at this point exynos5440.dtsi is still including
>> exynos5440.dtsi, we are just overriding the memory node with the same values
>> than skeleton.dtsi so this can be removed later in patch 7/7.
> 
> I don't get it. exynos5440.dtsi does not set size/address cells in top node.
>

Sorry, maybe I'm misunderstanding your question. The size/address cells are set
in the top node by exynos5440.dtsi including the skeleton.dtsi (since these are
set in that included dtsi).

IOW, scripts/dtc/dtx_diff doesn't show differences for these exynos5440 DTB
before and after $SUBJECT.

> Best regards,
> Krzysztof
> 

Best regards,
-- 
Javier Martinez Canillas
Open Source Group
Samsung Research America

Re: [PATCH 1/7] ARM: dts: exynos: Add missing memory node for Exynos5440 boards

[Javier Martinez Canillas]

Hello Krzysztof,

On 09/01/2016 11:05 AM, Krzysztof Kozlowski wrote:
> On 09/01/2016 10:43 AM, Javier Martinez Canillas wrote:
>>>> --- a/arch/arm/boot/dts/exynos5440-ssdk5440.dts
>>>> +++ b/arch/arm/boot/dts/exynos5440-ssdk5440.dts
>>>> @@ -21,6 +21,11 @@
>>>>  		bootargs = "root=/dev/sda2 rw rootwait ignore_loglevel earlyprintk no_console_suspend mem=2048M@0x80000000 mem=6144M@0x100000000 console=ttySAC0,115200";
>>>>  	};
>>>>  
>>>> +	memory {
>>>> +		device_type = "memory";
>>>> +		reg = <0 0>;
>>>> +	};
>>>
>>> This looks okay, but the default size and address cells won't be
>>> present. Won't that be a problem?
>>>
>>
>> They will be present since at this point exynos5440.dtsi is still including
>> exynos5440.dtsi, we are just overriding the memory node with the same values
>> than skeleton.dtsi so this can be removed later in patch 7/7.
> 
> I don't get it. exynos5440.dtsi does not set size/address cells in top node.
>

Sorry, maybe I'm misunderstanding your question. The size/address cells are set
in the top node by exynos5440.dtsi including the skeleton.dtsi (since these are
set in that included dtsi).

IOW, scripts/dtc/dtx_diff doesn't show differences for these exynos5440 DTB
before and after $SUBJECT.

> Best regards,
> Krzysztof
> 

Best regards,
-- 
Javier Martinez Canillas
Open Source Group
Samsung Research America
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH 1/7] ARM: dts: exynos: Add missing memory node for Exynos5440 boards

[Krzysztof Kozlowski]

On 09/01/2016 11:19 AM, Javier Martinez Canillas wrote:
> Hello Krzysztof,
> 
> On 09/01/2016 11:05 AM, Krzysztof Kozlowski wrote:
>> On 09/01/2016 10:43 AM, Javier Martinez Canillas wrote:
>>>>> --- a/arch/arm/boot/dts/exynos5440-ssdk5440.dts
>>>>> +++ b/arch/arm/boot/dts/exynos5440-ssdk5440.dts
>>>>> @@ -21,6 +21,11 @@
>>>>>  		bootargs = "root=/dev/sda2 rw rootwait ignore_loglevel earlyprintk no_console_suspend mem=2048M@0x80000000 mem=6144M@0x100000000 console=ttySAC0,115200";
>>>>>  	};
>>>>>  
>>>>> +	memory {
>>>>> +		device_type = "memory";
>>>>> +		reg = <0 0>;
>>>>> +	};
>>>>
>>>> This looks okay, but the default size and address cells won't be
>>>> present. Won't that be a problem?
>>>>
>>>
>>> They will be present since at this point exynos5440.dtsi is still including
>>> exynos5440.dtsi, we are just overriding the memory node with the same values
>>> than skeleton.dtsi so this can be removed later in patch 7/7.
>>
>> I don't get it. exynos5440.dtsi does not set size/address cells in top node.
>>
> 
> Sorry, maybe I'm misunderstanding your question. The size/address cells are set
> in the top node by exynos5440.dtsi including the skeleton.dtsi (since these are
> set in that included dtsi).

Where? Nothing in my sources...

15 / {
16         compatible = "samsung,exynos5440", "samsung,exynos5";
17
18         interrupt-parent = <&gic>;

> 
> IOW, scripts/dtc/dtx_diff doesn't show differences for these exynos5440 DTB
> before and after $SUBJECT.

Maybe these are also the default values so no differences... stating
them explicitly would be useful.

Best regards,
Krzysztof

Re: [PATCH 1/7] ARM: dts: exynos: Add missing memory node for Exynos5440 boards

[Krzysztof Kozlowski]

On 09/01/2016 11:19 AM, Javier Martinez Canillas wrote:
> Hello Krzysztof,
> 
> On 09/01/2016 11:05 AM, Krzysztof Kozlowski wrote:
>> On 09/01/2016 10:43 AM, Javier Martinez Canillas wrote:
>>>>> --- a/arch/arm/boot/dts/exynos5440-ssdk5440.dts
>>>>> +++ b/arch/arm/boot/dts/exynos5440-ssdk5440.dts
>>>>> @@ -21,6 +21,11 @@
>>>>>  		bootargs = "root=/dev/sda2 rw rootwait ignore_loglevel earlyprintk no_console_suspend mem=2048M@0x80000000 mem=6144M@0x100000000 console=ttySAC0,115200";
>>>>>  	};
>>>>>  
>>>>> +	memory {
>>>>> +		device_type = "memory";
>>>>> +		reg = <0 0>;
>>>>> +	};
>>>>
>>>> This looks okay, but the default size and address cells won't be
>>>> present. Won't that be a problem?
>>>>
>>>
>>> They will be present since at this point exynos5440.dtsi is still including
>>> exynos5440.dtsi, we are just overriding the memory node with the same values
>>> than skeleton.dtsi so this can be removed later in patch 7/7.
>>
>> I don't get it. exynos5440.dtsi does not set size/address cells in top node.
>>
> 
> Sorry, maybe I'm misunderstanding your question. The size/address cells are set
> in the top node by exynos5440.dtsi including the skeleton.dtsi (since these are
> set in that included dtsi).

Where? Nothing in my sources...

15 / {
16         compatible = "samsung,exynos5440", "samsung,exynos5";
17
18         interrupt-parent = <&gic>;

> 
> IOW, scripts/dtc/dtx_diff doesn't show differences for these exynos5440 DTB
> before and after $SUBJECT.

Maybe these are also the default values so no differences... stating
them explicitly would be useful.

Best regards,
Krzysztof


--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH 1/7] ARM: dts: exynos: Add missing memory node for Exynos5440 boards

[Javier Martinez Canillas]

Hello Krzysztof,

On 09/01/2016 11:28 AM, Krzysztof Kozlowski wrote:
> On 09/01/2016 11:19 AM, Javier Martinez Canillas wrote:
>> Hello Krzysztof,
>>
>> On 09/01/2016 11:05 AM, Krzysztof Kozlowski wrote:
>>> On 09/01/2016 10:43 AM, Javier Martinez Canillas wrote:
>>>>>> --- a/arch/arm/boot/dts/exynos5440-ssdk5440.dts
>>>>>> +++ b/arch/arm/boot/dts/exynos5440-ssdk5440.dts
>>>>>> @@ -21,6 +21,11 @@
>>>>>>  		bootargs = "root=/dev/sda2 rw rootwait ignore_loglevel earlyprintk no_console_suspend mem=2048M@0x80000000 mem=6144M@0x100000000 console=ttySAC0,115200";
>>>>>>  	};
>>>>>>  
>>>>>> +	memory {
>>>>>> +		device_type = "memory";
>>>>>> +		reg = <0 0>;
>>>>>> +	};
>>>>>
>>>>> This looks okay, but the default size and address cells won't be
>>>>> present. Won't that be a problem?
>>>>>
>>>>
>>>> They will be present since at this point exynos5440.dtsi is still including
>>>> exynos5440.dtsi, we are just overriding the memory node with the same values
>>>> than skeleton.dtsi so this can be removed later in patch 7/7.
>>>
>>> I don't get it. exynos5440.dtsi does not set size/address cells in top node.
>>>
>>
>> Sorry, maybe I'm misunderstanding your question. The size/address cells are set
>> in the top node by exynos5440.dtsi including the skeleton.dtsi (since these are
>> set in that included dtsi).
> 
> Where? Nothing in my sources...
> 
> 15 / {
> 16         compatible = "samsung,exynos5440", "samsung,exynos5";
> 17
> 18         interrupt-parent = <&gic>;
>

No, I meant that these are set by the fact that exynos5440.dtsi is including
the skeleton.dtsi, since the dtsi set these properties in the top node.

>>
>> IOW, scripts/dtc/dtx_diff doesn't show differences for these exynos5440 DTB
>> before and after $SUBJECT.
> 
> Maybe these are also the default values so no differences... stating
> them explicitly would be useful.
>

I could do it in this patch... but I don't see why that should be needed since:

a) All the others Exynos SoC dtsi file don't explicitly set these properties
   since are set by skeleton.dtsi when including it. So not adding them keeps
   exynos5440.dtsi consistent with the other SoC dtsi.

b) Adding those to the Exynos SoC dtsi when removing the skeleton.dtsi is done
   in a later patch of this series. Again, making it consistent with all the
   Exynos SoC dtsi since none will include skeleton.dtsi anymore.

> Best regards,
> Krzysztof
> 
> 

Best regards,
-- 
Javier Martinez Canillas
Open Source Group
Samsung Research America

Re: [PATCH 1/7] ARM: dts: exynos: Add missing memory node for Exynos5440 boards

[Krzysztof Kozlowski]

On 09/01/2016 11:36 AM, Javier Martinez Canillas wrote:
> Hello Krzysztof,
> 
> On 09/01/2016 11:28 AM, Krzysztof Kozlowski wrote:
>> On 09/01/2016 11:19 AM, Javier Martinez Canillas wrote:
>>> Hello Krzysztof,
>>>
>>> On 09/01/2016 11:05 AM, Krzysztof Kozlowski wrote:
>>>> On 09/01/2016 10:43 AM, Javier Martinez Canillas wrote:
>>>>>>> --- a/arch/arm/boot/dts/exynos5440-ssdk5440.dts
>>>>>>> +++ b/arch/arm/boot/dts/exynos5440-ssdk5440.dts
>>>>>>> @@ -21,6 +21,11 @@
>>>>>>>  		bootargs = "root=/dev/sda2 rw rootwait ignore_loglevel earlyprintk no_console_suspend mem=2048M@0x80000000 mem=6144M@0x100000000 console=ttySAC0,115200";
>>>>>>>  	};
>>>>>>>  
>>>>>>> +	memory {
>>>>>>> +		device_type = "memory";
>>>>>>> +		reg = <0 0>;
>>>>>>> +	};
>>>>>>
>>>>>> This looks okay, but the default size and address cells won't be
>>>>>> present. Won't that be a problem?
>>>>>>
>>>>>
>>>>> They will be present since at this point exynos5440.dtsi is still including
>>>>> exynos5440.dtsi, we are just overriding the memory node with the same values
>>>>> than skeleton.dtsi so this can be removed later in patch 7/7.
>>>>
>>>> I don't get it. exynos5440.dtsi does not set size/address cells in top node.
>>>>
>>>
>>> Sorry, maybe I'm misunderstanding your question. The size/address cells are set
>>> in the top node by exynos5440.dtsi including the skeleton.dtsi (since these are
>>> set in that included dtsi).
>>
>> Where? Nothing in my sources...
>>
>> 15 / {
>> 16         compatible = "samsung,exynos5440", "samsung,exynos5";
>> 17
>> 18         interrupt-parent = <&gic>;
>>
> 
> No, I meant that these are set by the fact that exynos5440.dtsi is including
> the skeleton.dtsi, since the dtsi set these properties in the top node.
> 
>>>
>>> IOW, scripts/dtc/dtx_diff doesn't show differences for these exynos5440 DTB
>>> before and after $SUBJECT.
>>
>> Maybe these are also the default values so no differences... stating
>> them explicitly would be useful.
>>
> 
> I could do it in this patch... but I don't see why that should be needed since:
> 
> a) All the others Exynos SoC dtsi file don't explicitly set these properties
>    since are set by skeleton.dtsi when including it. So not adding them keeps
>    exynos5440.dtsi consistent with the other SoC dtsi.
> 
> b) Adding those to the Exynos SoC dtsi when removing the skeleton.dtsi is done
>    in a later patch of this series. Again, making it consistent with all the
>    Exynos SoC dtsi since none will include skeleton.dtsi anymore.

Ah, I missed it. The 'b' is the solution I wanted so everything is fine.

Best regards,
Krzysztof

Re: [PATCH 1/7] ARM: dts: exynos: Add missing memory node for Exynos5440 boards

[Krzysztof Kozlowski]

On 09/01/2016 11:36 AM, Javier Martinez Canillas wrote:
> Hello Krzysztof,
> 
> On 09/01/2016 11:28 AM, Krzysztof Kozlowski wrote:
>> On 09/01/2016 11:19 AM, Javier Martinez Canillas wrote:
>>> Hello Krzysztof,
>>>
>>> On 09/01/2016 11:05 AM, Krzysztof Kozlowski wrote:
>>>> On 09/01/2016 10:43 AM, Javier Martinez Canillas wrote:
>>>>>>> --- a/arch/arm/boot/dts/exynos5440-ssdk5440.dts
>>>>>>> +++ b/arch/arm/boot/dts/exynos5440-ssdk5440.dts
>>>>>>> @@ -21,6 +21,11 @@
>>>>>>>  		bootargs = "root=/dev/sda2 rw rootwait ignore_loglevel earlyprintk no_console_suspend mem=2048M@0x80000000 mem=6144M@0x100000000 console=ttySAC0,115200";
>>>>>>>  	};
>>>>>>>  
>>>>>>> +	memory {
>>>>>>> +		device_type = "memory";
>>>>>>> +		reg = <0 0>;
>>>>>>> +	};
>>>>>>
>>>>>> This looks okay, but the default size and address cells won't be
>>>>>> present. Won't that be a problem?
>>>>>>
>>>>>
>>>>> They will be present since at this point exynos5440.dtsi is still including
>>>>> exynos5440.dtsi, we are just overriding the memory node with the same values
>>>>> than skeleton.dtsi so this can be removed later in patch 7/7.
>>>>
>>>> I don't get it. exynos5440.dtsi does not set size/address cells in top node.
>>>>
>>>
>>> Sorry, maybe I'm misunderstanding your question. The size/address cells are set
>>> in the top node by exynos5440.dtsi including the skeleton.dtsi (since these are
>>> set in that included dtsi).
>>
>> Where? Nothing in my sources...
>>
>> 15 / {
>> 16         compatible = "samsung,exynos5440", "samsung,exynos5";
>> 17
>> 18         interrupt-parent = <&gic>;
>>
> 
> No, I meant that these are set by the fact that exynos5440.dtsi is including
> the skeleton.dtsi, since the dtsi set these properties in the top node.
> 
>>>
>>> IOW, scripts/dtc/dtx_diff doesn't show differences for these exynos5440 DTB
>>> before and after $SUBJECT.
>>
>> Maybe these are also the default values so no differences... stating
>> them explicitly would be useful.
>>
> 
> I could do it in this patch... but I don't see why that should be needed since:
> 
> a) All the others Exynos SoC dtsi file don't explicitly set these properties
>    since are set by skeleton.dtsi when including it. So not adding them keeps
>    exynos5440.dtsi consistent with the other SoC dtsi.
> 
> b) Adding those to the Exynos SoC dtsi when removing the skeleton.dtsi is done
>    in a later patch of this series. Again, making it consistent with all the
>    Exynos SoC dtsi since none will include skeleton.dtsi anymore.

Ah, I missed it. The 'b' is the solution I wanted so everything is fine.

Best regards,
Krzysztof

--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH 0/7] ARM: dts: exynos: Remove skeleton.dtsi usage and fix memory node DTC warnings

[Bartlomiej Zolnierkiewicz]

Hi,

On Thursday, September 01, 2016 10:35:15 AM Javier Martinez Canillas wrote:
> Hello Bartlomiej,
> 
> On 08/31/2016 07:40 PM, Bartlomiej Zolnierkiewicz wrote:
> > 
> > Hi,
> > 
> > On Wednesday, August 31, 2016 03:45:24 PM Javier Martinez Canillas wrote:
> >> Hello Krzysztof,
> >>
> >> On 08/31/2016 02:55 PM, Krzysztof Kozlowski wrote:
> >>> On 08/31/2016 02:14 PM, Javier Martinez Canillas wrote:
> >>>> Hello Krzysztof,
> >>>>
> >>>> This series removes the usage of the skeleton.dtsi in all the Exynos dts,
> >>>> which allows to get rid of the DTC warnings about a mismatch between the
> >>>> memory nodes' unit names and reg properties.
> >>>>
> >>>> Patches are pretty trivial and shouldn't cause functional changes AFAIK,
> >>>> but only the Exynos5 changes have been tested. The others patches were
> >>>> just built tested.
> >>>
> >>> I think this is a common problem, not only Exynos-specific, so I would
> >>
> >> That's correct.
> >>
> >>> prefer to stick to common pattern. Either all DTS/DTSI include skeleton
> >>> or none of them.
> >>>
> >>
> >> The idea is to get rid of skeleton.dtsi [0], but that will of course take
> >> time until the dtsi is removed from all the files. So this patch is a step
> >> in the right direction so at least Exynos is not a blocker to remove it.
> > 
> > Krzysztof's point is valid.  If you are going to convert all DTS/DTSI
> > then it is okay to apply Exynos specific changes, otherwise the code
> > should stay as it is currently.
> > 
> > Exynos won't be a blocker since we have your patches now and they can
> > be applied when/if needed ;)..
> >
> 
> Sorry but I disagree. I see no reasons to need this to be an atomic, rather
> than incremental change. Deprecated things are usually handled by removing
> the usage and once there are no users, finally removing them.

Yes, given that there is agreement on the direction and people are aware
of the needed changes.  This doesn't seem to be a case yet as there is
no comment in skeleton.dtsi about being deprecated and other platforms'
Maintainers are not aware of the need for the change.

> Also, each subsystem maintainer should carry the patches for their platform
> so it can't be a kernel wide change anyways and most likely split by kernel
> releases.

Yep.

Best regards,
--
Bartlomiej Zolnierkiewicz
Samsung R&D Institute Poland
Samsung Electronics

Re: [PATCH 0/7] ARM: dts: exynos: Remove skeleton.dtsi usage and fix memory node DTC warnings

[Mark Rutland]

On Thu, Sep 01, 2016 at 11:59:48AM +0200, Bartlomiej Zolnierkiewicz wrote:
> On Thursday, September 01, 2016 10:35:15 AM Javier Martinez Canillas wrote:
> > On 08/31/2016 07:40 PM, Bartlomiej Zolnierkiewicz wrote:
> > > On Wednesday, August 31, 2016 03:45:24 PM Javier Martinez Canillas wrote:
> > >> The idea is to get rid of skeleton.dtsi [0], but that will of course take
> > >> time until the dtsi is removed from all the files. So this patch is a step
> > >> in the right direction so at least Exynos is not a blocker to remove it.
> > > 
> > > Krzysztof's point is valid.  If you are going to convert all DTS/DTSI
> > > then it is okay to apply Exynos specific changes, otherwise the code
> > > should stay as it is currently.
> > > 
> > > Exynos won't be a blocker since we have your patches now and they can
> > > be applied when/if needed ;)..
> > 
> > Sorry but I disagree. I see no reasons to need this to be an atomic, rather
> > than incremental change. Deprecated things are usually handled by removing
> > the usage and once there are no users, finally removing them.
> 
> Yes, given that there is agreement on the direction and people are aware
> of the needed changes.  This doesn't seem to be a case yet as there is
> no comment in skeleton.dtsi about being deprecated and other platforms'
> Maintainers are not aware of the need for the change.

On the DT side we're all agreed that skeleton.dtsi should die. I'll send
a patch adding a note to skeleton.dtsi to make this more obvious, but
that shouldn't be a blocker for removing existing uses.

Thanks,
Mark.

Re: [PATCH 0/7] ARM: dts: exynos: Remove skeleton.dtsi usage and fix memory node DTC warnings

[Bartlomiej Zolnierkiewicz]

Hi,

On Thursday, September 01, 2016 12:40:46 PM Mark Rutland wrote:
> On Thu, Sep 01, 2016 at 11:59:48AM +0200, Bartlomiej Zolnierkiewicz wrote:
> > On Thursday, September 01, 2016 10:35:15 AM Javier Martinez Canillas wrote:
> > > On 08/31/2016 07:40 PM, Bartlomiej Zolnierkiewicz wrote:
> > > > On Wednesday, August 31, 2016 03:45:24 PM Javier Martinez Canillas wrote:
> > > >> The idea is to get rid of skeleton.dtsi [0], but that will of course take
> > > >> time until the dtsi is removed from all the files. So this patch is a step
> > > >> in the right direction so at least Exynos is not a blocker to remove it.
> > > > 
> > > > Krzysztof's point is valid.  If you are going to convert all DTS/DTSI
> > > > then it is okay to apply Exynos specific changes, otherwise the code
> > > > should stay as it is currently.
> > > > 
> > > > Exynos won't be a blocker since we have your patches now and they can
> > > > be applied when/if needed ;)..
> > > 
> > > Sorry but I disagree. I see no reasons to need this to be an atomic, rather
> > > than incremental change. Deprecated things are usually handled by removing
> > > the usage and once there are no users, finally removing them.
> > 
> > Yes, given that there is agreement on the direction and people are aware
> > of the needed changes.  This doesn't seem to be a case yet as there is
> > no comment in skeleton.dtsi about being deprecated and other platforms'
> > Maintainers are not aware of the need for the change.
> 
> On the DT side we're all agreed that skeleton.dtsi should die. I'll send
> a patch adding a note to skeleton.dtsi to make this more obvious, but
> that shouldn't be a blocker for removing existing uses.

Thank you for clarifying this, I see no problem with applying Javier's
Exynos DTS/DTSI changes now.

Best regards,
--
Bartlomiej Zolnierkiewicz
Samsung R&D Institute Poland
Samsung Electronics