Re: [EXTERNAL] [master/dunfell PATCH] matrix-gui-pm-demos: Allow empty package

From: "Tammana, Gowtham" <g-tammana@ti.com>
To: Paul Barker <pbarker@konsulko.com>
Cc: "meta-arago@arago-project.org" <meta-arago@arago-project.org>
Subject: Re: [EXTERNAL] [master/dunfell PATCH] matrix-gui-pm-demos: Allow empty package
Date: Fri, 6 Nov 2020 22:45:51 +0000	[thread overview]
Message-ID: <bcf4433b6a8d4758a56eb570f1e84695@ti.com> (raw)
In-Reply-To: <CAM9ZRVsxSA04mVx08eeoMiWQNOCSDPE3bXhJW-Vn9HM43BzfcA@mail.gmail.com>

>-----Original Message-----
>From: Paul Barker <pbarker@konsulko.com>
>Sent: Friday, November 06, 2020 3:06 AM
>To: Tammana, Gowtham <g-tammana@ti.com>
>Cc: meta-arago@arago-project.org
>Subject: Re: [EXTERNAL] [meta-arago] [master/dunfell PATCH] matrix-gui-pm-
>demos: Allow empty package
>
>On Thu, 5 Nov 2020 at 22:54, Tammana, Gowtham <g-tammana@ti.com> wrote:
>>
>> >-----Original Message-----
>> >From: meta-arago-bounces@arago-project.org <meta-arago-bounces@arago-
>> >project.org> On Behalf Of Paul Barker
>> >Sent: Thursday, November 05, 2020 4:38 AM
>> >To: meta-arago@arago-project.org
>> >Subject: [EXTERNAL] [meta-arago] [master/dunfell PATCH] matrix-gui-pm-
>> >demos: Allow empty package
>> >
>> >The matrix-gui-pm-demos recipe splits its binaries into several
>> >subpackages leaving the default package empty. The dependencies for the
>> >default package are set so it makes sense to allow this empty package
>to
>> >be created.
>> >
>> >Signed-off-by: Paul Barker <pbarker@konsulko.com>
>> >---
>> > meta-arago-extras/recipes-core/matrix/matrix-gui-pm-demos_2.0.bb | 1 +
>> > 1 file changed, 1 insertion(+)
>> >
>> >diff --git a/meta-arago-extras/recipes-core/matrix/matrix-gui-pm-
>> >demos_2.0.bb b/meta-arago-extras/recipes-core/matrix/matrix-gui-pm-
>> >demos_2.0.bb
>> >index 0116f5ea..a9ebb84f 100644
>> >--- a/meta-arago-extras/recipes-core/matrix/matrix-gui-pm-demos_2.0.bb
>> >+++ b/meta-arago-extras/recipes-core/matrix/matrix-gui-pm-demos_2.0.bb
>> >@@ -10,6 +10,7 @@ S = "${WORKDIR}/git/power_apps"
>> >
>> > # Make sure power submenu and app images has been installed
>> > RDEPENDS_${PN} += "matrix-gui-apps-images matrix-gui-submenus-power
>> >matrix-gui-generic-pm"
>> >+ALLOW_EMPTY_${PN} = "1"
>>
>> Just curious, I assume that the deployment of the dependent packages is
>still
>> ensured even without this change. This just makes it apparent to the
>user that
>> the default package is empty. Or is it that the deployment of dependent
>packages
>> is broken without this.
>
>Without this change the matrix-gui-pm-demos package is not created and
>cannot be installed.

Yes, but as the package here is empty trying to understand why it needs to
be installed in the first place.

Now that the package is created, wondering if the dependencies with the 
sub-packages needs to be listed as well something like

RDEPENDS_${PN} += ${PN}-<subpackages} or

RDEPENDS_${PN}-<subpackages> = ${PN}

Thanks,
Gowtham