From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_PASS, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8A027C4360F for ; Thu, 4 Apr 2019 15:24:28 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 50C9B20855 for ; Thu, 4 Apr 2019 15:24:28 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="VVBc8jSC" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728861AbfDDPY1 (ORCPT ); Thu, 4 Apr 2019 11:24:27 -0400 Received: from mail-pf1-f194.google.com ([209.85.210.194]:33757 "EHLO mail-pf1-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727398AbfDDPY1 (ORCPT ); Thu, 4 Apr 2019 11:24:27 -0400 Received: by mail-pf1-f194.google.com with SMTP id i19so1551300pfd.0 for ; Thu, 04 Apr 2019 08:24:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=dBkH24p3OnPn6WAhmrhEH4gWUlEv3PwgbHpbuqHSdFc=; b=VVBc8jSCAwxjxxU5wM1F8WTT/nUnk9Ub0/2m821vfuoWBByYWcns/+VqLWkyTz27bt ilADIHNegDyTn2ZBtUdgneptu89KGcugf+rTNaLqyU7AHYnZtydiAGkaRp7SfUKUDyyS teDMAHh9sege3mAeSenP4NHT5Frp++1iOAq8+K+wJzCW/aHfbBjwQPaRUOe3jPLt5vMT ut+wQB9DlK+KjZe+3h0nJb/FpE8aeGldl9M1dsnTy7SkFY9TdKxyjG/prTq5R3awuIUl xjFeVHYU94L8TG0+KPf4jztNTMOHX4F/NZNv+0svr2rPhJhIOxVXk+vbGWGZLa8PEf+u KCMA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=dBkH24p3OnPn6WAhmrhEH4gWUlEv3PwgbHpbuqHSdFc=; b=t1eOYoKw5MWiSD2RER+XU7zbu9+QZ4lHF+QP4Z9qncl9qKtyJVQvAyBNtiAgpSuu51 xsKCOs2BXU0bY1Q1mS9IQ/cRatnoa9XrKj3cHuaL8g6WL3Ojsd2e/MJe8icQCFt/dawB 8BBEFqb5hjQjCVRImQF76Fb07bRvb4CkHW7R6PkzSvCOn8RAA5NjM3R1tm6Pj6yqvIT3 XNPZ3S7IeNATk9Knndkwd0YXpPNXI/UjA24VfPlxt2lQ+1bx/QTbh8Hc9P8Tmt+UoAU7 dglCLvvxu+t36tRBO0qvF/VwNxatkb9pMSIGgEd9621hD31s8o3Bwc+EPb/6WbKfr+5X qAJA== X-Gm-Message-State: APjAAAU3qUnNWVxl1x/18G90CCdPdUEgDaiXvH5pl/YyvUFPjTIz8mnh jWz0NnbJHR/q+ZseiHX4+/ifk6gK X-Google-Smtp-Source: APXvYqz6+kYV0FkuiLKMfSPFtWspGmCD071EQIjC7VzCvpBBzDH7ZxF+zAeZfmkXlnFl75oM50cUUg== X-Received: by 2002:a65:6091:: with SMTP id t17mr6473450pgu.328.1554391465201; Thu, 04 Apr 2019 08:24:25 -0700 (PDT) Received: from ?IPv6:2601:282:800:fd80:c5a1:6d6:d92c:c7c1? ([2601:282:800:fd80:c5a1:6d6:d92c:c7c1]) by smtp.googlemail.com with ESMTPSA id k10sm4505025pgo.82.2019.04.04.08.24.22 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 04 Apr 2019 08:24:23 -0700 (PDT) Subject: Re: [PATCH net-next] selftests: Add debugging options to pmtu.sh To: Stefano Brivio , David Ahern Cc: davem@davemloft.net, netdev@vger.kernel.org References: <20190404011824.20921-1-dsahern@kernel.org> <20190404141655.1cc171ad@redhat.com> From: David Ahern Message-ID: Date: Thu, 4 Apr 2019 09:24:21 -0600 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.14; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <20190404141655.1cc171ad@redhat.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On 4/4/19 6:16 AM, Stefano Brivio wrote: >> diff --git a/tools/testing/selftests/net/pmtu.sh b/tools/testing/selftests/net/pmtu.sh >> index 912b2dc50be3..28e8c97b5c9e 100755 >> --- a/tools/testing/selftests/net/pmtu.sh >> +++ b/tools/testing/selftests/net/pmtu.sh >> @@ -116,6 +116,9 @@ >> # Kselftest framework requirement - SKIP code is 4. >> ksft_skip=4 >> >> +PAUSE_ON_FAIL=no >> +VERBOSE=0 > > For consistency, I'd also rename 'tracing' below to TRACING and assign > it here. ok. > >> # Some systems don't have a ping6 binary anymore >> which ping6 > /dev/null 2>&1 && ping6=$(which ping6) || ping6=$(which ping) >> >> @@ -222,6 +225,26 @@ err_flush() { >> err_buf= >> } >> >> +run_cmd() { >> + local cmd="$*" >> + local out >> + local stderr="2>/dev/null" > > 'local' is not POSIX, and I think it actually breaks (at least) on > ksh93 (maybe not a big deal, but I kept everything else POSIX, so I > wouldn't break it just for this). ok. I did not realize this one is expected to be posix compliant. I have fib_test.sh using /bin/bash > > Besides, for 'ping' commands, it's stdout that needs to be suppressed > (we can just suppress both stdout and stderr if not in verbose mode). sure > >> + if [ "$VERBOSE" = "1" ]; then >> + printf " COMMAND: $cmd\n" >> + stderr= >> + fi >> + >> + out=$(eval $cmd $stderr) > > I think this needs quoting. Is eval really needed, by the way? old habits. Works fine with bash; not sure about others.