From: Cheah Kok Cheong <thrust73@gmail.com>
To: abbotti@mev.co.uk, hsweeten@visionengravers.com,
gregkh@linuxfoundation.org
Cc: devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org,
Cheah Kok Cheong <thrust73@gmail.com>
Subject: [PATCH 2/5] Staging: comedi: proc: Change file permission to read only
Date: Fri, 30 Dec 2016 19:26:24 +0800 [thread overview]
Message-ID: <bd1bad1ef7fa8702f7827da5dd5f2175d9da32e7.1483094820.git.thrust73@gmail.com> (raw)
In-Reply-To: <cover.1483094820.git.thrust73@gmail.com>
As there's no write operation, change to read only.
Was inadvertantly switched to 0644 in commit 1f817b86d5e6
("comedi: Don't use create_proc_read_entry()").
Signed-off-by: Cheah Kok Cheong <thrust73@gmail.com>
---
drivers/staging/comedi/proc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/comedi/proc.c b/drivers/staging/comedi/proc.c
index 91dea25..3513f4c 100644
--- a/drivers/staging/comedi/proc.c
+++ b/drivers/staging/comedi/proc.c
@@ -88,7 +88,7 @@ static const struct file_operations comedi_proc_fops = {
void comedi_proc_init(void)
{
- proc_create("comedi", 0644, NULL, &comedi_proc_fops);
+ proc_create("comedi", 0444, NULL, &comedi_proc_fops);
}
void comedi_proc_cleanup(void)
--
2.7.4
next prev parent reply other threads:[~2016-12-30 11:26 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-30 11:24 [PATCH 0/5] Staging: comedi: Proc FS related cleanup Cheah Kok Cheong
2016-12-30 11:25 ` [PATCH 1/5] Staging: comedi: comedi_fops: Avoid orphaned proc entry Cheah Kok Cheong
2016-12-30 11:26 ` Cheah Kok Cheong [this message]
2016-12-30 11:26 ` [PATCH 3/5] Staging: comedi: proc: Add __init prefix Cheah Kok Cheong
2016-12-30 11:27 ` [PATCH 4/5] Staging: comedi: proc: Add module owner Cheah Kok Cheong
2016-12-30 11:27 ` [PATCH 5/5] Staging: comedi: proc: Warn if unable to create proc entry Cheah Kok Cheong
2017-01-03 10:43 ` [PATCH 0/5] Staging: comedi: Proc FS related cleanup Ian Abbott
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bd1bad1ef7fa8702f7827da5dd5f2175d9da32e7.1483094820.git.thrust73@gmail.com \
--to=thrust73@gmail.com \
--cc=abbotti@mev.co.uk \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=hsweeten@visionengravers.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.