From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.6 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8B12AC49EA6 for ; Wed, 23 Jun 2021 21:54:29 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 700CD60FE9 for ; Wed, 23 Jun 2021 21:54:29 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230002AbhFWV4q (ORCPT ); Wed, 23 Jun 2021 17:56:46 -0400 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:28204 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229796AbhFWV4o (ORCPT ); Wed, 23 Jun 2021 17:56:44 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1624485266; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=q2oczT/WFO/JvI+sqLC25ZI6Paw6nUoV8jwB+hFflSQ=; b=Ta24a2cpjYLa2EC9tQhcHBhqoZYfuGt/ZEDZKraPbhrFR2PoI69g9uQHjbLVaEiUD73Y5S KZQGB9A1sRZUF9t9HcpJAiHc7Irdhqv3kHzY4VAJuYXlxVi0jKSWmfemtVx1advENIcowi IPbrgVt9+lxcQpFS+4T0t/evpjSobD4= Received: from mail-ej1-f71.google.com (mail-ej1-f71.google.com [209.85.218.71]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-7-zEy91oNqP6SjHFzE6JOuDQ-1; Wed, 23 Jun 2021 17:54:25 -0400 X-MC-Unique: zEy91oNqP6SjHFzE6JOuDQ-1 Received: by mail-ej1-f71.google.com with SMTP id f1-20020a1709064941b02903f6b5ef17bfso1416216ejt.20 for ; Wed, 23 Jun 2021 14:54:24 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=q2oczT/WFO/JvI+sqLC25ZI6Paw6nUoV8jwB+hFflSQ=; b=dk1UHicT2ztksmuFJ6Jt/XEjJq1JCttC7oilfVKyHHvmHqmpUIV5xvzX/T5ykjHFY5 dJSwUhGrbnon7r2MH8ge4jeZ5cDUBUZGy6JngroM8to7d9myarzh5K9zCfiTOuW7kj1H qszw5p36MD5uE3enjFtFhEAdi3/PXFGcsdF5OQKxbod+5GWURd+dm/hJpD4nZSXxDEPe /MPl0z3zrx47DFhccgKHQfcwpW9tu9egrIT2y2FZik6VfBERSmriCDGBbwlyUj1iz68+ mCLpP7IefF6VD4L4ub4HGvS0kbLECv+OvZ3uzVpfu/0/wskzzE/+rf4Zj4d0Au2llZE6 VZ2Q== X-Gm-Message-State: AOAM530wUAF7hKRSxc+HvxBT3SFePBk3P4AJ903XjT/C0E3+HQ7NhfVD wA9fS1Kl96S8ZZTOnm6fMskPKgE+E3w40vL7tPYylwfGPCQi9zYCQ3gR+dCe1G0XEIyOHZ2Nwyo 2FQg79UKtOAgnGB1F4E2vRuGw X-Received: by 2002:a17:906:585a:: with SMTP id h26mr2060452ejs.31.1624485263926; Wed, 23 Jun 2021 14:54:23 -0700 (PDT) X-Google-Smtp-Source: ABdhPJy6wF2IKkIuTm+iUZD3A7ksdCISq2WDa6KzhKMO2dYCj9ZXXGf/bICQzlY4TiYgoOCsQKAQag== X-Received: by 2002:a17:906:585a:: with SMTP id h26mr2060440ejs.31.1624485263793; Wed, 23 Jun 2021 14:54:23 -0700 (PDT) Received: from ?IPv6:2001:b07:6468:f312:c8dd:75d4:99ab:290a? ([2001:b07:6468:f312:c8dd:75d4:99ab:290a]) by smtp.gmail.com with ESMTPSA id j1sm722179edl.80.2021.06.23.14.54.22 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 23 Jun 2021 14:54:23 -0700 (PDT) Subject: Re: [PATCH 07/10] KVM: SVM: use vmcb01 in svm_refresh_apicv_exec_ctrl To: Maxim Levitsky , kvm@vger.kernel.org Cc: Thomas Gleixner , Sean Christopherson , Wanpeng Li , Vitaly Kuznetsov , Joerg Roedel , Borislav Petkov , "H. Peter Anvin" , Ingo Molnar , "open list:X86 ARCHITECTURE (32-BIT AND 64-BIT)" , "maintainer:X86 ARCHITECTURE (32-BIT AND 64-BIT)" , Jim Mattson References: <20210623113002.111448-1-mlevitsk@redhat.com> <20210623113002.111448-8-mlevitsk@redhat.com> From: Paolo Bonzini Message-ID: Date: Wed, 23 Jun 2021 23:54:21 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.10.1 MIME-Version: 1.0 In-Reply-To: <20210623113002.111448-8-mlevitsk@redhat.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 23/06/21 13:29, Maxim Levitsky wrote: > AVIC is not supported for nesting but in some corner > cases it is possible to have it still be enabled, > after we entered nesting, and use vmcb02. > > Fix this by always using vmcb01 in svm_refresh_apicv_exec_ctrl Please be more verbose about the corner case (and then the second paragraph should not be necessary anymore). Paolo > Signed-off-by: Maxim Levitsky > --- > arch/x86/kvm/svm/avic.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/x86/kvm/svm/avic.c b/arch/x86/kvm/svm/avic.c > index 1d01da64c333..a8ad78a2faa1 100644 > --- a/arch/x86/kvm/svm/avic.c > +++ b/arch/x86/kvm/svm/avic.c > @@ -646,7 +646,7 @@ static int svm_set_pi_irte_mode(struct kvm_vcpu *vcpu, bool activate) > void svm_refresh_apicv_exec_ctrl(struct kvm_vcpu *vcpu) > { > struct vcpu_svm *svm = to_svm(vcpu); > - struct vmcb *vmcb = svm->vmcb; > + struct vmcb *vmcb = svm->vmcb01.ptr; > bool activated = kvm_vcpu_apicv_active(vcpu); > > if (!enable_apicv) >