From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 08CB2C433DF for ; Fri, 24 Jul 2020 10:37:04 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id DD7E020748 for ; Fri, 24 Jul 2020 10:37:03 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726702AbgGXKhC (ORCPT ); Fri, 24 Jul 2020 06:37:02 -0400 Received: from foss.arm.com ([217.140.110.172]:59778 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726329AbgGXKhC (ORCPT ); Fri, 24 Jul 2020 06:37:02 -0400 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 6709330E; Fri, 24 Jul 2020 03:37:01 -0700 (PDT) Received: from [10.163.85.90] (unknown [10.163.85.90]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id BC33F3F66E; Fri, 24 Jul 2020 03:36:55 -0700 (PDT) Subject: Re: [PATCH -next] arm64: Export __cpu_logical_map To: Catalin Marinas Cc: Kefeng Wang , Will Deacon , Mikko Perttunen , Sumit Gupta , Viresh Kumar , Hulk Robot , "linux-kernel@vger.kernel.org List" , linux-arm-kernel@lists.infradead.org References: <20200724030433.22287-1-wangkefeng.wang@huawei.com> <82f750c4-d423-1ed8-a158-e75153745e07@huawei.com> <7998529f-da52-5e46-dd09-b9b11d83ec1a@arm.com> <20200724093054.GA23388@gaia> From: Anshuman Khandual Message-ID: Date: Fri, 24 Jul 2020 16:06:28 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <20200724093054.GA23388@gaia> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 07/24/2020 03:00 PM, Catalin Marinas wrote: > On Fri, Jul 24, 2020 at 01:46:18PM +0530, Anshuman Khandual wrote: >> On 07/24/2020 08:38 AM, Kefeng Wang wrote: >>> On 2020/7/24 11:04, Kefeng Wang wrote: >>>> ERROR: modpost: "__cpu_logical_map" [drivers/cpufreq/tegra194-cpufreq.ko] undefined! >>>> >>>> ARM64 tegra194-cpufreq driver use cpu_logical_map, export >>>> __cpu_logical_map to fix build issue. >> Commit 887d5fc82cb4 ("cpufreq: Add Tegra194 cpufreq driver") which adds >> this particular driver is present just on linux-next. But as expected, >> the driver does not use __cpu_logical_map directly but instead accesses >> it via cpu_logical_map() wrapper. Wondering, how did you even trigger >> the modpost error ? > Since the wrapper is a macro, it just expands to __cpu_logical_map[]. > Ahh, right. Existing cpu_logical_map() is not a true wrapper and it makes sense to convert that into one. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 75E83C433EA for ; Fri, 24 Jul 2020 10:38:45 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 3DD5E2074A for ; Fri, 24 Jul 2020 10:38:45 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="PP2Waz1x" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 3DD5E2074A Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:From: References:To:Subject:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=ZO1hmAEs8FvmbfIbvYnSXzUyXb9JlqJqcc+dcaKlyTk=; b=PP2Waz1xMoDJkk0GFTR1ZgdEA ruwX4epsIQfeNqnkiDPb5Jg4Da+npzNPzw+cLf98pEvDeaQpnEOl+L88KnlhxmLvmUpamVj+hk0X8 qvfbc0m5VAaWOvI1MMjIvw9mLTzY3Ur0rDEcxpphPaAiAOiB/O1csqL/oaDFRDIOBcwUVgyy+UJ2Q 4KEWiJ1rbdcHsvfwle41nU1mTxKx5BRm5ZeLU+J9n74l9BjAMMZvjS3GdDrB3wxVvzVomvC8hdYyo HmJ4pAnITc6lWHUYdddjCeOnecCpSoGZ+2rWeX7w+LIsqIO+jfm9V3553zBlJRjxX+i0bU9GkW2iS wU47ucpPA==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jyv4f-0005oJ-CQ; Fri, 24 Jul 2020 10:37:09 +0000 Received: from foss.arm.com ([217.140.110.172]) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jyv4c-0005nn-5z for linux-arm-kernel@lists.infradead.org; Fri, 24 Jul 2020 10:37:06 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 6709330E; Fri, 24 Jul 2020 03:37:01 -0700 (PDT) Received: from [10.163.85.90] (unknown [10.163.85.90]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id BC33F3F66E; Fri, 24 Jul 2020 03:36:55 -0700 (PDT) Subject: Re: [PATCH -next] arm64: Export __cpu_logical_map To: Catalin Marinas References: <20200724030433.22287-1-wangkefeng.wang@huawei.com> <82f750c4-d423-1ed8-a158-e75153745e07@huawei.com> <7998529f-da52-5e46-dd09-b9b11d83ec1a@arm.com> <20200724093054.GA23388@gaia> From: Anshuman Khandual Message-ID: Date: Fri, 24 Jul 2020 16:06:28 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <20200724093054.GA23388@gaia> Content-Language: en-US X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200724_063706_289377_5C4813E4 X-CRM114-Status: GOOD ( 12.64 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Kefeng Wang , Viresh Kumar , "linux-kernel@vger.kernel.org List" , Mikko Perttunen , Hulk Robot , Sumit Gupta , Will Deacon , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 07/24/2020 03:00 PM, Catalin Marinas wrote: > On Fri, Jul 24, 2020 at 01:46:18PM +0530, Anshuman Khandual wrote: >> On 07/24/2020 08:38 AM, Kefeng Wang wrote: >>> On 2020/7/24 11:04, Kefeng Wang wrote: >>>> ERROR: modpost: "__cpu_logical_map" [drivers/cpufreq/tegra194-cpufreq.ko] undefined! >>>> >>>> ARM64 tegra194-cpufreq driver use cpu_logical_map, export >>>> __cpu_logical_map to fix build issue. >> Commit 887d5fc82cb4 ("cpufreq: Add Tegra194 cpufreq driver") which adds >> this particular driver is present just on linux-next. But as expected, >> the driver does not use __cpu_logical_map directly but instead accesses >> it via cpu_logical_map() wrapper. Wondering, how did you even trigger >> the modpost error ? > Since the wrapper is a macro, it just expands to __cpu_logical_map[]. > Ahh, right. Existing cpu_logical_map() is not a true wrapper and it makes sense to convert that into one. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel