From: Konrad Dybcio <konrad.dybcio@linaro.org>
To: Andrew Halaney <ahalaney@redhat.com>, linux-kernel@vger.kernel.org
Cc: agross@kernel.org, andersson@kernel.org, robh+dt@kernel.org,
krzysztof.kozlowski+dt@linaro.org, linux-arm-msm@vger.kernel.org,
devicetree@vger.kernel.org
Subject: Re: [PATCH v2 3/3] arm64: dts: qcom: sa8155p-adp: Remove unneeded rgmii_phy information
Date: Fri, 14 Apr 2023 01:38:42 +0200 [thread overview]
Message-ID: <bd2fd84c-78f2-e629-ea47-6e40ea5dad23@linaro.org> (raw)
In-Reply-To: <20230413194020.1077857-3-ahalaney@redhat.com>
On 13.04.2023 21:40, Andrew Halaney wrote:
> Using interrupts-extended already indicates what the interrupt-parent
> is, so drop the explicit interrupt-parent.
>
> The comment about this being the phy-intr is not helpful either, since
> this is the only interrupt in the phy node.
>
> Suggested-by: Konrad Dybcio <konrad.dybcio@linaro.org>
> Signed-off-by: Andrew Halaney <ahalaney@redhat.com>
> ---
Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org>
Konrad
>
> Changes since v1:
> * New patch (Konrad)
>
> arch/arm64/boot/dts/qcom/sa8155p-adp.dts | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/qcom/sa8155p-adp.dts b/arch/arm64/boot/dts/qcom/sa8155p-adp.dts
> index ac52a8dfeba1..b65e0203d783 100644
> --- a/arch/arm64/boot/dts/qcom/sa8155p-adp.dts
> +++ b/arch/arm64/boot/dts/qcom/sa8155p-adp.dts
> @@ -361,8 +361,7 @@ rgmii_phy: phy@7 {
> compatible = "ethernet-phy-ieee802.3-c22";
> reg = <0x7>;
>
> - interrupt-parent = <&tlmm>;
> - interrupts-extended = <&tlmm 124 IRQ_TYPE_EDGE_FALLING>; /* phy intr */
> + interrupts-extended = <&tlmm 124 IRQ_TYPE_EDGE_FALLING>;
> device_type = "ethernet-phy";
> };
> };
next prev parent reply other threads:[~2023-04-13 23:38 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-13 19:40 [PATCH v2 1/3] arm64: dts: qcom: sa8155p-adp: Make compatible the first property Andrew Halaney
2023-04-13 19:40 ` [PATCH v2 2/3] arm64: dts: qcom: sa8155p-adp: Make -cells decimal Andrew Halaney
2023-04-13 23:37 ` Konrad Dybcio
2023-04-13 19:40 ` [PATCH v2 3/3] arm64: dts: qcom: sa8155p-adp: Remove unneeded rgmii_phy information Andrew Halaney
2023-04-13 23:38 ` Konrad Dybcio [this message]
2023-04-13 23:38 ` [PATCH v2 1/3] arm64: dts: qcom: sa8155p-adp: Make compatible the first property Konrad Dybcio
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bd2fd84c-78f2-e629-ea47-6e40ea5dad23@linaro.org \
--to=konrad.dybcio@linaro.org \
--cc=agross@kernel.org \
--cc=ahalaney@redhat.com \
--cc=andersson@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.