From mboxrd@z Thu Jan 1 00:00:00 1970 From: Suman Anna Subject: Re: [PATCH 1/9] dmaengine: omap-dma: include header for bool type Date: Wed, 14 Feb 2018 12:22:33 -0600 Message-ID: References: <20180213013243.8378-1-s-anna@ti.com> <20180213013243.8378-2-s-anna@ti.com> <20180214180714.GQ6364@atomide.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20180214180714.GQ6364@atomide.com> Content-Language: en-US List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=m.gmane.org@lists.infradead.org To: Tony Lindgren Cc: Tero Kristo , Keerthy , linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org List-Id: linux-omap@vger.kernel.org On 02/14/2018 12:07 PM, Tony Lindgren wrote: > * Suman Anna [180213 01:33]: >> The omap-dmaengine.h header file uses a bool type, so include >> the linux types.h header file so that it is self-contained. >> The lack of this header caused some build errors while cleaning >> up some header files from various omap_hwmod data files. > > Let's rather include types.h directly. Here's a patch > that replaces your first two patches. Yeah, I am ok with this as well. I went with the other approach primarily because whoever includes those header files will need a similar fixing or rely on others bringing in the types.h. > > Regards, > > Tony > > 8< -------------------- > From tony Mon Sep 17 00:00:00 2001 > From: Tony Lindgren > Date: Wed, 14 Feb 2018 09:35:20 -0800 > Subject: [PATCH] ARM: OMAP2+: Include types.h directly for hwmod data > > This is needed in preparation for dropping some unused > headers that indirectly include types.h. > > Signed-off-by: Tony Lindgren Tested-by: Suman Anna regards Suman > --- > arch/arm/mach-omap2/omap_hwmod_2xxx_ipblock_data.c | 2 ++ > arch/arm/mach-omap2/omap_hwmod_33xx_43xx_ipblock_data.c | 2 ++ > arch/arm/mach-omap2/omap_hwmod_81xx_data.c | 2 ++ > 3 files changed, 6 insertions(+) > > diff --git a/arch/arm/mach-omap2/omap_hwmod_2xxx_ipblock_data.c b/arch/arm/mach-omap2/omap_hwmod_2xxx_ipblock_data.c > --- a/arch/arm/mach-omap2/omap_hwmod_2xxx_ipblock_data.c > +++ b/arch/arm/mach-omap2/omap_hwmod_2xxx_ipblock_data.c > @@ -9,6 +9,8 @@ > * published by the Free Software Foundation. > */ > > +#include > + > #include > #include > #include > diff --git a/arch/arm/mach-omap2/omap_hwmod_33xx_43xx_ipblock_data.c b/arch/arm/mach-omap2/omap_hwmod_33xx_43xx_ipblock_data.c > --- a/arch/arm/mach-omap2/omap_hwmod_33xx_43xx_ipblock_data.c > +++ b/arch/arm/mach-omap2/omap_hwmod_33xx_43xx_ipblock_data.c > @@ -14,6 +14,8 @@ > * GNU General Public License for more details. > */ > > +#include > + > #include > #include > #include > diff --git a/arch/arm/mach-omap2/omap_hwmod_81xx_data.c b/arch/arm/mach-omap2/omap_hwmod_81xx_data.c > --- a/arch/arm/mach-omap2/omap_hwmod_81xx_data.c > +++ b/arch/arm/mach-omap2/omap_hwmod_81xx_data.c > @@ -15,6 +15,8 @@ > * > */ > > +#include > + > #include > #include > #include > From mboxrd@z Thu Jan 1 00:00:00 1970 From: s-anna@ti.com (Suman Anna) Date: Wed, 14 Feb 2018 12:22:33 -0600 Subject: [PATCH 1/9] dmaengine: omap-dma: include header for bool type In-Reply-To: <20180214180714.GQ6364@atomide.com> References: <20180213013243.8378-1-s-anna@ti.com> <20180213013243.8378-2-s-anna@ti.com> <20180214180714.GQ6364@atomide.com> Message-ID: To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On 02/14/2018 12:07 PM, Tony Lindgren wrote: > * Suman Anna [180213 01:33]: >> The omap-dmaengine.h header file uses a bool type, so include >> the linux types.h header file so that it is self-contained. >> The lack of this header caused some build errors while cleaning >> up some header files from various omap_hwmod data files. > > Let's rather include types.h directly. Here's a patch > that replaces your first two patches. Yeah, I am ok with this as well. I went with the other approach primarily because whoever includes those header files will need a similar fixing or rely on others bringing in the types.h. > > Regards, > > Tony > > 8< -------------------- > From tony Mon Sep 17 00:00:00 2001 > From: Tony Lindgren > Date: Wed, 14 Feb 2018 09:35:20 -0800 > Subject: [PATCH] ARM: OMAP2+: Include types.h directly for hwmod data > > This is needed in preparation for dropping some unused > headers that indirectly include types.h. > > Signed-off-by: Tony Lindgren Tested-by: Suman Anna regards Suman > --- > arch/arm/mach-omap2/omap_hwmod_2xxx_ipblock_data.c | 2 ++ > arch/arm/mach-omap2/omap_hwmod_33xx_43xx_ipblock_data.c | 2 ++ > arch/arm/mach-omap2/omap_hwmod_81xx_data.c | 2 ++ > 3 files changed, 6 insertions(+) > > diff --git a/arch/arm/mach-omap2/omap_hwmod_2xxx_ipblock_data.c b/arch/arm/mach-omap2/omap_hwmod_2xxx_ipblock_data.c > --- a/arch/arm/mach-omap2/omap_hwmod_2xxx_ipblock_data.c > +++ b/arch/arm/mach-omap2/omap_hwmod_2xxx_ipblock_data.c > @@ -9,6 +9,8 @@ > * published by the Free Software Foundation. > */ > > +#include > + > #include > #include > #include > diff --git a/arch/arm/mach-omap2/omap_hwmod_33xx_43xx_ipblock_data.c b/arch/arm/mach-omap2/omap_hwmod_33xx_43xx_ipblock_data.c > --- a/arch/arm/mach-omap2/omap_hwmod_33xx_43xx_ipblock_data.c > +++ b/arch/arm/mach-omap2/omap_hwmod_33xx_43xx_ipblock_data.c > @@ -14,6 +14,8 @@ > * GNU General Public License for more details. > */ > > +#include > + > #include > #include > #include > diff --git a/arch/arm/mach-omap2/omap_hwmod_81xx_data.c b/arch/arm/mach-omap2/omap_hwmod_81xx_data.c > --- a/arch/arm/mach-omap2/omap_hwmod_81xx_data.c > +++ b/arch/arm/mach-omap2/omap_hwmod_81xx_data.c > @@ -15,6 +15,8 @@ > * > */ > > +#include > + > #include > #include > #include >