From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2844DC55178 for ; Thu, 5 Nov 2020 16:23:48 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id B9DA720786 for ; Thu, 5 Nov 2020 16:23:46 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=alsa-project.org header.i=@alsa-project.org header.b="LkhsdTqn" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B9DA720786 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.intel.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=alsa-devel-bounces@alsa-project.org Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 1DC661689; Thu, 5 Nov 2020 17:22:55 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 1DC661689 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1604593425; bh=xHIHEruoFCjZE/+iLGPi4UtgPbm1U10eFI1IRDkw14Y=; h=Subject:To:References:From:Date:In-Reply-To:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=LkhsdTqnd4IazYh+Nm12YXyuaJdFtxsgzEBbuOFTBaH6/t7NvwnIhoGdCOqqWnjnr 6O/IQsZ8tAXeIdkcgClO2KcYJ9mPlfWiSiODPViFKFauLuGw0sLWNteZ8Zeu1iqXfr 7nwjMBO16PEYbabKWUgLmOJ4bvdbC+bHNfMdgZKM= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id B3E56F80171; Thu, 5 Nov 2020 17:22:04 +0100 (CET) Received: by alsa1.perex.cz (Postfix, from userid 50401) id DA01AF80162; Thu, 5 Nov 2020 17:22:02 +0100 (CET) Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 27D49F800BA for ; Thu, 5 Nov 2020 17:21:51 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 27D49F800BA IronPort-SDR: MsSCc9j5F99kCegzTd+YTq9VBzN9+kVZEZCcPwMaeX6DeyTHXiMTs528sNjFLoKet0holaciXR vynMP8z4bHvA== X-IronPort-AV: E=McAfee;i="6000,8403,9796"; a="254117008" X-IronPort-AV: E=Sophos;i="5.77,453,1596524400"; d="scan'208";a="254117008" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga005.jf.intel.com ([10.7.209.41]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 05 Nov 2020 08:21:50 -0800 IronPort-SDR: v21laxcnGwjvgZzt5CIQs440Ch9S/XmBQrqLZ7Q5j4Icm5uecrrvvJg8iP7a0+ly2xfvZ0oHE6 uKJlJMjmU4VQ== X-IronPort-AV: E=Sophos;i="5.77,453,1596524400"; d="scan'208";a="539466790" Received: from umedepal-mobl2.amr.corp.intel.com (HELO [10.254.6.114]) ([10.254.6.114]) by orsmga005-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 05 Nov 2020 08:21:49 -0800 Subject: Re: [PATCH] ASoC: nau8315: add codec driver To: Mark Brown , Tzung-Bi Shih References: <20201102023212.594137-1-CTLIN0@nuvoton.com> <0adb99c2-d0d9-5052-c163-4d9a341239fc@linux.intel.com> <20201105150249.GC4856@sirena.org.uk> From: Pierre-Louis Bossart Message-ID: Date: Thu, 5 Nov 2020 10:21:28 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <20201105150249.GC4856@sirena.org.uk> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Cc: ALSA development , WTLI@nuvoton.com, KCHSU0@nuvoton.com, Liam Girdwood , YHCHuang@nuvoton.com, CTLIN0 X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" On 11/5/20 9:02 AM, Mark Brown wrote: > On Thu, Nov 05, 2020 at 10:20:33AM +0800, Tzung-Bi Shih wrote: > >> If nau8315 doesn't share I2S with other components for now, it could >> be better to not introduce the software mute control. > > The mute callback is there because there's some controllers that don't > start up cleanly and end up outputing glitches (for example due to not > being able to flush their FIFOs) - keeping the CODEC muted until after > the I2S is running covers those glitches. Thanks for explaining those dependencies. The code looks good to me: Reviewed-by: Pierre-Louis Bossart