From: Andrew Cooper <andrew.cooper3@citrix.com>
To: Jan Beulich <JBeulich@suse.com>
Cc: Julien Grall <julien.grall@arm.com>,
Stefano Stabellini <sstabellini@kernel.org>,
Wei Liu <wei.liu2@citrix.com>,
Xen-devel <xen-devel@lists.xen.org>,
Roger Pau Monne <roger.pau@citrix.com>
Subject: Re: [PATCH v2] xen/cmdline: Fix buggy strncmp(s, LITERAL, ss - s) construct
Date: Mon, 7 Jan 2019 17:28:55 +0000 [thread overview]
Message-ID: <bd3f5d10-0d0f-df07-c3ae-b83a74d8809d@citrix.com> (raw)
In-Reply-To: <5C3314F0020000780020AAC3@prv1-mh.provo.novell.com>
On 07/01/2019 08:59, Jan Beulich wrote:
>> @@ -271,6 +297,27 @@ int parse_boolean(const char *name, const char *s, const char *e)
>> return -1;
>> }
>>
>> +int cmdline_strcmp(const char *frag, const char *name)
> So you've decided to retain the strcmp()-like return type and value,
> despite them being of no interest to any caller, and it being
> vanishingly unlikely for a caller to appear which would care. Fine
> for now, but I'd still like to understand why.
You already asked this, and give no objection to my answer, I presumed
you were satisfied with the concrete usecase I gave, citing a patch
needing this behaviour which has already been posted to the list.
<bff3c33d-a244-362a-529c-32f91b5f3965@citrix.com>
~Andrew
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
next prev parent reply other threads:[~2019-01-07 17:28 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-04 17:17 [PATCH v2] xen/cmdline: Fix buggy strncmp(s, LITERAL, ss - s) construct Andrew Cooper
2019-01-07 8:59 ` Jan Beulich
2019-01-07 17:28 ` Andrew Cooper [this message]
2019-01-08 8:31 ` Jan Beulich
2019-01-16 12:08 ` George Dunlap
2019-01-16 12:48 ` Jan Beulich
2019-01-14 15:17 ` PING ARM " Andrew Cooper
2019-01-14 16:07 ` Julien Grall
2019-01-14 16:59 ` Andrew Cooper
2019-01-14 17:16 ` Julien Grall
2019-01-14 17:43 ` Andrew Cooper
2019-01-15 11:39 ` Julien Grall
2019-01-15 8:47 ` Jan Beulich
2019-01-15 11:11 ` Julien Grall
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bd3f5d10-0d0f-df07-c3ae-b83a74d8809d@citrix.com \
--to=andrew.cooper3@citrix.com \
--cc=JBeulich@suse.com \
--cc=julien.grall@arm.com \
--cc=roger.pau@citrix.com \
--cc=sstabellini@kernel.org \
--cc=wei.liu2@citrix.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.