From: Stefan Roese <sr@denx.de>
To: "Marek Behún" <marek.behun@nic.cz>
Cc: u-boot@lists.denx.de, "Tony (bodhi)" <mibodhi@gmail.com>
Subject: Re: kirkwood stack size
Date: Thu, 28 Oct 2021 08:35:08 +0200 [thread overview]
Message-ID: <bd52dfcf-237f-45a6-7063-371f46f0f701@denx.de> (raw)
In-Reply-To: <20211028000753.45cbb531@thinkpad>
Hi Marek,
On 28.10.21 00:07, Marek Behún wrote:
> Hello Stefan,
>
> do you have some ARM Kirkwood board?
No, I don't have of them here. Sorry.
> I am working on some env patches,
> because the code in the env/ directory is a pain in the ass of old
> relics, and Kirkwood is the only platform using the eeprom environment
> driver.
>
> I would like to ask about Kirkwood stack size.
>
> In arch/arm/mach-kirkwood/include/mach/config.h it says
>
> /* Kirkwood has 2k of Security SRAM, use it for SP */
> #define CONFIG_SYS_INIT_SP_ADDR 0xC8012000
>
> So if I understand correctly, Kirkwood has only 2k of init stack.
>
> But the env_eeprom_load() method in env/eeprom.c allocates a
> CONFIG_ENV_SIZE bytes long array for environment, and CONFIG_ENV_SIZE
> is 2k.
>
> Is the init stack changed to another stack before environment is loaded?
> I couldn't find code which would do that. As far as I am able to
> determine, this 2k long init stack is used, and this means that the
> code in env/eeprom.c is wrong, since it allocates below stack space.
>
> Maybe no one used newer U-Boot on Kirkwood for a long time and this was
> not noticed? Should we remove support for Kirkwood?
As you have noticed, Tony is actively working on Kirkwood support
lately.
Thanks,
Stefan
next prev parent reply other threads:[~2021-10-28 6:35 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-27 22:07 kirkwood stack size Marek Behún
2021-10-28 6:35 ` Stefan Roese [this message]
2021-10-27 23:06 Tony Dinh
2021-10-28 1:28 ` Marek Behún
2021-10-28 1:50 ` Tony Dinh
2021-10-28 6:39 ` Stefan Roese
2021-10-28 9:37 ` Holger Brunck
2021-10-28 14:10 ` Stefan Roese
2021-10-28 15:30 ` Marek Behún
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bd52dfcf-237f-45a6-7063-371f46f0f701@denx.de \
--to=sr@denx.de \
--cc=marek.behun@nic.cz \
--cc=mibodhi@gmail.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.