From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.4 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B8726C5519F for ; Tue, 17 Nov 2020 10:55:47 +0000 (UTC) Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 41D0A2464E for ; Tue, 17 Nov 2020 10:55:47 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=suse.com header.i=@suse.com header.b="Wu2LVXOz" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 41D0A2464E Authentication-Results: mail.kernel.org; dmarc=fail (p=quarantine dis=none) header.from=suse.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=xen-devel-bounces@lists.xenproject.org Received: from list by lists.xenproject.org with outflank-mailman.28909.58049 (Exim 4.92) (envelope-from ) id 1keye9-0004PG-CE; Tue, 17 Nov 2020 10:55:37 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 28909.58049; Tue, 17 Nov 2020 10:55:37 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1keye9-0004P9-8v; Tue, 17 Nov 2020 10:55:37 +0000 Received: by outflank-mailman (input) for mailman id 28909; Tue, 17 Nov 2020 10:55:36 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1keye8-0004P4-BP for xen-devel@lists.xenproject.org; Tue, 17 Nov 2020 10:55:36 +0000 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 1619ef4f-0b0f-4656-9671-5d22267930e3; Tue, 17 Nov 2020 10:55:34 +0000 (UTC) Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 0979AACAC; Tue, 17 Nov 2020 10:55:34 +0000 (UTC) Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1keye8-0004P4-BP for xen-devel@lists.xenproject.org; Tue, 17 Nov 2020 10:55:36 +0000 X-Inumbo-ID: 1619ef4f-0b0f-4656-9671-5d22267930e3 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 1619ef4f-0b0f-4656-9671-5d22267930e3; Tue, 17 Nov 2020 10:55:34 +0000 (UTC) X-Virus-Scanned: by amavisd-new at test-mx.suse.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1605610534; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Tfa9QtYIAf/6uVkF4jzi1W9iwf4qW8zRvyaGVxS+W30=; b=Wu2LVXOzGH0c9ILBZIU+dEhgWPZE5eQBuV8HhRJ+pk0WqiFZNjTqCbTcaVl1jQ/upWeIxC 8ICwixC7KYotDA5gTskCv2L0zPYFw4YpgnPG8mm+W1QWlYa2zxOuu4lPDZw1czWOeNMip8 Zmp/EGpQhFEsQrOsxuq0wws6WsT/uBU= Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 0979AACAC; Tue, 17 Nov 2020 10:55:34 +0000 (UTC) Subject: Re: [PATCH v3 1/3] xen/ns16550: Make ns16550 driver usable on ARM with HAS_PCI enabled. To: Rahul Singh Cc: bertrand.marquis@arm.com, Andrew Cooper , George Dunlap , Ian Jackson , Julien Grall , Stefano Stabellini , Wei Liu , xen-devel@lists.xenproject.org References: <955996aa8cd7f17f9f39c60bd3b9b74ffaa5c5f7.1605527997.git.rahul.singh@arm.com> From: Jan Beulich Message-ID: Date: Tue, 17 Nov 2020 11:55:34 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.4.3 MIME-Version: 1.0 In-Reply-To: <955996aa8cd7f17f9f39c60bd3b9b74ffaa5c5f7.1605527997.git.rahul.singh@arm.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit On 16.11.2020 13:25, Rahul Singh wrote: > NS16550 driver has PCI support that is under HAS_PCI flag. When HAS_PCI > is enabled for ARM, compilation error is observed for ARM architecture > because ARM platforms do not have full PCI support available. While you've extended the sentence, it remains unclear to me what compilation error it is that results here. I've requested such clarification for v2 already. > --- a/xen/drivers/char/Kconfig > +++ b/xen/drivers/char/Kconfig > @@ -4,6 +4,10 @@ config HAS_NS16550 > help > This selects the 16550-series UART support. For most systems, say Y. > > +config HAS_NS16550_PCI > + def_bool y > + depends on X86 && HAS_NS16550 && HAS_PCI Looking at this again (in particular at all the #ifdef changes in the actual source file), I wonder whether an approach with less code churn and without such an extra Kconfig setting (with, as said, a bogus dependency on x86) couldn't be found. For example, how about ... > --- a/xen/drivers/char/ns16550.c > +++ b/xen/drivers/char/ns16550.c > @@ -16,7 +16,7 @@ > #include > #include > #include > -#ifdef CONFIG_HAS_PCI > +#ifdef CONFIG_HAS_NS16550_PCI > #include > #include > #include ... #undef-ining CONFIG_HAS_PCI at a suitable position in this file (e.g. after all #include-s, to make sure all structure layouts remain correct)? This would then be far easier to revert down the road, and would confine the oddity to a single file (and there a single place) in the code base. Jan