From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EC3B4C49EA6 for ; Thu, 24 Jun 2021 15:24:59 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id ADCA861351 for ; Thu, 24 Jun 2021 15:24:59 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org ADCA861351 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id C07396EC42; Thu, 24 Jun 2021 15:24:58 +0000 (UTC) Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by gabe.freedesktop.org (Postfix) with ESMTP id 20E7B6EC25 for ; Thu, 24 Jun 2021 15:24:57 +0000 (UTC) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 4EAF7ED1; Thu, 24 Jun 2021 08:24:57 -0700 (PDT) Received: from [192.168.1.179] (unknown [172.31.20.19]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 42D8E3F719; Thu, 24 Jun 2021 08:24:56 -0700 (PDT) Subject: Re: [PATCH] drm/sched: Declare entity idle only after HW submission To: Boris Brezillon , dri-devel@lists.freedesktop.org References: <20210624140850.2229697-1-boris.brezillon@collabora.com> From: Steven Price Message-ID: Date: Thu, 24 Jun 2021 16:24:47 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: <20210624140850.2229697-1-boris.brezillon@collabora.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-GB Content-Transfer-Encoding: 7bit X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Rob Herring , Robin Murphy , Alyssa Rosenzweig , Tomeu Vizoso Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On 24/06/2021 15:08, Boris Brezillon wrote: > The panfrost driver tries to kill in-flight jobs on FD close after > destroying the FD scheduler entities. For this to work properly, we > need to make sure the jobs popped from the scheduler entities have > been queued at the HW level before declaring the entity idle, otherwise > we might iterate over a list that doesn't contain those jobs. > > Suggested-by: Lucas Stach > Signed-off-by: Boris Brezillon > Cc: Lucas Stach Reviewed-by: Steven Price > --- > drivers/gpu/drm/scheduler/sched_main.c | 7 ++++--- > 1 file changed, 4 insertions(+), 3 deletions(-) > > diff --git a/drivers/gpu/drm/scheduler/sched_main.c b/drivers/gpu/drm/scheduler/sched_main.c > index 81496ae2602e..aa776ebe326a 100644 > --- a/drivers/gpu/drm/scheduler/sched_main.c > +++ b/drivers/gpu/drm/scheduler/sched_main.c > @@ -811,10 +811,10 @@ static int drm_sched_main(void *param) > > sched_job = drm_sched_entity_pop_job(entity); > > - complete(&entity->entity_idle); > - > - if (!sched_job) > + if (!sched_job) { > + complete(&entity->entity_idle); > continue; > + } > > s_fence = sched_job->s_fence; > > @@ -823,6 +823,7 @@ static int drm_sched_main(void *param) > > trace_drm_run_job(sched_job, entity); > fence = sched->ops->run_job(sched_job); > + complete(&entity->entity_idle); > drm_sched_fence_scheduled(s_fence); > > if (!IS_ERR_OR_NULL(fence)) { >