All of lore.kernel.org
 help / color / mirror / Atom feed
From: Stefan Metzmacher <metze@samba.org>
To: Steve French <smfrench@gmail.com>, CIFS <linux-cifs@vger.kernel.org>
Cc: samba-technical <samba-technical@lists.samba.org>
Subject: Re: [PATCH][SMB3.1.1] Add defines for new signing context
Date: Mon, 12 Oct 2020 10:55:18 +0200	[thread overview]
Message-ID: <bd8f21ed-5fd4-0974-f15a-16d2f3ee607f@samba.org> (raw)
In-Reply-To: <CAH2r5mtwBHTk-Xoeuo+RbgNwiNw-cWTAhdy1YG5y+vXnNDSv4w@mail.gmail.com>


[-- Attachment #1.1: Type: text/plain, Size: 1127 bytes --]

Am 11.10.20 um 03:25 schrieb Steve French via samba-technical:
> Add defines for the three supported signing algorithms
> 
> Signed-off-by: Steve French <stfrench@microsoft.com>
> ---
>  fs/cifs/smb2pdu.h | 14 ++++++++++++++
>  1 file changed, 14 insertions(+)
> 
> diff --git a/fs/cifs/smb2pdu.h b/fs/cifs/smb2pdu.h
> index 4dfb51dd7065..5932fc0dc62c 100644
> --- a/fs/cifs/smb2pdu.h
> +++ b/fs/cifs/smb2pdu.h
> @@ -323,6 +323,7 @@ struct smb2_negotiate_req {
>  #define SMB2_NETNAME_NEGOTIATE_CONTEXT_ID cpu_to_le16(5)
>  #define SMB2_TRANSPORT_CAPABILITIES cpu_to_le16(6)
>  #define SMB2_RDMA_TRANSFORM_CAPABILITIES cpu_to_le16(7)
> +#define SMB2_SIGNING_CAPABILITIES cpu_to_le16(8)
>  #define SMB2_POSIX_EXTENSIONS_AVAILABLE cpu_to_le16(0x100)
> 
>  struct smb2_neg_context {
> @@ -416,6 +417,19 @@ struct smb2_rdma_transform_capabilities_context {
>   __le16 RDMATransformIds[1];
>  } __packed;
> 
> +/* Signing algorithms */
> +#define SIGNING_ALG_HMAC_SHA256 0
> +#define SIGNING_ALG_AES_CMAC 1
> +#define SIGNING_ALG_AES_GMAC 2

This isn't in MS-SMB2 yet.

Is this AES_128?

metze



[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

  reply	other threads:[~2020-10-12  9:25 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-10-11  1:25 [PATCH][SMB3.1.1] Add defines for new signing context Steve French
2020-10-12  8:55 ` Stefan Metzmacher [this message]
2020-10-12  9:50   ` Aurélien Aptel
2020-10-15 18:15     ` Tom Talpey
2020-10-16  4:50       ` Steve French
2020-10-16  5:49         ` Steve French
2020-10-16  6:11           ` ronnie sahlberg
2020-10-16 14:27             ` Tom Talpey
2020-11-10  8:42       ` Stefan Metzmacher

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bd8f21ed-5fd4-0974-f15a-16d2f3ee607f@samba.org \
    --to=metze@samba.org \
    --cc=linux-cifs@vger.kernel.org \
    --cc=samba-technical@lists.samba.org \
    --cc=smfrench@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.