From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D7825C433DB for ; Wed, 24 Mar 2021 08:30:34 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id ABD50619F7 for ; Wed, 24 Mar 2021 08:30:34 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233665AbhCXIaD (ORCPT ); Wed, 24 Mar 2021 04:30:03 -0400 Received: from szxga06-in.huawei.com ([45.249.212.32]:14883 "EHLO szxga06-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233644AbhCXI3x (ORCPT ); Wed, 24 Mar 2021 04:29:53 -0400 Received: from DGGEMS402-HUB.china.huawei.com (unknown [172.30.72.60]) by szxga06-in.huawei.com (SkyGuard) with ESMTP id 4F51b04wnPzkdjt; Wed, 24 Mar 2021 16:28:12 +0800 (CST) Received: from [10.67.110.136] (10.67.110.136) by DGGEMS402-HUB.china.huawei.com (10.3.19.202) with Microsoft SMTP Server id 14.3.498.0; Wed, 24 Mar 2021 16:29:45 +0800 Subject: Re: [PATCH v2 -next] powerpc: kernel/time.c - cleanup warnings To: Christophe Leroy , Alexandre Belloni CC: , , , , , , , , , , , , , References: <20210323091257.90054-1-heying24@huawei.com> <95cd80c5-40ff-1316-9c89-2e8e7836fb6a@csgroup.eu> From: "heying (H)" Message-ID: Date: Wed, 24 Mar 2021 16:29:45 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 8bit X-Originating-IP: [10.67.110.136] X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Dear, 在 2021/3/24 14:22, Christophe Leroy 写道: > > > Le 24/03/2021 à 07:14, Christophe Leroy a écrit : >> >> >> Le 24/03/2021 à 00:05, Alexandre Belloni a écrit : >>> On 23/03/2021 23:18:17+0100, Alexandre Belloni wrote: >>>> Hello, >>>> >>>> On 23/03/2021 05:12:57-0400, He Ying wrote: >>>>> We found these warnings in arch/powerpc/kernel/time.c as follows: >>>>> warning: symbol 'decrementer_max' was not declared. Should it be >>>>> static? >>>>> warning: symbol 'rtc_lock' was not declared. Should it be static? >>>>> warning: symbol 'dtl_consumer' was not declared. Should it be static? >>>>> >>>>> Declare 'decrementer_max' and 'rtc_lock' in powerpc asm/time.h. >>>>> Rename 'rtc_lock' in drviers/rtc/rtc-vr41xx.c to 'vr41xx_rtc_lock' to >>>>> avoid the conflict with the variable in powerpc asm/time.h. >>>>> Move 'dtl_consumer' definition behind "include " >>>>> because it >>>>> is declared there. >>>>> >>>>> Reported-by: Hulk Robot >>>>> Signed-off-by: He Ying >>>>> --- >>>>> v2: >>>>> - Instead of including linux/mc146818rtc.h in powerpc >>>>> kernel/time.c, declare >>>>>    rtc_lock in powerpc asm/time.h. >>>>> >>>> >>>> V1 was actually the correct thing to do. rtc_lock is there exactly >>>> because chrp and maple are using mc146818 compatible RTCs. This is >>>> then >>>> useful because then drivers/char/nvram.c is enabled. The proper fix >>>> would be to scrap all of that and use rtc-cmos for those platforms as >>>> this drives the RTC properly and exposes the NVRAM for the mc146818. >>>> >>>> Or at least, if there are no users for the char/nvram driver on those >>>> two platforms, remove the spinlock and stop enabling CONFIG_NVRAM or >>>> more likely rename the symbol as it seems to be abused by both chrp >>>> and >>>> powermac. >>>> >>> >>> Ok so rtc_lock is not even used by the char/nvram.c driver as it is >>> completely compiled out. >>> >>> I guess it is fine having it move to the individual platform as looking >>> very quickly at the Kconfig, it is not possible to select both >>> simultaneously. Tentative patch: >>> >> >> Looking at it once more, it looks like including linux/mc146818rtc.h >> is the thing to do, at least for now. Several platforms are defining >> the rtc_lock exactly the same way as powerpc does, and including >> mc146818rtc.h >> >> I think that to get it clean, this change should go in a dedicated >> patch and do a bit more and explain exactly what is being do and why. >> I'll try to draft something for it. >> >> He Y., can you make a version v3 of your patch excluding the rtc_lock >> change ? >> > > Finally, I think there is not enough changes to justify a separate patch. > > So you can send a V3 based on your V1. In addition to the changes you > had in V1, please remove the declaration of rfc_lock in > arch/powerpc/platforms/chrp/chrp.h So glad to hear that. I'll do that and send my V3. Thanks. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5EAE6C433DB for ; Wed, 24 Mar 2021 08:30:28 +0000 (UTC) Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id BF5B1619D3 for ; Wed, 24 Mar 2021 08:30:27 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org BF5B1619D3 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=huawei.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Received: from boromir.ozlabs.org (localhost [IPv6:::1]) by lists.ozlabs.org (Postfix) with ESMTP id 4F51dZ0PjXz3bpx for ; Wed, 24 Mar 2021 19:30:26 +1100 (AEDT) Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=huawei.com (client-ip=45.249.212.32; helo=szxga06-in.huawei.com; envelope-from=heying24@huawei.com; receiver=) Received: from szxga06-in.huawei.com (szxga06-in.huawei.com [45.249.212.32]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4F51dB4frMz301B for ; Wed, 24 Mar 2021 19:29:59 +1100 (AEDT) Received: from DGGEMS402-HUB.china.huawei.com (unknown [172.30.72.60]) by szxga06-in.huawei.com (SkyGuard) with ESMTP id 4F51b04wnPzkdjt; Wed, 24 Mar 2021 16:28:12 +0800 (CST) Received: from [10.67.110.136] (10.67.110.136) by DGGEMS402-HUB.china.huawei.com (10.3.19.202) with Microsoft SMTP Server id 14.3.498.0; Wed, 24 Mar 2021 16:29:45 +0800 Subject: Re: [PATCH v2 -next] powerpc: kernel/time.c - cleanup warnings To: Christophe Leroy , Alexandre Belloni References: <20210323091257.90054-1-heying24@huawei.com> <95cd80c5-40ff-1316-9c89-2e8e7836fb6a@csgroup.eu> From: "heying (H)" Message-ID: Date: Wed, 24 Mar 2021 16:29:45 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 8bit X-Originating-IP: [10.67.110.136] X-CFilter-Loop: Reflected X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-rtc@vger.kernel.org, a.zummo@towertech.it, geert+renesas@glider.be, peterz@infradead.org, frederic@kernel.org, linux-kernel@vger.kernel.org, npiggin@gmail.com, paulus@samba.org, kernelfans@gmail.com, tglx@linutronix.de, msuchanek@suse.de, linuxppc-dev@lists.ozlabs.org Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" Dear, 在 2021/3/24 14:22, Christophe Leroy 写道: > > > Le 24/03/2021 à 07:14, Christophe Leroy a écrit : >> >> >> Le 24/03/2021 à 00:05, Alexandre Belloni a écrit : >>> On 23/03/2021 23:18:17+0100, Alexandre Belloni wrote: >>>> Hello, >>>> >>>> On 23/03/2021 05:12:57-0400, He Ying wrote: >>>>> We found these warnings in arch/powerpc/kernel/time.c as follows: >>>>> warning: symbol 'decrementer_max' was not declared. Should it be >>>>> static? >>>>> warning: symbol 'rtc_lock' was not declared. Should it be static? >>>>> warning: symbol 'dtl_consumer' was not declared. Should it be static? >>>>> >>>>> Declare 'decrementer_max' and 'rtc_lock' in powerpc asm/time.h. >>>>> Rename 'rtc_lock' in drviers/rtc/rtc-vr41xx.c to 'vr41xx_rtc_lock' to >>>>> avoid the conflict with the variable in powerpc asm/time.h. >>>>> Move 'dtl_consumer' definition behind "include " >>>>> because it >>>>> is declared there. >>>>> >>>>> Reported-by: Hulk Robot >>>>> Signed-off-by: He Ying >>>>> --- >>>>> v2: >>>>> - Instead of including linux/mc146818rtc.h in powerpc >>>>> kernel/time.c, declare >>>>>    rtc_lock in powerpc asm/time.h. >>>>> >>>> >>>> V1 was actually the correct thing to do. rtc_lock is there exactly >>>> because chrp and maple are using mc146818 compatible RTCs. This is >>>> then >>>> useful because then drivers/char/nvram.c is enabled. The proper fix >>>> would be to scrap all of that and use rtc-cmos for those platforms as >>>> this drives the RTC properly and exposes the NVRAM for the mc146818. >>>> >>>> Or at least, if there are no users for the char/nvram driver on those >>>> two platforms, remove the spinlock and stop enabling CONFIG_NVRAM or >>>> more likely rename the symbol as it seems to be abused by both chrp >>>> and >>>> powermac. >>>> >>> >>> Ok so rtc_lock is not even used by the char/nvram.c driver as it is >>> completely compiled out. >>> >>> I guess it is fine having it move to the individual platform as looking >>> very quickly at the Kconfig, it is not possible to select both >>> simultaneously. Tentative patch: >>> >> >> Looking at it once more, it looks like including linux/mc146818rtc.h >> is the thing to do, at least for now. Several platforms are defining >> the rtc_lock exactly the same way as powerpc does, and including >> mc146818rtc.h >> >> I think that to get it clean, this change should go in a dedicated >> patch and do a bit more and explain exactly what is being do and why. >> I'll try to draft something for it. >> >> He Y., can you make a version v3 of your patch excluding the rtc_lock >> change ? >> > > Finally, I think there is not enough changes to justify a separate patch. > > So you can send a V3 based on your V1. In addition to the changes you > had in V1, please remove the declaration of rfc_lock in > arch/powerpc/platforms/chrp/chrp.h So glad to hear that. I'll do that and send my V3. Thanks.