From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:44060) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dRRKT-0003Jl-JF for qemu-devel@nongnu.org; Sat, 01 Jul 2017 18:57:30 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dRRKQ-0000mj-JH for qemu-devel@nongnu.org; Sat, 01 Jul 2017 18:57:29 -0400 Received: from mail-qk0-x244.google.com ([2607:f8b0:400d:c09::244]:36633) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1dRRKQ-0000mN-Cr for qemu-devel@nongnu.org; Sat, 01 Jul 2017 18:57:26 -0400 Received: by mail-qk0-x244.google.com with SMTP id v143so7085459qkb.3 for ; Sat, 01 Jul 2017 15:57:26 -0700 (PDT) Sender: Richard Henderson References: <149865219962.17063.10630533069463266646.stgit@frigg.lan> <149865316837.17063.1608754834009945976.stgit@frigg.lan> <20170630000240.GF13979@flamenco> From: Richard Henderson Message-ID: Date: Sat, 1 Jul 2017 15:57:21 -0700 MIME-Version: 1.0 In-Reply-To: <20170630000240.GF13979@flamenco> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v11 04/29] target: [tcg] Add generic translation framework List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Emilio G. Cota" , =?UTF-8?Q?Llu=c3=ads_Vilanova?= Cc: Paolo Bonzini , Peter Crosthwaite , =?UTF-8?Q?Alex_Benn=c3=a9e?= , qemu-devel@nongnu.org On 06/29/2017 05:02 PM, Emilio G. Cota wrote: >> +void translate_block(const TranslatorOps *ops, DisasContextBase *db, >> + CPUState *cpu, TranslationBlock *tb); > I'd rather avoid "block" here. Some alternatives: > > - tb_translate() > - translate_tb() > - translate() > - translator_gen() > - translator_loop() I like translator_loop. r~