All of lore.kernel.org
 help / color / mirror / Atom feed
From: Sagi Grimberg <sagi@grimberg.me>
To: Christoph Hellwig <hch@infradead.org>
Cc: linux-nvme@lists.infradead.org, Christoph Hellwig <hch@lst.de>,
	Keith Busch <kbusch@kernel.org>,
	Chaitanya Kulkarni <Chaitanya.Kulkarni@wdc.com>,
	Yi Zhang <yi.zhang@redhat.com>
Subject: Re: [PATCH] nvmet: fix workqueue MEM_RECLAIM flushing dependency
Date: Wed, 12 Oct 2022 09:40:11 +0300	[thread overview]
Message-ID: <bd982b71-ec85-ab60-e916-1a58046ce4f0@grimberg.me> (raw)
In-Reply-To: <Y0PXLA3yTnX7n5SA@infradead.org>


>> The keep alive timer needs to stay on nvmet_wq, and not
>> modified to reschedule on the system_wq.
> 
> Does it?  The keep alive timeout is required for making progress
> under heavy memory pressure.

nvmet_wq has WQ_MEM_RECLAIM. Also, note that keep_alive is initially
scheduled in nvmet_wq but mod_delayed_work incorrectly moved it to
the system_wq...


  reply	other threads:[~2022-10-12  6:40 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-09-28  6:39 [PATCH] nvmet: fix workqueue MEM_RECLAIM flushing dependency Sagi Grimberg
2022-09-30  1:31 ` Chaitanya Kulkarni
2022-10-10  8:26 ` Christoph Hellwig
2022-10-12  6:40   ` Sagi Grimberg [this message]
2022-10-17  7:18 ` Christoph Hellwig

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bd982b71-ec85-ab60-e916-1a58046ce4f0@grimberg.me \
    --to=sagi@grimberg.me \
    --cc=Chaitanya.Kulkarni@wdc.com \
    --cc=hch@infradead.org \
    --cc=hch@lst.de \
    --cc=kbusch@kernel.org \
    --cc=linux-nvme@lists.infradead.org \
    --cc=yi.zhang@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.