From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0F875C6FA8E for ; Mon, 26 Sep 2022 06:38:32 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233588AbiIZGia (ORCPT ); Mon, 26 Sep 2022 02:38:30 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54000 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233322AbiIZGi0 (ORCPT ); Mon, 26 Sep 2022 02:38:26 -0400 Received: from mail-lj1-x234.google.com (mail-lj1-x234.google.com [IPv6:2a00:1450:4864:20::234]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 58907DF5C for ; Sun, 25 Sep 2022 23:38:25 -0700 (PDT) Received: by mail-lj1-x234.google.com with SMTP id a10so6363296ljq.0 for ; Sun, 25 Sep 2022 23:38:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date; bh=W3hxzdrBIum1j0xz9YZTHAUg/0XjqqL/D7mMmLIxdR4=; b=ePexRndPURvdCW/6uFFqR/iEiqGsxFN63U0+E7Mw/SDz4ZwwNEHsmVHumFqZeMYCUP w8s7D75BCLIzBKqYzi2ogsSYLQfENPA4YBlkAy7xmGIaZVpzOBLJOJBVmSgV8B9AxENp 4k9tn5vOQllbiqS/XTVubaMGN3+gj9u09UhLCVk0TYFk8T5lw7S/gkcV2EfEw/3L/JMQ D1Pt/0hEH58mgxQwVwA1fUt8341UKEQFrik2uQZ70jnH8wajATyMJdZbd8uzdTiFw7/8 s4sXMk+6hYNL9CHWmFGnedd4ZzjP6bKJB+in83kJvdPYJbbwwdg5MwyBBVmi4j+WhIEb IqSQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date; bh=W3hxzdrBIum1j0xz9YZTHAUg/0XjqqL/D7mMmLIxdR4=; b=hlaAloPOMsBUrPXdz22s4SiOq1HO0dsLWLLWeWwTz0oVhkntZ2EdJHMExsqSfy5kls OYd1VcOrE1soV08unWVYbM6OM0A25t0GNLwyLLMEkl3b74LTh+/HyPg5z79po06lKkVJ g3Jo++9/fgTpIXE8+6hj7thi57cUo078g1PYtA10WWRpik50SJQz6JBvC6Z/1z93IU9n hg8nLxb6FYhQlXtxscGfjsrAhABEMcuifB/kLfHZYGD/35AAnLmeQOhAx981m8vPGGco pLgR5WB9RMsM4efeh4VVfuVryXM778vZaX3yBBhUmOMo5DaisLxoY6v6Z9FLKHisgZND VMyg== X-Gm-Message-State: ACrzQf3XiYfZx+HVdVGIyt6+ad7lsbr7WTs63aV1u9LCfJIFm7d7avbH Jx1aJGYSv1Sq//vHOYh8hya1bQ== X-Google-Smtp-Source: AMsMyM7zYhJnhCTUeUDjnpPqlK+tH954E2LgxBK1i8gOU2GZVXuiyg0sE4TRiLJTrdd7ByA6IdiJnQ== X-Received: by 2002:a05:651c:a04:b0:26c:50df:75ad with SMTP id k4-20020a05651c0a0400b0026c50df75admr6942132ljq.416.1664174303703; Sun, 25 Sep 2022 23:38:23 -0700 (PDT) Received: from [192.168.0.21] (78-11-189-27.static.ip.netia.com.pl. [78.11.189.27]) by smtp.gmail.com with ESMTPSA id b5-20020ac25625000000b004a050ddc4ecsm1321680lff.125.2022.09.25.23.38.22 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 25 Sep 2022 23:38:23 -0700 (PDT) Message-ID: Date: Mon, 26 Sep 2022 08:38:21 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.3.0 Subject: Re: [PATCH v1 15/17] dt-bindings: display: mediatek: dpi: Add compatible for MediaTek MT8195 Content-Language: en-US To: Chen-Yu Tsai Cc: Guillaume Ranquet , Vinod Koul , Stephen Boyd , David Airlie , Rob Herring , Philipp Zabel , Krzysztof Kozlowski , Daniel Vetter , Chunfeng Yun , CK Hu , Jitao shi , Chun-Kuang Hu , Michael Turquette , Kishon Vijay Abraham I , Matthias Brugger , devicetree@vger.kernel.org, Mattijs Korpershoek , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-clk@vger.kernel.org, linux-mediatek@lists.infradead.org, linux-phy@lists.infradead.org, Pablo Sun , linux-arm-kernel@lists.infradead.org References: <20220919-v1-0-4844816c9808@baylibre.com> <20220919-v1-15-4844816c9808@baylibre.com> From: Krzysztof Kozlowski In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 26/09/2022 07:24, Chen-Yu Tsai wrote: > On Thu, Sep 22, 2022 at 3:20 PM Krzysztof Kozlowski > wrote: >> >> On 19/09/2022 18:56, Guillaume Ranquet wrote: >>> Add dt-binding documentation of dpi for MediaTek MT8195 SoC. >>> >>> Signed-off-by: Guillaume Ranquet >>> >>> diff --git a/Documentation/devicetree/bindings/display/mediatek/mediatek,dpi.yaml b/Documentation/devicetree/bindings/display/mediatek/mediatek,dpi.yaml >>> index 5bb23e97cf33..2c7ecef54986 100644 >>> --- a/Documentation/devicetree/bindings/display/mediatek/mediatek,dpi.yaml >>> +++ b/Documentation/devicetree/bindings/display/mediatek/mediatek,dpi.yaml >>> @@ -24,6 +24,7 @@ properties: >>> - mediatek,mt8183-dpi >>> - mediatek,mt8186-dpi >>> - mediatek,mt8192-dpi >>> + - mediatek,mt8195-dpi >>> - mediatek,mt8195-dp-intf >> >> Aren't these the same? > > *-dpi are MIPI DPI (as in parallel data with DDR modes) encoders. > *-dp-intf are Display Port encoder. > > Totally distinguishable. :) > > The hardware blocks seem similar upon cursory comparison of the register > tables, with the base layout being the same, and sharing registers for > basic settings such as the display timings. > > The DPI ones have some extra registers, presumably to control the signals > or output width. The DP one has some registers of its own that only make > sense for Display Port. OK. Acked-by: Krzysztof Kozlowski Best regards, Krzysztof From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 1722BC07E9D for ; Mon, 26 Sep 2022 06:38:31 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id C903D10E532; Mon, 26 Sep 2022 06:38:29 +0000 (UTC) Received: from mail-lj1-x232.google.com (mail-lj1-x232.google.com [IPv6:2a00:1450:4864:20::232]) by gabe.freedesktop.org (Postfix) with ESMTPS id 686B810E531 for ; Mon, 26 Sep 2022 06:38:25 +0000 (UTC) Received: by mail-lj1-x232.google.com with SMTP id l12so6269102ljg.9 for ; Sun, 25 Sep 2022 23:38:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date; bh=W3hxzdrBIum1j0xz9YZTHAUg/0XjqqL/D7mMmLIxdR4=; b=ePexRndPURvdCW/6uFFqR/iEiqGsxFN63U0+E7Mw/SDz4ZwwNEHsmVHumFqZeMYCUP w8s7D75BCLIzBKqYzi2ogsSYLQfENPA4YBlkAy7xmGIaZVpzOBLJOJBVmSgV8B9AxENp 4k9tn5vOQllbiqS/XTVubaMGN3+gj9u09UhLCVk0TYFk8T5lw7S/gkcV2EfEw/3L/JMQ D1Pt/0hEH58mgxQwVwA1fUt8341UKEQFrik2uQZ70jnH8wajATyMJdZbd8uzdTiFw7/8 s4sXMk+6hYNL9CHWmFGnedd4ZzjP6bKJB+in83kJvdPYJbbwwdg5MwyBBVmi4j+WhIEb IqSQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date; bh=W3hxzdrBIum1j0xz9YZTHAUg/0XjqqL/D7mMmLIxdR4=; b=4X94lN4djQvCGzO1k9SXMwVZzXyFZtRX/hrIWU3ZPFqSjHAke3Mtz/MpwDvRYg3bwX 3p5+8TUqn0eMWkztuKd9PrnfpCTZMe/fiKQS+HOFJghIKPK4iV+V75sm6MGsbrSD3Jbj tVMRdTp4k9ss7WZlmatQvyT5t+WP+oaoyaWmB8z6eLV8cAVvqodKmfwbPvGOGkDZbeXx gFJML6KLrJjC3UbyLx1gtHfOo9LaQENd/qhs8qDR1gMhrEygU0WuhX2uhr9N4f8S/Crb YBDzvUGeX3U8GVj4MNZ1NsvUJgB42be9rZtgJESqKUZ5y4YUks9USMXxnl9KEYDAEg0p pmVQ== X-Gm-Message-State: ACrzQf2OJJY5PFnIhv37zT1izYOcbrlpdrwh2KBBPr5lSz8YSkEXYqAr bzL0NpnvC5x2sdLBMCBEvCUo3g== X-Google-Smtp-Source: AMsMyM7zYhJnhCTUeUDjnpPqlK+tH954E2LgxBK1i8gOU2GZVXuiyg0sE4TRiLJTrdd7ByA6IdiJnQ== X-Received: by 2002:a05:651c:a04:b0:26c:50df:75ad with SMTP id k4-20020a05651c0a0400b0026c50df75admr6942132ljq.416.1664174303703; Sun, 25 Sep 2022 23:38:23 -0700 (PDT) Received: from [192.168.0.21] (78-11-189-27.static.ip.netia.com.pl. [78.11.189.27]) by smtp.gmail.com with ESMTPSA id b5-20020ac25625000000b004a050ddc4ecsm1321680lff.125.2022.09.25.23.38.22 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 25 Sep 2022 23:38:23 -0700 (PDT) Message-ID: Date: Mon, 26 Sep 2022 08:38:21 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.3.0 Subject: Re: [PATCH v1 15/17] dt-bindings: display: mediatek: dpi: Add compatible for MediaTek MT8195 Content-Language: en-US To: Chen-Yu Tsai References: <20220919-v1-0-4844816c9808@baylibre.com> <20220919-v1-15-4844816c9808@baylibre.com> From: Krzysztof Kozlowski In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, David Airlie , Michael Turquette , dri-devel@lists.freedesktop.org, Krzysztof Kozlowski , linux-phy@lists.infradead.org, linux-clk@vger.kernel.org, Kishon Vijay Abraham I , Chun-Kuang Hu , Jitao shi , Chunfeng Yun , Rob Herring , linux-mediatek@lists.infradead.org, Matthias Brugger , linux-arm-kernel@lists.infradead.org, Guillaume Ranquet , Stephen Boyd , Mattijs Korpershoek , linux-kernel@vger.kernel.org, Vinod Koul , Pablo Sun Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On 26/09/2022 07:24, Chen-Yu Tsai wrote: > On Thu, Sep 22, 2022 at 3:20 PM Krzysztof Kozlowski > wrote: >> >> On 19/09/2022 18:56, Guillaume Ranquet wrote: >>> Add dt-binding documentation of dpi for MediaTek MT8195 SoC. >>> >>> Signed-off-by: Guillaume Ranquet >>> >>> diff --git a/Documentation/devicetree/bindings/display/mediatek/mediatek,dpi.yaml b/Documentation/devicetree/bindings/display/mediatek/mediatek,dpi.yaml >>> index 5bb23e97cf33..2c7ecef54986 100644 >>> --- a/Documentation/devicetree/bindings/display/mediatek/mediatek,dpi.yaml >>> +++ b/Documentation/devicetree/bindings/display/mediatek/mediatek,dpi.yaml >>> @@ -24,6 +24,7 @@ properties: >>> - mediatek,mt8183-dpi >>> - mediatek,mt8186-dpi >>> - mediatek,mt8192-dpi >>> + - mediatek,mt8195-dpi >>> - mediatek,mt8195-dp-intf >> >> Aren't these the same? > > *-dpi are MIPI DPI (as in parallel data with DDR modes) encoders. > *-dp-intf are Display Port encoder. > > Totally distinguishable. :) > > The hardware blocks seem similar upon cursory comparison of the register > tables, with the base layout being the same, and sharing registers for > basic settings such as the display timings. > > The DPI ones have some extra registers, presumably to control the signals > or output width. The DP one has some registers of its own that only make > sense for Display Port. OK. Acked-by: Krzysztof Kozlowski Best regards, Krzysztof From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 8BF4DC32771 for ; Mon, 26 Sep 2022 06:40:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To: Subject:MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=gaDuf5Piv7pGQ7KS01gVD8+dVMHGou4nmJRTyJEYHYI=; b=nPjbQuDCP5Bn7D uwnnwFyqzhPhWXhqfML7CxuCQvlYzgyLmPFHY7owkRfsa3RhOLOh7Y0aK9Eoe0uS7iHKLe+uzYXHA bSWkvy1oTjnrB5MFJ9DPpFTAUDiWLkd4npYPOJ4y+ESaW+VvhjVE30rs23gX/3I/C50Z7LzQRqq0T 46+4jP2RuFk5x7l//bs09ILqB5J6VghwwMaQ2J12eXY+lctba7E9XeutL1Ph5aX7hK0sr0z/ECIlT ViV8fn1CEDUmBNPiuaYnp/LaSCVSz4yDHXJgoPWT20eh0YLegyApg6ksZ+ytSeWwMDA67nt2GnmZ5 k797UWEiy+W5sMPLrCwg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1ochmj-002PNf-Kw; Mon, 26 Sep 2022 06:40:09 +0000 Received: from mail-lj1-x233.google.com ([2a00:1450:4864:20::233]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1ochl6-002OFi-Ir for linux-phy@lists.infradead.org; Mon, 26 Sep 2022 06:38:31 +0000 Received: by mail-lj1-x233.google.com with SMTP id t16so2274203ljh.3 for ; Sun, 25 Sep 2022 23:38:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date; bh=W3hxzdrBIum1j0xz9YZTHAUg/0XjqqL/D7mMmLIxdR4=; b=ePexRndPURvdCW/6uFFqR/iEiqGsxFN63U0+E7Mw/SDz4ZwwNEHsmVHumFqZeMYCUP w8s7D75BCLIzBKqYzi2ogsSYLQfENPA4YBlkAy7xmGIaZVpzOBLJOJBVmSgV8B9AxENp 4k9tn5vOQllbiqS/XTVubaMGN3+gj9u09UhLCVk0TYFk8T5lw7S/gkcV2EfEw/3L/JMQ D1Pt/0hEH58mgxQwVwA1fUt8341UKEQFrik2uQZ70jnH8wajATyMJdZbd8uzdTiFw7/8 s4sXMk+6hYNL9CHWmFGnedd4ZzjP6bKJB+in83kJvdPYJbbwwdg5MwyBBVmi4j+WhIEb IqSQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date; bh=W3hxzdrBIum1j0xz9YZTHAUg/0XjqqL/D7mMmLIxdR4=; b=x3FqzksG56NOiVA1oJSf+05sRMgLK2eG+D8x3gqiP+uTXqrvjqXSoVBZCNlqY5AwVT Ec4TLtuQjwgA6fuPuwm7zJEyfXzBw/PxO9CIv+V8Aj6T6DwmD5bGaM2p2cbzh2ax/eCg Q27GWT+HqZJtsL580cE1cuAcUKoLS9QnM1Itq81obWZKZnbjBgSCaeiaQkwD3kVvQeVZ Weo4MLLaXamEVmerlAIeY8o74z2ForlmplleZh9600iTdofiob0kx8aG57uuevaMdM8z Iat3CLbzWXyg/6ncJsBGssrTDuXj9MxGfhr3/+VAdROWmOLfBJxUSI9tDdV3OfEAAxfv zU5g== X-Gm-Message-State: ACrzQf1UiRfU2A3WMVLigpC2Afwa9WmcbKM5KEkTUoa3F2SWMRk0tFJZ PEmrD+1gP7iw1HgVQnF+hJHUIw== X-Google-Smtp-Source: AMsMyM7zYhJnhCTUeUDjnpPqlK+tH954E2LgxBK1i8gOU2GZVXuiyg0sE4TRiLJTrdd7ByA6IdiJnQ== X-Received: by 2002:a05:651c:a04:b0:26c:50df:75ad with SMTP id k4-20020a05651c0a0400b0026c50df75admr6942132ljq.416.1664174303703; Sun, 25 Sep 2022 23:38:23 -0700 (PDT) Received: from [192.168.0.21] (78-11-189-27.static.ip.netia.com.pl. [78.11.189.27]) by smtp.gmail.com with ESMTPSA id b5-20020ac25625000000b004a050ddc4ecsm1321680lff.125.2022.09.25.23.38.22 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 25 Sep 2022 23:38:23 -0700 (PDT) Message-ID: Date: Mon, 26 Sep 2022 08:38:21 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.3.0 Subject: Re: [PATCH v1 15/17] dt-bindings: display: mediatek: dpi: Add compatible for MediaTek MT8195 Content-Language: en-US To: Chen-Yu Tsai Cc: Guillaume Ranquet , Vinod Koul , Stephen Boyd , David Airlie , Rob Herring , Philipp Zabel , Krzysztof Kozlowski , Daniel Vetter , Chunfeng Yun , CK Hu , Jitao shi , Chun-Kuang Hu , Michael Turquette , Kishon Vijay Abraham I , Matthias Brugger , devicetree@vger.kernel.org, Mattijs Korpershoek , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-clk@vger.kernel.org, linux-mediatek@lists.infradead.org, linux-phy@lists.infradead.org, Pablo Sun , linux-arm-kernel@lists.infradead.org References: <20220919-v1-0-4844816c9808@baylibre.com> <20220919-v1-15-4844816c9808@baylibre.com> From: Krzysztof Kozlowski In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220925_233828_658769_B40C757C X-CRM114-Status: GOOD ( 13.51 ) X-BeenThere: linux-phy@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux Phy Mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-phy" Errors-To: linux-phy-bounces+linux-phy=archiver.kernel.org@lists.infradead.org On 26/09/2022 07:24, Chen-Yu Tsai wrote: > On Thu, Sep 22, 2022 at 3:20 PM Krzysztof Kozlowski > wrote: >> >> On 19/09/2022 18:56, Guillaume Ranquet wrote: >>> Add dt-binding documentation of dpi for MediaTek MT8195 SoC. >>> >>> Signed-off-by: Guillaume Ranquet >>> >>> diff --git a/Documentation/devicetree/bindings/display/mediatek/mediatek,dpi.yaml b/Documentation/devicetree/bindings/display/mediatek/mediatek,dpi.yaml >>> index 5bb23e97cf33..2c7ecef54986 100644 >>> --- a/Documentation/devicetree/bindings/display/mediatek/mediatek,dpi.yaml >>> +++ b/Documentation/devicetree/bindings/display/mediatek/mediatek,dpi.yaml >>> @@ -24,6 +24,7 @@ properties: >>> - mediatek,mt8183-dpi >>> - mediatek,mt8186-dpi >>> - mediatek,mt8192-dpi >>> + - mediatek,mt8195-dpi >>> - mediatek,mt8195-dp-intf >> >> Aren't these the same? > > *-dpi are MIPI DPI (as in parallel data with DDR modes) encoders. > *-dp-intf are Display Port encoder. > > Totally distinguishable. :) > > The hardware blocks seem similar upon cursory comparison of the register > tables, with the base layout being the same, and sharing registers for > basic settings such as the display timings. > > The DPI ones have some extra registers, presumably to control the signals > or output width. The DP one has some registers of its own that only make > sense for Display Port. OK. Acked-by: Krzysztof Kozlowski Best regards, Krzysztof -- linux-phy mailing list linux-phy@lists.infradead.org https://lists.infradead.org/mailman/listinfo/linux-phy From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 3E623C32771 for ; Mon, 26 Sep 2022 06:40:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To: Subject:MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=eV+Fd04DQ3OIup/2Vlu2IWRVYb1hCV0nXsryGhFMBe0=; b=hpt8KbCp7Svql7 MVEJXEknvEQFwtCX7bJ7GNzI4r8dhi4U3k1FYB3gyfkNrXoSFCkPtvoHD/iKsrTws2ainOkPuCFZ3 7tK3E/W9Haw9fQxnLTwImlvqDUE9fJnhCH4t2QpMhfBpLTeNKAe3QxK88DENTTNd2ql491vy8jkbO l0M5rso8WBLTsP5ybfJ3MHjESGBdX5932d6yGkG10EpdlBu2r3un34qeAZHv1zwybe0epknstLMnX zlXrNGJweGJQf4iKaYNf40Yk5SDLmJcSC1ijBdgkRgVcezxWoFW02HquacmWJBuiGn1mlufZWnaN8 2YR94j0p+PMATVc6xKPQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1ochmC-002OzQ-3u; Mon, 26 Sep 2022 06:39:37 +0000 Received: from mail-lj1-x232.google.com ([2a00:1450:4864:20::232]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1ochl6-002OFg-Bd for linux-arm-kernel@lists.infradead.org; Mon, 26 Sep 2022 06:38:29 +0000 Received: by mail-lj1-x232.google.com with SMTP id s10so6299921ljp.5 for ; Sun, 25 Sep 2022 23:38:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date; bh=W3hxzdrBIum1j0xz9YZTHAUg/0XjqqL/D7mMmLIxdR4=; b=ePexRndPURvdCW/6uFFqR/iEiqGsxFN63U0+E7Mw/SDz4ZwwNEHsmVHumFqZeMYCUP w8s7D75BCLIzBKqYzi2ogsSYLQfENPA4YBlkAy7xmGIaZVpzOBLJOJBVmSgV8B9AxENp 4k9tn5vOQllbiqS/XTVubaMGN3+gj9u09UhLCVk0TYFk8T5lw7S/gkcV2EfEw/3L/JMQ D1Pt/0hEH58mgxQwVwA1fUt8341UKEQFrik2uQZ70jnH8wajATyMJdZbd8uzdTiFw7/8 s4sXMk+6hYNL9CHWmFGnedd4ZzjP6bKJB+in83kJvdPYJbbwwdg5MwyBBVmi4j+WhIEb IqSQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date; bh=W3hxzdrBIum1j0xz9YZTHAUg/0XjqqL/D7mMmLIxdR4=; b=E3KTGlKQU0rZlYvyqcit3WKQlq2/b4pkgsyCHCQdKkeeXdH/XfIjn6G/cM1o1aZ7P7 QkXVlwS7nFqqxDyDCk5hgtxZdk6EoK6/AwKag5UQlb/p/g4vgCnrm7+g+TkOwwgE1olV PZz2OkrfWGQhTYlimo/tDxsD0jNvxx3pNp8QkHHtXdL/kfgbLjPCS0NeQl1JVwzsLrRj 3bvP4C24ZQDsbi7liqCOhGYClKgta1EEjC3QyxxzNiiFXBfT7izyoOtZV4HrTCP58fT5 1wyBnmGbL08saCnRKHN810ZW1Mxrg2Okorki3rAHFz0MDDPGOhw7rUSbDl9LX7e+NLm7 ifIg== X-Gm-Message-State: ACrzQf1Tus67+wDERX4SkjEaFb6zB9g2t0miy+POQ4i1paNxTU9FqZqH yFgisddU/GX1w1mM+Q4XovoO0A== X-Google-Smtp-Source: AMsMyM7zYhJnhCTUeUDjnpPqlK+tH954E2LgxBK1i8gOU2GZVXuiyg0sE4TRiLJTrdd7ByA6IdiJnQ== X-Received: by 2002:a05:651c:a04:b0:26c:50df:75ad with SMTP id k4-20020a05651c0a0400b0026c50df75admr6942132ljq.416.1664174303703; Sun, 25 Sep 2022 23:38:23 -0700 (PDT) Received: from [192.168.0.21] (78-11-189-27.static.ip.netia.com.pl. [78.11.189.27]) by smtp.gmail.com with ESMTPSA id b5-20020ac25625000000b004a050ddc4ecsm1321680lff.125.2022.09.25.23.38.22 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 25 Sep 2022 23:38:23 -0700 (PDT) Message-ID: Date: Mon, 26 Sep 2022 08:38:21 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.3.0 Subject: Re: [PATCH v1 15/17] dt-bindings: display: mediatek: dpi: Add compatible for MediaTek MT8195 Content-Language: en-US To: Chen-Yu Tsai Cc: Guillaume Ranquet , Vinod Koul , Stephen Boyd , David Airlie , Rob Herring , Philipp Zabel , Krzysztof Kozlowski , Daniel Vetter , Chunfeng Yun , CK Hu , Jitao shi , Chun-Kuang Hu , Michael Turquette , Kishon Vijay Abraham I , Matthias Brugger , devicetree@vger.kernel.org, Mattijs Korpershoek , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-clk@vger.kernel.org, linux-mediatek@lists.infradead.org, linux-phy@lists.infradead.org, Pablo Sun , linux-arm-kernel@lists.infradead.org References: <20220919-v1-0-4844816c9808@baylibre.com> <20220919-v1-15-4844816c9808@baylibre.com> From: Krzysztof Kozlowski In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220925_233828_500299_208ED68F X-CRM114-Status: GOOD ( 14.92 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 26/09/2022 07:24, Chen-Yu Tsai wrote: > On Thu, Sep 22, 2022 at 3:20 PM Krzysztof Kozlowski > wrote: >> >> On 19/09/2022 18:56, Guillaume Ranquet wrote: >>> Add dt-binding documentation of dpi for MediaTek MT8195 SoC. >>> >>> Signed-off-by: Guillaume Ranquet >>> >>> diff --git a/Documentation/devicetree/bindings/display/mediatek/mediatek,dpi.yaml b/Documentation/devicetree/bindings/display/mediatek/mediatek,dpi.yaml >>> index 5bb23e97cf33..2c7ecef54986 100644 >>> --- a/Documentation/devicetree/bindings/display/mediatek/mediatek,dpi.yaml >>> +++ b/Documentation/devicetree/bindings/display/mediatek/mediatek,dpi.yaml >>> @@ -24,6 +24,7 @@ properties: >>> - mediatek,mt8183-dpi >>> - mediatek,mt8186-dpi >>> - mediatek,mt8192-dpi >>> + - mediatek,mt8195-dpi >>> - mediatek,mt8195-dp-intf >> >> Aren't these the same? > > *-dpi are MIPI DPI (as in parallel data with DDR modes) encoders. > *-dp-intf are Display Port encoder. > > Totally distinguishable. :) > > The hardware blocks seem similar upon cursory comparison of the register > tables, with the base layout being the same, and sharing registers for > basic settings such as the display timings. > > The DPI ones have some extra registers, presumably to control the signals > or output width. The DP one has some registers of its own that only make > sense for Display Port. OK. Acked-by: Krzysztof Kozlowski Best regards, Krzysztof _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel