From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id B68D5C433EF for ; Tue, 7 Dec 2021 04:35:56 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236144AbhLGEjZ (ORCPT ); Mon, 6 Dec 2021 23:39:25 -0500 Received: from marcansoft.com ([212.63.210.85]:48140 "EHLO mail.marcansoft.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236121AbhLGEjT (ORCPT ); Mon, 6 Dec 2021 23:39:19 -0500 Received: from [127.0.0.1] (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (No client certificate requested) (Authenticated sender: marcan@marcan.st) by mail.marcansoft.com (Postfix) with ESMTPSA id 2442942181; Tue, 7 Dec 2021 04:35:44 +0000 (UTC) Subject: Re: [PATCH v2 1/2] dt-bindings: watchdog: Add Apple Watchdog To: Guenter Roeck , Sven Peter Cc: Rob Herring , devicetree@vger.kernel.org, Wim Van Sebroeck , Alyssa Rosenzweig , linux-kernel@vger.kernel.org, linux-watchdog@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Janne Grunau , Mark Kettenis , Rob Herring References: <20211130161809.64591-1-sven@svenpeter.dev> <20211202144301.GA829000@roeck-us.net> From: Hector Martin Message-ID: Date: Tue, 7 Dec 2021 13:35:43 +0900 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.13.0 MIME-Version: 1.0 In-Reply-To: <20211202144301.GA829000@roeck-us.net> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: es-ES Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 02/12/2021 23.43, Guenter Roeck wrote: > On Tue, Nov 30, 2021 at 05:18:08PM +0100, Sven Peter wrote: >> Apple SoCs come with a simple embedded watchdog. This watchdog is also >> required in order to reset the SoC. >> >> Reviewed-by: Mark Kettenis >> Reviewed-by: Rob Herring >> Signed-off-by: Sven Peter > > Reviewed-by: Guenter Roeck > >> --- >> v1 --> v2: >> - add Mark's and Rob's r-b tags >> >> .../bindings/watchdog/apple,wdt.yaml | 52 +++++++++++++++++++ >> MAINTAINERS | 1 + >> 2 files changed, 53 insertions(+) >> create mode 100644 Documentation/devicetree/bindings/watchdog/apple,wdt.yaml >> >> diff --git a/Documentation/devicetree/bindings/watchdog/apple,wdt.yaml b/Documentation/devicetree/bindings/watchdog/apple,wdt.yaml >> new file mode 100644 >> index 000000000000..e58c56a6fdf6 >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/watchdog/apple,wdt.yaml >> @@ -0,0 +1,52 @@ >> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) >> +%YAML 1.2 >> +--- >> +$id: http://devicetree.org/schemas/watchdog/apple,wdt.yaml# >> +$schema: http://devicetree.org/meta-schemas/core.yaml# >> + >> +title: Apple SoC Watchdog >> + >> +allOf: >> + - $ref: "watchdog.yaml#" >> + >> +maintainers: >> + - Sven Peter >> + >> +properties: >> + compatible: >> + items: >> + - enum: >> + - apple,t8103-wdt >> + - apple,t6000-wdt >> + - const: apple,wdt >> + >> + reg: >> + maxItems: 1 >> + >> + clocks: >> + maxItems: 1 >> + >> + interrupts: >> + maxItems: 1 >> + >> +required: >> + - compatible >> + - reg >> + - clocks >> + - interrupts >> + >> +unevaluatedProperties: false >> + >> +examples: >> + - | >> + #include >> + #include >> + >> + wdt: watchdog@50000000 { >> + compatible = "apple,t8103-wdt", "apple,wdt"; >> + reg = <0x50000000 0x4000>; >> + clocks = <&clk>; >> + interrupts = ; >> + }; >> + >> +... >> diff --git a/MAINTAINERS b/MAINTAINERS >> index 360e9aa0205d..859201bbd4e8 100644 >> --- a/MAINTAINERS >> +++ b/MAINTAINERS >> @@ -1750,6 +1750,7 @@ F: Documentation/devicetree/bindings/interrupt-controller/apple,aic.yaml >> F: Documentation/devicetree/bindings/mailbox/apple,mailbox.yaml >> F: Documentation/devicetree/bindings/pci/apple,pcie.yaml >> F: Documentation/devicetree/bindings/pinctrl/apple,pinctrl.yaml >> +F: Documentation/devicetree/bindings/watchdog/apple,wdt.yaml >> F: arch/arm64/boot/dts/apple/ >> F: drivers/i2c/busses/i2c-pasemi-core.c >> F: drivers/i2c/busses/i2c-pasemi-platform.c >> -- >> 2.25.1 >> > I've gone ahead and applied this patch to the asahi-soc/dt tree, so we can build off of that to add the DT nodes. Sven, can you spin a v3 with the MAINTAINERS split and just the driver itself, without this patch? I imagine Guenter will want to take the driver itself through the linux-watchdog tree. -- Hector Martin (marcan@marcan.st) Public Key: https://mrcn.st/pub From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 0848AC433EF for ; Tue, 7 Dec 2021 04:37:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:From: References:Cc:To:Subject:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=fAArlMdThUki5TY8FUPo+8yWsSpeHTKP6FZ3yl0/lic=; b=eIZB6T3U2bGl8UecjQ1iTcqYAj mMxszDPv2AlyISaAVKfDFHe/61fWwkFI+bSAO++HrL8hdmwSMDL/vhveDTOeG9VxILB4Ur0H7gqya Wwx27U6nVhZu+rAv2+REvDEsRWwJUP0mTJamJ4ib1ThecOAywn3oR06J7iKrGVbMupMkf5ImBze/r 7yElHVUK4WyO+1EbZojFPbCOez8y6R9M6x9DCISz8wGaBznvdSe31YDBDUCrUESvfpC2ZagH9TnPI FbYbvHrJkbCL/AUGDFHQY6A1ckrB0QlGOihoB0Yp546rU2LaMju64PCpVKfTx0Eeehyl43HT6Vg0p QbpTb+uA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1muSCq-006w8G-DM; Tue, 07 Dec 2021 04:35:56 +0000 Received: from marcansoft.com ([212.63.210.85] helo=mail.marcansoft.com) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1muSCm-006w7Y-LK for linux-arm-kernel@lists.infradead.org; Tue, 07 Dec 2021 04:35:54 +0000 Received: from [127.0.0.1] (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (No client certificate requested) (Authenticated sender: marcan@marcan.st) by mail.marcansoft.com (Postfix) with ESMTPSA id 2442942181; Tue, 7 Dec 2021 04:35:44 +0000 (UTC) Subject: Re: [PATCH v2 1/2] dt-bindings: watchdog: Add Apple Watchdog To: Guenter Roeck , Sven Peter Cc: Rob Herring , devicetree@vger.kernel.org, Wim Van Sebroeck , Alyssa Rosenzweig , linux-kernel@vger.kernel.org, linux-watchdog@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Janne Grunau , Mark Kettenis , Rob Herring References: <20211130161809.64591-1-sven@svenpeter.dev> <20211202144301.GA829000@roeck-us.net> From: Hector Martin Message-ID: Date: Tue, 7 Dec 2021 13:35:43 +0900 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.13.0 MIME-Version: 1.0 In-Reply-To: <20211202144301.GA829000@roeck-us.net> Content-Language: es-ES X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211206_203552_889872_23DD9FB5 X-CRM114-Status: GOOD ( 19.92 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 02/12/2021 23.43, Guenter Roeck wrote: > On Tue, Nov 30, 2021 at 05:18:08PM +0100, Sven Peter wrote: >> Apple SoCs come with a simple embedded watchdog. This watchdog is also >> required in order to reset the SoC. >> >> Reviewed-by: Mark Kettenis >> Reviewed-by: Rob Herring >> Signed-off-by: Sven Peter > > Reviewed-by: Guenter Roeck > >> --- >> v1 --> v2: >> - add Mark's and Rob's r-b tags >> >> .../bindings/watchdog/apple,wdt.yaml | 52 +++++++++++++++++++ >> MAINTAINERS | 1 + >> 2 files changed, 53 insertions(+) >> create mode 100644 Documentation/devicetree/bindings/watchdog/apple,wdt.yaml >> >> diff --git a/Documentation/devicetree/bindings/watchdog/apple,wdt.yaml b/Documentation/devicetree/bindings/watchdog/apple,wdt.yaml >> new file mode 100644 >> index 000000000000..e58c56a6fdf6 >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/watchdog/apple,wdt.yaml >> @@ -0,0 +1,52 @@ >> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) >> +%YAML 1.2 >> +--- >> +$id: http://devicetree.org/schemas/watchdog/apple,wdt.yaml# >> +$schema: http://devicetree.org/meta-schemas/core.yaml# >> + >> +title: Apple SoC Watchdog >> + >> +allOf: >> + - $ref: "watchdog.yaml#" >> + >> +maintainers: >> + - Sven Peter >> + >> +properties: >> + compatible: >> + items: >> + - enum: >> + - apple,t8103-wdt >> + - apple,t6000-wdt >> + - const: apple,wdt >> + >> + reg: >> + maxItems: 1 >> + >> + clocks: >> + maxItems: 1 >> + >> + interrupts: >> + maxItems: 1 >> + >> +required: >> + - compatible >> + - reg >> + - clocks >> + - interrupts >> + >> +unevaluatedProperties: false >> + >> +examples: >> + - | >> + #include >> + #include >> + >> + wdt: watchdog@50000000 { >> + compatible = "apple,t8103-wdt", "apple,wdt"; >> + reg = <0x50000000 0x4000>; >> + clocks = <&clk>; >> + interrupts = ; >> + }; >> + >> +... >> diff --git a/MAINTAINERS b/MAINTAINERS >> index 360e9aa0205d..859201bbd4e8 100644 >> --- a/MAINTAINERS >> +++ b/MAINTAINERS >> @@ -1750,6 +1750,7 @@ F: Documentation/devicetree/bindings/interrupt-controller/apple,aic.yaml >> F: Documentation/devicetree/bindings/mailbox/apple,mailbox.yaml >> F: Documentation/devicetree/bindings/pci/apple,pcie.yaml >> F: Documentation/devicetree/bindings/pinctrl/apple,pinctrl.yaml >> +F: Documentation/devicetree/bindings/watchdog/apple,wdt.yaml >> F: arch/arm64/boot/dts/apple/ >> F: drivers/i2c/busses/i2c-pasemi-core.c >> F: drivers/i2c/busses/i2c-pasemi-platform.c >> -- >> 2.25.1 >> > I've gone ahead and applied this patch to the asahi-soc/dt tree, so we can build off of that to add the DT nodes. Sven, can you spin a v3 with the MAINTAINERS split and just the driver itself, without this patch? I imagine Guenter will want to take the driver itself through the linux-watchdog tree. -- Hector Martin (marcan@marcan.st) Public Key: https://mrcn.st/pub _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel