From: "Philippe Mathieu-Daudé" <philmd@redhat.com>
To: Richard Henderson <richard.henderson@linaro.org>, qemu-devel@nongnu.org
Cc: "Daniel P . Berrangé" <berrange@redhat.com>
Subject: Re: [PATCH v4 5/7] crypto/tlssession: Introduce qcrypto_tls_creds_check_endpoint() helper
Date: Wed, 16 Jun 2021 21:21:45 +0200 [thread overview]
Message-ID: <bda6ced3-3299-f1ed-f5c4-b53ed61bde28@redhat.com> (raw)
In-Reply-To: <55c03d12-3359-858e-8e71-7ba7a6fddad4@linaro.org>
On 6/16/21 9:12 PM, Richard Henderson wrote:
> On 6/16/21 9:22 AM, Philippe Mathieu-Daudé wrote:
>> Introduce the qcrypto_tls_creds_check_endpoint() helper
>> to avoid accessing QCryptoTLSCreds internal 'endpoint' field
>> directly.
>
> I don't understand this one. Comment ...
>
>> +bool qcrypto_tls_session_check_role(QCryptoTLSCreds *creds,
>> + QCryptoTLSCredsEndpoint endpoint,
>> + Error **errp)
>> +{
>> + return qcrypto_tls_creds_check_endpoint(creds, endpoint, errp);
>> +}
>
> ... doesn't match the function.
>
> The new function is a pure forwarder, and begs the question of why the
> caller isn't using qcrypto_tls_creds_check_endpoint directly.
I tried to follow the maintainer/subsystem style (I was also tempted to
use qcrypto_tls_creds_check_endpoint directly). ui/vnc uses the TLS
"session" API and not the "creds" one. Daniel, what is your preference?
next prev parent reply other threads:[~2021-06-16 19:22 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-16 16:22 [PATCH v4 0/7] crypto: Make QCryptoTLSCreds* structures private Philippe Mathieu-Daudé
2021-06-16 16:22 ` [PATCH v4 1/7] crypto/tlscreds: Introduce qcrypto_tls_creds_check_endpoint() helper Philippe Mathieu-Daudé
2021-06-16 19:08 ` Richard Henderson
2021-06-17 9:30 ` Daniel P. Berrangé
2021-06-16 16:22 ` [PATCH v4 2/7] block/nbd: Use qcrypto_tls_creds_check_endpoint() Philippe Mathieu-Daudé
2021-06-16 19:08 ` Richard Henderson
2021-06-17 9:31 ` Daniel P. Berrangé
2021-06-16 16:22 ` [PATCH v4 3/7] chardev/socket: " Philippe Mathieu-Daudé
2021-06-16 19:09 ` Richard Henderson
2021-06-17 9:31 ` Daniel P. Berrangé
2021-06-16 16:22 ` [PATCH v4 4/7] migration/tls: " Philippe Mathieu-Daudé
2021-06-16 19:09 ` Richard Henderson
2021-06-17 9:32 ` Daniel P. Berrangé
2021-06-16 16:22 ` [PATCH v4 5/7] crypto/tlssession: Introduce qcrypto_tls_creds_check_endpoint() helper Philippe Mathieu-Daudé
2021-06-16 19:12 ` Richard Henderson
2021-06-16 19:21 ` Philippe Mathieu-Daudé [this message]
2021-06-17 9:33 ` Daniel P. Berrangé
2021-06-17 12:02 ` Philippe Mathieu-Daudé
2021-06-16 16:22 ` [PATCH v4 6/7] ui/vnc: Use qcrypto_tls_session_check_role() Philippe Mathieu-Daudé
2021-06-16 16:22 ` [PATCH v4 7/7] crypto: Make QCryptoTLSCreds* structures private Philippe Mathieu-Daudé
2021-06-17 9:35 ` Daniel P. Berrangé
2021-06-17 12:08 ` Philippe Mathieu-Daudé
2021-06-17 12:15 ` Daniel P. Berrangé
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bda6ced3-3299-f1ed-f5c4-b53ed61bde28@redhat.com \
--to=philmd@redhat.com \
--cc=berrange@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=richard.henderson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.