From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.3 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5E4E6C11F69 for ; Fri, 2 Jul 2021 14:05:39 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 3A6F96142C for ; Fri, 2 Jul 2021 14:05:39 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232803AbhGBOIK (ORCPT ); Fri, 2 Jul 2021 10:08:10 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36648 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232686AbhGBOIK (ORCPT ); Fri, 2 Jul 2021 10:08:10 -0400 Received: from mail-lf1-x12f.google.com (mail-lf1-x12f.google.com [IPv6:2a00:1450:4864:20::12f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2F4BBC061762; Fri, 2 Jul 2021 07:05:38 -0700 (PDT) Received: by mail-lf1-x12f.google.com with SMTP id bu19so18288444lfb.9; Fri, 02 Jul 2021 07:05:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=Cjfl3c0J1wDK0xB6m0y3uhz6p6gS8JB9sGZSHtLepfc=; b=ocEmqlClYeANx41+Aff3aBsIZIc3UVL4RukOuIMXBs3c/pjDrBTh7SKzR1xGu3X1D+ HnLnYqQSqbVNwZphjkzXKuzrtTREydyNMI7xq0um2Dijg2FABDK5/f7wv3q1U9OPhpTD lE9dlJ7Bl0jRg6UJdme4qM2uWiLTYOm4+6N9dZwQjsWyIWXYqUdoUeZ130j0vJXLsaUy rbeGxR1S8HWJ8p9uPlQU7oCzGUJ3+DqhFRDtUqzcdd2gBc0jaZh6FDCzm4uoiOWIh32c uK6h1asNzG2jqNBMt/8czvBAiSBePEULa8Ib1Bn/fGPGDaQpernRoyWYEJGdeA+/j4Gz xkmw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=Cjfl3c0J1wDK0xB6m0y3uhz6p6gS8JB9sGZSHtLepfc=; b=MMh5qrMDSt+MfbU1Z8VY6cEePQpJNFa0Z0vhWnHMJwGNExZo/pCqWeHXXtIr8A5Fzb TRcWvbpd4xCn5pSMJX5A7s+kIEEOWqL2zyXklAsTnw1O9Le2o++BcLv1kvMsIKVlwWvI 33RwWy0w0Ryk0zgw/iRF0FEfA/5KqmixXKi6HSj69wxr1yIUB+WGU4iUx3D8S9MAFDM2 08NZ3xaNUTq7TVyFGR5S8SQxZRyGeuybSCt0GI2eMtnjqIUbZlxncOWqJFfQAR7DkvRs Kw1DN5Doail9esgSWaABFQnHmc/mwB2JoIerix3PmJJIyLKzBgEjn7ZWi0WZ8GHhTsit eNgw== X-Gm-Message-State: AOAM533oS1JRGuc2n7ZV28huf0UtryZy60R2yDBlXK3S/5Z/00YZBg8X YloDi0fF1nPqQFo2D5BXFT0= X-Google-Smtp-Source: ABdhPJzkutMeeLEPXZOMUQKVeT4A2lCgpel8CCjVgI5HBDtKFzrED7+2eYblNwWvXC7GZ5j86yLWyw== X-Received: by 2002:a05:6512:3fa2:: with SMTP id x34mr3972751lfa.437.1625234736576; Fri, 02 Jul 2021 07:05:36 -0700 (PDT) Received: from [192.168.2.145] (94-29-37-113.dynamic.spd-mgts.ru. [94.29.37.113]) by smtp.googlemail.com with ESMTPSA id q24sm304955lfj.200.2021.07.02.07.05.35 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 02 Jul 2021 07:05:35 -0700 (PDT) Subject: Re: [PATCH v2 2/5] iommu: Implement of_iommu_get_resv_regions() To: Thierry Reding , Joerg Roedel , Rob Herring Cc: Will Deacon , Robin Murphy , Nicolin Chen , Krishna Reddy , devicetree@vger.kernel.org, iommu@lists.linux-foundation.org, linux-tegra@vger.kernel.org, Frank Rowand , Rob Herring References: <20210423163234.3651547-1-thierry.reding@gmail.com> <20210423163234.3651547-3-thierry.reding@gmail.com> From: Dmitry Osipenko Message-ID: Date: Fri, 2 Jul 2021 17:05:35 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 MIME-Version: 1.0 In-Reply-To: <20210423163234.3651547-3-thierry.reding@gmail.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-tegra@vger.kernel.org 23.04.2021 19:32, Thierry Reding пишет: > +void of_iommu_get_resv_regions(struct device *dev, struct list_head *list) > +{ > + struct of_phandle_iterator it; > + int err; > + > + of_for_each_phandle(&it, err, dev->of_node, "memory-region", "#memory-region-cells", 0) { > + struct iommu_resv_region *region; > + struct of_phandle_args args; > + struct resource res; > + > + args.args_count = of_phandle_iterator_args(&it, args.args, MAX_PHANDLE_ARGS); > + > + err = of_address_to_resource(it.node, 0, &res); > + if (err < 0) { > + dev_err(dev, "failed to parse memory region %pOF: %d\n", > + it.node, err); > + continue; > + } > + > + if (args.args_count > 0) { > + /* > + * Active memory regions are expected to be accessed by hardware during > + * boot and must therefore have an identity mapping created prior to the > + * driver taking control of the hardware. This ensures that non-quiescent > + * hardware doesn't cause IOMMU faults during boot. > + */ > + if (args.args[0] & MEMORY_REGION_IDENTITY_MAPPING) { > + region = iommu_alloc_resv_region(res.start, resource_size(&res), > + IOMMU_READ | IOMMU_WRITE, > + IOMMU_RESV_DIRECT_RELAXABLE); > + if (!region) > + continue; > + > + list_add_tail(®ion->list, list); > + } > + } > + } > +} > +EXPORT_SYMBOL(of_iommu_get_resv_regions); Any reason why this is not EXPORT_SYMBOL_GPL? I'm curious what is the logic behind the OF symbols in general since it looks like half of them are GPL. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.0 required=3.0 tests=BAYES_00,DKIM_ADSP_CUSTOM_MED, DKIM_INVALID,DKIM_SIGNED,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A27C1C11F68 for ; Fri, 2 Jul 2021 14:05:43 +0000 (UTC) Received: from smtp1.osuosl.org (smtp1.osuosl.org [140.211.166.138]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 4AC716142C for ; Fri, 2 Jul 2021 14:05:43 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 4AC716142C Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=iommu-bounces@lists.linux-foundation.org Received: from localhost (localhost [127.0.0.1]) by smtp1.osuosl.org (Postfix) with ESMTP id 127B583E0C; Fri, 2 Jul 2021 14:05:43 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp1.osuosl.org ([127.0.0.1]) by localhost (smtp1.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id MifqVvKhZUYI; Fri, 2 Jul 2021 14:05:41 +0000 (UTC) Received: from lists.linuxfoundation.org (lf-lists.osuosl.org [IPv6:2605:bc80:3010:104::8cd3:938]) by smtp1.osuosl.org (Postfix) with ESMTPS id 9B74983E09; Fri, 2 Jul 2021 14:05:40 +0000 (UTC) Received: from lf-lists.osuosl.org (localhost [127.0.0.1]) by lists.linuxfoundation.org (Postfix) with ESMTP id 800D6C001A; Fri, 2 Jul 2021 14:05:40 +0000 (UTC) Received: from smtp3.osuosl.org (smtp3.osuosl.org [IPv6:2605:bc80:3010::136]) by lists.linuxfoundation.org (Postfix) with ESMTP id A7615C000E for ; Fri, 2 Jul 2021 14:05:39 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp3.osuosl.org (Postfix) with ESMTP id 81780606AA for ; Fri, 2 Jul 2021 14:05:39 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Authentication-Results: smtp3.osuosl.org (amavisd-new); dkim=pass (2048-bit key) header.d=gmail.com Received: from smtp3.osuosl.org ([127.0.0.1]) by localhost (smtp3.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id O1sG28fUD21Q for ; Fri, 2 Jul 2021 14:05:38 +0000 (UTC) X-Greylist: whitelisted by SQLgrey-1.8.0 Received: from mail-lf1-x12f.google.com (mail-lf1-x12f.google.com [IPv6:2a00:1450:4864:20::12f]) by smtp3.osuosl.org (Postfix) with ESMTPS id A553660672 for ; Fri, 2 Jul 2021 14:05:38 +0000 (UTC) Received: by mail-lf1-x12f.google.com with SMTP id k10so18212747lfv.13 for ; Fri, 02 Jul 2021 07:05:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=Cjfl3c0J1wDK0xB6m0y3uhz6p6gS8JB9sGZSHtLepfc=; b=ocEmqlClYeANx41+Aff3aBsIZIc3UVL4RukOuIMXBs3c/pjDrBTh7SKzR1xGu3X1D+ HnLnYqQSqbVNwZphjkzXKuzrtTREydyNMI7xq0um2Dijg2FABDK5/f7wv3q1U9OPhpTD lE9dlJ7Bl0jRg6UJdme4qM2uWiLTYOm4+6N9dZwQjsWyIWXYqUdoUeZ130j0vJXLsaUy rbeGxR1S8HWJ8p9uPlQU7oCzGUJ3+DqhFRDtUqzcdd2gBc0jaZh6FDCzm4uoiOWIh32c uK6h1asNzG2jqNBMt/8czvBAiSBePEULa8Ib1Bn/fGPGDaQpernRoyWYEJGdeA+/j4Gz xkmw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=Cjfl3c0J1wDK0xB6m0y3uhz6p6gS8JB9sGZSHtLepfc=; b=kUW5FGSxcrkDH+LbH/mi3BSYmQq8PQc+HNxM/FG6bn2O8byeGZgDMH1ivJ5UXP+nv3 qFhip65cCgdlLAxd44u4Rs2Hz1I3+bC/Tbgrl2mhgEtF/C6a5vfLC2m9XTY1i97qJf6+ 1tIhspSSs3mhMVEXMXcXV9Af0EdY5b9v5ipqXajjbHt0N/+Zi0+qN1KnMfnNjZ5GxHuY v/FqXlzx/SvlbKexCxtcPTZVm1DBYBKGK3qVlGROKV8EF5L+QiJm8rgtRUPnRk2UKIGE v1Z253g2OP8zvyrxJdJ+Wgk2vCMFqGr0MYlTRRvA+se/ip33dIjgTqNTs0xrIrjqDwAC CKTw== X-Gm-Message-State: AOAM530Nyy9V29w0ViLDf4MV9NsKWlG/R+mvFJi0C5ruQbkn6d7YT0i6 Pjm4Xg/90Ax4Mi1UaOlvkpI= X-Google-Smtp-Source: ABdhPJzkutMeeLEPXZOMUQKVeT4A2lCgpel8CCjVgI5HBDtKFzrED7+2eYblNwWvXC7GZ5j86yLWyw== X-Received: by 2002:a05:6512:3fa2:: with SMTP id x34mr3972751lfa.437.1625234736576; Fri, 02 Jul 2021 07:05:36 -0700 (PDT) Received: from [192.168.2.145] (94-29-37-113.dynamic.spd-mgts.ru. [94.29.37.113]) by smtp.googlemail.com with ESMTPSA id q24sm304955lfj.200.2021.07.02.07.05.35 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 02 Jul 2021 07:05:35 -0700 (PDT) Subject: Re: [PATCH v2 2/5] iommu: Implement of_iommu_get_resv_regions() To: Thierry Reding , Joerg Roedel , Rob Herring References: <20210423163234.3651547-1-thierry.reding@gmail.com> <20210423163234.3651547-3-thierry.reding@gmail.com> From: Dmitry Osipenko Message-ID: Date: Fri, 2 Jul 2021 17:05:35 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 MIME-Version: 1.0 In-Reply-To: <20210423163234.3651547-3-thierry.reding@gmail.com> Content-Language: en-US Cc: devicetree@vger.kernel.org, Frank Rowand , Rob Herring , Will Deacon , iommu@lists.linux-foundation.org, Nicolin Chen , linux-tegra@vger.kernel.org, Robin Murphy X-BeenThere: iommu@lists.linux-foundation.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: Development issues for Linux IOMMU support List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: iommu-bounces@lists.linux-foundation.org Sender: "iommu" MjMuMDQuMjAyMSAxOTozMiwgVGhpZXJyeSBSZWRpbmcg0L/QuNGI0LXRgjoKPiArdm9pZCBvZl9p b21tdV9nZXRfcmVzdl9yZWdpb25zKHN0cnVjdCBkZXZpY2UgKmRldiwgc3RydWN0IGxpc3RfaGVh ZCAqbGlzdCkKPiArewo+ICsJc3RydWN0IG9mX3BoYW5kbGVfaXRlcmF0b3IgaXQ7Cj4gKwlpbnQg ZXJyOwo+ICsKPiArCW9mX2Zvcl9lYWNoX3BoYW5kbGUoJml0LCBlcnIsIGRldi0+b2Zfbm9kZSwg Im1lbW9yeS1yZWdpb24iLCAiI21lbW9yeS1yZWdpb24tY2VsbHMiLCAwKSB7Cj4gKwkJc3RydWN0 IGlvbW11X3Jlc3ZfcmVnaW9uICpyZWdpb247Cj4gKwkJc3RydWN0IG9mX3BoYW5kbGVfYXJncyBh cmdzOwo+ICsJCXN0cnVjdCByZXNvdXJjZSByZXM7Cj4gKwo+ICsJCWFyZ3MuYXJnc19jb3VudCA9 IG9mX3BoYW5kbGVfaXRlcmF0b3JfYXJncygmaXQsIGFyZ3MuYXJncywgTUFYX1BIQU5ETEVfQVJH Uyk7Cj4gKwo+ICsJCWVyciA9IG9mX2FkZHJlc3NfdG9fcmVzb3VyY2UoaXQubm9kZSwgMCwgJnJl cyk7Cj4gKwkJaWYgKGVyciA8IDApIHsKPiArCQkJZGV2X2VycihkZXYsICJmYWlsZWQgdG8gcGFy c2UgbWVtb3J5IHJlZ2lvbiAlcE9GOiAlZFxuIiwKPiArCQkJCWl0Lm5vZGUsIGVycik7Cj4gKwkJ CWNvbnRpbnVlOwo+ICsJCX0KPiArCj4gKwkJaWYgKGFyZ3MuYXJnc19jb3VudCA+IDApIHsKPiAr CQkJLyoKPiArCQkJICogQWN0aXZlIG1lbW9yeSByZWdpb25zIGFyZSBleHBlY3RlZCB0byBiZSBh Y2Nlc3NlZCBieSBoYXJkd2FyZSBkdXJpbmcKPiArCQkJICogYm9vdCBhbmQgbXVzdCB0aGVyZWZv cmUgaGF2ZSBhbiBpZGVudGl0eSBtYXBwaW5nIGNyZWF0ZWQgcHJpb3IgdG8gdGhlCj4gKwkJCSAq IGRyaXZlciB0YWtpbmcgY29udHJvbCBvZiB0aGUgaGFyZHdhcmUuIFRoaXMgZW5zdXJlcyB0aGF0 IG5vbi1xdWllc2NlbnQKPiArCQkJICogaGFyZHdhcmUgZG9lc24ndCBjYXVzZSBJT01NVSBmYXVs dHMgZHVyaW5nIGJvb3QuCj4gKwkJCSAqLwo+ICsJCQlpZiAoYXJncy5hcmdzWzBdICYgTUVNT1JZ X1JFR0lPTl9JREVOVElUWV9NQVBQSU5HKSB7Cj4gKwkJCQlyZWdpb24gPSBpb21tdV9hbGxvY19y ZXN2X3JlZ2lvbihyZXMuc3RhcnQsIHJlc291cmNlX3NpemUoJnJlcyksCj4gKwkJCQkJCQkJIElP TU1VX1JFQUQgfCBJT01NVV9XUklURSwKPiArCQkJCQkJCQkgSU9NTVVfUkVTVl9ESVJFQ1RfUkVM QVhBQkxFKTsKPiArCQkJCWlmICghcmVnaW9uKQo+ICsJCQkJCWNvbnRpbnVlOwo+ICsKPiArCQkJ CWxpc3RfYWRkX3RhaWwoJnJlZ2lvbi0+bGlzdCwgbGlzdCk7Cj4gKwkJCX0KPiArCQl9Cj4gKwl9 Cj4gK30KPiArRVhQT1JUX1NZTUJPTChvZl9pb21tdV9nZXRfcmVzdl9yZWdpb25zKTsKCkFueSBy ZWFzb24gd2h5IHRoaXMgaXMgbm90IEVYUE9SVF9TWU1CT0xfR1BMPyBJJ20gY3VyaW91cyB3aGF0 IGlzIHRoZQpsb2dpYyBiZWhpbmQgdGhlIE9GIHN5bWJvbHMgaW4gZ2VuZXJhbCBzaW5jZSBpdCBs b29rcyBsaWtlIGhhbGYgb2YgdGhlbQphcmUgR1BMLgpfX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fXwppb21tdSBtYWlsaW5nIGxpc3QKaW9tbXVAbGlzdHMubGlu dXgtZm91bmRhdGlvbi5vcmcKaHR0cHM6Ly9saXN0cy5saW51eGZvdW5kYXRpb24ub3JnL21haWxt YW4vbGlzdGluZm8vaW9tbXU=