From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 67B27C433F5 for ; Thu, 10 Feb 2022 11:17:14 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S240728AbiBJLRL (ORCPT ); Thu, 10 Feb 2022 06:17:11 -0500 Received: from mxb-00190b01.gslb.pphosted.com ([23.128.96.19]:49868 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S240722AbiBJLRI (ORCPT ); Thu, 10 Feb 2022 06:17:08 -0500 Received: from sipsolutions.net (s3.sipsolutions.net [IPv6:2a01:4f8:191:4433::2]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 88DBDFE5 for ; Thu, 10 Feb 2022 03:17:09 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sipsolutions.net; s=mail; h=Content-Transfer-Encoding:MIME-Version: Content-Type:References:In-Reply-To:Date:Cc:To:From:Subject:Message-ID:Sender :Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From:Resent-To: Resent-Cc:Resent-Message-ID; bh=D25bj31y0a/n8jRLLLVFFPPQadJDst9Lss6NCfSOze0=; t=1644491829; x=1645701429; b=Z1TIQlN0AVQ4E9vzyAV55MY7qgE0HbyMR7GmneRZujbv9bT nCpl6XqQZxRCT9sXeYqanOq/vOPkeQTegT8SpKPyzCWrU2wKc1T+5XMVoB2JicPaicZuHiBEZkbZD +dCpz8Y4durja1ICMFvDMQQOuiRoxyDzXJdi43EtWW+hAE5z0uFW+h3seh/TMRhKzg+GXglhmkPOA hKaJ/TB2o8f/7kWQuolHBP97QzwCKk1uuECuwxqp4XUAkorQ8MH/IZS1cze74cFdnmf0XEkzfjNSi mVccsC1PEU/2A31jPB3DFDf7fYtmQTOcvvwTuH70YdHNi0r3F9XoPpCGof8BtCEg==; Received: by sipsolutions.net with esmtpsa (TLS1.3:ECDHE_SECP256R1__RSA_PSS_RSAE_SHA256__AES_256_GCM:256) (Exim 4.95) (envelope-from ) id 1nI7Rj-00H1EO-5R; Thu, 10 Feb 2022 12:17:07 +0100 Message-ID: Subject: Re: [PATCH 2/6] nl80211: add support to advertise driver's EHT capabilities From: Johannes Berg To: "Aloka Dixit (QUIC)" Cc: "linux-wireless@vger.kernel.org" , "Vikram Kandukuri (QUIC)" , "Jia Ding (QUIC)" , "Karthikeyan Periyasamy (QUIC)" , "Muna Sinada (QUIC)" , "Sriram R (QUIC)" , "Veerendranath Jakkam (QUIC)" , Aloka Dixit Date: Thu, 10 Feb 2022 12:17:06 +0100 In-Reply-To: <793a595932ea0adf7a72eeafb6ababdae8e21fc2.camel@sipsolutions.net> References: <1640163883-12696-1-git-send-email-quic_vjakkam@quicinc.com> <1640163883-12696-3-git-send-email-quic_vjakkam@quicinc.com> <793a595932ea0adf7a72eeafb6ababdae8e21fc2.camel@sipsolutions.net> Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.42.3 (3.42.3-1.fc35) MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-malware-bazaar: not-scanned Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org On Thu, 2022-02-10 at 09:26 +0100, Johannes Berg wrote: > > > > Considering that 20MHz-only STA and one that supports other bandwidths will not occur at the same time, > > instead of a separate field for struct ieee80211_eht_mcs_nss_supp_20mhz_only inside struct ieee80211_eht_mcs_nss_supp, we can use a byte array as we added in here: > > https://patchwork.kernel.org/project/linux-wireless/patch/1640163883-12696-3-git-send-email-quic_vjakkam@quicinc.com/ > > Instead of length field with dynamic allocation we can have an array of size 9 bytes. > > > > We did something like that in our patches: > > https://patchwork.kernel.org/project/linux-wireless/patch/20220204230119.b0eeb527d761.I2413a37c8f7d2d6d638038a3d95360a3fce0114d@changeid/ > https://patchwork.kernel.org/project/linux-wireless/patch/20220204230119.1ee92202ac30.Id30a3ef2844b296efbd5486fe1da9ca36a95c5cf@changeid/ > > Not overlapping wastes like 4 bytes of memory, I think I can live with > that, vs. the extra complexity? If you overlap you need another bit to > indicate which one you're using ... > OTOH, that means we need to unwrap it in userspace, which is also strange ... So yeah I'm changing it to a union. johannes