From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sameer Pujar Subject: Re: [alsa-devel] [PATCH 4/9] ASoC: tegra: add Tegra210 based I2S driver Date: Wed, 22 Jan 2020 10:02:25 +0530 Message-ID: References: <1579530198-13431-1-git-send-email-spujar@nvidia.com> <1579530198-13431-5-git-send-email-spujar@nvidia.com> <0c571858-d72c-97c2-2d6a-ead6fdde06eb@nvidia.com> <444731da-c4cd-8578-a732-c803eef31ef0@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: quoted-printable Return-path: In-Reply-To: <444731da-c4cd-8578-a732-c803eef31ef0-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> Content-Language: en-GB Sender: linux-tegra-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Dmitry Osipenko , perex-/Fr2/VpizcU@public.gmane.org, tiwai-IBi9RG/b67k@public.gmane.org, robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org Cc: devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, alsa-devel-K7yf7f+aM1XWsZ/bQMPhNw@public.gmane.org, atalambedu-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, lgirdwood-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org, jonathanh-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org, viswanathl-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org, sharadg-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org, broonie-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org, thierry.reding-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org, linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, rlokhande-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org, mkumard-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org, dramesh-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org List-Id: linux-tegra@vger.kernel.org On 1/21/2020 9:33 PM, Dmitry Osipenko wrote: > External email: Use caution opening links or attachments > > > 21.01.2020 17:21, Sameer Pujar =D0=BF=D0=B8=D1=88=D0=B5=D1=82: > > [snip] > >>>> +static int tegra210_i2s_put_control(struct snd_kcontrol *kcontrol, >>>> + struct snd_ctl_elem_value *ucontrol) >>> Checkpatch should complain about the wrong indentation here. >> I had run checkpatch before sending the patch, below is the result. >> ----- >> WARNING: added, moved or deleted file(s), does MAINTAINERS need updating= ? >> #70: >> new file mode 100644 >> >> total: 0 errors, 1 warnings, 1103 lines checked >> >> NOTE: For some of the reported defects, checkpatch may be able to >> mechanically convert to the typical style using --fix or >> --fix-inplace. >> ----- > Using 'checkpatch --strict': > > CHECK: Alignment should match open parenthesis > #2693: FILE: sound/soc/tegra/tegra210_i2s.c:362: > +static int tegra210_i2s_put_control(struct snd_kcontrol *kcontrol, > + struct snd_ctl_elem_value *ucontrol > > [snip] will fix >>>> + >>>> + } else if (strstr(kcontrol->id.name, "Playback Audio Bit Format"= )) >>>> + i2s->audio_fmt_override[I2S_RX_PATH] =3D value; >>>> + else if (strstr(kcontrol->id.name, "Capture Audio Bit Format")) >>>> + i2s->audio_fmt_override[I2S_TX_PATH] =3D value; >>>> + else if (strstr(kcontrol->id.name, "Client Bit Format")) >>>> + i2s->client_fmt_override =3D value; >>>> + else if (strstr(kcontrol->id.name, "Playback Audio Channels")) >>>> + i2s->audio_ch_override[I2S_RX_PATH] =3D value; >>>> + else if (strstr(kcontrol->id.name, "Capture Audio Channels")) >>>> + i2s->audio_ch_override[I2S_TX_PATH] =3D value; >>>> + else if (strstr(kcontrol->id.name, "Client Channels")) >>>> + i2s->client_ch_override =3D value; >>>> + else if (strstr(kcontrol->id.name, "Capture Stereo To Mono")) >>>> + i2s->stereo_to_mono[I2S_TX_PATH] =3D value; >>>> + else if (strstr(kcontrol->id.name, "Capture Mono To Stereo")) >>>> + i2s->mono_to_stereo[I2S_TX_PATH] =3D value; >>>> + else if (strstr(kcontrol->id.name, "Playback Stereo To Mono")) >>>> + i2s->stereo_to_mono[I2S_RX_PATH] =3D value; >>>> + else if (strstr(kcontrol->id.name, "Playback Mono To Stereo")) >>>> + i2s->mono_to_stereo[I2S_RX_PATH] =3D value; >>>> + else if (strstr(kcontrol->id.name, "Playback FIFO Threshold")) >>>> + i2s->rx_fifo_th =3D value; >>>> + else if (strstr(kcontrol->id.name, "BCLK Ratio")) >>>> + i2s->bclk_ratio =3D value; >>> I'm pretty sure that checkpatch should complain about the missing >>> brackets, they should make code's indentation uniform and thus easier t= o >>> read. Same for all other occurrences in the code. >> same as above > CHECK: braces {} should be used on all arms of this statement > #2699: FILE: sound/soc/tegra/tegra210_i2s.c:368: > + if (strstr(kcontrol->id.name, "Loopback")) { > [...] > + } else if (strstr(kcontrol->id.name, "Sample Rate")) > [...] > + else if (strstr(kcontrol->id.name, "FSYNC Width")) { > [...] > + } else if (strstr(kcontrol->id.name, "Playback Audio Bit Format")= ) > [...] > + else if (strstr(kcontrol->id.name, "Capture Audio Bit Format")) > [...] > + else if (strstr(kcontrol->id.name, "Client Bit Format")) > [...] > + else if (strstr(kcontrol->id.name, "Playback Audio Channels")) > [...] > + else if (strstr(kcontrol->id.name, "Capture Audio Channels")) > [...] > + else if (strstr(kcontrol->id.name, "Client Channels")) > [...] > + else if (strstr(kcontrol->id.name, "Capture Stereo To Mono")) > [...] > + else if (strstr(kcontrol->id.name, "Capture Mono To Stereo")) > [...] > + else if (strstr(kcontrol->id.name, "Playback Stereo To Mono")) > [...] > + else if (strstr(kcontrol->id.name, "Playback Mono To Stereo")) > [...] > + else if (strstr(kcontrol->id.name, "Playback FIFO Threshold")) > [...] > + else if (strstr(kcontrol->id.name, "BCLK Ratio")) > [...] > > [snip] will fix >>>> + pm_runtime_enable(dev); >>> Error checking? >> return type for above is void() > Ok > >>>> + return 0; >>>> +} >>>> + >>>> +static int tegra210_i2s_remove(struct platform_device *pdev) >>>> +{ >>>> + pm_runtime_disable(&pdev->dev); >>>> + if (!pm_runtime_status_suspended(&pdev->dev)) >>>> + tegra210_i2s_runtime_suspend(&pdev->dev); >>> This breaks device's RPM refcounting if it was disabled in the active >>> state. This code should be removed. At most you could warn about the >>> unxpected RPM state here, but it shouldn't be necessary. >> I guess this was added for safety and explicit suspend keeps clock >> disabled. >> Not sure if ref-counting of the device matters when runtime PM is >> disabled and device is removed. >> I see few drivers using this way. > It should matter (if I'm not missing something) because RPM should be in > a wrecked state once you'll try to re-load the driver's module. Likely > that those few other drivers are wrong. > > [snip] Once the driver is re-loaded and RPM is enabled, I don't think it would use the same 'dev' and the corresponding ref count. Doesn't it use the new=20 counters? If RPM is not working for some reason, most likely it would be the case=20 for other devices. What best driver can do is probably do a force suspend during=20 removal if already not done. I would prefer to keep, since multiple drivers still=20 have it, unless there is a real harm in doing so. > >>>> + int rx_fifo_th; >>> Could rx_fifo_th be negative? >> rx_fifo_th itself does not take negative values, explicit typecasting> i= s avoided in "if" condition by declaring this as "int" > Explicit typecasting isn't needed for integers. What I meant was, rx_fifo_th is checked against a 'int' variable in an=20 "if" condition. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.4 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B3A7AC32771 for ; Wed, 22 Jan 2020 04:32:39 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 7ABFD20828 for ; Wed, 22 Jan 2020 04:32:39 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=nvidia.com header.i=@nvidia.com header.b="WGBvzz7K" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729037AbgAVEci (ORCPT ); Tue, 21 Jan 2020 23:32:38 -0500 Received: from hqnvemgate26.nvidia.com ([216.228.121.65]:16443 "EHLO hqnvemgate26.nvidia.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726605AbgAVEci (ORCPT ); Tue, 21 Jan 2020 23:32:38 -0500 Received: from hqpgpgate102.nvidia.com (Not Verified[216.228.121.13]) by hqnvemgate26.nvidia.com (using TLS: TLSv1.2, DES-CBC3-SHA) id ; Tue, 21 Jan 2020 20:32:19 -0800 Received: from hqmail.nvidia.com ([172.20.161.6]) by hqpgpgate102.nvidia.com (PGP Universal service); Tue, 21 Jan 2020 20:32:33 -0800 X-PGP-Universal: processed; by hqpgpgate102.nvidia.com on Tue, 21 Jan 2020 20:32:33 -0800 Received: from [10.24.44.92] (10.124.1.5) by HQMAIL107.nvidia.com (172.20.187.13) with Microsoft SMTP Server (TLS) id 15.0.1473.3; Wed, 22 Jan 2020 04:32:28 +0000 Subject: Re: [alsa-devel] [PATCH 4/9] ASoC: tegra: add Tegra210 based I2S driver To: Dmitry Osipenko , , , CC: , , , , , , , , , , , , , References: <1579530198-13431-1-git-send-email-spujar@nvidia.com> <1579530198-13431-5-git-send-email-spujar@nvidia.com> <0c571858-d72c-97c2-2d6a-ead6fdde06eb@nvidia.com> <444731da-c4cd-8578-a732-c803eef31ef0@gmail.com> From: Sameer Pujar Message-ID: Date: Wed, 22 Jan 2020 10:02:25 +0530 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.4.1 MIME-Version: 1.0 In-Reply-To: <444731da-c4cd-8578-a732-c803eef31ef0@gmail.com> X-Originating-IP: [10.124.1.5] X-ClientProxiedBy: HQMAIL111.nvidia.com (172.20.187.18) To HQMAIL107.nvidia.com (172.20.187.13) Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: quoted-printable Content-Language: en-GB DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nvidia.com; s=n1; t=1579667539; bh=KdmKX9d8S+PQrtUkIVTaIyhy3ejgQLwLEoBvJKFTNnE=; h=X-PGP-Universal:Subject:To:CC:References:From:Message-ID:Date: User-Agent:MIME-Version:In-Reply-To:X-Originating-IP: X-ClientProxiedBy:Content-Type:Content-Transfer-Encoding: Content-Language; b=WGBvzz7KG05TcenZvck/dp97lpcrgOKH51OcIQnur3eIJ4HBue9LyYqC5M6j67Are Oa/gGGlwdl75oHpwowTo6ELVDM92lhTQjkeqeSwtnOnuMFuxA/Y8CXKjariz5Poj09 C1snVF41uhsttluLGDnquh8qu7akwvNPjuEg1Z7nCjKvtEDWz7hs2Z/7/MdEBZCsrR LY4gkxw//Q4YwslGwy9XMBzIK274GR63dJQ6QmkLMNBTbZSXr09UAEwWqwlqUkNnCv e5y+/SB796VoegRoJIXRcLrVXz/FHwAbkeJAlrgnAMNvw9vmayJ1zd+fBZ+zMjDF38 wC0lDvnkC19Zg== Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 1/21/2020 9:33 PM, Dmitry Osipenko wrote: > External email: Use caution opening links or attachments > > > 21.01.2020 17:21, Sameer Pujar =D0=BF=D0=B8=D1=88=D0=B5=D1=82: > > [snip] > >>>> +static int tegra210_i2s_put_control(struct snd_kcontrol *kcontrol, >>>> + struct snd_ctl_elem_value *ucontrol) >>> Checkpatch should complain about the wrong indentation here. >> I had run checkpatch before sending the patch, below is the result. >> ----- >> WARNING: added, moved or deleted file(s), does MAINTAINERS need updating= ? >> #70: >> new file mode 100644 >> >> total: 0 errors, 1 warnings, 1103 lines checked >> >> NOTE: For some of the reported defects, checkpatch may be able to >> mechanically convert to the typical style using --fix or >> --fix-inplace. >> ----- > Using 'checkpatch --strict': > > CHECK: Alignment should match open parenthesis > #2693: FILE: sound/soc/tegra/tegra210_i2s.c:362: > +static int tegra210_i2s_put_control(struct snd_kcontrol *kcontrol, > + struct snd_ctl_elem_value *ucontrol > > [snip] will fix >>>> + >>>> + } else if (strstr(kcontrol->id.name, "Playback Audio Bit Format"= )) >>>> + i2s->audio_fmt_override[I2S_RX_PATH] =3D value; >>>> + else if (strstr(kcontrol->id.name, "Capture Audio Bit Format")) >>>> + i2s->audio_fmt_override[I2S_TX_PATH] =3D value; >>>> + else if (strstr(kcontrol->id.name, "Client Bit Format")) >>>> + i2s->client_fmt_override =3D value; >>>> + else if (strstr(kcontrol->id.name, "Playback Audio Channels")) >>>> + i2s->audio_ch_override[I2S_RX_PATH] =3D value; >>>> + else if (strstr(kcontrol->id.name, "Capture Audio Channels")) >>>> + i2s->audio_ch_override[I2S_TX_PATH] =3D value; >>>> + else if (strstr(kcontrol->id.name, "Client Channels")) >>>> + i2s->client_ch_override =3D value; >>>> + else if (strstr(kcontrol->id.name, "Capture Stereo To Mono")) >>>> + i2s->stereo_to_mono[I2S_TX_PATH] =3D value; >>>> + else if (strstr(kcontrol->id.name, "Capture Mono To Stereo")) >>>> + i2s->mono_to_stereo[I2S_TX_PATH] =3D value; >>>> + else if (strstr(kcontrol->id.name, "Playback Stereo To Mono")) >>>> + i2s->stereo_to_mono[I2S_RX_PATH] =3D value; >>>> + else if (strstr(kcontrol->id.name, "Playback Mono To Stereo")) >>>> + i2s->mono_to_stereo[I2S_RX_PATH] =3D value; >>>> + else if (strstr(kcontrol->id.name, "Playback FIFO Threshold")) >>>> + i2s->rx_fifo_th =3D value; >>>> + else if (strstr(kcontrol->id.name, "BCLK Ratio")) >>>> + i2s->bclk_ratio =3D value; >>> I'm pretty sure that checkpatch should complain about the missing >>> brackets, they should make code's indentation uniform and thus easier t= o >>> read. Same for all other occurrences in the code. >> same as above > CHECK: braces {} should be used on all arms of this statement > #2699: FILE: sound/soc/tegra/tegra210_i2s.c:368: > + if (strstr(kcontrol->id.name, "Loopback")) { > [...] > + } else if (strstr(kcontrol->id.name, "Sample Rate")) > [...] > + else if (strstr(kcontrol->id.name, "FSYNC Width")) { > [...] > + } else if (strstr(kcontrol->id.name, "Playback Audio Bit Format")= ) > [...] > + else if (strstr(kcontrol->id.name, "Capture Audio Bit Format")) > [...] > + else if (strstr(kcontrol->id.name, "Client Bit Format")) > [...] > + else if (strstr(kcontrol->id.name, "Playback Audio Channels")) > [...] > + else if (strstr(kcontrol->id.name, "Capture Audio Channels")) > [...] > + else if (strstr(kcontrol->id.name, "Client Channels")) > [...] > + else if (strstr(kcontrol->id.name, "Capture Stereo To Mono")) > [...] > + else if (strstr(kcontrol->id.name, "Capture Mono To Stereo")) > [...] > + else if (strstr(kcontrol->id.name, "Playback Stereo To Mono")) > [...] > + else if (strstr(kcontrol->id.name, "Playback Mono To Stereo")) > [...] > + else if (strstr(kcontrol->id.name, "Playback FIFO Threshold")) > [...] > + else if (strstr(kcontrol->id.name, "BCLK Ratio")) > [...] > > [snip] will fix >>>> + pm_runtime_enable(dev); >>> Error checking? >> return type for above is void() > Ok > >>>> + return 0; >>>> +} >>>> + >>>> +static int tegra210_i2s_remove(struct platform_device *pdev) >>>> +{ >>>> + pm_runtime_disable(&pdev->dev); >>>> + if (!pm_runtime_status_suspended(&pdev->dev)) >>>> + tegra210_i2s_runtime_suspend(&pdev->dev); >>> This breaks device's RPM refcounting if it was disabled in the active >>> state. This code should be removed. At most you could warn about the >>> unxpected RPM state here, but it shouldn't be necessary. >> I guess this was added for safety and explicit suspend keeps clock >> disabled. >> Not sure if ref-counting of the device matters when runtime PM is >> disabled and device is removed. >> I see few drivers using this way. > It should matter (if I'm not missing something) because RPM should be in > a wrecked state once you'll try to re-load the driver's module. Likely > that those few other drivers are wrong. > > [snip] Once the driver is re-loaded and RPM is enabled, I don't think it would use the same 'dev' and the corresponding ref count. Doesn't it use the new=20 counters? If RPM is not working for some reason, most likely it would be the case=20 for other devices. What best driver can do is probably do a force suspend during=20 removal if already not done. I would prefer to keep, since multiple drivers still=20 have it, unless there is a real harm in doing so. > >>>> + int rx_fifo_th; >>> Could rx_fifo_th be negative? >> rx_fifo_th itself does not take negative values, explicit typecasting> i= s avoided in "if" condition by declaring this as "int" > Explicit typecasting isn't needed for integers. What I meant was, rx_fifo_th is checked against a 'int' variable in an=20 "if" condition. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E4762C32771 for ; Wed, 22 Jan 2020 04:33:37 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 700E120828 for ; Wed, 22 Jan 2020 04:33:37 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=alsa-project.org header.i=@alsa-project.org header.b="mtem+T4B"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=nvidia.com header.i=@nvidia.com header.b="WGBvzz7K" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 700E120828 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=nvidia.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=alsa-devel-bounces@alsa-project.org Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id B5CDC165D; Wed, 22 Jan 2020 05:32:45 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz B5CDC165D DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1579667615; bh=eUBH41nRO6MgwRISwxcf6QB19DJfc/C/s6peIYGugfg=; h=To:References:From:Date:In-Reply-To:Cc:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=mtem+T4B3esOMW9axwkQIgufYT7DB8GO2LTKjsXkwMRyfKN4pgiHKVKwsg4pIHR4n +2rq1lDES+EGaKOoj5bWp7BPzx6cWIJV23B+dmJevyr63wAnIzynSD3ZshbN3hlR3t PWzZYZJbyLafieiwEQ7dG5SNuZYbxqzhbRtkBOPM= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id 4418EF8020C; Wed, 22 Jan 2020 05:32:45 +0100 (CET) Received: by alsa1.perex.cz (Postfix, from userid 50401) id D3D9AF80229; Wed, 22 Jan 2020 05:32:42 +0100 (CET) Received: from hqnvemgate26.nvidia.com (hqnvemgate26.nvidia.com [216.228.121.65]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 427D0F8007E for ; Wed, 22 Jan 2020 05:32:35 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 427D0F8007E Authentication-Results: alsa1.perex.cz; dkim=pass (2048-bit key) header.d=nvidia.com header.i=@nvidia.com header.b="WGBvzz7K" Received: from hqpgpgate102.nvidia.com (Not Verified[216.228.121.13]) by hqnvemgate26.nvidia.com (using TLS: TLSv1.2, DES-CBC3-SHA) id ; Tue, 21 Jan 2020 20:32:19 -0800 Received: from hqmail.nvidia.com ([172.20.161.6]) by hqpgpgate102.nvidia.com (PGP Universal service); Tue, 21 Jan 2020 20:32:33 -0800 X-PGP-Universal: processed; by hqpgpgate102.nvidia.com on Tue, 21 Jan 2020 20:32:33 -0800 Received: from [10.24.44.92] (10.124.1.5) by HQMAIL107.nvidia.com (172.20.187.13) with Microsoft SMTP Server (TLS) id 15.0.1473.3; Wed, 22 Jan 2020 04:32:28 +0000 To: Dmitry Osipenko , , , References: <1579530198-13431-1-git-send-email-spujar@nvidia.com> <1579530198-13431-5-git-send-email-spujar@nvidia.com> <0c571858-d72c-97c2-2d6a-ead6fdde06eb@nvidia.com> <444731da-c4cd-8578-a732-c803eef31ef0@gmail.com> From: Sameer Pujar Message-ID: Date: Wed, 22 Jan 2020 10:02:25 +0530 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.4.1 MIME-Version: 1.0 In-Reply-To: <444731da-c4cd-8578-a732-c803eef31ef0@gmail.com> X-Originating-IP: [10.124.1.5] X-ClientProxiedBy: HQMAIL111.nvidia.com (172.20.187.18) To HQMAIL107.nvidia.com (172.20.187.13) Content-Language: en-GB DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nvidia.com; s=n1; t=1579667539; bh=KdmKX9d8S+PQrtUkIVTaIyhy3ejgQLwLEoBvJKFTNnE=; h=X-PGP-Universal:Subject:To:CC:References:From:Message-ID:Date: User-Agent:MIME-Version:In-Reply-To:X-Originating-IP: X-ClientProxiedBy:Content-Type:Content-Transfer-Encoding: Content-Language; b=WGBvzz7KG05TcenZvck/dp97lpcrgOKH51OcIQnur3eIJ4HBue9LyYqC5M6j67Are Oa/gGGlwdl75oHpwowTo6ELVDM92lhTQjkeqeSwtnOnuMFuxA/Y8CXKjariz5Poj09 C1snVF41uhsttluLGDnquh8qu7akwvNPjuEg1Z7nCjKvtEDWz7hs2Z/7/MdEBZCsrR LY4gkxw//Q4YwslGwy9XMBzIK274GR63dJQ6QmkLMNBTbZSXr09UAEwWqwlqUkNnCv e5y+/SB796VoegRoJIXRcLrVXz/FHwAbkeJAlrgnAMNvw9vmayJ1zd+fBZ+zMjDF38 wC0lDvnkC19Zg== Cc: devicetree@vger.kernel.org, alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org, lgirdwood@gmail.com, jonathanh@nvidia.com, viswanathl@nvidia.com, linux-tegra@vger.kernel.org, broonie@kernel.org, atalambedu@nvidia.com, sharadg@nvidia.com, thierry.reding@gmail.com, rlokhande@nvidia.com, mkumard@nvidia.com, dramesh@nvidia.com Subject: Re: [alsa-devel] [PATCH 4/9] ASoC: tegra: add Tegra210 based I2S driver X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: base64 Content-Type: text/plain; charset="utf-8"; Format="flowed" Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" CgpPbiAxLzIxLzIwMjAgOTozMyBQTSwgRG1pdHJ5IE9zaXBlbmtvIHdyb3RlOgo+IEV4dGVybmFs IGVtYWlsOiBVc2UgY2F1dGlvbiBvcGVuaW5nIGxpbmtzIG9yIGF0dGFjaG1lbnRzCj4KPgo+IDIx LjAxLjIwMjAgMTc6MjEsIFNhbWVlciBQdWphciDQv9C40YjQtdGCOgo+Cj4gW3NuaXBdCj4KPj4+ PiArc3RhdGljIGludCB0ZWdyYTIxMF9pMnNfcHV0X2NvbnRyb2woc3RydWN0IHNuZF9rY29udHJv bCAqa2NvbnRyb2wsCj4+Pj4gKyAgICAgc3RydWN0IHNuZF9jdGxfZWxlbV92YWx1ZSAqdWNvbnRy b2wpCj4+PiBDaGVja3BhdGNoIHNob3VsZCBjb21wbGFpbiBhYm91dCB0aGUgd3JvbmcgaW5kZW50 YXRpb24gaGVyZS4KPj4gSSBoYWQgcnVuIGNoZWNrcGF0Y2ggYmVmb3JlIHNlbmRpbmcgdGhlIHBh dGNoLCBiZWxvdyBpcyB0aGUgcmVzdWx0Lgo+PiAtLS0tLQo+PiBXQVJOSU5HOiBhZGRlZCwgbW92 ZWQgb3IgZGVsZXRlZCBmaWxlKHMpLCBkb2VzIE1BSU5UQUlORVJTIG5lZWQgdXBkYXRpbmc/Cj4+ ICM3MDoKPj4gbmV3IGZpbGUgbW9kZSAxMDA2NDQKPj4KPj4gdG90YWw6IDAgZXJyb3JzLCAxIHdh cm5pbmdzLCAxMTAzIGxpbmVzIGNoZWNrZWQKPj4KPj4gTk9URTogRm9yIHNvbWUgb2YgdGhlIHJl cG9ydGVkIGRlZmVjdHMsIGNoZWNrcGF0Y2ggbWF5IGJlIGFibGUgdG8KPj4gICAgICAgIG1lY2hh bmljYWxseSBjb252ZXJ0IHRvIHRoZSB0eXBpY2FsIHN0eWxlIHVzaW5nIC0tZml4IG9yCj4+IC0t Zml4LWlucGxhY2UuCj4+IC0tLS0tCj4gVXNpbmcgJ2NoZWNrcGF0Y2ggLS1zdHJpY3QnOgo+Cj4g Q0hFQ0s6IEFsaWdubWVudCBzaG91bGQgbWF0Y2ggb3BlbiBwYXJlbnRoZXNpcwo+ICMyNjkzOiBG SUxFOiBzb3VuZC9zb2MvdGVncmEvdGVncmEyMTBfaTJzLmM6MzYyOgo+ICtzdGF0aWMgaW50IHRl Z3JhMjEwX2kyc19wdXRfY29udHJvbChzdHJ1Y3Qgc25kX2tjb250cm9sICprY29udHJvbCwKPiAr ICAgICAgIHN0cnVjdCBzbmRfY3RsX2VsZW1fdmFsdWUgKnVjb250cm9sCj4KPiBbc25pcF0KCndp bGwgZml4Cj4+Pj4gKwo+Pj4+ICsgICAgIH0gZWxzZSBpZiAoc3Ryc3RyKGtjb250cm9sLT5pZC5u YW1lLCAiUGxheWJhY2sgQXVkaW8gQml0IEZvcm1hdCIpKQo+Pj4+ICsgICAgICAgICAgICAgaTJz LT5hdWRpb19mbXRfb3ZlcnJpZGVbSTJTX1JYX1BBVEhdID0gdmFsdWU7Cj4+Pj4gKyAgICAgZWxz ZSBpZiAoc3Ryc3RyKGtjb250cm9sLT5pZC5uYW1lLCAiQ2FwdHVyZSBBdWRpbyBCaXQgRm9ybWF0 IikpCj4+Pj4gKyAgICAgICAgICAgICBpMnMtPmF1ZGlvX2ZtdF9vdmVycmlkZVtJMlNfVFhfUEFU SF0gPSB2YWx1ZTsKPj4+PiArICAgICBlbHNlIGlmIChzdHJzdHIoa2NvbnRyb2wtPmlkLm5hbWUs ICJDbGllbnQgQml0IEZvcm1hdCIpKQo+Pj4+ICsgICAgICAgICAgICAgaTJzLT5jbGllbnRfZm10 X292ZXJyaWRlID0gdmFsdWU7Cj4+Pj4gKyAgICAgZWxzZSBpZiAoc3Ryc3RyKGtjb250cm9sLT5p ZC5uYW1lLCAiUGxheWJhY2sgQXVkaW8gQ2hhbm5lbHMiKSkKPj4+PiArICAgICAgICAgICAgIGky cy0+YXVkaW9fY2hfb3ZlcnJpZGVbSTJTX1JYX1BBVEhdID0gdmFsdWU7Cj4+Pj4gKyAgICAgZWxz ZSBpZiAoc3Ryc3RyKGtjb250cm9sLT5pZC5uYW1lLCAiQ2FwdHVyZSBBdWRpbyBDaGFubmVscyIp KQo+Pj4+ICsgICAgICAgICAgICAgaTJzLT5hdWRpb19jaF9vdmVycmlkZVtJMlNfVFhfUEFUSF0g PSB2YWx1ZTsKPj4+PiArICAgICBlbHNlIGlmIChzdHJzdHIoa2NvbnRyb2wtPmlkLm5hbWUsICJD bGllbnQgQ2hhbm5lbHMiKSkKPj4+PiArICAgICAgICAgICAgIGkycy0+Y2xpZW50X2NoX292ZXJy aWRlID0gdmFsdWU7Cj4+Pj4gKyAgICAgZWxzZSBpZiAoc3Ryc3RyKGtjb250cm9sLT5pZC5uYW1l LCAiQ2FwdHVyZSBTdGVyZW8gVG8gTW9ubyIpKQo+Pj4+ICsgICAgICAgICAgICAgaTJzLT5zdGVy ZW9fdG9fbW9ub1tJMlNfVFhfUEFUSF0gPSB2YWx1ZTsKPj4+PiArICAgICBlbHNlIGlmIChzdHJz dHIoa2NvbnRyb2wtPmlkLm5hbWUsICJDYXB0dXJlIE1vbm8gVG8gU3RlcmVvIikpCj4+Pj4gKyAg ICAgICAgICAgICBpMnMtPm1vbm9fdG9fc3RlcmVvW0kyU19UWF9QQVRIXSA9IHZhbHVlOwo+Pj4+ ICsgICAgIGVsc2UgaWYgKHN0cnN0cihrY29udHJvbC0+aWQubmFtZSwgIlBsYXliYWNrIFN0ZXJl byBUbyBNb25vIikpCj4+Pj4gKyAgICAgICAgICAgICBpMnMtPnN0ZXJlb190b19tb25vW0kyU19S WF9QQVRIXSA9IHZhbHVlOwo+Pj4+ICsgICAgIGVsc2UgaWYgKHN0cnN0cihrY29udHJvbC0+aWQu bmFtZSwgIlBsYXliYWNrIE1vbm8gVG8gU3RlcmVvIikpCj4+Pj4gKyAgICAgICAgICAgICBpMnMt Pm1vbm9fdG9fc3RlcmVvW0kyU19SWF9QQVRIXSA9IHZhbHVlOwo+Pj4+ICsgICAgIGVsc2UgaWYg KHN0cnN0cihrY29udHJvbC0+aWQubmFtZSwgIlBsYXliYWNrIEZJRk8gVGhyZXNob2xkIikpCj4+ Pj4gKyAgICAgICAgICAgICBpMnMtPnJ4X2ZpZm9fdGggPSB2YWx1ZTsKPj4+PiArICAgICBlbHNl IGlmIChzdHJzdHIoa2NvbnRyb2wtPmlkLm5hbWUsICJCQ0xLIFJhdGlvIikpCj4+Pj4gKyAgICAg ICAgICAgICBpMnMtPmJjbGtfcmF0aW8gPSB2YWx1ZTsKPj4+IEknbSBwcmV0dHkgc3VyZSB0aGF0 IGNoZWNrcGF0Y2ggc2hvdWxkIGNvbXBsYWluIGFib3V0IHRoZSBtaXNzaW5nCj4+PiBicmFja2V0 cywgdGhleSBzaG91bGQgbWFrZSBjb2RlJ3MgaW5kZW50YXRpb24gdW5pZm9ybSBhbmQgdGh1cyBl YXNpZXIgdG8KPj4+IHJlYWQuIFNhbWUgZm9yIGFsbCBvdGhlciBvY2N1cnJlbmNlcyBpbiB0aGUg Y29kZS4KPj4gc2FtZSBhcyBhYm92ZQo+IENIRUNLOiBicmFjZXMge30gc2hvdWxkIGJlIHVzZWQg b24gYWxsIGFybXMgb2YgdGhpcyBzdGF0ZW1lbnQKPiAjMjY5OTogRklMRTogc291bmQvc29jL3Rl Z3JhL3RlZ3JhMjEwX2kycy5jOjM2ODoKPiArICAgICAgIGlmIChzdHJzdHIoa2NvbnRyb2wtPmlk Lm5hbWUsICJMb29wYmFjayIpKSB7Cj4gWy4uLl0KPiArICAgICAgIH0gZWxzZSBpZiAoc3Ryc3Ry KGtjb250cm9sLT5pZC5uYW1lLCAiU2FtcGxlIFJhdGUiKSkKPiBbLi4uXQo+ICsgICAgICAgZWxz ZSBpZiAoc3Ryc3RyKGtjb250cm9sLT5pZC5uYW1lLCAiRlNZTkMgV2lkdGgiKSkgewo+IFsuLi5d Cj4gKyAgICAgICB9IGVsc2UgaWYgKHN0cnN0cihrY29udHJvbC0+aWQubmFtZSwgIlBsYXliYWNr IEF1ZGlvIEJpdCBGb3JtYXQiKSkKPiBbLi4uXQo+ICsgICAgICAgZWxzZSBpZiAoc3Ryc3RyKGtj b250cm9sLT5pZC5uYW1lLCAiQ2FwdHVyZSBBdWRpbyBCaXQgRm9ybWF0IikpCj4gWy4uLl0KPiAr ICAgICAgIGVsc2UgaWYgKHN0cnN0cihrY29udHJvbC0+aWQubmFtZSwgIkNsaWVudCBCaXQgRm9y bWF0IikpCj4gWy4uLl0KPiArICAgICAgIGVsc2UgaWYgKHN0cnN0cihrY29udHJvbC0+aWQubmFt ZSwgIlBsYXliYWNrIEF1ZGlvIENoYW5uZWxzIikpCj4gWy4uLl0KPiArICAgICAgIGVsc2UgaWYg KHN0cnN0cihrY29udHJvbC0+aWQubmFtZSwgIkNhcHR1cmUgQXVkaW8gQ2hhbm5lbHMiKSkKPiBb Li4uXQo+ICsgICAgICAgZWxzZSBpZiAoc3Ryc3RyKGtjb250cm9sLT5pZC5uYW1lLCAiQ2xpZW50 IENoYW5uZWxzIikpCj4gWy4uLl0KPiArICAgICAgIGVsc2UgaWYgKHN0cnN0cihrY29udHJvbC0+ aWQubmFtZSwgIkNhcHR1cmUgU3RlcmVvIFRvIE1vbm8iKSkKPiBbLi4uXQo+ICsgICAgICAgZWxz ZSBpZiAoc3Ryc3RyKGtjb250cm9sLT5pZC5uYW1lLCAiQ2FwdHVyZSBNb25vIFRvIFN0ZXJlbyIp KQo+IFsuLi5dCj4gKyAgICAgICBlbHNlIGlmIChzdHJzdHIoa2NvbnRyb2wtPmlkLm5hbWUsICJQ bGF5YmFjayBTdGVyZW8gVG8gTW9ubyIpKQo+IFsuLi5dCj4gKyAgICAgICBlbHNlIGlmIChzdHJz dHIoa2NvbnRyb2wtPmlkLm5hbWUsICJQbGF5YmFjayBNb25vIFRvIFN0ZXJlbyIpKQo+IFsuLi5d Cj4gKyAgICAgICBlbHNlIGlmIChzdHJzdHIoa2NvbnRyb2wtPmlkLm5hbWUsICJQbGF5YmFjayBG SUZPIFRocmVzaG9sZCIpKQo+IFsuLi5dCj4gKyAgICAgICBlbHNlIGlmIChzdHJzdHIoa2NvbnRy b2wtPmlkLm5hbWUsICJCQ0xLIFJhdGlvIikpCj4gWy4uLl0KPgo+IFtzbmlwXQoKd2lsbCBmaXgK Pj4+PiArICAgICBwbV9ydW50aW1lX2VuYWJsZShkZXYpOwo+Pj4gRXJyb3IgY2hlY2tpbmc/Cj4+ IHJldHVybiB0eXBlIGZvciBhYm92ZSBpcyB2b2lkKCkKPiBPawo+Cj4+Pj4gKyAgICAgcmV0dXJu IDA7Cj4+Pj4gK30KPj4+PiArCj4+Pj4gK3N0YXRpYyBpbnQgdGVncmEyMTBfaTJzX3JlbW92ZShz dHJ1Y3QgcGxhdGZvcm1fZGV2aWNlICpwZGV2KQo+Pj4+ICt7Cj4+Pj4gKyAgICAgcG1fcnVudGlt ZV9kaXNhYmxlKCZwZGV2LT5kZXYpOwo+Pj4+ICsgICAgIGlmICghcG1fcnVudGltZV9zdGF0dXNf c3VzcGVuZGVkKCZwZGV2LT5kZXYpKQo+Pj4+ICsgICAgICAgICAgICAgdGVncmEyMTBfaTJzX3J1 bnRpbWVfc3VzcGVuZCgmcGRldi0+ZGV2KTsKPj4+IFRoaXMgYnJlYWtzIGRldmljZSdzIFJQTSBy ZWZjb3VudGluZyBpZiBpdCB3YXMgZGlzYWJsZWQgaW4gdGhlIGFjdGl2ZQo+Pj4gc3RhdGUuIFRo aXMgY29kZSBzaG91bGQgYmUgcmVtb3ZlZC4gQXQgbW9zdCB5b3UgY291bGQgd2FybiBhYm91dCB0 aGUKPj4+IHVueHBlY3RlZCBSUE0gc3RhdGUgaGVyZSwgYnV0IGl0IHNob3VsZG4ndCBiZSBuZWNl c3NhcnkuCj4+IEkgZ3Vlc3MgdGhpcyB3YXMgYWRkZWQgZm9yIHNhZmV0eSBhbmQgZXhwbGljaXQg c3VzcGVuZCBrZWVwcyBjbG9jawo+PiBkaXNhYmxlZC4KPj4gTm90IHN1cmUgaWYgcmVmLWNvdW50 aW5nIG9mIHRoZSBkZXZpY2UgbWF0dGVycyB3aGVuIHJ1bnRpbWUgUE0gaXMKPj4gZGlzYWJsZWQg YW5kIGRldmljZSBpcyByZW1vdmVkLgo+PiBJIHNlZSBmZXcgZHJpdmVycyB1c2luZyB0aGlzIHdh eS4KPiBJdCBzaG91bGQgbWF0dGVyIChpZiBJJ20gbm90IG1pc3Npbmcgc29tZXRoaW5nKSBiZWNh dXNlIFJQTSBzaG91bGQgYmUgaW4KPiBhIHdyZWNrZWQgc3RhdGUgb25jZSB5b3UnbGwgdHJ5IHRv IHJlLWxvYWQgdGhlIGRyaXZlcidzIG1vZHVsZS4gTGlrZWx5Cj4gdGhhdCB0aG9zZSBmZXcgb3Ro ZXIgZHJpdmVycyBhcmUgd3JvbmcuCj4KPiBbc25pcF0KCk9uY2UgdGhlIGRyaXZlciBpcyByZS1s b2FkZWQgYW5kIFJQTSBpcyBlbmFibGVkLCBJIGRvbid0IHRoaW5rIGl0IHdvdWxkIHVzZQp0aGUg c2FtZSAnZGV2JyBhbmQgdGhlIGNvcnJlc3BvbmRpbmcgcmVmIGNvdW50LiBEb2Vzbid0IGl0IHVz ZSB0aGUgbmV3IApjb3VudGVycz8KSWYgUlBNIGlzIG5vdCB3b3JraW5nIGZvciBzb21lIHJlYXNv biwgbW9zdCBsaWtlbHkgaXQgd291bGQgYmUgdGhlIGNhc2UgCmZvciBvdGhlcgpkZXZpY2VzLiBX aGF0IGJlc3QgZHJpdmVyIGNhbiBkbyBpcyBwcm9iYWJseSBkbyBhIGZvcmNlIHN1c3BlbmQgZHVy aW5nIApyZW1vdmFsIGlmCmFscmVhZHkgbm90IGRvbmUuIEkgd291bGQgcHJlZmVyIHRvIGtlZXAs IHNpbmNlIG11bHRpcGxlIGRyaXZlcnMgc3RpbGwgCmhhdmUgaXQsCnVubGVzcyB0aGVyZSBpcyBh IHJlYWwgaGFybSBpbiBkb2luZyBzby4KPgo+Pj4+ICsgICAgIGludCByeF9maWZvX3RoOwo+Pj4g Q291bGQgcnhfZmlmb190aCBiZSBuZWdhdGl2ZT8KPj4gcnhfZmlmb190aCBpdHNlbGYgZG9lcyBu b3QgdGFrZSBuZWdhdGl2ZSB2YWx1ZXMsIGV4cGxpY2l0IHR5cGVjYXN0aW5nPiBpcyBhdm9pZGVk IGluICJpZiIgY29uZGl0aW9uIGJ5IGRlY2xhcmluZyB0aGlzIGFzICJpbnQiCj4gRXhwbGljaXQg dHlwZWNhc3RpbmcgaXNuJ3QgbmVlZGVkIGZvciBpbnRlZ2Vycy4KCldoYXQgSSBtZWFudCB3YXMs IHJ4X2ZpZm9fdGggaXMgY2hlY2tlZCBhZ2FpbnN0IGEgJ2ludCcgdmFyaWFibGUgaW4gYW4gCiJp ZiIgY29uZGl0aW9uLgoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX18KQWxzYS1kZXZlbCBtYWlsaW5nIGxpc3QKQWxzYS1kZXZlbEBhbHNhLXByb2plY3Qub3Jn Cmh0dHBzOi8vbWFpbG1hbi5hbHNhLXByb2plY3Qub3JnL21haWxtYW4vbGlzdGluZm8vYWxzYS1k ZXZlbAo=