From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.1 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 52B0CC433ED for ; Fri, 14 May 2021 14:43:29 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id ECA146144B for ; Fri, 14 May 2021 14:43:28 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org ECA146144B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:53434 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lhZ2F-0006kJ-VF for qemu-devel@archiver.kernel.org; Fri, 14 May 2021 10:43:27 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:58362) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lhZ1O-000618-HX for qemu-devel@nongnu.org; Fri, 14 May 2021 10:42:34 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]:44374) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lhZ1J-0004S1-4C for qemu-devel@nongnu.org; Fri, 14 May 2021 10:42:34 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1621003348; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=hPrDhZy8bVmIkDG27MQuVcQ7i1Lz090MmgmQ3Zhd43Q=; b=blth0MEE79yUW+R2NFS2beEeMf8cYQDQ1NTx2kcnIEDrGb9WkZ5yN75QF1i0xfGXVKQqPT M/XjD4m61vuYO9UzPS7SJFJ0LfHA7TCGR+x/Y4utma47R9peP/3+w0lRIQAs7KpepHSpQu Op87iymYR+9Nz+HNy+h/QX0hb8rLbk4= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-144-36-h1WvyPuupiBHpmZQ17g-1; Fri, 14 May 2021 10:42:26 -0400 X-MC-Unique: 36-h1WvyPuupiBHpmZQ17g-1 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id E2A48801AF5; Fri, 14 May 2021 14:42:25 +0000 (UTC) Received: from wainer-laptop.localdomain (ovpn-116-173.gru2.redhat.com [10.97.116.173]) by smtp.corp.redhat.com (Postfix) with ESMTP id 8112D6060F; Fri, 14 May 2021 14:42:20 +0000 (UTC) Subject: Re: [PATCH 05/10] python/machine: Disable pylint warning for open() in _pre_launch To: John Snow , qemu-devel@nongnu.org References: <20210512214642.2803189-1-jsnow@redhat.com> <20210512214642.2803189-6-jsnow@redhat.com> From: Wainer dos Santos Moschetta Message-ID: Date: Fri, 14 May 2021 11:42:17 -0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.7.0 MIME-Version: 1.0 In-Reply-To: <20210512214642.2803189-6-jsnow@redhat.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=wainersm@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Content-Language: en-US Received-SPF: pass client-ip=170.10.133.124; envelope-from=wainersm@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -34 X-Spam_score: -3.5 X-Spam_bar: --- X-Spam_report: (-3.5 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.699, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, NICE_REPLY_A=-0.001, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Kevin Wolf , Cleber Rosa , Eduardo Habkost , qemu-block@nongnu.org, Max Reitz Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" Hi, On 5/12/21 6:46 PM, John Snow wrote: > Shift the open() call later so that the pylint pragma applies *only* to > that one open() call. Add a note that suggests why this is safe: the > resource is unconditionally cleaned up in _post_shutdown(). You can also put it in a pylint disable/enable block. E.g.:     # pylint: disable=consider-using-with     self._qemu_log_file = open(self._qemu_log_path, 'wb')     # pylint: enable=consider-using-with However I don't know if this is bad practice. :) Reviewed-by: Wainer dos Santos Moschetta > > _post_shutdown is called after failed launches (see launch()), and > unconditionally after every call to shutdown(), and therefore also on > __exit__. > > Signed-off-by: John Snow > --- > python/qemu/machine.py | 6 +++++- > 1 file changed, 5 insertions(+), 1 deletion(-) > > diff --git a/python/qemu/machine.py b/python/qemu/machine.py > index c13ff9b32bf..8f86303b48f 100644 > --- a/python/qemu/machine.py > +++ b/python/qemu/machine.py > @@ -308,7 +308,6 @@ def _pre_launch(self) -> None: > self._temp_dir = tempfile.mkdtemp(prefix="qemu-machine-", > dir=self._test_dir) > self._qemu_log_path = os.path.join(self._temp_dir, self._name + ".log") > - self._qemu_log_file = open(self._qemu_log_path, 'wb') > > if self._console_set: > self._remove_files.append(self._console_address) > @@ -323,6 +322,11 @@ def _pre_launch(self) -> None: > nickname=self._name > ) > > + # NOTE: Make sure any opened resources are *definitely* freed in > + # _post_shutdown()! > + # pylint: disable=consider-using-with > + self._qemu_log_file = open(self._qemu_log_path, 'wb') > + > def _post_launch(self) -> None: > if self._qmp_connection: > self._qmp.accept()