From mboxrd@z Thu Jan 1 00:00:00 1970 From: Julien Grall Subject: Re: [PATCH v2 04/25] arm/altp2m: Move hostp2m init/teardown to individual functions. Date: Wed, 3 Aug 2016 18:40:57 +0100 Message-ID: References: <20160801171028.11615-1-proskurin@sec.in.tum.de> <20160801171028.11615-5-proskurin@sec.in.tum.de> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: Received: from mail6.bemta6.messagelabs.com ([85.158.143.247]) by lists.xenproject.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bV0AA-0006g1-QU for xen-devel@lists.xenproject.org; Wed, 03 Aug 2016 17:41:02 +0000 In-Reply-To: <20160801171028.11615-5-proskurin@sec.in.tum.de> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xen.org Sender: "Xen-devel" To: Sergej Proskurin , xen-devel@lists.xenproject.org Cc: Stefano Stabellini List-Id: xen-devel@lists.xenproject.org SGVsbG8gU2VyZ2VqLAoKVGl0bGU6IHMvYWx0cDJtL3AybS8gYW5kIHBsZWFzZSBkcm9wIHRoZSBm dWxsIHN0b3AuCgpPbiAwMS8wOC8xNiAxODoxMCwgU2VyZ2VqIFByb3NrdXJpbiB3cm90ZToKPiBU aGlzIGNvbW1pdCBwdWxscyBvdXQgZ2VuZXJpYyBpbml0L3RlYXJkb3duIGZ1bmN0aW9uYWxpdHkg b3V0IG9mCj4gcDJtX2luaXQgYW5kIHAybV90ZWFyZG93biBpbnRvIHAybV9pbml0X29uZSwgcDJt X2ZyZWVfb25lLCBhbmQKPiBwMm1fZmx1c2hfdGFibGUgZnVuY3Rpb25zLiAgVGhpcyBhbGxvd3Mg b3VyIGZ1dHVyZSBpbXBsZW1lbnRhdGlvbiB0bwo+IHJldXNlIGV4aXN0aW5nIGNvZGUgZm9yIHRo ZSBpbml0aWFsaXphdGlvbi90ZWFyZG93biBvZiBhbHRwMm0gdmlld3MuCgpQbGVhc2UgYXZvaWQg dG8gbWl4LXVwIGNvZGUgbW92ZW1lbnQgYW5kIG5ldyBhZGRpdGlvbnMuIFRoaXMgbWFrZXMgdGhl IApjb2RlIG1vcmUgZGlmZmljdWx0IHRvIHJldmlldy4KCkFsc28sIHlvdSBkb24ndCBtZW50aW9u IHRoZSBuZXcgY2hhbmdlcyBpbiB0aGUgY29tbWl0IG1lc3NhZ2UuCgpBZnRlciByZWFkaW5nIHRo ZSBwYXRjaCwgaXQgc2hvdWxkIHJlYWxseSBiZSBkaXZpZGVkIGFuZCBleHBsYWluIHdoeSB5b3Ug CnNwbGl0IGxpa2UgdGhhdC4KCj4KPiBTaWduZWQtb2ZmLWJ5OiBTZXJnZWogUHJvc2t1cmluIDxw cm9za3VyaW5Ac2VjLmluLnR1bS5kZT4KPiAtLS0KPiBDYzogU3RlZmFubyBTdGFiZWxsaW5pIDxz c3RhYmVsbGluaUBrZXJuZWwub3JnPgo+IENjOiBKdWxpZW4gR3JhbGwgPGp1bGllbi5ncmFsbEBh cm0uY29tPgo+IC0tLQo+IHYyOiBBZGRlZCB0aGUgZnVuY3Rpb24gcDJtX2ZsdXNoX3RhYmxlIHRv IHRoZSBwcmV2aW91cyB2ZXJzaW9uLgo+IC0tLQo+ICB4ZW4vYXJjaC9hcm0vcDJtLmMgICAgICAg IHwgNzQgKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKy0tLS0tLS0tLS0KPiAg eGVuL2luY2x1ZGUvYXNtLWFybS9wMm0uaCB8IDExICsrKysrKysKPiAgMiBmaWxlcyBjaGFuZ2Vk LCA3MCBpbnNlcnRpb25zKCspLCAxNSBkZWxldGlvbnMoLSkKPgo+IGRpZmYgLS1naXQgYS94ZW4v YXJjaC9hcm0vcDJtLmMgYi94ZW4vYXJjaC9hcm0vcDJtLmMKPiBpbmRleCBjYmM2NGExLi4xN2Yz Mjk5IDEwMDY0NAo+IC0tLSBhL3hlbi9hcmNoL2FybS9wMm0uYwo+ICsrKyBiL3hlbi9hcmNoL2Fy bS9wMm0uYwo+IEBAIC0xMzYwLDUwICsxMzYwLDk0IEBAIHN0YXRpYyB2b2lkIHAybV9mcmVlX3Zt aWQoc3RydWN0IGRvbWFpbiAqZCkKPiAgICAgIHNwaW5fdW5sb2NrKCZ2bWlkX2FsbG9jX2xvY2sp Owo+ICB9Cj4KPiAtdm9pZCBwMm1fdGVhcmRvd24oc3RydWN0IGRvbWFpbiAqZCkKPiArLyogUmVz ZXQgdGhpcyBwMm0gdGFibGUgdG8gYmUgZW1wdHkgKi8KPiArdm9pZCBwMm1fZmx1c2hfdGFibGUo c3RydWN0IHAybV9kb21haW4gKnAybSkKCkFueSBmdW5jdGlvbiBleHBvcnRlZCBzaG91bGQgaGF2 ZSBpdHMgcHJvdG90eXBlIGluIGFuIGhlYWRlciB3aXRoaW4gdGhlIApzYW1lIHBhdGNoLgoKPiAg ewo+IC0gICAgc3RydWN0IHAybV9kb21haW4gKnAybSA9ICZkLT5hcmNoLnAybTsKPiAtICAgIHN0 cnVjdCBwYWdlX2luZm8gKnBnOwo+ICsgICAgc3RydWN0IHBhZ2VfaW5mbyAqcGFnZSwgKnBnOwo+ ICsgICAgdW5zaWduZWQgaW50IGk7Cj4gKwo+ICsgICAgcGFnZSA9IHAybS0+cm9vdDsKCgpUaGlz IGZ1bmN0aW9uIGNhbiBiZSBjYWxsZWQgd2l0aCBwMm0tPnJvb3QgZXF1YWwgdG8gTlVMTC4gKHNl ZSB0aGUgY2hlY2sgCmluIHAybV9mcmVlX29uZS4KCj4gKwo+ICsgICAgLyogQ2xlYXIgYWxsIGNv bmNhdGVuYXRlZCBmaXJzdCBsZXZlbCBwYWdlcyAqLwo+ICsgICAgZm9yICggaSA9IDA7IGkgPCBQ Mk1fUk9PVF9QQUdFUzsgaSsrICkKPiArICAgICAgICBjbGVhcl9hbmRfY2xlYW5fcGFnZShwYWdl ICsgaSk7Cj4KPiArICAgIC8qIEZyZWUgdGhlIHJlc3Qgb2YgdGhlIHRyaWUgcGFnZXMgYmFjayB0 byB0aGUgcGFnaW5nIHBvb2wgKi8KPiAgICAgIHdoaWxlICggKHBnID0gcGFnZV9saXN0X3JlbW92 ZV9oZWFkKCZwMm0tPnBhZ2VzKSkgKQo+ICAgICAgICAgIGZyZWVfZG9taGVhcF9wYWdlKHBnKTsK PiArfQo+ICsKPiArc3RhdGljIGlubGluZSB2b2lkIHAybV9mcmVlX29uZShzdHJ1Y3QgcDJtX2Rv bWFpbiAqcDJtKQoKV2h5IGlubGluZSBoZXJlPyBBbHNvLCBpdCBzZWVtcyB0aGF0IHlvdSBleHBv cnQgdGhlIGZ1bmN0aW9uIGxhdGVyLiBXaHkgCmRvbid0IHlvdSBkbyBpdCBoZXJlPwoKRmluYWxs eSwgSSB0aGluayB0aGlzIGZ1bmN0aW9uIHNob3VsZCBiZSByZW5hbWUgcDJtX3RlYXJkb3duX29u ZSB0byAKbWF0Y2ggdGhlIGNhbGxlcnMnIG5hbWUuCgo+ICt7Cj4gKyAgICBwMm1fZmx1c2hfdGFi bGUocDJtKTsKPiArCj4gKyAgICAvKiBGcmVlIFZNSUQgYW5kIHJlc2V0IFZUVEJSICovCj4gKyAg ICBwMm1fZnJlZV92bWlkKHAybS0+ZG9tYWluKTsKCldoeSBkbyB5b3UgbW92ZSB0aGUgY2FsbCB0 byBwMm1fZnJlZV92bWlkPwoKPiArICAgIHAybS0+dnR0YnIudnR0YnIgPSBJTlZBTElEX1ZUVEJS OwoKV2h5IGRvIHlvdSByZXNldCB2dHRiciwgdGhlIHAybSB3aWxsIG5ldmVyIGJlIHVzZWQgYWZ0 ZXJ3YXJkcy4KCj4KPiAgICAgIGlmICggcDJtLT5yb290ICkKPiAgICAgICAgICBmcmVlX2RvbWhl YXBfcGFnZXMocDJtLT5yb290LCBQMk1fUk9PVF9PUkRFUik7Cj4KPiAgICAgIHAybS0+cm9vdCA9 IE5VTEw7Cj4KPiAtICAgIHAybV9mcmVlX3ZtaWQoZCk7Cj4gLQo+ICAgICAgcmFkaXhfdHJlZV9k ZXN0cm95KCZwMm0tPm1lbV9hY2Nlc3Nfc2V0dGluZ3MsIE5VTEwpOwo+ICB9Cj4KPiAtaW50IHAy bV9pbml0KHN0cnVjdCBkb21haW4gKmQpCj4gK2ludCBwMm1faW5pdF9vbmUoc3RydWN0IGRvbWFp biAqZCwgc3RydWN0IHAybV9kb21haW4gKnAybSkKCkFueSBmdW5jdGlvbiBleHBvcnRlZCBzaG91 bGQgaGF2ZSBpdHMgcHJvdG90eXBlIGluIGFuIGhlYWRlciB3aXRoaW4gdGhlIApzYW1lIHBhdGNo LgoKPiAgewo+IC0gICAgc3RydWN0IHAybV9kb21haW4gKnAybSA9ICZkLT5hcmNoLnAybTsKPiAg ICAgIGludCByYyA9IDA7Cj4KPiAgICAgIHJ3bG9ja19pbml0KCZwMm0tPmxvY2spOwo+ICAgICAg SU5JVF9QQUdFX0xJU1RfSEVBRCgmcDJtLT5wYWdlcyk7Cj4KPiAtICAgIHAybS0+dm1pZCA9IElO VkFMSURfVk1JRDsKPiAtCgpXaHkgdGhpcyBpcyBkcm9wcGVkPwoKPiAgICAgIHJjID0gcDJtX2Fs bG9jX3ZtaWQoZCk7Cj4gICAgICBpZiAoIHJjICE9IDAgKQo+ICAgICAgICAgIHJldHVybiByYzsK Pgo+IC0gICAgcDJtLT5tYXhfbWFwcGVkX2dmbiA9IF9nZm4oMCk7Cj4gLSAgICBwMm0tPmxvd2Vz dF9tYXBwZWRfZ2ZuID0gX2dmbihVTE9OR19NQVgpOwo+IC0KPiAtICAgIHAybS0+ZGVmYXVsdF9h Y2Nlc3MgPSBwMm1fYWNjZXNzX3J3eDsKPiArICAgIHAybS0+ZG9tYWluID0gZDsKPiArICAgIHAy bS0+YWNjZXNzX3JlcXVpcmVkID0gZmFsc2U7Cj4gICAgICBwMm0tPm1lbV9hY2Nlc3NfZW5hYmxl ZCA9IGZhbHNlOwo+ICsgICAgcDJtLT5kZWZhdWx0X2FjY2VzcyA9IHAybV9hY2Nlc3Nfcnd4Owo+ ICsgICAgcDJtLT5yb290ID0gTlVMTDsKPiArICAgIHAybS0+bWF4X21hcHBlZF9nZm4gPSBfZ2Zu KDApOwo+ICsgICAgcDJtLT5sb3dlc3RfbWFwcGVkX2dmbiA9IElOVkFMSURfR0ZOOwoKUGxlYXNl IGRvbid0IG1vdmUgY29kZSB3aGVuIGl0IGlzIG5vdCBuZWNlc3NhcnkuIFRoaXMgbWFrZSB0aGUg Y29kZSAKcmV2aWV3IG1vcmUgZGlmZmljdWx0IHRvIHJlYWQuCgo+ICsgICAgcDJtLT52dHRici52 dHRiciA9IElOVkFMSURfVlRUQlI7Cj4gICAgICByYWRpeF90cmVlX2luaXQoJnAybS0+bWVtX2Fj Y2Vzc19zZXR0aW5ncyk7Cj4KPiAtICAgIHJjID0gcDJtX2FsbG9jX3RhYmxlKGQpOwo+IC0KClRo ZSBmdW5jdGlvbiBwMm1faW5pdF9vbmUgc2hvdWxkIGZ1bGx5IGluaXRpYWxpemUgdGhlIHAybSAo aS5lIGFsbG9jYXRlIAp0aGUgdGFibGUpLgoKV2h5IGFsdHAybV9kZXN0cm95X2J5X2lkIGRvbid0 IGZyZWUgdGhlIHAybSBlbnRpcmVseT8KVGhpcyB3b3VsZCBzaW1wbHkgYSBsb3QgdGhpcyBzZXJp ZXMgYW5kIGF2b2lkIHRvIHNwcmVhZCBwMm0gCmluaXRpYWxpemF0aW9uIGV2ZXJ5d2hlcmUuCgo+ ICAgICAgcmV0dXJuIHJjOwo+ICB9Cj4KPiArc3RhdGljIHZvaWQgcDJtX3RlYXJkb3duX2hvc3Rw Mm0oc3RydWN0IGRvbWFpbiAqZCkKPiArewo+ICsgICAgc3RydWN0IHAybV9kb21haW4gKnAybSA9 IHAybV9nZXRfaG9zdHAybShkKTsKPiArCj4gKyAgICBwMm1fZnJlZV9vbmUocDJtKTsKPiArfQo+ ICsKPiArdm9pZCBwMm1fdGVhcmRvd24oc3RydWN0IGRvbWFpbiAqZCkKPiArewo+ICsgICAgcDJt X3RlYXJkb3duX2hvc3RwMm0oZCk7Cj4gK30KPiArCj4gK3N0YXRpYyBpbnQgcDJtX2luaXRfaG9z dHAybShzdHJ1Y3QgZG9tYWluICpkKQo+ICt7Cj4gKyAgICBpbnQgcmM7Cj4gKyAgICBzdHJ1Y3Qg cDJtX2RvbWFpbiAqcDJtID0gcDJtX2dldF9ob3N0cDJtKGQpOwo+ICsKPiArICAgIHAybS0+cDJt X2NsYXNzID0gcDJtX2hvc3Q7Cj4gKwo+ICsgICAgcmMgPSBwMm1faW5pdF9vbmUoZCwgcDJtKTsK PiArICAgIGlmICggcmMgKQo+ICsgICAgICAgIHJldHVybiByYzsKPiArCj4gKyAgICByZXR1cm4g cDJtX2FsbG9jX3RhYmxlKGQpOwo+ICt9Cj4gKwo+ICtpbnQgcDJtX2luaXQoc3RydWN0IGRvbWFp biAqZCkKPiArewo+ICsgICAgcmV0dXJuIHAybV9pbml0X2hvc3RwMm0oZCk7Cj4gK30KPiArCj4g IGludCByZWxpbnF1aXNoX3AybV9tYXBwaW5nKHN0cnVjdCBkb21haW4gKmQpCj4gIHsKPiAgICAg IHN0cnVjdCBwMm1fZG9tYWluICpwMm0gPSAmZC0+YXJjaC5wMm07Cj4gZGlmZiAtLWdpdCBhL3hl bi9pbmNsdWRlL2FzbS1hcm0vcDJtLmggYi94ZW4vaW5jbHVkZS9hc20tYXJtL3AybS5oCj4gaW5k ZXggNWM3Y2QxYS4uMWY5YzM3MCAxMDA2NDQKPiAtLS0gYS94ZW4vaW5jbHVkZS9hc20tYXJtL3Ay bS5oCj4gKysrIGIveGVuL2luY2x1ZGUvYXNtLWFybS9wMm0uaAo+IEBAIC0xOCw2ICsxOCwxMSBA QCBzdHJ1Y3QgZG9tYWluOwo+Cj4gIGV4dGVybiB2b2lkIG1lbW9yeV90eXBlX2NoYW5nZWQoc3Ry dWN0IGRvbWFpbiAqKTsKPgo+ICt0eXBlZGVmIGVudW0gewo+ICsgICAgcDJtX2hvc3QsCj4gKyAg ICBwMm1fYWx0ZXJuYXRlLAo+ICt9IHAybV9jbGFzc190Owo+ICsKClRoaXMgYWRkaXRpb24gc2hv dWxkIHJlYWxseSBiZSBpbiBhIHNlcGFyYXRlIHBhdGNoLgoKPiAgLyogUGVyLXAybS10YWJsZSBz dGF0ZSAqLwo+ICBzdHJ1Y3QgcDJtX2RvbWFpbiB7Cj4gICAgICAvKiBMb2NrIHRoYXQgcHJvdGVj dHMgdXBkYXRlcyB0byB0aGUgcDJtICovCj4gQEAgLTc4LDYgKzgzLDEyIEBAIHN0cnVjdCBwMm1f ZG9tYWluIHsKPiAgICAgICAqIGVub3VnaCBhdmFpbGFibGUgYml0cyB0byBzdG9yZSB0aGlzIGlu Zm9ybWF0aW9uLgo+ICAgICAgICovCj4gICAgICBzdHJ1Y3QgcmFkaXhfdHJlZV9yb290IG1lbV9h Y2Nlc3Nfc2V0dGluZ3M7Cj4gKwo+ICsgICAgLyogQ2hvb3NlIGJldHdlZW46IGhvc3QvYWx0ZXJu YXRlICovCj4gKyAgICBwMm1fY2xhc3NfdCBwMm1fY2xhc3M7Cj4gKwo+ICsgICAgLyogQmFjayBw b2ludGVyIHRvIGRvbWFpbiAqLwo+ICsgICAgc3RydWN0IGRvbWFpbiAqZG9tYWluOwoKU2FtZSBo ZXJlLiBXaXRoIGp1c3RpZmljYXRpb24gd2h5IHdlIHdhbnQgaXQuCgo+ICB9Owo+Cj4gIC8qCj4K ClJlZ2FyZHMsCgotLSAKSnVsaWVuIEdyYWxsCgpfX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fXwpYZW4tZGV2ZWwgbWFpbGluZyBsaXN0Clhlbi1kZXZlbEBsaXN0 cy54ZW4ub3JnCmh0dHBzOi8vbGlzdHMueGVuLm9yZy94ZW4tZGV2ZWwK