From: Rehas Sachdeva <aquannie@gmail.com>
To: outreachy-kernel@googlegroups.com
Cc: Lior Dotan <liodot@gmail.com>,
Christopher Harrer <charrer@alacritech.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Subject: [PATCH 4/5] staging: slicoss: Remove unnecessary braces {}
Date: Fri, 16 Sep 2016 00:45:32 +0530 [thread overview]
Message-ID: <bde8d1850b22cbffa26dc38b666cbef79c350e98.1473966683.git.aquannie@gmail.com> (raw)
In-Reply-To: <cover.1473966683.git.aquannie@gmail.com>
Removes unnecessary braces {} on both arms of an if-else block as they
have a single statement each. Issue detected by checkpatch.
Signed-off-by: Rehas Sachdeva <aquannie@gmail.com>
---
drivers/staging/slicoss/slicoss.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/slicoss/slicoss.c b/drivers/staging/slicoss/slicoss.c
index 8182e58..6b1c92e 100644
--- a/drivers/staging/slicoss/slicoss.c
+++ b/drivers/staging/slicoss/slicoss.c
@@ -1631,11 +1631,10 @@ static u32 slic_rcvqueue_reinsert(struct adapter *adapter, struct sk_buff *skb)
dev_err(dev, " rcvq->tail[%p]\n", rcvq->tail);
dev_err(dev, " rcvq->count[%x]\n", rcvq->count);
}
- if (paddrh == 0) {
+ if (paddrh == 0)
slic_write32(adapter, SLIC_REG_HBAR, (u32)paddrl);
- } else {
+ else
slic_write64(adapter, SLIC_REG_HBAR64, paddrl, paddrh);
- }
if (rcvq->head)
rcvq->tail->next = skb;
else
--
2.7.4
next prev parent reply other threads:[~2016-09-15 19:15 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-15 19:13 [PATCH 0/5] staging: slicoss: Fix multiple checkpatch warnings Rehas Sachdeva
2016-09-15 19:14 ` [PATCH 1/5] staging: slicoss: Fix alignment with open parentheses Rehas Sachdeva
2016-09-15 19:20 ` [Outreachy kernel] " Julia Lawall
2016-09-15 19:28 ` Rehas Sachdeva
2016-09-15 19:14 ` [PATCH 2/5] staging: slicoss: Remove blank lines before & after braces Rehas Sachdeva
2016-09-15 19:15 ` [PATCH 3/5] staging: slicoss: Add {} to an arm of if-else Rehas Sachdeva
2016-09-16 7:54 ` [Outreachy kernel] " Greg Kroah-Hartman
2016-09-15 19:15 ` Rehas Sachdeva [this message]
2016-09-15 19:15 ` [PATCH 5/5] staging: slicoss: Remove unnecessary blank line Rehas Sachdeva
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bde8d1850b22cbffa26dc38b666cbef79c350e98.1473966683.git.aquannie@gmail.com \
--to=aquannie@gmail.com \
--cc=charrer@alacritech.com \
--cc=gregkh@linuxfoundation.org \
--cc=liodot@gmail.com \
--cc=outreachy-kernel@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.