From mboxrd@z Thu Jan 1 00:00:00 1970 From: Paul Durrant Subject: Re: [PATCH 14/18] xen: add implementations of xen-qdisk connect and disconnect functions... Date: Thu, 29 Nov 2018 09:33:06 +0000 Message-ID: References: <20181121151211.15997-1-paul.durrant@citrix.com> <20181121151211.15997-15-paul.durrant@citrix.com> <20181128163447.GF4222@dhcp-200-186.str.redhat.com> <20181129090046.GA4797@linux.fritz.box> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1gSIh6-0005UF-7t for xen-devel@lists.xenproject.org; Thu, 29 Nov 2018 09:33:12 +0000 In-Reply-To: <20181129090046.GA4797@linux.fritz.box> Content-Language: en-US List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" To: 'Kevin Wolf' Cc: Stefano Stabellini , "qemu-block@nongnu.org" , "qemu-devel@nongnu.org" , Max Reitz , Anthony Perard , "xen-devel@lists.xenproject.org" List-Id: xen-devel@lists.xenproject.org PiAtLS0tLU9yaWdpbmFsIE1lc3NhZ2UtLS0tLQo+IEZyb206IEtldmluIFdvbGYgW21haWx0bzpr d29sZkByZWRoYXQuY29tXQo+IFNlbnQ6IDI5IE5vdmVtYmVyIDIwMTggMDk6MDEKPiBUbzogUGF1 bCBEdXJyYW50IDxQYXVsLkR1cnJhbnRAY2l0cml4LmNvbT4KPiBDYzogcWVtdS1ibG9ja0Bub25n bnUub3JnOyBxZW11LWRldmVsQG5vbmdudS5vcmc7IHhlbi0KPiBkZXZlbEBsaXN0cy54ZW5wcm9q ZWN0Lm9yZzsgU3RlZmFubyBTdGFiZWxsaW5pIDxzc3RhYmVsbGluaUBrZXJuZWwub3JnPjsKPiBB bnRob255IFBlcmFyZCA8YW50aG9ueS5wZXJhcmRAY2l0cml4LmNvbT47IE1heCBSZWl0eiA8bXJl aXR6QHJlZGhhdC5jb20+Cj4gU3ViamVjdDogUmU6IFtQQVRDSCAxNC8xOF0geGVuOiBhZGQgaW1w bGVtZW50YXRpb25zIG9mIHhlbi1xZGlzayBjb25uZWN0Cj4gYW5kIGRpc2Nvbm5lY3QgZnVuY3Rp b25zLi4uCj4gCj4gQW0gMjguMTEuMjAxOCB1bSAxNzo0MCBoYXQgUGF1bCBEdXJyYW50IGdlc2No cmllYmVuOgo+ID4gPiAtLS0tLU9yaWdpbmFsIE1lc3NhZ2UtLS0tLQo+ID4gPiBGcm9tOiBLZXZp biBXb2xmIFttYWlsdG86a3dvbGZAcmVkaGF0LmNvbV0KPiA+ID4gU2VudDogMjggTm92ZW1iZXIg MjAxOCAxNjozNQo+ID4gPiBUbzogUGF1bCBEdXJyYW50IDxQYXVsLkR1cnJhbnRAY2l0cml4LmNv bT4KPiA+ID4gQ2M6IHFlbXUtYmxvY2tAbm9uZ251Lm9yZzsgcWVtdS1kZXZlbEBub25nbnUub3Jn OyB4ZW4tCj4gPiA+IGRldmVsQGxpc3RzLnhlbnByb2plY3Qub3JnOyBTdGVmYW5vIFN0YWJlbGxp bmkKPiA8c3N0YWJlbGxpbmlAa2VybmVsLm9yZz47Cj4gPiA+IEFudGhvbnkgUGVyYXJkIDxhbnRo b255LnBlcmFyZEBjaXRyaXguY29tPjsgTWF4IFJlaXR6Cj4gPG1yZWl0ekByZWRoYXQuY29tPgo+ ID4gPiBTdWJqZWN0OiBSZTogW1BBVENIIDE0LzE4XSB4ZW46IGFkZCBpbXBsZW1lbnRhdGlvbnMg b2YgeGVuLXFkaXNrCj4gY29ubmVjdAo+ID4gPiBhbmQgZGlzY29ubmVjdCBmdW5jdGlvbnMuLi4K PiA+ID4KPiA+ID4gQW0gMjEuMTEuMjAxOCB1bSAxNjoxMiBoYXQgUGF1bCBEdXJyYW50IGdlc2No cmllYmVuOgo+ID4gPiA+IC4uLmFuZCB3aXJlIGluIHRoZSBkYXRhcGxhbmUuCj4gPiA+ID4KPiA+ ID4gPiBUaGlzIHBhdGNoIGFkZHMgdGhlIHJlbWFpbmluZyBjb2RlIHRvIG1ha2UgdGhlIHhlbi1x ZGlzayBYZW5EZXZpY2UKPiA+ID4gPiBmdW5jdGlvbmFsLiBUaGUgcGFyYW1ldGVycyB0aGF0IGEg YmxvY2sgZnJvbnRlbmQgZXhwZWN0cyB0byBmaW5kIGFyZQo+ID4gPiA+IHBvcHVsYXRlZCBpbiB0 aGUgYmFja2VuZCB4ZW5zdG9yZSBhcmVhLCBhbmQgdGhlICdyaW5nLXJlZicgYW5kCj4gPiA+ID4g J2V2ZW50LWNoYW5uZWwnIHZhbHVlcyBzcGVjaWZpZWQgaW4gdGhlIGZyb250ZW5kIHhlbnN0b3Jl IGFyZWEgYXJlCj4gPiA+ID4gbWFwcGVkL2JvdW5kIGFuZCB1c2VkIHRvIHNldCB1cCB0aGUgZGF0 YXBsYW5lLgo+ID4gPiA+Cj4gPiA+ID4gU2lnbmVkLW9mZi1ieTogUGF1bCBEdXJyYW50IDxwYXVs LmR1cnJhbnRAY2l0cml4LmNvbT4KPiA+ID4gPiAtLS0KPiA+ID4gPiBDYzogU3RlZmFubyBTdGFi ZWxsaW5pIDxzc3RhYmVsbGluaUBrZXJuZWwub3JnPgo+ID4gPiA+IENjOiBBbnRob255IFBlcmFy ZCA8YW50aG9ueS5wZXJhcmRAY2l0cml4LmNvbT4KPiA+ID4gPiBDYzogS2V2aW4gV29sZiA8a3dv bGZAcmVkaGF0LmNvbT4KPiA+ID4gPiBDYzogTWF4IFJlaXR6IDxtcmVpdHpAcmVkaGF0LmNvbT4K PiA+ID4gPiAtLS0KPiA+ID4gPiAgaHcvYmxvY2sveGVuLXFkaXNrLmMgICAgICAgfCAxNDAKPiA+ ID4gKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrCj4gPiA+ID4g IGh3L3hlbi94ZW4tYnVzLmMgICAgICAgICAgIHwgIDEyICsrLS0KPiA+ID4gPiAgaW5jbHVkZS9o dy94ZW4veGVuLWJ1cy5oICAgfCAgIDggKysrCj4gPiA+ID4gIGluY2x1ZGUvaHcveGVuL3hlbi1x ZGlzay5oIHwgIDEyICsrKysKPiA+ID4gPiAgNCBmaWxlcyBjaGFuZ2VkLCAxNjYgaW5zZXJ0aW9u cygrKSwgNiBkZWxldGlvbnMoLSkKPiA+ID4gPgo+ID4gPiA+IGRpZmYgLS1naXQgYS9ody9ibG9j ay94ZW4tcWRpc2suYyBiL2h3L2Jsb2NrL3hlbi1xZGlzay5jCj4gPiA+ID4gaW5kZXggMzVmN2I3 MDQ4MC4uOGM4ODM5MzgzMiAxMDA2NDQKPiA+ID4gPiAtLS0gYS9ody9ibG9jay94ZW4tcWRpc2su Ywo+ID4gPiA+ICsrKyBiL2h3L2Jsb2NrL3hlbi1xZGlzay5jCj4gPiA+ID4gQEAgLTksNiArOSwx MCBAQAo+ID4gPiA+ICAjaW5jbHVkZSAicWFwaS92aXNpdG9yLmgiCj4gPiA+ID4gICNpbmNsdWRl ICJody9ody5oIgo+ID4gPiA+ICAjaW5jbHVkZSAiaHcveGVuL3hlbi1xZGlzay5oIgo+ID4gPiA+ ICsjaW5jbHVkZSAic3lzZW11L2Jsb2NrZGV2LmgiCj4gPiA+ID4gKyNpbmNsdWRlICJzeXNlbXUv YmxvY2stYmFja2VuZC5oIgo+ID4gPiA+ICsjaW5jbHVkZSAic3lzZW11L2lvdGhyZWFkLmgiCj4g PiA+ID4gKyNpbmNsdWRlICJkYXRhcGxhbmUveGVuLXFkaXNrLmgiCj4gPiA+ID4gICNpbmNsdWRl ICJ0cmFjZS5oIgo+ID4gPiA+Cj4gPiA+ID4gIHN0YXRpYyBjaGFyICp4ZW5fcWRpc2tfZ2V0X25h bWUoWGVuRGV2aWNlICp4ZW5kZXYsIEVycm9yICoqZXJycCkKPiA+ID4gPiBAQCAtMjMsNiArMjcs MTEgQEAgc3RhdGljIHZvaWQgeGVuX3FkaXNrX3JlYWxpemUoWGVuRGV2aWNlICp4ZW5kZXYsCj4g PiA+IEVycm9yICoqZXJycCkKPiA+ID4gPiAgewo+ID4gPiA+ICAgICAgWGVuUWRpc2tEZXZpY2Ug KnFkaXNrZGV2ID0gWEVOX1FESVNLX0RFVklDRSh4ZW5kZXYpOwo+ID4gPiA+ICAgICAgWGVuUWRp c2tWZGV2ICp2ZGV2ID0gJnFkaXNrZGV2LT52ZGV2Owo+ID4gPiA+ICsgICAgQmxvY2tDb25mICpj b25mID0gJnFkaXNrZGV2LT5jb25mOwo+ID4gPiA+ICsgICAgRHJpdmVJbmZvICpkaW5mbzsKPiA+ ID4gPiArICAgIGJvb2wgaXNfY2Ryb207Cj4gPiA+ID4gKyAgICB1bnNpZ25lZCBpbnQgaW5mbzsK PiA+ID4gPiArICAgIGludDY0X3Qgc2l6ZTsKPiA+ID4gPgo+ID4gPiA+ICAgICAgaWYgKCF2ZGV2 LT52YWxpZCkgewo+ID4gPiA+ICAgICAgICAgIGVycm9yX3NldGcoZXJycCwgInZkZXYgcHJvcGVy dHkgbm90IHNldCIpOwo+ID4gPiA+IEBAIC0zMCwxMyArMzksMTM0IEBAIHN0YXRpYyB2b2lkIHhl bl9xZGlza19yZWFsaXplKFhlbkRldmljZQo+ICp4ZW5kZXYsCj4gPiA+IEVycm9yICoqZXJycCkK PiA+ID4gPiAgICAgIH0KPiA+ID4gPgo+ID4gPiA+ICAgICAgdHJhY2VfeGVuX3FkaXNrX3JlYWxp emUodmRldi0+ZGlzaywgdmRldi0+cGFydGl0aW9uKTsKPiA+ID4gPiArCj4gPiA+ID4gKyAgICBp ZiAoIWNvbmYtPmJsaykgewo+ID4gPiA+ICsgICAgICAgIGVycm9yX3NldGcoZXJycCwgImRyaXZl IHByb3BlcnR5IG5vdCBzZXQiKTsKPiA+ID4gPiArICAgICAgICByZXR1cm47Cj4gPiA+ID4gKyAg ICB9Cj4gPiA+ID4gKwo+ID4gPiA+ICsgICAgaWYgKCFibGtfaXNfaW5zZXJ0ZWQoY29uZi0+Ymxr KSkgewo+ID4gPiA+ICsgICAgICAgIGVycm9yX3NldGcoZXJycCwgImRldmljZSBuZWVkcyBtZWRp YSwgYnV0IGRyaXZlIGlzIGVtcHR5Iik7Cj4gPiA+ID4gKyAgICAgICAgcmV0dXJuOwo+ID4gPiA+ ICsgICAgfQo+ID4gPgo+ID4gPiBIbSwgdGhlIGNvZGUgYmVsb3cgc3VnZ2VzdHMgdGhhdCB5b3Ug c3VwcG9ydCBDRC1ST01zLiBEb24ndCB5b3Ugd2FudAo+IHRvCj4gPiA+IHN1cHBvcnQgbWVkaWEg Y2hhbmdlIGFzIHdlbGwgdGhlbj8gV2hpY2ggd291bGQgbWVhbiB0aGF0IHlvdSBuZWVkIHRvCj4g PiA+IHN1cHBvcnQgZW1wdHkgZHJpdmVzLgo+ID4KPiA+IFllcywgdGhhdCdzIGEgZ29vZCBwb2lu dC4gSSBzaG91bGQgZ2V0IHJpZCBvZiB0aGF0IGNoZWNrLgo+IAo+IE9yIHJhdGhlciBhcHBseSBp dCBvbmx5IHRvIGhhcmQgZGlza3MuIEFuZCBmb3IgZW1wdHkgQ0RzLCB5b3UnbGwKPiBwcm9iYWJs eSBuZWVkIHRvIGNyZWF0ZSBhbiBlbXB0eSBCbG9ja0JhY2tlbmQgKHRoZSAhY29uZi0+YmxrIGNh c2UpLgo+IEp1c3QgY2hlY2sgdGhlIElERSBhbmQvb3IgU0NTSSBjb2RlIGZvciBjb21wYXJpc29u Lgo+IAo+ID4gPgo+ID4gPiA+ICsgICAgaWYgKCFibGtjb25mX2FwcGx5X2JhY2tlbmRfb3B0aW9u cyhjb25mLCBibGtfaXNfcmVhZF9vbmx5KGNvbmYtCj4gPiA+ID5ibGspLAo+ID4gPiA+ICsgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBmYWxzZSwgZXJycCkpIHsKPiA+ID4g PiArICAgICAgICByZXR1cm47Cj4gPiA+ID4gKyAgICB9Cj4gPiA+ID4gKwo+ID4gPiA+ICsgICAg aWYgKCFibGtjb25mX2dlb21ldHJ5KGNvbmYsIE5VTEwsIDY1NTM1LCAyNTUsIDI1NSwgZXJycCkp IHsKPiA+ID4gPiArICAgICAgICByZXR1cm47Cj4gPiA+ID4gKyAgICB9Cj4gPiA+ID4gKwo+ID4g PiA+ICsgICAgZGluZm8gPSBibGtfbGVnYWN5X2RpbmZvKGNvbmYtPmJsayk7Cj4gPiA+ID4gKyAg ICBpc19jZHJvbSA9IChkaW5mbyAmJiBkaW5mby0+bWVkaWFfY2QpOwo+ID4gPgo+ID4gPiBJdCdz IGNhbGxlZCBsZWdhY3kgZm9yIGEgcmVhc29uLiBEb24ndCB1c2UgdGhpcyBpbiBuZXcgZGV2aWNl cy4KPiA+ID4KPiA+ID4gVGhlIHByb3BlciB3YXkgaXMgdG8gaGF2ZSB0d28gZGlmZmVyZW50IGRl dmljZXMgZm9yIGhhcmQgZGlza3MgYW5kIENEcwo+ID4gPiAobGlrZSBzY3NpLWhkIGFuZCBzY3Np LWNkKS4KPiA+Cj4gPiAuLi5vciBwcmVzdW1hYmx5IEkgY291bGQgaGF2ZSBhIHByb3BlcnR5PyBU aGUgbGVnYWN5IGluaXQgY29kZSBjb3VsZAo+ID4gdGhlbiBzZXQgaXQgYmFzZWQgb24gdGhlIGRy aXZlIGluZm8uCj4gCj4gVGVjaG5pY2FsbHkgeWVzLCBidXQgd2h5IHdvdWxkIHRoYXQgYmUgYSBn b29kIHdheSB0byBtb2RlbCB0aGluZ3M/IEkKPiBtZWFuLCBpdCdzIHRydWUgdGhhdCB4ZW4tcWRp c2sgaXMgbm90IHJlYWwgaGFyZHdhcmUsIGJ1dCBJJ3ZlIG5ldmVyIHNlZW4KPiBhbnkgaGFyZHdh cmUgdGhhdCBoYXMgYSBzd2l0Y2ggdG8gZGVjaWRlIHdoZXRoZXIgaXQgc2hvdWxkIGJlaGF2ZSBh cyBhCj4gQ0QgZHJpdmUgb3IgYSBoYXJkIGRpc2suCj4gCj4gQm90aCBoYXZlIHZlcnkgZGlmZmVy ZW50IGNoYXJhY3RlcmlzdGljcyAocmVhZC1vbmx5IHdpdGggcmVtb3ZhYmxlCj4gbWVkaWEsIG9y IGEgc2luZ2xlIHJlYWQtd3JpdGUgZGlzayksIGFuZCB0aGUgZXhpc3RpbmcgaW1wbGVtZW50YXRp b25zCj4gdXNlIHR3byBzZXBhcmF0ZSBkZXZpY2VzLiBTbyBldmVuIGlmIHlvdSdyZSBub3QgY29u dmluY2VkIHRoYXQgdXNlcnMKPiB3aWxsIGNvbnNpZGVyIHRoZW0gZGlmZmVyZW50IGNvbmNlcHRz IChJIGFtOyBhbmQgaWYgdGhleSB3ZXJlbid0Cj4gZGlmZmVyZW50IGNvbmNlcHRzLCB5b3Ugd291 bGRuJ3QgbmVlZCBhbiBpc19jZHJvbSB2YXJpYWJsZSksIGNvbnNpc3RlbmN5Cj4gaXMgc3RpbGwg YSBnb29kIHRoaW5nLgoKT2suIEknbGwgc3BsaXQgdGhlIGRldmljZSBhcyB5b3Ugc3VnZ2VzdC4u LiBpdCBtYXkgbWVhbiBkdXBsaWNhdGVkIGNvZGUsIGJ1dCB0aGUgZGF0YXBhdGggY2FuIHN0aWxs IGJlIGNvbW1vbi4KCiAgUGF1bAoKPiAKPiBLZXZpbgoKX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX18KWGVuLWRldmVsIG1haWxpbmcgbGlzdApYZW4tZGV2ZWxA bGlzdHMueGVucHJvamVjdC5vcmcKaHR0cHM6Ly9saXN0cy54ZW5wcm9qZWN0Lm9yZy9tYWlsbWFu L2xpc3RpbmZvL3hlbi1kZXZlbA==