From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932711AbeARPX5 (ORCPT ); Thu, 18 Jan 2018 10:23:57 -0500 Received: from mail-wm0-f67.google.com ([74.125.82.67]:38583 "EHLO mail-wm0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932573AbeARPX4 (ORCPT ); Thu, 18 Jan 2018 10:23:56 -0500 X-Google-Smtp-Source: ACJfBouw2tqCYEJiMwAwRdCi8MBxf0y3R2nciw19iIuU7FBn0+8z4H1e+1447nq+6b/Z0kxi6xjEjg== Subject: Re: [PATCH V5 1/2] nvme-pci: introduce RECONNECTING state to mark initializing procedure To: Jianchao Wang , keith.busch@intel.com, axboe@fb.com, hch@lst.de, sagi@grimberg.me, maxg@mellanox.com Cc: linux-nvme@lists.infradead.org, linux-kernel@vger.kernel.org References: <1516270202-8051-1-git-send-email-jianchao.w.wang@oracle.com> <1516270202-8051-2-git-send-email-jianchao.w.wang@oracle.com> From: James Smart Message-ID: Date: Thu, 18 Jan 2018 07:23:50 -0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.5.2 MIME-Version: 1.0 In-Reply-To: <1516270202-8051-2-git-send-email-jianchao.w.wang@oracle.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Content-Language: en-US Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 1/18/2018 2:10 AM, Jianchao Wang wrote: > After Sagi's commit (nvme-rdma: fix concurrent reset and reconnect), > both nvme-fc/rdma have following pattern: > RESETTING - quiesce blk-mq queues, teardown and delete queues/ > connections, clear out outstanding IO requests... > RECONNECTING - establish new queues/connections and some other > initializing things. > Introduce RECONNECTING to nvme-pci transport to do the same mark. > Then we get a coherent state definition among nvme pci/rdma/fc > transports. > > Suggested-by: James Smart > Signed-off-by: Jianchao Wang > --- > drivers/nvme/host/core.c | 2 +- > drivers/nvme/host/pci.c | 19 +++++++++++++++++-- > 2 files changed, 18 insertions(+), 3 deletions(-) > Reviewed-by: James Smart  From mboxrd@z Thu Jan 1 00:00:00 1970 From: james.smart@broadcom.com (James Smart) Date: Thu, 18 Jan 2018 07:23:50 -0800 Subject: [PATCH V5 1/2] nvme-pci: introduce RECONNECTING state to mark initializing procedure In-Reply-To: <1516270202-8051-2-git-send-email-jianchao.w.wang@oracle.com> References: <1516270202-8051-1-git-send-email-jianchao.w.wang@oracle.com> <1516270202-8051-2-git-send-email-jianchao.w.wang@oracle.com> Message-ID: On 1/18/2018 2:10 AM, Jianchao Wang wrote: > After Sagi's commit (nvme-rdma: fix concurrent reset and reconnect), > both nvme-fc/rdma have following pattern: > RESETTING - quiesce blk-mq queues, teardown and delete queues/ > connections, clear out outstanding IO requests... > RECONNECTING - establish new queues/connections and some other > initializing things. > Introduce RECONNECTING to nvme-pci transport to do the same mark. > Then we get a coherent state definition among nvme pci/rdma/fc > transports. > > Suggested-by: James Smart > Signed-off-by: Jianchao Wang > --- > drivers/nvme/host/core.c | 2 +- > drivers/nvme/host/pci.c | 19 +++++++++++++++++-- > 2 files changed, 18 insertions(+), 3 deletions(-) > Reviewed-by: James Smart?