From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id BC7BEC433F5 for ; Tue, 10 May 2022 06:52:26 +0000 (UTC) Received: from list by lists.xenproject.org with outflank-mailman.325252.547747 (Exim 4.92) (envelope-from ) id 1noJjE-0002o9-24; Tue, 10 May 2022 06:52:16 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 325252.547747; Tue, 10 May 2022 06:52:16 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1noJjD-0002o2-VO; Tue, 10 May 2022 06:52:15 +0000 Received: by outflank-mailman (input) for mailman id 325252; Tue, 10 May 2022 06:52:14 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1noJjC-0002nw-FE for xen-devel@lists.xenproject.org; Tue, 10 May 2022 06:52:14 +0000 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by se1-gles-flk1.inumbo.com (Halon) with ESMTP id b2236eb0-d02d-11ec-8fc4-03012f2f19d4; Tue, 10 May 2022 08:52:02 +0200 (CEST) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id D0EE513D5; Mon, 9 May 2022 23:52:12 -0700 (PDT) Received: from [10.57.3.29] (unknown [10.57.3.29]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 118063F73D; Mon, 9 May 2022 23:52:10 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: b2236eb0-d02d-11ec-8fc4-03012f2f19d4 Message-ID: Date: Tue, 10 May 2022 08:52:04 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.8.1 Subject: Re: [PATCH v2 1/2] xen/arm: gnttab: use static inlines for gnttab_{release_}host_mapping* Content-Language: en-US To: Jan Beulich Cc: Stefano Stabellini , Julien Grall , Bertrand Marquis , Volodymyr Babchuk , xen-devel@lists.xenproject.org References: <20220506094225.181815-1-michal.orzel@arm.com> <20220506094225.181815-2-michal.orzel@arm.com> From: Michal Orzel In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Hi Jan, On 06.05.2022 12:03, Jan Beulich wrote: > On 06.05.2022 11:42, Michal Orzel wrote: >> Function unmap_common_complete (common/grant_table.c) defines and sets >> a variable ld that is later on passed to a macro: >> gnttab_host_mapping_get_page_type(). >> On Arm this macro does not make use of any arguments causing a compiler >> to warn about unused-but-set variable (when -Wunused-but-set-variable >> is enabled). Fix it by converting this macro to a static inline >> helper and using the boolean return type. >> >> While there, also convert macro gnttab_release_host_mappings. >> >> Signed-off-by: Michal Orzel >> Reviewed-by: Jan Beulich > > This R-b applies only ... > >> --- a/xen/arch/arm/include/asm/grant_table.h >> +++ b/xen/arch/arm/include/asm/grant_table.h >> @@ -29,12 +29,22 @@ static inline void gnttab_mark_dirty(struct domain *d, mfn_t mfn) >> #endif >> } >> >> +static inline bool gnttab_host_mapping_get_page_type(const bool ro, > > ... with this const dropped again. As said elsewhere, while not > technically wrong we don't normally do so elsewhere, and this ends > up inconsistent with ... > >> + const struct domain *ld, >> + const struct domain *rd) > > ... there being just a single const here. > > Jan > Do you have any remarks related to the second patch in this series? If yes, I will handle removal of const in the next version. If not, Julien said in v1 that this can be handled on commit. Cheers, Michal