From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 18F00CCA47C for ; Tue, 7 Jun 2022 18:03:02 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1349367AbiFGSC7 (ORCPT ); Tue, 7 Jun 2022 14:02:59 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55850 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1351009AbiFGSBf (ORCPT ); Tue, 7 Jun 2022 14:01:35 -0400 X-Greylist: delayed 73037 seconds by postgrey-1.37 at lindbergh.monkeyblade.net; Tue, 07 Jun 2022 10:43:52 PDT Received: from madras.collabora.co.uk (madras.collabora.co.uk [46.235.227.172]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0F0D214E95E for ; Tue, 7 Jun 2022 10:43:52 -0700 (PDT) Received: from [IPV6:2804:431:c7c2:5159:3412:12e6:5871:933a] (unknown [IPv6:2804:431:c7c2:5159:3412:12e6:5871:933a]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: dwlsalmeida) by madras.collabora.co.uk (Postfix) with ESMTPSA id E629066018EF; Tue, 7 Jun 2022 18:43:48 +0100 (BST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1654623830; bh=XdQ/FSeGh6ngxNT+8I/J3ys8wUnwdExr8I5FrgdXMS4=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=oaTzbREp5eLgV8nrUmOWeOiFa6l5s66yB4FcRAVujicFfyFwgQyFYXEg2FCnQa8ep IVxFj143fRwaesSVU6fS0SBhBfBJVZyOgscR0nc9x+aJeoxT8QM3YDDPewuKS1pos2 XpU0EjNu1fOPO9DxXaX7Fclqr0vYzQ8fwmLMQEFSbm1GwOU9Y3rnQa+Gwbzi4wMr6/ iUrNJq2VRbW3/EagbUT3UBpNjZAZIojST6BVhlPhxeQ/JLg/yVJLZyTv3FdypcJLaQ HR4a/wIPl6qjvyjwpdE3ZgPV63wTWFva+5gt4lfkPSFk8EMlgWQKzGF34gMqCvmj49 oaqk5niKRHBxQ== Message-ID: Date: Tue, 7 Jun 2022 14:43:44 -0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.9.1 Subject: Re: [RFC PATCH v2] media: Add AV1 uAPI Content-Language: en-US To: Steve Cho Cc: hverkuil@xs4all.nl, linux-media@vger.kernel.org, Nicolas Dufresne References: <20220322160101.620748-1-daniel.almeida@collabora.com> From: Daniel Almeida In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org Hi Steve. > > Question about update_ref_delta, update_mode_delta flags for loop > filter params in the spec. > > > > I don't see these flags in v4l2_av1_loop_filter struct. > > > > After looking at gstreamer implementation, I think arrays ref_deltas, > mode_deltas are only filled in when these flags are 1. > > > > Is this correct understanding? > > If not, can you explain the background why these flags are omitted? > > Possibly forgotten. Will fix in RFC v3. I looked into this issue again. Apparently the other codec APIs do not convey these flags either. Let's wait until we get a second driver to see whether they will be necessary. -- Daniel