From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C5F47C433E6 for ; Thu, 11 Mar 2021 23:27:41 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 90FDD64F94 for ; Thu, 11 Mar 2021 23:27:41 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231352AbhCKX1K (ORCPT ); Thu, 11 Mar 2021 18:27:10 -0500 Received: from mail.kernel.org ([198.145.29.99]:55950 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229441AbhCKX06 (ORCPT ); Thu, 11 Mar 2021 18:26:58 -0500 Received: by mail.kernel.org (Postfix) with ESMTPSA id 266B464F92; Thu, 11 Mar 2021 23:26:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1615505217; bh=muPWX0Eq0pYxdUFY28jWi+rGMz0Zydt8/SQ82W/z3so=; h=Subject:From:To:Cc:Date:In-Reply-To:References:From; b=nOCXmdDd4W8iPpCd/c2YLLaPr7trLnJAypKblgP0h/KQ2jnH75dP8zJIAHXHjpCch orGeYVHwTQiYg3lsyL34m2hu1tIQvqszSlPkNltgKV1LKj8v2Jwie8vpIYs+B3k2Bp qSxRNurUwUQOgkWIGyN2qZHqSUFao+bx86RM1WkxQzWHlXmTHcGPC8lXxfCK0Mvcz/ +eE5iL8eHhuXmURBggTvuk63LFeZ/41r9D43BNddBKD3KSlY9SizA6+hTLfBscebgu nq2JbdzTu6GmDASoplvHqyt+t4JikVo3CSqc8BpmUIAeGV8v1o0ppXTBhVmfpPzfLN 14gRe7ig2FZJQ== Message-ID: Subject: Re: [PATCH] net/mlx5: use kvfree() for memory allocated with kvzalloc() From: Saeed Mahameed To: Roi Dayan , angkery , leon@kernel.org, davem@davemloft.net, kuba@kernel.org, vladbu@nvidia.com, dlinkin@nvidia.com, dan.carpenter@oracle.com Cc: netdev@vger.kernel.org, linux-rdma@vger.kernel.org, linux-kernel@vger.kernel.org, Junlin Yang Date: Thu, 11 Mar 2021 15:26:56 -0800 In-Reply-To: <0c195a3a-53cc-dbd2-f656-54a92e5a569b@nvidia.com> References: <20210303024019.2245-1-angkery@163.com> <0c195a3a-53cc-dbd2-f656-54a92e5a569b@nvidia.com> Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.38.4 (3.38.4-1.fc33) MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-rdma@vger.kernel.org On Wed, 2021-03-03 at 09:54 +0200, Roi Dayan wrote: > > > On 2021-03-03 4:40 AM, angkery wrote: > > From: Junlin Yang > > > > It is allocated with kvzalloc(), the corresponding release function > > should not be kfree(), use kvfree() instead. > > > > Generated by: scripts/coccinelle/api/kfree_mismatch.cocci > > > > Signed-off-by: Junlin Yang > > --- > >   drivers/net/ethernet/mellanox/mlx5/core/esw/indir_table.c | 10 > > +++++----- > >   1 file changed, 5 insertions(+), 5 deletions(-) > > > > diff --git > > a/drivers/net/ethernet/mellanox/mlx5/core/esw/indir_table.c > > b/drivers/net/ethernet/mellanox/mlx5/core/esw/indir_table.c > > index 6f6772b..3da7bec 100644 > > --- a/drivers/net/ethernet/mellanox/mlx5/core/esw/indir_table.c > > +++ b/drivers/net/ethernet/mellanox/mlx5/core/esw/indir_table.c > > @@ -248,7 +248,7 @@ static int mlx5_esw_indir_table_rule_get(struct > > mlx5_eswitch *esw, > >   err_ethertype: > >         kfree(rule); > >   out: > > -       kfree(rule_spec); > > +       kvfree(rule_spec); > >         return err; > >   } > >   > > @@ -328,7 +328,7 @@ static int > > mlx5_create_indir_recirc_group(struct mlx5_eswitch *esw, > >         e->recirc_cnt = 0; > >   > >   out: > > -       kfree(in); > > +       kvfree(in); > >         return err; > >   } > >   > > @@ -347,7 +347,7 @@ static int mlx5_create_indir_fwd_group(struct > > mlx5_eswitch *esw, > >   > >         spec = kvzalloc(sizeof(*spec), GFP_KERNEL); > >         if (!spec) { > > -               kfree(in); > > +               kvfree(in); > >                 return -ENOMEM; > >         } > >   > > @@ -371,8 +371,8 @@ static int mlx5_create_indir_fwd_group(struct > > mlx5_eswitch *esw, > >         } > >   > >   err_out: > > -       kfree(spec); > > -       kfree(in); > > +       kvfree(spec); > > +       kvfree(in); > >         return err; > >   } > >   > > > > thanks! > > Reviewed-by: Roi Dayan > applied to net-next-mlx5