From: "Saleem, Shiraz" <shiraz.saleem@intel.com>
To: coverity-bot <keescook@chromium.org>,
"Ismail, Mustafa" <mustafa.ismail@intel.com>,
"Nikolova, Tatyana E" <tatyana.e.nikolova@intel.com>
Cc: Jason Gunthorpe <jgg@nvidia.com>,
"Gustavo A. R. Silva" <gustavo@embeddedor.com>,
"linux-next@vger.kernel.org" <linux-next@vger.kernel.org>
Subject: RE: Coverity: irdma_prm_get_pbles(): Integer handling issues
Date: Tue, 15 Jun 2021 15:58:57 +0000 [thread overview]
Message-ID: <be18ddbbac97471ca9e7b5f80e8a9cd9@intel.com> (raw)
In-Reply-To: <202106081101.0D7C450C@keescook>
> Subject: Coverity: irdma_prm_get_pbles(): Integer handling issues
>
> Hello!
>
> This is an experimental semi-automated report about issues detected by Coverity
> from a scan of next-20210608 as part of the linux-next scan project:
> https://scan.coverity.com/projects/linux-next-weekly-scan
>
> You're getting this email because you were associated with the identified lines of
> code (noted below) that were touched by commits:
>
> Wed Jun 2 19:55:19 2021 -0300
> 915cc7ac0f8e ("RDMA/irdma: Add miscellaneous utility definitions")
>
> Coverity reported the following:
>
> *** CID 1505157: Integer handling issues (OVERFLOW_BEFORE_WIDEN)
> /drivers/infiniband/hw/irdma/utils.c: 2329 in irdma_prm_get_pbles()
> 2323 struct list_head *chunk_entry = pprm->clist.next;
> 2324 u32 offset;
> 2325 unsigned long flags;
> 2326 *vaddr = 0;
> 2327 *fpm_addr = 0;
> 2328
> vvv CID 1505157: Integer handling issues (OVERFLOW_BEFORE_WIDEN)
> vvv Potentially overflowing expression "1 << pprm->pble_shift" with type "int"
> (32 bits, signed) is evaluated using 32-bit arithmetic, and then used in a context
> that expects an expression of type "u64" (64 bits, unsigned).
> 2329 bits_needed = (mem_size + (1 << pprm->pble_shift) - 1) >> pprm-
> >pble_shift;
> 2330
> 2331 spin_lock_irqsave(&pprm->prm_lock, flags);
> 2332 while (chunk_entry != &pprm->clist) {
> 2333 pchunk = (struct irdma_chunk *)chunk_entry;
> 2334 bit_idx = bitmap_find_next_zero_area(pchunk->bitmapbuf,
>
> If this is a false positive, please let us know so we can mark it as such, or teach
> the Coverity rules to be smarter. If not, please make sure fixes get into linux-next.
> :) For patches fixing this, please include these lines (but double-check the "Fixes"
> first):
>
> Reported-by: coverity-bot <keescook+coverity-bot@chromium.org>
> Addresses-Coverity-ID: 1505157 ("Integer handling issues")
> Fixes: 915cc7ac0f8e ("RDMA/irdma: Add miscellaneous utility definitions")
>
> Thanks for your attention!
This appears to be a bug. We will send a fix.
Shiraz
prev parent reply other threads:[~2021-06-15 16:00 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-08 18:01 Coverity: irdma_prm_get_pbles(): Integer handling issues coverity-bot
2021-06-15 15:58 ` Saleem, Shiraz [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=be18ddbbac97471ca9e7b5f80e8a9cd9@intel.com \
--to=shiraz.saleem@intel.com \
--cc=gustavo@embeddedor.com \
--cc=jgg@nvidia.com \
--cc=keescook@chromium.org \
--cc=linux-next@vger.kernel.org \
--cc=mustafa.ismail@intel.com \
--cc=tatyana.e.nikolova@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.