From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8098CC433F5 for ; Tue, 26 Oct 2021 16:12:27 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 5EB9B60527 for ; Tue, 26 Oct 2021 16:12:27 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237241AbhJZQOr (ORCPT ); Tue, 26 Oct 2021 12:14:47 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]:27829 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235340AbhJZQOp (ORCPT ); Tue, 26 Oct 2021 12:14:45 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1635264741; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=y/8qPSuga2nSdD4ObnPRjMzoPwBrPBTCysCx0s1aic4=; b=HXeh27CV8hJRaETDK6hQOpnP45k3CVN3SmEZGClNq7UYeHDti1sMQE40Q9KP2PP6tyaQ2I orJVQXxUk8U1XN2n6u+a3epp9C/dCkhT5MuzOp8x/Js6W5Za41+LrdIs+yGwZJjYq0362v 79f1/BmEa6EFyJMmnSf2RTCKnOJQnls= Received: from mail-ed1-f69.google.com (mail-ed1-f69.google.com [209.85.208.69]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-143-_e0-_2_BMsivapR_nWGHQw-1; Tue, 26 Oct 2021 12:12:19 -0400 X-MC-Unique: _e0-_2_BMsivapR_nWGHQw-1 Received: by mail-ed1-f69.google.com with SMTP id f21-20020a0564021e9500b003dd77985601so3372020edf.9 for ; Tue, 26 Oct 2021 09:12:19 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=y/8qPSuga2nSdD4ObnPRjMzoPwBrPBTCysCx0s1aic4=; b=2lsXTs2EaHPow8FanpB+/Y287FZBXp1wU7ORVSJblo+Cps5Nh+9b04gHQ3TF2Wzw+O 14qpj5UQETdUpiSbWOoEDdS/VqXj9s6U1l0NW5VlSzEah01ZHUt6x85BiGfJfihbd+gV JH3eAuidRJircaeuKH+QsjoNfT9JrmL9SXrwWvM9lqaga1H7pKR4en8meHa4ZyvdTcCt zv/ti2Zjlh4V38aqAIPE70IdyU3lQ2tAU0pXTTvt0EnGnp/hby3QBcPe65cE+9rLuZcK i44F29gQ5VYkVw8g2GT/FMOkWa2BQqO2QLMDZv6SvCsgy57IJvwh6m4oWk1tlg59ffu6 zl0A== X-Gm-Message-State: AOAM531o6RALE9mu2MxBcEGSTvLR2D6/ui8I16UBKyCjJES4b7BMqXPP vntw+fkA67NRSnJ/IeCwzfAwMcXIU+8eSGoXhzCOajPWZ2/3XpMzuuMcE0h4ZC2NPJKKvmpBVL5 iSyh7apsbLq//mQ0+OzdYIdyT X-Received: by 2002:aa7:da84:: with SMTP id q4mr36991757eds.371.1635264738786; Tue, 26 Oct 2021 09:12:18 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwASeQAxYa4SVxx7fzZJcK2OTnFNOTNNHLf+PErJyPRemx/Rf7LwxYWqAfn33dB1Qf24eGGDw== X-Received: by 2002:aa7:da84:: with SMTP id q4mr36991714eds.371.1635264738510; Tue, 26 Oct 2021 09:12:18 -0700 (PDT) Received: from ?IPV6:2001:b07:6468:f312:c8dd:75d4:99ab:290a? ([2001:b07:6468:f312:c8dd:75d4:99ab:290a]) by smtp.gmail.com with ESMTPSA id n1sm4753815edf.45.2021.10.26.09.12.11 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 26 Oct 2021 09:12:17 -0700 (PDT) Message-ID: Date: Tue, 26 Oct 2021 18:12:06 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.1.0 Subject: Re: [PATCH v2 10/43] KVM: arm64: Move vGIC v4 handling for WFI out arch callback hook Content-Language: en-US To: Marc Zyngier Cc: Sean Christopherson , Huacai Chen , Aleksandar Markovic , Paul Mackerras , Anup Patel , Paul Walmsley , Palmer Dabbelt , Albert Ou , Christian Borntraeger , Janosch Frank , James Morse , Alexandru Elisei , Suzuki K Poulose , Atish Patra , David Hildenbrand , Cornelia Huck , Claudio Imbrenda , Vitaly Kuznetsov , Wanpeng Li , Jim Mattson , Joerg Roedel , linux-arm-kernel@lists.infradead.org, kvmarm@lists.cs.columbia.edu, linux-mips@vger.kernel.org, kvm@vger.kernel.org, kvm-ppc@vger.kernel.org, kvm-riscv@lists.infradead.org, linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org, David Matlack , Oliver Upton , Jing Zhang References: <20211009021236.4122790-1-seanjc@google.com> <20211009021236.4122790-11-seanjc@google.com> <9236e715-c471-e1c8-6117-6f37b908a6bd@redhat.com> <875ytjbxpq.wl-maz@kernel.org> From: Paolo Bonzini In-Reply-To: <875ytjbxpq.wl-maz@kernel.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 26/10/21 17:41, Marc Zyngier wrote: >> This needs a word on why kvm_psci_vcpu_suspend does not need the >> hooks. Or it needs to be changed to also use kvm_vcpu_wfi in the PSCI >> code, I don't know. >> >> Marc, can you review and/or advise? > I was looking at that over the weekend, and that's a pre-existing > bug. I would have addressed it independently, but it looks like you > already have queued the patch. I have "queued" it, but that's just my queue - it's not on kernel.org and it's not going to be in 5.16, at least not in the first batch. There's plenty of time for me to rebase on top of a fix, if you want to send the fix through your kvm-arm pull request. Just Cc me so that I understand what's going on. Thanks, Paolo From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D734BC433EF for ; Tue, 26 Oct 2021 16:12:26 +0000 (UTC) Received: from mm01.cs.columbia.edu (mm01.cs.columbia.edu [128.59.11.253]) by mail.kernel.org (Postfix) with ESMTP id 5813660527 for ; Tue, 26 Oct 2021 16:12:26 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 5813660527 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.cs.columbia.edu Received: from localhost (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id C8A144B0D0; Tue, 26 Oct 2021 12:12:25 -0400 (EDT) X-Virus-Scanned: at lists.cs.columbia.edu Authentication-Results: mm01.cs.columbia.edu (amavisd-new); dkim=softfail (fail, message has been altered) header.i=@redhat.com Received: from mm01.cs.columbia.edu ([127.0.0.1]) by localhost (mm01.cs.columbia.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id bVNo8tCuK3vJ; Tue, 26 Oct 2021 12:12:24 -0400 (EDT) Received: from mm01.cs.columbia.edu (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id 9A5AD4A534; Tue, 26 Oct 2021 12:12:24 -0400 (EDT) Received: from localhost (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id 256DE4A49C for ; Tue, 26 Oct 2021 12:12:23 -0400 (EDT) X-Virus-Scanned: at lists.cs.columbia.edu Received: from mm01.cs.columbia.edu ([127.0.0.1]) by localhost (mm01.cs.columbia.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 35WlOvfB+fyL for ; Tue, 26 Oct 2021 12:12:21 -0400 (EDT) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mm01.cs.columbia.edu (Postfix) with ESMTP id DC67A4A3BF for ; Tue, 26 Oct 2021 12:12:21 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1635264741; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=y/8qPSuga2nSdD4ObnPRjMzoPwBrPBTCysCx0s1aic4=; b=HXeh27CV8hJRaETDK6hQOpnP45k3CVN3SmEZGClNq7UYeHDti1sMQE40Q9KP2PP6tyaQ2I orJVQXxUk8U1XN2n6u+a3epp9C/dCkhT5MuzOp8x/Js6W5Za41+LrdIs+yGwZJjYq0362v 79f1/BmEa6EFyJMmnSf2RTCKnOJQnls= Received: from mail-ed1-f70.google.com (mail-ed1-f70.google.com [209.85.208.70]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-34-w5TawSx-MziT0siX2VBZhw-1; Tue, 26 Oct 2021 12:12:20 -0400 X-MC-Unique: w5TawSx-MziT0siX2VBZhw-1 Received: by mail-ed1-f70.google.com with SMTP id k28-20020a508adc000000b003dd5e21da4bso5905230edk.11 for ; Tue, 26 Oct 2021 09:12:19 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=y/8qPSuga2nSdD4ObnPRjMzoPwBrPBTCysCx0s1aic4=; b=AJgmPsb8TE/jM+1mZDJ1npUXKx98uek3dApKGd2/QwbLDNrRZLmfR/hvtimiQqYVt7 gWKDdIVTyJOhCom7bRTWpsMAPZ4QizouXQfDBjSRQFKHQ70DtVFUXTdoCMbFnZxSNz6k kXS5T5gbVaqzrkvbRZ/01FRCQHkjC5n/zpXvWFr976u5ZP7HbsAIiuPOg6LhYd9LiYG+ pRY++JqJW+/1ozt5NTPZESPHTn2y8NZTAsYpkcJ+pbV3EaZUPPZE2ntrpVO5a1SGGD6e EcTiPyrz1t+hxL7hLCIxnH17LGIDtJVHr2j1/30XswqxV5yxspN0Xc9v7GqTaAxbWRFX JsOg== X-Gm-Message-State: AOAM533Mu8w8fRdhaq5Tm4jmicp8U1sWDIF0nsbV2RUJByjmA30uFSMD dxFUyh8bhiq5oSdNiNaXfpeHPbWDNUU8VyQS1aoIC0kenkuxFcrlHatc4em4YRUMLGj4y2VnajS MyCFJ0PJDoTY+jUvBcul1b5bG X-Received: by 2002:aa7:da84:: with SMTP id q4mr36991777eds.371.1635264738790; Tue, 26 Oct 2021 09:12:18 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwASeQAxYa4SVxx7fzZJcK2OTnFNOTNNHLf+PErJyPRemx/Rf7LwxYWqAfn33dB1Qf24eGGDw== X-Received: by 2002:aa7:da84:: with SMTP id q4mr36991714eds.371.1635264738510; Tue, 26 Oct 2021 09:12:18 -0700 (PDT) Received: from ?IPV6:2001:b07:6468:f312:c8dd:75d4:99ab:290a? ([2001:b07:6468:f312:c8dd:75d4:99ab:290a]) by smtp.gmail.com with ESMTPSA id n1sm4753815edf.45.2021.10.26.09.12.11 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 26 Oct 2021 09:12:17 -0700 (PDT) Message-ID: Date: Tue, 26 Oct 2021 18:12:06 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.1.0 Subject: Re: [PATCH v2 10/43] KVM: arm64: Move vGIC v4 handling for WFI out arch callback hook To: Marc Zyngier References: <20211009021236.4122790-1-seanjc@google.com> <20211009021236.4122790-11-seanjc@google.com> <9236e715-c471-e1c8-6117-6f37b908a6bd@redhat.com> <875ytjbxpq.wl-maz@kernel.org> From: Paolo Bonzini In-Reply-To: <875ytjbxpq.wl-maz@kernel.org> Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=pbonzini@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Cc: Cornelia Huck , Wanpeng Li , kvm@vger.kernel.org, David Hildenbrand , linux-kernel@vger.kernel.org, Paul Mackerras , Atish Patra , linux-riscv@lists.infradead.org, Claudio Imbrenda , kvmarm@lists.cs.columbia.edu, Janosch Frank , Joerg Roedel , Huacai Chen , Christian Borntraeger , Aleksandar Markovic , Albert Ou , kvm-ppc@vger.kernel.org, Paul Walmsley , David Matlack , linux-arm-kernel@lists.infradead.org, Jim Mattson , Anup Patel , linux-mips@vger.kernel.org, Palmer Dabbelt , kvm-riscv@lists.infradead.org, Vitaly Kuznetsov X-BeenThere: kvmarm@lists.cs.columbia.edu X-Mailman-Version: 2.1.14 Precedence: list List-Id: Where KVM/ARM decisions are made List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: kvmarm-bounces@lists.cs.columbia.edu Sender: kvmarm-bounces@lists.cs.columbia.edu On 26/10/21 17:41, Marc Zyngier wrote: >> This needs a word on why kvm_psci_vcpu_suspend does not need the >> hooks. Or it needs to be changed to also use kvm_vcpu_wfi in the PSCI >> code, I don't know. >> >> Marc, can you review and/or advise? > I was looking at that over the weekend, and that's a pre-existing > bug. I would have addressed it independently, but it looks like you > already have queued the patch. I have "queued" it, but that's just my queue - it's not on kernel.org and it's not going to be in 5.16, at least not in the first batch. There's plenty of time for me to rebase on top of a fix, if you want to send the fix through your kvm-arm pull request. Just Cc me so that I understand what's going on. Thanks, Paolo _______________________________________________ kvmarm mailing list kvmarm@lists.cs.columbia.edu https://lists.cs.columbia.edu/mailman/listinfo/kvmarm From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A8013C433FE for ; Tue, 26 Oct 2021 16:19:23 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 66AF3603E9 for ; Tue, 26 Oct 2021 16:19:23 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 66AF3603E9 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To:Subject: MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=8NhZNkWHURpWJC0ThsGf01GAZprZiN+uGXuUO893onQ=; b=DRcS+VkosAbyZ3 1LZ9fSA+Iq2BwAflyh6rBmPyFcanyjNCYBWVYZaIhTnZUBfhgbdi+YvcH9qXRdaBryp0xKLtPj5g/ wFZ/4p9ttq4FywPAf6mk9cN1pYzt3iEI+BdJXL7UXjZUQ5tIbeX9LiKRPKFM4uTkyM6DZ5JHjoDOo +QFUzx+1M8D5jsJKdxpyFfybNqG6b6sG5vpyUPBkchT5d5wyOJBRTxjpuJ81rX1cnryuaq96ENuVR 3aGQzAsJEDw0swXFpkF2h24MxVq5FOMj0kQxmBarsvBejaWERNwBVDdSRJkhOJRc/MJgn+orYkSCF nvoC4h79/QCa3yJdqWvw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mfPAQ-002RK5-3r; Tue, 26 Oct 2021 16:19:14 +0000 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mfP3o-002NME-3k for linux-riscv@lists.infradead.org; Tue, 26 Oct 2021 16:12:25 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1635264741; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=y/8qPSuga2nSdD4ObnPRjMzoPwBrPBTCysCx0s1aic4=; b=HXeh27CV8hJRaETDK6hQOpnP45k3CVN3SmEZGClNq7UYeHDti1sMQE40Q9KP2PP6tyaQ2I orJVQXxUk8U1XN2n6u+a3epp9C/dCkhT5MuzOp8x/Js6W5Za41+LrdIs+yGwZJjYq0362v 79f1/BmEa6EFyJMmnSf2RTCKnOJQnls= Received: from mail-ed1-f72.google.com (mail-ed1-f72.google.com [209.85.208.72]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-451-_fBb2WnbN7GEthQvB_BA4Q-1; Tue, 26 Oct 2021 12:12:20 -0400 X-MC-Unique: _fBb2WnbN7GEthQvB_BA4Q-1 Received: by mail-ed1-f72.google.com with SMTP id t1-20020a056402524100b003dd9a419eb5so1792951edd.4 for ; Tue, 26 Oct 2021 09:12:19 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=y/8qPSuga2nSdD4ObnPRjMzoPwBrPBTCysCx0s1aic4=; b=BnaNgMfBDULBN9okKooEHdNTGjiYumQPiz0wW3sCbbEYN77xz2iPABNdEL84PUT9IC q4LuCjS/9QJQANARSu0PohYiRv39YDlYiRGFpmQsuMlg7nNRRJ7em6MD2kIQsKMB4Egw TqQMxWh6xj6IfwxUsO1sEGWJ7zYtF0QYHMfjAGXwfyd6CCA63aGf6luL9dX17AIrGmOm nvsjjS4GCQS9gf8ESHdcjczrvqGd4mSfCzfGWCF9VCeJc8yk+KOi0CAGB8HJFt354W+S x0elR3d8BP6OSht6kWV3kkXZyla9+zn/HLn/18QZ8hmBCSv4RjplO7/F6vja16sU9CAQ u7UA== X-Gm-Message-State: AOAM533MIufC7Sk3YKWJ6g29k0wt2Jys1SaHYlotT8Vh+9dgIL5kqA/K u6i1ESwDV2dkQbU0BhCNPAdyweY4NfndG9RybMV0LUKGbpy9hKqqHSnlN8nzlvqVrQjZioHQawO fzdSdcULCT8o32pdGCSuftNjwDm+8 X-Received: by 2002:aa7:da84:: with SMTP id q4mr36991781eds.371.1635264738791; Tue, 26 Oct 2021 09:12:18 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwASeQAxYa4SVxx7fzZJcK2OTnFNOTNNHLf+PErJyPRemx/Rf7LwxYWqAfn33dB1Qf24eGGDw== X-Received: by 2002:aa7:da84:: with SMTP id q4mr36991714eds.371.1635264738510; Tue, 26 Oct 2021 09:12:18 -0700 (PDT) Received: from ?IPV6:2001:b07:6468:f312:c8dd:75d4:99ab:290a? ([2001:b07:6468:f312:c8dd:75d4:99ab:290a]) by smtp.gmail.com with ESMTPSA id n1sm4753815edf.45.2021.10.26.09.12.11 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 26 Oct 2021 09:12:17 -0700 (PDT) Message-ID: Date: Tue, 26 Oct 2021 18:12:06 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.1.0 Subject: Re: [PATCH v2 10/43] KVM: arm64: Move vGIC v4 handling for WFI out arch callback hook To: Marc Zyngier Cc: Sean Christopherson , Huacai Chen , Aleksandar Markovic , Paul Mackerras , Anup Patel , Paul Walmsley , Palmer Dabbelt , Albert Ou , Christian Borntraeger , Janosch Frank , James Morse , Alexandru Elisei , Suzuki K Poulose , Atish Patra , David Hildenbrand , Cornelia Huck , Claudio Imbrenda , Vitaly Kuznetsov , Wanpeng Li , Jim Mattson , Joerg Roedel , linux-arm-kernel@lists.infradead.org, kvmarm@lists.cs.columbia.edu, linux-mips@vger.kernel.org, kvm@vger.kernel.org, kvm-ppc@vger.kernel.org, kvm-riscv@lists.infradead.org, linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org, David Matlack , Oliver Upton , Jing Zhang References: <20211009021236.4122790-1-seanjc@google.com> <20211009021236.4122790-11-seanjc@google.com> <9236e715-c471-e1c8-6117-6f37b908a6bd@redhat.com> <875ytjbxpq.wl-maz@kernel.org> From: Paolo Bonzini In-Reply-To: <875ytjbxpq.wl-maz@kernel.org> Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=pbonzini@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211026_091224_272753_F1820C75 X-CRM114-Status: GOOD ( 10.42 ) X-BeenThere: linux-riscv@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-riscv" Errors-To: linux-riscv-bounces+linux-riscv=archiver.kernel.org@lists.infradead.org On 26/10/21 17:41, Marc Zyngier wrote: >> This needs a word on why kvm_psci_vcpu_suspend does not need the >> hooks. Or it needs to be changed to also use kvm_vcpu_wfi in the PSCI >> code, I don't know. >> >> Marc, can you review and/or advise? > I was looking at that over the weekend, and that's a pre-existing > bug. I would have addressed it independently, but it looks like you > already have queued the patch. I have "queued" it, but that's just my queue - it's not on kernel.org and it's not going to be in 5.16, at least not in the first batch. There's plenty of time for me to rebase on top of a fix, if you want to send the fix through your kvm-arm pull request. Just Cc me so that I understand what's going on. Thanks, Paolo _______________________________________________ linux-riscv mailing list linux-riscv@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-riscv From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 248E2C433F5 for ; Tue, 26 Oct 2021 16:20:13 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id DAD41604AC for ; Tue, 26 Oct 2021 16:20:12 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org DAD41604AC Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To:Subject: MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=soCVW9bYZwmLm9daIoPeGu1PpEgqbiwKuQDeKLXraCg=; b=dLsJ7mPtLXL1ik MSEHYXM5+F7/19nkiN2zUj+ruL2FwROYAB7UJzxkhOB6y/MByjGrtrZElmYS+ccOZ2l0TK1HJGgvg EYmA6/s219m5MPFBqOmoW3nUuZbL809RqO4ptAWlaQCsMo55IWZUhYZUJ0WqS6cPij/Vs9TbzvpOM ucYgUMziJZqb/HgVRrgH/sODuwd6XehTa2Pz3aNGS7nIyOVslHPy/6naV9DOo6lU/blo7tO4cjYO2 +vxh0UjqzQLSqtd94EGAh6Xcwt7IsmbCO4qMu2BkMOioxU4l3sOFn+WYCzNOkKsW9rUGY0iK/WnH5 cYStMY5ttjsikWQluyVQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mfP9U-002Qps-MG; Tue, 26 Oct 2021 16:18:16 +0000 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mfP3n-002NMF-ND for linux-arm-kernel@lists.infradead.org; Tue, 26 Oct 2021 16:12:25 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1635264741; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=y/8qPSuga2nSdD4ObnPRjMzoPwBrPBTCysCx0s1aic4=; b=HXeh27CV8hJRaETDK6hQOpnP45k3CVN3SmEZGClNq7UYeHDti1sMQE40Q9KP2PP6tyaQ2I orJVQXxUk8U1XN2n6u+a3epp9C/dCkhT5MuzOp8x/Js6W5Za41+LrdIs+yGwZJjYq0362v 79f1/BmEa6EFyJMmnSf2RTCKnOJQnls= Received: from mail-ed1-f70.google.com (mail-ed1-f70.google.com [209.85.208.70]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-160-AV812IsQM16_LD_v-vVW-Q-1; Tue, 26 Oct 2021 12:12:20 -0400 X-MC-Unique: AV812IsQM16_LD_v-vVW-Q-1 Received: by mail-ed1-f70.google.com with SMTP id q6-20020a056402518600b003dd81fc405eso2663648edd.1 for ; Tue, 26 Oct 2021 09:12:19 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=y/8qPSuga2nSdD4ObnPRjMzoPwBrPBTCysCx0s1aic4=; b=NH+EPlcquFVTtejJIEC+9z1Q6vSnBzUvHchnm+cCL1SVSz919KN8WjONjguuxCtGzA az/KvsaK/+876ab4bsHw0YpHhOQmfsA3gToHfPAxGrWUIvRDodAR0Dx91YdfCxdj9zO/ t13IzWvNCCk8dQ6lU4svv3iUBoPstUALg0pNkozQsZL9BYv0itYlsoJFbLF9ql/S4NUl RUdZHF/IR1jQ+TQU5vXcTEvopqnWmZfLY1yNPGN9EWxso+84sSUUil6Iuv3N2ZwfhEm2 Vvuok6TR9YTZYPOSnsZSSNMjuNv5g8Eu8mGM1I0O8NrDouxcp4lq137ytJBs1tkt8VpN yYTA== X-Gm-Message-State: AOAM532exgJVD0x0dqxnKqyd6XU/qpza300jduy/gw3tVcVV+Bv47KPd IleuKJixzNlRCl2PA3GT7+l7cAgTO1vhHDpYOp5DA91MACIcuGU68QS7ZCIfLBIYesT+t2Ppq92 Ds9M1SUh3uE86bqVB4GEws6RJcFMRi+w56Vg= X-Received: by 2002:aa7:da84:: with SMTP id q4mr36991773eds.371.1635264738788; Tue, 26 Oct 2021 09:12:18 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwASeQAxYa4SVxx7fzZJcK2OTnFNOTNNHLf+PErJyPRemx/Rf7LwxYWqAfn33dB1Qf24eGGDw== X-Received: by 2002:aa7:da84:: with SMTP id q4mr36991714eds.371.1635264738510; Tue, 26 Oct 2021 09:12:18 -0700 (PDT) Received: from ?IPV6:2001:b07:6468:f312:c8dd:75d4:99ab:290a? ([2001:b07:6468:f312:c8dd:75d4:99ab:290a]) by smtp.gmail.com with ESMTPSA id n1sm4753815edf.45.2021.10.26.09.12.11 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 26 Oct 2021 09:12:17 -0700 (PDT) Message-ID: Date: Tue, 26 Oct 2021 18:12:06 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.1.0 Subject: Re: [PATCH v2 10/43] KVM: arm64: Move vGIC v4 handling for WFI out arch callback hook To: Marc Zyngier Cc: Sean Christopherson , Huacai Chen , Aleksandar Markovic , Paul Mackerras , Anup Patel , Paul Walmsley , Palmer Dabbelt , Albert Ou , Christian Borntraeger , Janosch Frank , James Morse , Alexandru Elisei , Suzuki K Poulose , Atish Patra , David Hildenbrand , Cornelia Huck , Claudio Imbrenda , Vitaly Kuznetsov , Wanpeng Li , Jim Mattson , Joerg Roedel , linux-arm-kernel@lists.infradead.org, kvmarm@lists.cs.columbia.edu, linux-mips@vger.kernel.org, kvm@vger.kernel.org, kvm-ppc@vger.kernel.org, kvm-riscv@lists.infradead.org, linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org, David Matlack , Oliver Upton , Jing Zhang References: <20211009021236.4122790-1-seanjc@google.com> <20211009021236.4122790-11-seanjc@google.com> <9236e715-c471-e1c8-6117-6f37b908a6bd@redhat.com> <875ytjbxpq.wl-maz@kernel.org> From: Paolo Bonzini In-Reply-To: <875ytjbxpq.wl-maz@kernel.org> Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=pbonzini@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211026_091223_906236_09F4C838 X-CRM114-Status: GOOD ( 11.94 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 26/10/21 17:41, Marc Zyngier wrote: >> This needs a word on why kvm_psci_vcpu_suspend does not need the >> hooks. Or it needs to be changed to also use kvm_vcpu_wfi in the PSCI >> code, I don't know. >> >> Marc, can you review and/or advise? > I was looking at that over the weekend, and that's a pre-existing > bug. I would have addressed it independently, but it looks like you > already have queued the patch. I have "queued" it, but that's just my queue - it's not on kernel.org and it's not going to be in 5.16, at least not in the first batch. There's plenty of time for me to rebase on top of a fix, if you want to send the fix through your kvm-arm pull request. Just Cc me so that I understand what's going on. Thanks, Paolo _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel From mboxrd@z Thu Jan 1 00:00:00 1970 From: Paolo Bonzini Date: Tue, 26 Oct 2021 16:12:06 +0000 Subject: Re: [PATCH v2 10/43] KVM: arm64: Move vGIC v4 handling for WFI out arch callback hook Message-Id: List-Id: References: <20211009021236.4122790-1-seanjc@google.com> <20211009021236.4122790-11-seanjc@google.com> <9236e715-c471-e1c8-6117-6f37b908a6bd@redhat.com> <875ytjbxpq.wl-maz@kernel.org> In-Reply-To: <875ytjbxpq.wl-maz@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Marc Zyngier Cc: Sean Christopherson , Huacai Chen , Aleksandar Markovic , Paul Mackerras , Anup Patel , Paul Walmsley , Palmer Dabbelt , Albert Ou , Christian Borntraeger , Janosch Frank , James Morse , Alexandru Elisei , Suzuki K Poulose , Atish Patra , David Hildenbrand , Cornelia Huck , Claudio Imbrenda , Vitaly Kuznetsov , Wanpeng Li , Jim Mattson , Joerg Roedel , linux-arm-kernel@lists.infradead.org, kvmarm@lists.cs.columbia.edu, linux-mips@vger.kernel.org, kvm@vger.kernel.org, kvm-ppc@vger.kernel.org, kvm-riscv@lists.infradead.org, linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org, David Matlack , Oliver Upton , Jing Zhang On 26/10/21 17:41, Marc Zyngier wrote: >> This needs a word on why kvm_psci_vcpu_suspend does not need the >> hooks. Or it needs to be changed to also use kvm_vcpu_wfi in the PSCI >> code, I don't know. >> >> Marc, can you review and/or advise? > I was looking at that over the weekend, and that's a pre-existing > bug. I would have addressed it independently, but it looks like you > already have queued the patch. I have "queued" it, but that's just my queue - it's not on kernel.org and it's not going to be in 5.16, at least not in the first batch. There's plenty of time for me to rebase on top of a fix, if you want to send the fix through your kvm-arm pull request. Just Cc me so that I understand what's going on. Thanks, Paolo