From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Hunt, David" Subject: Re: [PATCH] net/i40e: fix default PFC setting Date: Tue, 11 Apr 2017 11:11:54 +0100 Message-ID: References: <1491896149-29328-1-git-send-email-jingjing.wu@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit To: Jingjing Wu , dev@dpdk.org Return-path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by dpdk.org (Postfix) with ESMTP id BDD012BAE for ; Tue, 11 Apr 2017 12:12:04 +0200 (CEST) In-Reply-To: <1491896149-29328-1-git-send-email-jingjing.wu@intel.com> List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 11/4/2017 8:35 AM, Jingjing Wu wrote: > To keep consistent with previous release, PFC need to be disabled > by default. This patch fixes it. > > Fixes: 6f0a707e5b55 ("net/i40e: enable DCB on SRIOV VFs") > Signed-off-by: Jingjing Wu > --- > drivers/net/i40e/i40e_ethdev.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/drivers/net/i40e/i40e_ethdev.c b/drivers/net/i40e/i40e_ethdev.c > index 6927fde..3e640b3 100644 > --- a/drivers/net/i40e/i40e_ethdev.c > +++ b/drivers/net/i40e/i40e_ethdev.c > @@ -10266,8 +10266,6 @@ i40e_dcb_init_configure(struct rte_eth_dev *dev, bool sw_dcb) > hw->local_dcbx_config.pfc.willing = 0; > hw->local_dcbx_config.pfc.pfccap = > I40E_MAX_TRAFFIC_CLASS; > - hw->local_dcbx_config.pfc.pfcenable = > - I40E_DEFAULT_TCMAP; > /* FW needs one App to configure HW */ > hw->local_dcbx_config.numapps = 1; > hw->local_dcbx_config.app[0].selector = This also fixes an issue I was having occasionally where traffic was not forwarded by testpmd on my platform. In those cases I was seeing ~4770 pps on one of the ports rather than the full rate (>20mpps). A git bisect confirmed that this commit (6f0a707e5b55) was the source of the issue. Tested-by: David Hunt