All of lore.kernel.org
 help / color / mirror / Atom feed
From: Sean Anderson <sean.anderson@seco.com>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: linux-serial@vger.kernel.org, Peter Korsgaard <jacmet@sunsite.dk>,
	Michal Simek <michal.simek@xilinx.com>
Subject: Re: [PATCH] tty: serial: uartlite: Use read_poll_timeout for a polling loop
Date: Thu, 29 Jul 2021 11:31:21 -0400	[thread overview]
Message-ID: <be426a00-d60b-a645-8f5f-f2beb104461f@seco.com> (raw)
In-Reply-To: <YQLCX5pTkVC1Url9@kroah.com>



On 7/29/21 10:59 AM, Greg Kroah-Hartman wrote:
> On Fri, Jul 23, 2021 at 05:52:20PM -0400, Sean Anderson wrote:
>> This uses read_poll_timeout_atomic to spin while waiting on uart_in32.
>
> That says what you are doing, but nothing about _why_ you are making
> this change.  Please fix up.

Ok, how about

read_poll_timeout was recently introduced, and can be used to simplify
our console polling loop. This results in a slight reduction in code.
early_uartlite_putc can't get the same treatment, because it can be
called before udelay is set up.

      reply	other threads:[~2021-07-29 15:31 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-07-23 21:52 [PATCH] tty: serial: uartlite: Use read_poll_timeout for a polling loop Sean Anderson
2021-07-23 21:55 ` Sean Anderson
2021-07-26 14:19 ` Michal Simek
2021-07-29 14:59 ` Greg Kroah-Hartman
2021-07-29 15:31   ` Sean Anderson [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=be426a00-d60b-a645-8f5f-f2beb104461f@seco.com \
    --to=sean.anderson@seco.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=jacmet@sunsite.dk \
    --cc=linux-serial@vger.kernel.org \
    --cc=michal.simek@xilinx.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.