All of lore.kernel.org
 help / color / mirror / Atom feed
From: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
To: Vinod Koul <vkoul@kernel.org>
Cc: alsa-devel@alsa-project.org, Leon Romanovsky <leon@kernel.org>,
	gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org,
	Ranjani Sridharan <ranjani.sridharan@linux.intel.com>,
	hui.wang@canonical.com, Jason Gunthorpe <jgg@nvidia.com>,
	Dave Ertman <david.m.ertman@intel.com>,
	sanyog.r.kale@intel.com,
	Bard Liao <yung-chuan.liao@linux.intel.com>,
	rander.wang@linux.intel.com, bard.liao@intel.com
Subject: Re: [PATCH v4] soundwire: intel: move to auxiliary bus
Date: Fri, 11 Jun 2021 09:51:49 -0500	[thread overview]
Message-ID: <be440569-e18b-b079-2795-0af1e6812935@linux.intel.com> (raw)
In-Reply-To: <YMNQBpFX9DXcoGAc@vkoul-mobl>

Thanks Vinod for your feedback,

>> If you look at the *existing* code, we don't handle any "resources" with the
>> platform devices, we use the platform_device_info.data to pass the link
>> information. It's a void pointer. We do not touch the resource field in the
>> platform_device_into at all.
> 
> Yes that is true I dont disagree on that part. My ask here is to make it
> better, it can be followed up after this but I would at least like to
> agree on the direction.

[...]

>> That's it. We did not change anything else, all the other fields are
>> identical. We are only changing the TYPE of device and the interfaces for
>> probe/remove but using the same information and the same device hierarchy.
> 
> The move in itself is okay but I dont think that should be the end goal.

What we suggested in this patch is only an iso-functionality change. I 
believe from Greg's and your feedback that there is no objection on that 
small step.

This is not the end-goal indeed. The second step would be to remove the 
intel_init.c file. I fully agree with you Vinod that this can be moved 
into the SOF driver, and we could do this in a follow-up step. We can 
also improve the partition between 'context' used by the child driver 
and information passed by the parent on SHIM registers and bases.

I think we'd need to agree on the details of the second step, Bard and I 
can work on a proposal, but I don't see a disconnect on the direction to 
simplify the interface. That's the right thing to do.





  reply	other threads:[~2021-06-11 14:51 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-05-11  5:21 [PATCH v4] soundwire: intel: move to auxiliary bus Bard Liao
2021-05-11  5:21 ` Bard Liao
2021-05-25 18:30 ` Pierre-Louis Bossart
2021-05-25 18:30   ` Pierre-Louis Bossart
2021-05-31 10:19   ` Vinod Koul
2021-05-31 10:19     ` Vinod Koul
2021-06-01 13:56     ` Pierre-Louis Bossart
2021-06-09  4:46       ` Vinod Koul
2021-06-09 14:44         ` Pierre-Louis Bossart
2021-06-09 15:10           ` Jason Gunthorpe
2021-06-09 15:10             ` Jason Gunthorpe
2021-06-09 16:00             ` Pierre-Louis Bossart
2021-06-11 11:26             ` Vinod Koul
2021-06-11 11:26               ` Vinod Koul
2021-06-11 13:29               ` Greg KH
2021-06-11 13:29                 ` Greg KH
2021-06-09 19:02           ` Greg KH
2021-06-09 19:02             ` Greg KH
2021-06-11 11:59           ` Vinod Koul
2021-06-11 14:51             ` Pierre-Louis Bossart [this message]
2021-06-14  4:43               ` Vinod Koul
2021-06-14  4:42 ` Vinod Koul
2021-06-14  4:42   ` Vinod Koul

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=be440569-e18b-b079-2795-0af1e6812935@linux.intel.com \
    --to=pierre-louis.bossart@linux.intel.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=bard.liao@intel.com \
    --cc=david.m.ertman@intel.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=hui.wang@canonical.com \
    --cc=jgg@nvidia.com \
    --cc=leon@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rander.wang@linux.intel.com \
    --cc=ranjani.sridharan@linux.intel.com \
    --cc=sanyog.r.kale@intel.com \
    --cc=vkoul@kernel.org \
    --cc=yung-chuan.liao@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.